<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>218972</bug_id>
          
          <creation_ts>2020-11-16 01:31:14 -0800</creation_ts>
          <short_desc>Use downcast instead of static_cast for casting GraphicsContextGL -&gt; GraphicsContextGLOpenGL</short_desc>
          <delta_ts>2020-11-26 03:17:37 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebGL</component>
          <version>WebKit Local Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>NEW</bug_status>
          <resolution></resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>218333</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Kimmo Kinnunen">kkinnunen</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>dino</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1707719</commentid>
    <comment_count>0</comment_count>
    <who name="Kimmo Kinnunen">kkinnunen</who>
    <bug_when>2020-11-16 01:31:14 -0800</bug_when>
    <thetext>Use downcast instead of static_cast for casting GraphicsContextGL to GraphicsContextGLOpenGL
  
This is to be done only if removing !USE(ANGLE) from WebGL implementation is not possible.

https://bugs.webkit.org/show_bug.cgi?id=218333#c9

Simon Fraser (smfr) 2020-11-13 10:38:15 PST
&gt;&gt; Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1790
&gt;&gt; +    static_cast&lt;GraphicsContextGLOpenGL*&gt;(m_context.get())-&gt;compressedTexImage2D(target, level, internalformat, width, height,

&gt;I think you should add SPECIALIZE_TYPE_TRAITS macros and use downcast&lt;&gt; for all these casts.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1710121</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2020-11-26 03:17:37 -0800</bug_when>
    <thetext>&lt;rdar://problem/71747680&gt;</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>