218966 2020-11-15 16:00:22 -0800 Remove and re-add fast/forms/selection-direction.html without CRs 2020-11-16 09:05:08 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build All All RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=217567 InRadar P2 Normal --- 1 sam webkit-unassigned darin webkit-bug-importer oldest_to_newest 1707667 0 sam 2020-11-15 16:00:22 -0800 fast/forms/selection-direction.html has CR line ending and the scripts won't allow me to change it. They will allow me to remove it though, so let's remove it and add it back without the line endings. 1707668 1 414184 sam 2020-11-15 16:01:55 -0800 Created attachment 414184 Remove test temporarily 1707671 2 ews-feeder 2020-11-15 16:33:50 -0800 Committed r269834: <https://trac.webkit.org/changeset/269834> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414184. 1707672 3 webkit-bug-importer 2020-11-15 16:34:19 -0800 <rdar://problem/71421831> 1707673 4 darin 2020-11-15 16:39:26 -0800 Seems like we didn’t need to use a bug and commit-queue for this. Could just use git/svn directly. 1707833 5 sam 2020-11-16 08:54:02 -0800 (In reply to Darin Adler from comment #4) > Seems like we didn’t need to use a bug and commit-queue for this. Could just > use git/svn directly. Yeah, I didn't think it through. Should have done that. 1707841 6 sam 2020-11-16 09:05:08 -0800 Added test back in https://trac.webkit.org/changeset/269854/webkit. 414184 2020-11-15 16:01:55 -0800 2020-11-15 16:33:50 -0800 Remove test temporarily patch.diff text/plain 4750 sam SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDI2OTgzMykKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDIwLTExLTE1ICBTYW0gV2VpbmlnICA8d2Vp bmlnQGFwcGxlLmNvbT4KKworICAgICAgICBSZW1vdmUgYW5kIHJlLWFkZCBmYXN0L2Zvcm1zL3Nl bGVjdGlvbi1kaXJlY3Rpb24uaHRtbCB3aXRob3V0IENScworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE4OTY2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBmYXN0L2Zvcm1zL3NlbGVjdGlvbi1kaXJlY3Rp b24uaHRtbDogUmVtb3ZlZC4KKyAgICAgICAgVGVtcG9yYXJpbHkgcmVtb3ZlIHRlc3QuIFdpbGwg YWRkIGJhY2sgd2l0aG91dCBDUnMgaW4gbmV4dCBjb21taXQuCisKIDIwMjAtMTEtMTUgIFlvdWVu biBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBhIFdlYlJUQyBTRnJh bWUgdHJhbnNmb3JtCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3NlbGVjdGlvbi1kaXJl Y3Rpb24uaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3NlbGVjdGlv bi1kaXJlY3Rpb24uaHRtbAkocmV2aXNpb24gMjY5ODMwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9m b3Jtcy9zZWxlY3Rpb24tZGlyZWN0aW9uLmh0bWwJKG5vbmV4aXN0ZW50KQpAQCAtMSwxMDUgKzAs MCBAQAotPCFET0NUWVBFIGh0bWw+DQotPGh0bWw+DQotPGhlYWQ+DQotPHNjcmlwdCBzcmM9Ii4u Ly4uL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+DQotPC9oZWFkPg0KLTxib2R5 Pg0KLTxwIGlkPSJkZXNjcmlwdGlvbiI+PC9wPg0KLTxkaXY+PGlucHV0IGlkPSJkdW1teSI+PC9k aXY+DQotPGRpdiBpZD0idGVzdHMiPjxpbnB1dCB2YWx1ZT0iaGVsbG8iPjx0ZXh0YXJlYT5oZWxs bzwvdGV4dGFyZWE+PC9kaXY+DQotPGRpdiBpZD0iY29uc29sZSI+PC9kaXY+DQotPGRpdj4NCi08 c2NyaXB0IHR5cGU9InRleHQvamF2YXNjcmlwdCI+DQotZGVzY3JpcHRpb24oJ1Rlc3RzIGZvciBz ZWxlY3Rpb25EaXJlY3Rpb24nKTsNCi0NCi12YXIgZHVtbXkgPSBkb2N1bWVudC5nZXRFbGVtZW50 QnlJZCgnZHVtbXknKTsNCi0NCi1mdW5jdGlvbiBhc3NlcnREaXJlY3Rpb24oZXhwZWN0ZWREaXJl Y3Rpb24sIGVsZW1lbnQsIGRlc2NyaXB0aW9uKSB7DQotICAgIHZhciBhY3Rpb24gPSAnc2VsZWN0 aW9uRGlyZWN0aW9uIHdhcyAiJyArIGVsZW1lbnQuc2VsZWN0aW9uRGlyZWN0aW9uDQotICAgICAg ICArICciIGFmdGVyICcgKyBkZXNjcmlwdGlvbjsNCi0NCi0gICAgaWYgKGVsZW1lbnQuc2VsZWN0 aW9uRGlyZWN0aW9uID09IGV4cGVjdGVkRGlyZWN0aW9uKQ0KLSAgICAgICAgdGVzdFBhc3NlZChh Y3Rpb24pOw0KLSAgICBlbHNlDQotICAgICAgICB0ZXN0RmFpbGVkKGFjdGlvbiArICcsIGJ1dCBl eHBlY3RlZCAiJyArIGV4cGVjdGVkRGlyZWN0aW9uICsgJyInKTsNCi19DQotDQotZnVuY3Rpb24g dGVzdENhY2hlKGV4cGVjdGVkRGlyZWN0aW9uLCBlbGVtZW50KSB7DQotICAgIGR1bW15LmZvY3Vz KCk7DQotICAgIGFzc2VydERpcmVjdGlvbihleHBlY3RlZERpcmVjdGlvbiwgZWxlbWVudCwgJ2Zv Y3VzaW5nIG9uIGFub3RoZXIgZWxlbWVudCcpOw0KLQ0KLSAgICBlbGVtZW50LnN0eWxlLmRpc3Bs YXkgPSAnbm9uZSc7DQotICAgIGFzc2VydERpcmVjdGlvbihleHBlY3RlZERpcmVjdGlvbiwgZWxl bWVudCwgJ2hpZGluZyB0aGUgZWxlbWVudCcpOw0KLSAgICBlbGVtZW50LnN0eWxlLmRpc3BsYXkg PSBudWxsOw0KLX0NCi0NCi1mdW5jdGlvbiBydW5UZXN0KGVsZW1lbnQsIHBsYXRmb3JtKSB7DQot ICAgIGRlYnVnKGVsZW1lbnQubG9jYWxOYW1lICsgJyBvbiAnICsgcGxhdGZvcm0pOw0KLSAgICBl bGVtZW50LmZvY3VzKCk7DQotDQotICAgIHZhciBub25lT25NYWNBbmRGb3J3YXJkT25PdGhlcnMg PSAocGxhdGZvcm0gPT0gJ01hYycpID8gJ25vbmUnIDogJ2ZvcndhcmQnOw0KLQ0KLSAgICBlbGVt ZW50LnNldFNlbGVjdGlvblJhbmdlKDEsIDIpOw0KLSAgICBhc3NlcnREaXJlY3Rpb24obm9uZU9u TWFjQW5kRm9yd2FyZE9uT3RoZXJzLCBlbGVtZW50LCAnZm9jdXNpbmcgYW5kIHNldHRpbmcgc2Vs ZWN0aW9uIGJ5IHNldFNlbGVjdGlvblJhbmdlKDEsIDIpJyk7DQotICAgIHRlc3RDYWNoZShub25l T25NYWNBbmRGb3J3YXJkT25PdGhlcnMsIGVsZW1lbnQpOw0KLQ0KLSAgICBlbGVtZW50LmZvY3Vz KCk7DQotICAgIGVsZW1lbnQuc2V0U2VsZWN0aW9uUmFuZ2UoMSwgMiwgJ2ZvcndhcmQnKTsNCi0g ICAgYXNzZXJ0RGlyZWN0aW9uKCdmb3J3YXJkJywgZWxlbWVudCwgJ2ZvY3VzaW5nIGFuZCBzZXR0 aW5nIHNlbGVjdGlvbiBieSBzZXRTZWxlY3Rpb25SYW5nZSgxLCAyLCAiZm9yd2FyZCIpJyk7DQot ICAgIHRlc3RDYWNoZSgnZm9yd2FyZCcsIGVsZW1lbnQpOw0KLQ0KLSAgICBlbGVtZW50LnNldFNl bGVjdGlvblJhbmdlKDEsIDIsICdiYWNrd2FyZCcpOw0KLSAgICBhc3NlcnREaXJlY3Rpb24oJ2Jh Y2t3YXJkJywgZWxlbWVudCwgJ3NldHRpbmcgc2VsZWN0aW9uIGJ5IHNldFNlbGVjdGlvblJhbmdl KDEsIDIsICJiYWNrd2FyZCIpIHdpdGhvdXQgZm9jdXMnKTsNCi0gICAgdGVzdENhY2hlKCdiYWNr d2FyZCcsIGVsZW1lbnQpOw0KLQ0KLSAgICBlbGVtZW50LnNlbGVjdGlvbkRpcmVjdGlvbiA9ICdu b25lJzsNCi0gICAgYXNzZXJ0RGlyZWN0aW9uKG5vbmVPbk1hY0FuZEZvcndhcmRPbk90aGVycywg ZWxlbWVudCwgJ3NldHRpbmcgc2VsZWN0aW9uIGJ5IHNlbGVjdGlvbkRpcmVjdGlvbiA9ICJub25l IiB3aXRob3V0IGZvY3VzJyk7DQotICAgIHRlc3RDYWNoZShub25lT25NYWNBbmRGb3J3YXJkT25P dGhlcnMsIGVsZW1lbnQpOw0KLQ0KLSAgICBlbGVtZW50LnNlbGVjdGlvbkRpcmVjdGlvbiA9ICdm b3J3YXJkJzsNCi0gICAgYXNzZXJ0RGlyZWN0aW9uKCdmb3J3YXJkJywgZWxlbWVudCwgJ2ZvY3Vz aW5nIGFuZCBzZXR0aW5nIHNlbGVjdGlvbiBieSBzZWxlY3Rpb25EaXJlY3Rpb24gPSAiZm9yd2Fy ZCIgd2l0aG91dCBmb2N1cycpOw0KLSAgICB0ZXN0Q2FjaGUoJ2ZvcndhcmQnLCBlbGVtZW50KTsN Ci0NCi0gICAgZWxlbWVudC5mb2N1cygpOw0KLSAgICBlbGVtZW50LnNlbGVjdGlvbkRpcmVjdGlv biA9ICdiYWNrd2FyZCc7DQotICAgIGFzc2VydERpcmVjdGlvbignYmFja3dhcmQnLCBlbGVtZW50 LCAnZm9jdXNpbmcgYW5kIHNldHRpbmcgc2VsZWN0aW9uIGJ5IHNlbGVjdGlvbkRpcmVjdGlvbiA9 ICJiYWNrd2FyZCInKTsNCi0gICAgdGVzdENhY2hlKCdiYWNrd2FyZCcsIGVsZW1lbnQpOw0KLQ0K LSAgICBlbGVtZW50LmZvY3VzKCk7DQotICAgIGVsZW1lbnQuc2V0U2VsZWN0aW9uUmFuZ2UoMSwg MSk7DQotICAgIHdpbmRvdy5nZXRTZWxlY3Rpb24oKS5tb2RpZnkoJ2V4dGVuZCcsICdmb3J3YXJk JywgJ2NoYXJhY3RlcicpOw0KLSAgICBhc3NlcnREaXJlY3Rpb24oJ2ZvcndhcmQnLCBlbGVtZW50 LCAnZXh0ZW5kaW5nIHNlbGVjdGlvbiBmb3J3YXJkIGJ5IGNoYXJhY3RlcicpOw0KLSAgICB0ZXN0 Q2FjaGUoJ2ZvcndhcmQnLCBlbGVtZW50KTsNCi0NCi0gICAgZWxlbWVudC5mb2N1cygpOw0KLSAg ICBlbGVtZW50LnNldFNlbGVjdGlvblJhbmdlKDEsIDEpOw0KLSAgICB3aW5kb3cuZ2V0U2VsZWN0 aW9uKCkubW9kaWZ5KCdleHRlbmQnLCAnYmFja3dhcmQnLCAnY2hhcmFjdGVyJyk7DQotICAgIGFz c2VydERpcmVjdGlvbignYmFja3dhcmQnLCBlbGVtZW50LCAnZXh0ZW5kaW5nIHNlbGVjdGlvbiBi YWNrd2FyZCBieSBjaGFyYWN0ZXInKTsNCi0gICAgdGVzdENhY2hlKCdiYWNrd2FyZCcsIGVsZW1l bnQpOw0KLQ0KLX0NCi0NCi1mdW5jdGlvbiBydW5UZXN0Rm9yKHBsYXRmb3JtKSB7DQotICAgIGlm ICh3aW5kb3cuaW50ZXJuYWxzKQ0KLSAgICAgICAgaW50ZXJuYWxzLnNldHRpbmdzLnNldEVkaXRp bmdCZWhhdmlvcihwbGF0Zm9ybS50b0xvd2VyQ2FzZSgpKTsNCi0gICAgdmFyIHRlc3RzID0gZG9j dW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ3Rlc3RzJyk7DQotICAgIGZvciAodmFyIGkgPSAwOyBpIDwg dGVzdHMuY2hpbGROb2Rlcy5sZW5ndGg7IGkrKykgew0KLSAgICAgICAgcnVuVGVzdCh0ZXN0cy5j aGlsZE5vZGVzW2ldLCBwbGF0Zm9ybSk7DQotICAgICAgICBkZWJ1ZygnJyk7DQotICAgIH0NCi19 DQotDQotaWYgKHdpbmRvdy5pbnRlcm5hbHMpIHsNCi0gICAgcnVuVGVzdEZvcignTWFjJyk7DQot ICAgIHJ1blRlc3RGb3IoJ1dpbicpOw0KLSAgICBydW5UZXN0Rm9yKCdVbml4Jyk7DQotfSBlbHNl DQotICAgIHJ1blRlc3RGb3IobmF2aWdhdG9yLnBsYXRmb3JtLmluZGV4T2YoJ01hYycpID49IDAg PyAnTWFjJyA6ICdXaW4nKTsNCi0NCi10ZXN0cy5zdHlsZS5kaXNwbGF5ID0gJ25vbmUnOw0KLWR1 bW15LnBhcmVudE5vZGUuc3R5bGUuZGlzcGxheSA9ICdub25lJzsNCi0NCi08L3NjcmlwdD4NCi08 c2NyaXB0IHNyYz0iLi4vLi4vcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+DQot PC9ib2R5Pg0KLTwvaHRtbD4NCg==