218958 2020-11-15 09:36:55 -0800 Add logging of AXCoreObject outerHTML to AXLogger. 2020-11-16 10:13:17 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 andresg_22 andresg_22 aboxhall apinheiro cfleizach dmazzoni ews-watchlist jcraig jdiggs samuel_white webkit-bug-importer oldest_to_newest 1707609 0 andresg_22 2020-11-15 09:36:55 -0800 Add logging of AXCoreObject outerHTML to AXLogger. 1707610 1 414167 andresg_22 2020-11-15 09:43:47 -0800 Created attachment 414167 Patch 1707699 2 414167 cfleizach 2020-11-16 00:11:36 -0800 Comment on attachment 414167 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414167&action=review > Source/WebCore/accessibility/AXLogger.cpp:270 > + const AXCoreObject* objectWithInterestingHtML = nullptr; HtML > HTML can we use auto here? 1707793 3 414230 andresg_22 2020-11-16 06:40:35 -0800 Created attachment 414230 Patch 1707795 4 andresg_22 2020-11-16 06:42:19 -0800 (In reply to chris fleizach from comment #2) > Comment on attachment 414167 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=414167&action=review > > > Source/WebCore/accessibility/AXLogger.cpp:270 > > + const AXCoreObject* objectWithInterestingHtML = nullptr; > > HtML > HTML Fixed. > > can we use auto here? Done. 1707871 5 ews-feeder 2020-11-16 10:12:38 -0800 Committed r269859: <https://trac.webkit.org/changeset/269859> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414230. 1707872 6 webkit-bug-importer 2020-11-16 10:13:17 -0800 <rdar://problem/71446493> 414167 2020-11-15 09:43:47 -0800 2020-11-16 06:40:33 -0800 Patch bug-218958-20201115124346.patch text/plain 2486 andresg_22 U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5ODI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2NkYzY5NTYyZDM5YTBl YjY5NTNhODYxZjIzOTFiNTZlYjZjODAxMy4uODA3OTVjMTUyZWNlYzhhNGJkMDQzYjQwNGUzYTM0 NGQ3NzZiYmEzYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIwLTExLTE1ICBBbmRy ZXMgR29uemFsZXogIDxhbmRyZXNnXzIyQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgbG9nZ2lu ZyBvZiBBWENvcmVPYmplY3Qgb3V0ZXJIVE1MIHRvIEFYTG9nZ2VyLgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE4OTU4CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gY2hhbmdlIGluIGZ1bmN0aW9uYWxp dHksIGRlYnVnZ2luZyBjb2RlLgorCisgICAgICAgICogYWNjZXNzaWJpbGl0eS9BWExvZ2dlci5j cHA6CisgICAgICAgIChXZWJDb3JlOjpvcGVyYXRvcjw8KToKKyAgICAgICAgLSBBZGRlZCBsb2dn aW5nIG9mIHRoZSBvdXRlckhUTUwgb2YgdGhlIGNvcnJlc3BvbmRpbmcgRWxlbWVudCBmb3IgQVhD b3JlT2JqZWN0cy4KKyAgICAgICAgLSBBZGRlZCBsb2dnaW5nIG9mIHRoZSBwbGF0Zm9ybSB3cmFw cGVyIGFkZHJlc3MgZm9yIEFYQ29yZU9iamVjdHMuCisKIDIwMjAtMTEtMTUgIFphbGFuIEJ1anRh cyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICAiVHlwbyIgaW4gcjI2OTgyMSAoYnkgc3Rk OjpudW1lcmljX2xpbWl0czw+OjptaW4gSSByZWFsbHkgbWVhbnQgc3RkOjpudW1lcmljX2xpbWl0 czw+Ojpsb3dlc3QgKGdvdCB0cmlja2VkIGJ5IHRoZSBmbG9hdGluZy1wb2ludCB0eXBlIGJlaGF2 aW9yKSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQVhMb2dnZXIu Y3BwIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BWExvZ2dlci5jcHAKaW5kZXggNGY1 YzZiNWVjNTA3ZDQ3MjdjZWJhMjMyYWM4MmNjM2I4Njk5MDI2Ni4uZjdmM2U4ODI5MDAzZDhiYjZk NzdlMzZlMWNlZDg2ZDhmZGI2ZmQwYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYWNjZXNz aWJpbGl0eS9BWExvZ2dlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9B WExvZ2dlci5jcHAKQEAgLTI2NCwxMCArMjY0LDIzIEBAIFRleHRTdHJlYW0mIG9wZXJhdG9yPDwo VGV4dFN0cmVhbSYgc3RyZWFtLCBjb25zdCBBWENvcmVPYmplY3QmIG9iamVjdCkKICAgICBUZXh0 U3RyZWFtOjpHcm91cFNjb3BlIGdyb3VwU2NvcGUoc3RyZWFtKTsKICAgICBzdHJlYW0gPDwgIm9i amVjdElEICIgPDwgb2JqZWN0Lm9iamVjdElEKCk7CiAgICAgc3RyZWFtLmR1bXBQcm9wZXJ0eSgi aWRlbnRpZmllckF0dHJpYnV0ZSIsIG9iamVjdC5pZGVudGlmaWVyQXR0cmlidXRlKCkpOwotICAg IHN0cmVhbS5kdW1wUHJvcGVydHkoInJvbGVWYWx1ZSIsIG9iamVjdC5yb2xlVmFsdWUoKSk7Ci0g ICAgc3RyZWFtLmR1bXBQcm9wZXJ0eSgiYWRkcmVzcyIsICZvYmplY3QpOworICAgIGF1dG8gcm9s ZSA9IG9iamVjdC5yb2xlVmFsdWUoKTsKKyAgICBzdHJlYW0uZHVtcFByb3BlcnR5KCJyb2xlVmFs dWUiLCByb2xlKTsKIAorICAgIGNvbnN0IEFYQ29yZU9iamVjdCogb2JqZWN0V2l0aEludGVyZXN0 aW5nSHRNTCA9IG51bGxwdHI7CiAgICAgYXV0byogcGFyZW50ID0gb2JqZWN0LnBhcmVudE9iamVj dCgpOworICAgIGlmIChyb2xlID09IEFjY2Vzc2liaWxpdHlSb2xlOjpTdGF0aWNUZXh0ICYmIHBh cmVudCkKKyAgICAgICAgb2JqZWN0V2l0aEludGVyZXN0aW5nSHRNTCA9IHBhcmVudDsKKyAgICBl bHNlIGlmIChyb2xlID09IEFjY2Vzc2liaWxpdHlSb2xlOjpCdXR0b24pCisgICAgICAgIG9iamVj dFdpdGhJbnRlcmVzdGluZ0h0TUwgPSAmb2JqZWN0OworICAgIGlmIChvYmplY3RXaXRoSW50ZXJl c3RpbmdIdE1MKSB7CisgICAgICAgIGlmIChhdXRvKiBlbGVtZW50ID0gb2JqZWN0V2l0aEludGVy ZXN0aW5nSHRNTC0+ZWxlbWVudCgpKQorICAgICAgICAgICAgc3RyZWFtLmR1bXBQcm9wZXJ0eSgi b3V0ZXJIVE1MIiwgZWxlbWVudC0+b3V0ZXJIVE1MKCkpOworICAgIH0KKworICAgIHN0cmVhbS5k dW1wUHJvcGVydHkoIndyYXBwZXIiLCBvYmplY3Qud3JhcHBlcigpKTsKKyAgICBzdHJlYW0uZHVt cFByb3BlcnR5KCJhZGRyZXNzIiwgJm9iamVjdCk7CisKICAgICBzdHJlYW0uZHVtcFByb3BlcnR5 KCJwYXJlbnRPYmplY3QiLCBwYXJlbnQgPyBwYXJlbnQtPm9iamVjdElEKCkgOiAwKTsKICNpZiBQ TEFURk9STShDT0NPQSkKICAgICBzdHJlYW0uZHVtcFByb3BlcnR5KCJyZW1vdGVQYXJlbnRPYmpl Y3QiLCBvYmplY3QucmVtb3RlUGFyZW50T2JqZWN0KCkpOwo= 414230 2020-11-16 06:40:35 -0800 2020-11-16 10:12:39 -0800 Patch bug-218958-20201116094034.patch text/plain 2400 andresg_22 U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5ODUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmFiMzgwY2VlY2RkMjk1 NGU1ZGM4NGU3MGZlMzc2YmIyZTBjYmQ0OS4uZWIzYWJhZTRmMTdkMTQxMTZmMzcyODU5YmViZjY4 NDU3ODE5YWIxYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIwLTExLTE2ICBBbmRy ZXMgR29uemFsZXogIDxhbmRyZXNnXzIyQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgbG9nZ2lu ZyBvZiBBWENvcmVPYmplY3Qgb3V0ZXJIVE1MIHRvIEFYTG9nZ2VyLgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE4OTU4CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgQ2hyaXMgRmxlaXphY2guCisKKyAgICAgICAgTm8gY2hhbmdlIGluIGZ1bmN0aW9uYWxp dHksIGRlYnVnZ2luZyBjb2RlLgorCisgICAgICAgICogYWNjZXNzaWJpbGl0eS9BWExvZ2dlci5j cHA6CisgICAgICAgIChXZWJDb3JlOjpvcGVyYXRvcjw8KToKKyAgICAgICAgLSBBZGRlZCBsb2dn aW5nIG9mIHRoZSBvdXRlckhUTUwgb2YgdGhlIGNvcnJlc3BvbmRpbmcgRWxlbWVudCBmb3IgQVhD b3JlT2JqZWN0cy4KKyAgICAgICAgLSBBZGRlZCBsb2dnaW5nIG9mIHRoZSBwbGF0Zm9ybSB3cmFw cGVyIGFkZHJlc3MgZm9yIEFYQ29yZU9iamVjdHMuCisKIDIwMjAtMTEtMTYgIEtpbW1vIEtpbm51 bmVuICA8a2tpbm51bmVuQGFwcGxlLmNvbT4KIAogICAgICAgICBGaW5hbCByZWZhY3RvciBmb3Ig V2ViR0wgaW1wbGVtZW50YXRpb24gdG8gdXNlIG9ubHkgR3JhcGhpY3NDb250ZXh0R0wKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQVhMb2dnZXIuY3BwIGIvU291cmNl L1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BWExvZ2dlci5jcHAKaW5kZXggNGY1YzZiNWVjNTA3ZDQ3 MjdjZWJhMjMyYWM4MmNjM2I4Njk5MDI2Ni4uYThkNDYxZWFhMTEyZGY2N2U0NjM0NTQxYWRmNjM3 YTUxZTAzNGU1NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BWExv Z2dlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BWExvZ2dlci5jcHAK QEAgLTI2NCwxMCArMjY0LDIyIEBAIFRleHRTdHJlYW0mIG9wZXJhdG9yPDwoVGV4dFN0cmVhbSYg c3RyZWFtLCBjb25zdCBBWENvcmVPYmplY3QmIG9iamVjdCkKICAgICBUZXh0U3RyZWFtOjpHcm91 cFNjb3BlIGdyb3VwU2NvcGUoc3RyZWFtKTsKICAgICBzdHJlYW0gPDwgIm9iamVjdElEICIgPDwg b2JqZWN0Lm9iamVjdElEKCk7CiAgICAgc3RyZWFtLmR1bXBQcm9wZXJ0eSgiaWRlbnRpZmllckF0 dHJpYnV0ZSIsIG9iamVjdC5pZGVudGlmaWVyQXR0cmlidXRlKCkpOwotICAgIHN0cmVhbS5kdW1w UHJvcGVydHkoInJvbGVWYWx1ZSIsIG9iamVjdC5yb2xlVmFsdWUoKSk7Ci0gICAgc3RyZWFtLmR1 bXBQcm9wZXJ0eSgiYWRkcmVzcyIsICZvYmplY3QpOworICAgIGF1dG8gcm9sZSA9IG9iamVjdC5y b2xlVmFsdWUoKTsKKyAgICBzdHJlYW0uZHVtcFByb3BlcnR5KCJyb2xlVmFsdWUiLCByb2xlKTsK IAorICAgIGF1dG8qIG9iamVjdFdpdGhJbnRlcmVzdGluZ0hUTUwgPSByb2xlID09IEFjY2Vzc2li aWxpdHlSb2xlOjpCdXR0b24gPyAvLyBBZGQgaGVyZSBvdGhlciByb2xlcyBvZiBpbnRlcmVzdC4K KyAgICAgICAgJm9iamVjdCA6IG51bGxwdHI7CiAgICAgYXV0byogcGFyZW50ID0gb2JqZWN0LnBh cmVudE9iamVjdCgpOworICAgIGlmIChyb2xlID09IEFjY2Vzc2liaWxpdHlSb2xlOjpTdGF0aWNU ZXh0ICYmIHBhcmVudCkKKyAgICAgICAgb2JqZWN0V2l0aEludGVyZXN0aW5nSFRNTCA9IHBhcmVu dDsKKyAgICBpZiAob2JqZWN0V2l0aEludGVyZXN0aW5nSFRNTCkgeworICAgICAgICBpZiAoYXV0 byogZWxlbWVudCA9IG9iamVjdFdpdGhJbnRlcmVzdGluZ0hUTUwtPmVsZW1lbnQoKSkKKyAgICAg ICAgICAgIHN0cmVhbS5kdW1wUHJvcGVydHkoIm91dGVySFRNTCIsIGVsZW1lbnQtPm91dGVySFRN TCgpKTsKKyAgICB9CisKKyAgICBzdHJlYW0uZHVtcFByb3BlcnR5KCJhZGRyZXNzIiwgJm9iamVj dCk7CisgICAgc3RyZWFtLmR1bXBQcm9wZXJ0eSgid3JhcHBlciIsIG9iamVjdC53cmFwcGVyKCkp OworCiAgICAgc3RyZWFtLmR1bXBQcm9wZXJ0eSgicGFyZW50T2JqZWN0IiwgcGFyZW50ID8gcGFy ZW50LT5vYmplY3RJRCgpIDogMCk7CiAjaWYgUExBVEZPUk0oQ09DT0EpCiAgICAgc3RyZWFtLmR1 bXBQcm9wZXJ0eSgicmVtb3RlUGFyZW50T2JqZWN0Iiwgb2JqZWN0LnJlbW90ZVBhcmVudE9iamVj dCgpKTsK