218950 2020-11-14 20:06:49 -0800 [LFC][Geometry] Add support for horizontal/vertical scrollbar spacing 2020-11-16 12:18:11 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1707559 0 zalan 2020-11-14 20:06:49 -0800 (this is for integration only) 1707566 1 414153 zalan 2020-11-14 20:38:29 -0800 Created attachment 414153 Patch 1707595 2 ews-feeder 2020-11-15 06:23:45 -0800 Committed r269825: <https://trac.webkit.org/changeset/269825> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414153. 1707596 3 webkit-bug-importer 2020-11-15 06:24:17 -0800 <rdar://problem/71414265> 1707824 4 simon.fraser 2020-11-16 08:25:52 -0800 Does this support the "scrollbars on the left" configuration? 1707865 5 zalan 2020-11-16 09:58:58 -0800 >Does this support the "scrollbars on the left" configuration? Certainly not. This is about reserving space for the scrollbars which is pretty much all we need in the context of layout (unless I miss something here). 1707878 6 simon.fraser 2020-11-16 10:19:04 -0800 The left-side scrollbar does take space, so I think you'd have to support it. See shouldPlaceBlockDirectionScrollbarOnLeft() 1707942 7 zalan 2020-11-16 12:18:11 -0800 (In reply to Simon Fraser (smfr) from comment #6) > The left-side scrollbar does take space, so I think you'd have to support > it. See shouldPlaceBlockDirectionScrollbarOnLeft() Let me rephrase it. This is an integration patch, so whatever the renderer has as scrollbar space, we reserve the same amount of pixels in BoxGeometry (when we copy the pre-computed geometry from RenderTree to LayoutTree). What I meant by "certainly not" was that at this point we don't really care whether it's a left or right scrollbar. 414153 2020-11-14 20:38:29 -0800 2020-11-15 06:23:46 -0800 Patch bug-218950-20201114203828.patch text/plain 6659 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5ODE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGQyZjJkMTYzYjU2OWM0 MWIzMjIwNjlhZTAwOTlhNWViMWY5ZTU1MC4uMmEzODc3MTJhYjVhMTc2ZWVlNGNmMTU3NmQ2NzY0 MjBiZTUyOWVlMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDIwLTExLTE0ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bR2VvbWV0cnldIEFk ZCBzdXBwb3J0IGZvciBob3Jpem9udGFsL3ZlcnRpY2FsIHNjcm9sbGJhciBzcGFjaW5nCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTg5NTAKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBMZXQncyBtYWtlIHJv b20gZm9yIHZpc2libGUgc2Nyb2xsYmFycyBiZXR3ZWVuIHRoZSBib3JkZXIgYW5kIHRoZSBwYWRk aW5nIGJveC4KKworICAgICAgICAqIGxheW91dC9pbnRlZ3JhdGlvbi9MYXlvdXRJbnRlZ3JhdGlv bkxpbmVMYXlvdXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0SW50ZWdyYXRpb246Okxp bmVMYXlvdXQ6OnVwZGF0ZUxheW91dEJveERpbWVuc2lvbnMpOgorICAgICAgICAqIGxheW91dC9s YXlvdXR0cmVlL0xheW91dEJveEdlb21ldHJ5LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkxheW91 dDo6Qm94R2VvbWV0cnk6OkJveEdlb21ldHJ5KToKKyAgICAgICAgKFdlYkNvcmU6OkxheW91dDo6 Qm94R2VvbWV0cnk6OnBhZGRpbmdCb3ggY29uc3QpOgorICAgICAgICAqIGxheW91dC9sYXlvdXR0 cmVlL0xheW91dEJveEdlb21ldHJ5Lmg6CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6OkJveEdl b21ldHJ5Ojpib3JkZXJCb3hIZWlnaHQgY29uc3QpOgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0 OjpCb3hHZW9tZXRyeTo6Ym9yZGVyQm94V2lkdGggY29uc3QpOgorICAgICAgICAoV2ViQ29yZTo6 TGF5b3V0OjpCb3hHZW9tZXRyeTo6dmVydGljYWxTY3JvbGxiYXJXaWR0aCBjb25zdCk6CisgICAg ICAgIChXZWJDb3JlOjpMYXlvdXQ6OkJveEdlb21ldHJ5Ojpob3Jpem9udGFsU2Nyb2xsYmFySGVp Z2h0IGNvbnN0KToKKyAgICAgICAgKFdlYkNvcmU6OkxheW91dDo6Qm94R2VvbWV0cnk6OnNldFZl cnRpY2FsU2Nyb2xsYmFyV2lkdGgpOgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0OjpCb3hHZW9t ZXRyeTo6c2V0SG9yaXpvbnRhbFNjcm9sbGJhckhlaWdodCk6CisKIDIwMjAtMTEtMTQgIFphbGFu IEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICAiVHlwbyIgaW4gcjI2OTgyMSAo Ynkgc3RkOjpudW1lcmljX2xpbWl0czw+OjptaW4gSSByZWFsbHkgbWVhbnQgc3RkOjpudW1lcmlj X2xpbWl0czw+Ojpsb3dlc3QgKGdvdCB0cmlja2VkIGJ5IHRoZSBmbG9hdGluZy1wb2ludCB0eXBl IGJlaGF2aW9yKSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbnRlZ3JhdGlv bi9MYXlvdXRJbnRlZ3JhdGlvbkxpbmVMYXlvdXQuY3BwIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0 L2ludGVncmF0aW9uL0xheW91dEludGVncmF0aW9uTGluZUxheW91dC5jcHAKaW5kZXggNmRlNTIx NTYzOTI1MTAxZTEyZmRjNjhkOGJjM2Q1YjU1ODg3NzIxZS4uNDliYTM4NTM1NmVlZTIzNGIxZTJh NjM4MWNlNjdkZjNmNWFlMjE2NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lu dGVncmF0aW9uL0xheW91dEludGVncmF0aW9uTGluZUxheW91dC5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvbGF5b3V0L2ludGVncmF0aW9uL0xheW91dEludGVncmF0aW9uTGluZUxheW91dC5jcHAK QEAgLTEyNyw2ICsxMjcsMTAgQEAgdm9pZCBMaW5lTGF5b3V0Ojp1cGRhdGVMYXlvdXRCb3hEaW1l bnNpb25zKGNvbnN0IFJlbmRlckJveCYgcmVwbGFjZWRPcklubGluZUJsb2MKICAgICAvLyBBbHdh eXMgdXNlIHRoZSBwaHlzaWNhbCBzaXplIGhlcmUgZm9yIGlubGluZSBsZXZlbCBib3hlcyAodGhp cyBpcyB3aGVyZSB0aGUgbG9naWNhbCB2cy4gcGh5c2ljYWwgY29vcmRzIGZsaXAgaGFwcGVucyku CiAgICAgcmVwbGFjZWRCb3guc2V0Q29udGVudFNpemVGb3JJbnRlZ3JhdGlvbih7IHJlcGxhY2Vk T3JJbmxpbmVCbG9jay5jb250ZW50V2lkdGgoKSwgcmVwbGFjZWRPcklubGluZUJsb2NrLmNvbnRl bnRIZWlnaHQoKSB9KTsKIAorICAgIGF1dG8mIHJlcGxhY2VkQm94R2VvbWV0cnkgPSBtX2xheW91 dFN0YXRlLmVuc3VyZUdlb21ldHJ5Rm9yQm94KHJlcGxhY2VkQm94KTsKKyAgICByZXBsYWNlZEJv eEdlb21ldHJ5LnNldFZlcnRpY2FsU2Nyb2xsYmFyV2lkdGgocmVwbGFjZWRPcklubGluZUJsb2Nr LnZlcnRpY2FsU2Nyb2xsYmFyV2lkdGgoKSk7CisgICAgcmVwbGFjZWRCb3hHZW9tZXRyeS5zZXRI b3Jpem9udGFsU2Nyb2xsYmFySGVpZ2h0KHJlcGxhY2VkT3JJbmxpbmVCbG9jay5ob3Jpem9udGFs U2Nyb2xsYmFySGVpZ2h0KCkpOworCiAgICAgYXV0byBiYXNlbGluZSA9IHJlcGxhY2VkT3JJbmxp bmVCbG9jay5iYXNlbGluZVBvc2l0aW9uKEFscGhhYmV0aWNCYXNlbGluZSwgZmFsc2UgLyogZmly c3RMaW5lICovLCBIb3Jpem9udGFsTGluZSwgUG9zaXRpb25PbkNvbnRhaW5pbmdMaW5lKTsKICAg ICByZXBsYWNlZEJveC5zZXRCYXNlbGluZShiYXNlbGluZSk7CiB9CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9sYXlvdXQvbGF5b3V0dHJlZS9MYXlvdXRCb3hHZW9tZXRyeS5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9sYXlvdXQvbGF5b3V0dHJlZS9MYXlvdXRCb3hHZW9tZXRyeS5jcHAKaW5kZXgg ZmQ4NTJkM2M1YzE2MzFjM2UwMzUxOWNkODdkNWJkNjgzMDg2NTM3MS4uMDFiMGJmYWYzNzkwMDY1 MjI5OTk3NzE1ZDQ3NWVhNDZhMjQwZDBkMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbGF5 b3V0L2xheW91dHRyZWUvTGF5b3V0Qm94R2VvbWV0cnkuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2xheW91dC9sYXlvdXR0cmVlL0xheW91dEJveEdlb21ldHJ5LmNwcApAQCAtNDMsNiArNDMsOCBA QCBCb3hHZW9tZXRyeTo6Qm94R2VvbWV0cnkoY29uc3QgQm94R2VvbWV0cnkmIG90aGVyKQogICAg ICwgbV92ZXJ0aWNhbE1hcmdpbihvdGhlci5tX3ZlcnRpY2FsTWFyZ2luKQogICAgICwgbV9ib3Jk ZXIob3RoZXIubV9ib3JkZXIpCiAgICAgLCBtX3BhZGRpbmcob3RoZXIubV9wYWRkaW5nKQorICAg ICwgbV92ZXJ0aWNhbFNjcm9sbGJhcldpZHRoKG90aGVyLm1fdmVydGljYWxTY3JvbGxiYXJXaWR0 aCkKKyAgICAsIG1faG9yaXpvbnRhbFNjcm9sbGJhckhlaWdodChvdGhlci5tX2hvcml6b250YWxT Y3JvbGxiYXJIZWlnaHQpCiAjaWYgQVNTRVJUX0VOQUJMRUQKICAgICAsIG1faGFzVmFsaWRUb3Ao b3RoZXIubV9oYXNWYWxpZFRvcCkKICAgICAsIG1faGFzVmFsaWRMZWZ0KG90aGVyLm1faGFzVmFs aWRMZWZ0KQpAQCAtODgsOCArOTAsOCBAQCBSZWN0IEJveEdlb21ldHJ5OjpwYWRkaW5nQm94KCkg Y29uc3QKICAgICBSZWN0IHBhZGRpbmdCb3g7CiAgICAgcGFkZGluZ0JveC5zZXRUb3AoYm9yZGVy Qm94LnRvcCgpICsgYm9yZGVyVG9wKCkpOwogICAgIHBhZGRpbmdCb3guc2V0TGVmdChib3JkZXJC b3gubGVmdCgpICsgYm9yZGVyTGVmdCgpKTsKLSAgICBwYWRkaW5nQm94LnNldEhlaWdodChib3Jk ZXJCb3guYm90dG9tKCkgLSBib3JkZXJUb3AoKSAtIGJvcmRlckJvdHRvbSgpKTsKLSAgICBwYWRk aW5nQm94LnNldFdpZHRoKGJvcmRlckJveC53aWR0aCgpIC0gYm9yZGVyTGVmdCgpIC0gYm9yZGVy UmlnaHQoKSk7CisgICAgcGFkZGluZ0JveC5zZXRIZWlnaHQoYm9yZGVyQm94LmJvdHRvbSgpIC0g aG9yaXpvbnRhbFNjcm9sbGJhckhlaWdodCgpIC0gYm9yZGVyQm90dG9tKCkgLSBib3JkZXJUb3Ao KSk7CisgICAgcGFkZGluZ0JveC5zZXRXaWR0aChib3JkZXJCb3gud2lkdGgoKSAtIGJvcmRlclJp Z2h0KCkgLSB2ZXJ0aWNhbFNjcm9sbGJhcldpZHRoKCkgLSBib3JkZXJMZWZ0KCkpOwogICAgIHJl dHVybiBwYWRkaW5nQm94OwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQv bGF5b3V0dHJlZS9MYXlvdXRCb3hHZW9tZXRyeS5oIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2xh eW91dHRyZWUvTGF5b3V0Qm94R2VvbWV0cnkuaAppbmRleCA1NDk1ZDQyMDk4MDFjZWYzODM1NjRl MjM1YmNkM2E0ZmY2YTcxZTRiLi4wYTBiOGFlZDc3YTcyZGExMjc2MmQyYzczMGMyYzMxMzlkNzk0 Mjk3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvbGF5b3V0dHJlZS9MYXlvdXRC b3hHZW9tZXRyeS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9sYXlvdXR0cmVlL0xheW91 dEJveEdlb21ldHJ5LmgKQEAgLTkxLDE0ICs5MSwxNyBAQCBwdWJsaWM6CiAgICAgTGF5b3V0VW5p dCBwYWRkaW5nQm94SGVpZ2h0KCkgY29uc3QgeyByZXR1cm4gcGFkZGluZ1RvcCgpLnZhbHVlT3Io MCkgKyBjb250ZW50Qm94SGVpZ2h0KCkgKyBwYWRkaW5nQm90dG9tKCkudmFsdWVPcigwKTsgfQog ICAgIExheW91dFVuaXQgcGFkZGluZ0JveFdpZHRoKCkgY29uc3QgeyByZXR1cm4gcGFkZGluZ0xl ZnQoKS52YWx1ZU9yKDApICsgY29udGVudEJveFdpZHRoKCkgKyBwYWRkaW5nUmlnaHQoKS52YWx1 ZU9yKDApOyB9CiAKLSAgICBMYXlvdXRVbml0IGJvcmRlckJveEhlaWdodCgpIGNvbnN0IHsgcmV0 dXJuIGJvcmRlclRvcCgpICsgcGFkZGluZ0JveEhlaWdodCgpICsgYm9yZGVyQm90dG9tKCk7IH0K LSAgICBMYXlvdXRVbml0IGJvcmRlckJveFdpZHRoKCkgY29uc3QgeyByZXR1cm4gYm9yZGVyTGVm dCgpICsgcGFkZGluZ0JveFdpZHRoKCkgKyBib3JkZXJSaWdodCgpOyB9CisgICAgTGF5b3V0VW5p dCBib3JkZXJCb3hIZWlnaHQoKSBjb25zdCB7IHJldHVybiBib3JkZXJUb3AoKSArIHBhZGRpbmdC b3hIZWlnaHQoKSArIGhvcml6b250YWxTY3JvbGxiYXJIZWlnaHQoKSArIGJvcmRlckJvdHRvbSgp OyB9CisgICAgTGF5b3V0VW5pdCBib3JkZXJCb3hXaWR0aCgpIGNvbnN0IHsgcmV0dXJuIGJvcmRl ckxlZnQoKSArIHBhZGRpbmdCb3hXaWR0aCgpICsgdmVydGljYWxTY3JvbGxiYXJXaWR0aCgpICsg Ym9yZGVyUmlnaHQoKTsgfQogICAgIExheW91dFVuaXQgbWFyZ2luQm94SGVpZ2h0KCkgY29uc3Qg eyByZXR1cm4gbWFyZ2luQmVmb3JlKCkgKyBib3JkZXJCb3hIZWlnaHQoKSArIG1hcmdpbkFmdGVy KCk7IH0KICAgICBMYXlvdXRVbml0IG1hcmdpbkJveFdpZHRoKCkgY29uc3QgeyByZXR1cm4gbWFy Z2luU3RhcnQoKSArIGJvcmRlckJveFdpZHRoKCkgKyBtYXJnaW5FbmQoKTsgfQogCiAgICAgTGF5 b3V0VW5pdCB2ZXJ0aWNhbE1hcmdpbkJvcmRlckFuZFBhZGRpbmcoKSBjb25zdCB7IHJldHVybiBt YXJnaW5CZWZvcmUoKSArIHZlcnRpY2FsQm9yZGVyKCkgKyB2ZXJ0aWNhbFBhZGRpbmcoKS52YWx1 ZU9yKDApICsgbWFyZ2luQWZ0ZXIoKTsgfQogICAgIExheW91dFVuaXQgaG9yaXpvbnRhbE1hcmdp bkJvcmRlckFuZFBhZGRpbmcoKSBjb25zdCB7IHJldHVybiBtYXJnaW5TdGFydCgpICsgaG9yaXpv bnRhbEJvcmRlcigpICsgaG9yaXpvbnRhbFBhZGRpbmcoKS52YWx1ZU9yKDApICsgbWFyZ2luRW5k KCk7IH0KIAorICAgIExheW91dFVuaXQgdmVydGljYWxTY3JvbGxiYXJXaWR0aCgpIGNvbnN0IHsg cmV0dXJuIG1fdmVydGljYWxTY3JvbGxiYXJXaWR0aDsgfQorICAgIExheW91dFVuaXQgaG9yaXpv bnRhbFNjcm9sbGJhckhlaWdodCgpIGNvbnN0IHsgcmV0dXJuIG1faG9yaXpvbnRhbFNjcm9sbGJh ckhlaWdodDsgfQorCiAgICAgUmVjdCBtYXJnaW5Cb3goKSBjb25zdDsKICAgICBSZWN0IGJvcmRl ckJveCgpIGNvbnN0OwogICAgIFJlY3QgcGFkZGluZ0JveCgpIGNvbnN0OwpAQCAtMTI3LDYgKzEz MCw5IEBAIHB1YmxpYzoKICAgICB2b2lkIHNldFZlcnRpY2FsUGFkZGluZyhMYXlvdXQ6OlZlcnRp Y2FsRWRnZXMpOwogICAgIHZvaWQgc2V0UGFkZGluZyhPcHRpb25hbDxMYXlvdXQ6OkVkZ2VzPik7 CiAKKyAgICB2b2lkIHNldFZlcnRpY2FsU2Nyb2xsYmFyV2lkdGgoTGF5b3V0VW5pdCB3aWR0aCkg eyBtX3ZlcnRpY2FsU2Nyb2xsYmFyV2lkdGggPSB3aWR0aDsgfQorICAgIHZvaWQgc2V0SG9yaXpv bnRhbFNjcm9sbGJhckhlaWdodChMYXlvdXRVbml0IGhlaWdodCkgeyBtX2hvcml6b250YWxTY3Jv bGxiYXJIZWlnaHQgPSBoZWlnaHQ7IH0KKwogcHJpdmF0ZToKICAgICBMYXlvdXRVbml0IGxvZ2lj YWxUb3AoKSBjb25zdDsKICAgICBMYXlvdXRVbml0IGxvZ2ljYWxMZWZ0KCkgY29uc3Q7CkBAIC0x NjAsNiArMTY2LDkgQEAgcHJpdmF0ZToKICAgICBMYXlvdXQ6OkVkZ2VzIG1fYm9yZGVyOwogICAg IE9wdGlvbmFsPExheW91dDo6RWRnZXM+IG1fcGFkZGluZzsKIAorICAgIExheW91dFVuaXQgbV92 ZXJ0aWNhbFNjcm9sbGJhcldpZHRoOworICAgIExheW91dFVuaXQgbV9ob3Jpem9udGFsU2Nyb2xs YmFySGVpZ2h0OworCiAjaWYgQVNTRVJUX0VOQUJMRUQKICAgICBib29sIG1faGFzVmFsaWRUb3Ag eyBmYWxzZSB9OwogICAgIGJvb2wgbV9oYXNWYWxpZExlZnQgeyBmYWxzZSB9Owo=