218948 2020-11-14 15:35:06 -0800 [LFC] Do not use RenderStyle's logical margin API 2020-11-15 06:27:17 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham koivisto sam simon.fraser webkit-bug-importer zalan oldest_to_newest 1707546 0 zalan 2020-11-14 15:35:06 -0800 it flips the values based on the box's own writing mode and not the writing mode the box lives in. see https://www.w3.org/TR/css-writing-modes-4/#logical-direction-layout 1707548 1 414146 zalan 2020-11-14 15:44:04 -0800 Created attachment 414146 Patch 1707552 2 414146 sam 2020-11-14 16:19:17 -0800 Comment on attachment 414146 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414146&action=review > Source/WebCore/ChangeLog:16 > + RenderStyle::marginStart/End/Before/After flips these values based on the box's own writing mode. Should these RenderStyle functions be renamed to make it more clear? 1707561 3 zalan 2020-11-14 20:22:35 -0800 (In reply to Sam Weinig from comment #2) > Comment on attachment 414146 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=414146&action=review > > > Source/WebCore/ChangeLog:16 > > + RenderStyle::marginStart/End/Before/After flips these values based on the box's own writing mode. > > Should these RenderStyle functions be renamed to make it more clear? Most certainly. I am not sure though what their name would be like. Guess I should figure out the cases where we would call them first. 1707597 4 ews-feeder 2020-11-15 06:26:04 -0800 Committed r269826: <https://trac.webkit.org/changeset/269826> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414146. 1707598 5 webkit-bug-importer 2020-11-15 06:27:17 -0800 <rdar://problem/71414284> 414146 2020-11-14 15:44:04 -0800 2020-11-15 06:26:05 -0800 Patch bug-218948-20201114154403.patch text/plain 4245 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5ODE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjQ4ZDdiYjgwYzRmOGE5 ZWNjMDhjZTA0NjliZWNmOGNjZmNkMjVjMi4uODY5MDA3YWIyOTg1MThkNTQ1YTdkNTdkY2NmZTBm ZjRkY2U5NjkzNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDIwLTExLTE0ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ10gRG8gbm90IHVzZSBS ZW5kZXJTdHlsZSdzIGxvZ2ljYWwgbWFyZ2luIEFQSQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE4OTQ4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly93d3cudzMub3JnL1RSL2Nzcy13cml0aW5n LW1vZGVzLTQvI2xvZ2ljYWwtZGlyZWN0aW9uLWxheW91dAorCisgICAgICAgICJGbG93LXJlbGF0 aXZlIGRpcmVjdGlvbnMgYXJlIGNhbGN1bGF0ZWQgd2l0aCByZXNwZWN0IHRvIHRoZSB3cml0aW5n IG1vZGUgb2YgdGhlIGNvbnRhaW5pbmcgYmxvY2sgb2YgdGhlIGJveAorICAgICAgICBhbmQgdXNl ZCB0byBhYnN0cmFjdCBsYXlvdXQgcnVsZXMgcmVsYXRlZCB0byB0aGUgYm94IHByb3BlcnRpZXMg KG1hcmdpbnMsIGJvcmRlcnMsIHBhZGRpbmcpCisgICAgICAgIGFuZCBhbnkgcHJvcGVydGllcyBy ZWxhdGVkIHRvIHBvc2l0aW9uaW5nIHRoZSBib3ggd2l0aGluIGl0cyBjb250YWluaW5nIGJsb2Nr CisgICAgICAgIChmbG9hdCwgY2xlYXIsIHRvcCwgYm90dG9tLCBsZWZ0LCByaWdodCwgY2FwdGlv bi1zaWRlKS4KKyAgICAgICAgRm9yIGlubGluZS1sZXZlbCBib3hlcywgdGhlIHdyaXRpbmcgbW9k ZSBvZiB0aGUgcGFyZW50IGJveCBpcyB1c2VkIGluc3RlYWQuIgorCisgICAgICAgIFJlbmRlclN0 eWxlOjptYXJnaW5TdGFydC9FbmQvQmVmb3JlL0FmdGVyIGZsaXBzIHRoZXNlIHZhbHVlcyBiYXNl ZCBvbiB0aGUgYm94J3Mgb3duIHdyaXRpbmcgbW9kZS4KKworICAgICAgICAqIGxheW91dC9Gb3Jt YXR0aW5nQ29udGV4dEdlb21ldHJ5LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkxheW91dDo6dXNl ZFdyaXRpbmdNb2RlKToKKyAgICAgICAgKFdlYkNvcmU6OkxheW91dDo6Rm9ybWF0dGluZ0NvbnRl eHQ6Okdlb21ldHJ5Ojpjb21wdXRlZEhvcml6b250YWxNYXJnaW4gY29uc3QpOgorICAgICAgICAo V2ViQ29yZTo6TGF5b3V0OjpGb3JtYXR0aW5nQ29udGV4dDo6R2VvbWV0cnk6OmNvbXB1dGVkVmVy dGljYWxNYXJnaW4gY29uc3QpOgorCiAyMDIwLTExLTE0ICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBh cHBsZS5jb20+CiAKICAgICAgICAgW0xGQ11bSUZDXSBOZWdhdGl2ZSBtYXJnaW4gYmVmb3JlICg+ Ym9yZGVyIGJveCBoZWlnaHQgdmFsdWUpIGNvbXBsZXRlbHkgcHVsbHMgdGhlIGlubGluZSBsZXZl bCBib3ggb3V0IG9mIHRoZSBsaW5lIGJveApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbGF5 b3V0L0Zvcm1hdHRpbmdDb250ZXh0R2VvbWV0cnkuY3BwIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0 L0Zvcm1hdHRpbmdDb250ZXh0R2VvbWV0cnkuY3BwCmluZGV4IDM0NjY3ZGJjODIwYjUxZDI3ZWU5 NmZhNmFiMDI1ZDA5YTg4NjIzMzQuLjBjYmIwNTRiMWQwYTY1ZDJjYjhlZWJiNjM3OTc2NWU0Y2M4 YjM3NDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9Gb3JtYXR0aW5nQ29udGV4 dEdlb21ldHJ5LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvRm9ybWF0dGluZ0NvbnRl eHRHZW9tZXRyeS5jcHAKQEAgLTExMjIsNiArMTEyMiwxNCBAQCBMYXlvdXRTaXplIEZvcm1hdHRp bmdDb250ZXh0OjpHZW9tZXRyeTo6aW5GbG93UG9zaXRpb25lZFBvc2l0aW9uT2Zmc2V0KGNvbnN0 IEJveAogICAgIHJldHVybiB7IGxlZnRQb3NpdGlvbk9mZnNldCwgdG9wUG9zaXRpb25PZmZzZXQg fTsKIH0KIAoraW5saW5lIHN0YXRpYyBXcml0aW5nTW9kZSB1c2VkV3JpdGluZ01vZGUoY29uc3Qg Qm94JiBsYXlvdXRCb3gpCit7CisgICAgLy8gaHR0cHM6Ly93d3cudzMub3JnL1RSL2Nzcy13cml0 aW5nLW1vZGVzLTQvI2xvZ2ljYWwtZGlyZWN0aW9uLWxheW91dAorICAgIC8vIEZsb3ctcmVsYXRp dmUgZGlyZWN0aW9ucyBhcmUgY2FsY3VsYXRlZCB3aXRoIHJlc3BlY3QgdG8gdGhlIHdyaXRpbmcg bW9kZSBvZiB0aGUgY29udGFpbmluZyBibG9jayBvZiB0aGUgYm94LgorICAgIC8vIEZvciBpbmxp bmUtbGV2ZWwgYm94ZXMsIHRoZSB3cml0aW5nIG1vZGUgb2YgdGhlIHBhcmVudCBib3ggaXMgdXNl ZCBpbnN0ZWFkLgorICAgIHJldHVybiBsYXlvdXRCb3guaXNJbmxpbmVMZXZlbEJveCgpID8gbGF5 b3V0Qm94LnBhcmVudCgpLnN0eWxlKCkud3JpdGluZ01vZGUoKSA6IGxheW91dEJveC5jb250YWlu aW5nQmxvY2soKS5zdHlsZSgpLndyaXRpbmdNb2RlKCk7Cit9CisKIEVkZ2VzIEZvcm1hdHRpbmdD b250ZXh0OjpHZW9tZXRyeTo6Y29tcHV0ZWRCb3JkZXIoY29uc3QgQm94JiBsYXlvdXRCb3gpIGNv bnN0CiB7CiAgICAgYXV0byYgc3R5bGUgPSBsYXlvdXRCb3guc3R5bGUoKTsKQEAgLTExNDksMTQg KzExNTcsMTggQEAgQ29tcHV0ZWRIb3Jpem9udGFsTWFyZ2luIEZvcm1hdHRpbmdDb250ZXh0OjpH ZW9tZXRyeTo6Y29tcHV0ZWRIb3Jpem9udGFsTWFyZ2luKGMKIHsKICAgICBhdXRvJiBzdHlsZSA9 IGxheW91dEJveC5zdHlsZSgpOwogICAgIGF1dG8gY29udGFpbmluZ0Jsb2NrV2lkdGggPSBob3Jp em9udGFsQ29uc3RyYWludHMubG9naWNhbFdpZHRoOwotICAgIHJldHVybiB7IGNvbXB1dGVkVmFs dWUoc3R5bGUubWFyZ2luU3RhcnQoKSwgY29udGFpbmluZ0Jsb2NrV2lkdGgpLCBjb21wdXRlZFZh bHVlKHN0eWxlLm1hcmdpbkVuZCgpLCBjb250YWluaW5nQmxvY2tXaWR0aCkgfTsKKyAgICBpZiAo aXNIb3Jpem9udGFsV3JpdGluZ01vZGUodXNlZFdyaXRpbmdNb2RlKGxheW91dEJveCkpKQorICAg ICAgICByZXR1cm4geyBjb21wdXRlZFZhbHVlKHN0eWxlLm1hcmdpbkxlZnQoKSwgY29udGFpbmlu Z0Jsb2NrV2lkdGgpLCBjb21wdXRlZFZhbHVlKHN0eWxlLm1hcmdpblJpZ2h0KCksIGNvbnRhaW5p bmdCbG9ja1dpZHRoKSB9OworICAgIHJldHVybiB7IGNvbXB1dGVkVmFsdWUoc3R5bGUubWFyZ2lu VG9wKCksIGNvbnRhaW5pbmdCbG9ja1dpZHRoKSwgY29tcHV0ZWRWYWx1ZShzdHlsZS5tYXJnaW5C b3R0b20oKSwgY29udGFpbmluZ0Jsb2NrV2lkdGgpIH07CiB9CiAKIENvbXB1dGVkVmVydGljYWxN YXJnaW4gRm9ybWF0dGluZ0NvbnRleHQ6Okdlb21ldHJ5Ojpjb21wdXRlZFZlcnRpY2FsTWFyZ2lu KGNvbnN0IEJveCYgbGF5b3V0Qm94LCBjb25zdCBIb3Jpem9udGFsQ29uc3RyYWludHMmIGhvcml6 b250YWxDb25zdHJhaW50cykgY29uc3QKIHsKICAgICBhdXRvJiBzdHlsZSA9IGxheW91dEJveC5z dHlsZSgpOwogICAgIGF1dG8gY29udGFpbmluZ0Jsb2NrV2lkdGggPSBob3Jpem9udGFsQ29uc3Ry YWludHMubG9naWNhbFdpZHRoOwotICAgIHJldHVybiB7IGNvbXB1dGVkVmFsdWUoc3R5bGUubWFy Z2luQmVmb3JlKCksIGNvbnRhaW5pbmdCbG9ja1dpZHRoKSwgY29tcHV0ZWRWYWx1ZShzdHlsZS5t YXJnaW5BZnRlcigpLCBjb250YWluaW5nQmxvY2tXaWR0aCkgfTsKKyAgICBpZiAoaXNIb3Jpem9u dGFsV3JpdGluZ01vZGUodXNlZFdyaXRpbmdNb2RlKGxheW91dEJveCkpKQorICAgICAgICByZXR1 cm4geyBjb21wdXRlZFZhbHVlKHN0eWxlLm1hcmdpblRvcCgpLCBjb250YWluaW5nQmxvY2tXaWR0 aCksIGNvbXB1dGVkVmFsdWUoc3R5bGUubWFyZ2luQm90dG9tKCksIGNvbnRhaW5pbmdCbG9ja1dp ZHRoKSB9OworICAgIHJldHVybiB7IGNvbXB1dGVkVmFsdWUoc3R5bGUubWFyZ2luTGVmdCgpLCBj b250YWluaW5nQmxvY2tXaWR0aCksIGNvbXB1dGVkVmFsdWUoc3R5bGUubWFyZ2luUmlnaHQoKSwg Y29udGFpbmluZ0Jsb2NrV2lkdGgpIH07CiB9CiAKIEZvcm1hdHRpbmdDb250ZXh0OjpJbnRyaW5z aWNXaWR0aENvbnN0cmFpbnRzIEZvcm1hdHRpbmdDb250ZXh0OjpHZW9tZXRyeTo6Y29uc3RyYWlu QnlNaW5NYXhXaWR0aChjb25zdCBCb3gmIGxheW91dEJveCwgSW50cmluc2ljV2lkdGhDb25zdHJh aW50cyBpbnRyaW5zaWNXaWR0aCkgY29uc3QK