218921 2020-11-13 13:47:45 -0800 [GTK][WPE] Build broken in stable 2.30.x releases with ENABLE_VIDEO=OFF 2020-11-16 03:17:54 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build Unspecified Unspecified RESOLVED FIXED https://bugs.busybox.net/show_bug.cgi?id=13306 P2 Normal --- 218615 1 aperez aperez cgarcia clopez mcatanzaro oldest_to_newest 1707378 0 aperez 2020-11-13 13:47:45 -0800 Error: In file included from /home/matuschd/buildroot-4/build/wpewebkit-2.30.2/DerivedSources/WebKit/unified-sources/UnifiedSource-54928a2b-6.cpp:2: /home/matuschd/buildroot-4/build/wpewebkit-2.30.2/Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.cpp: In member function ‘void WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner(WebKit::WebPageGroupProxy*, const WTF::String&, bool)’: /home/matuschd/buildroot-4/build/wpewebkit-2.30.2/Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.cpp:242:30: error: ‘class WebCore::Settings’ has no member named ‘setGenericCueAPIEnabled’; did you mean ‘setBeaconAPIEnabled’? page->settings().setGenericCueAPIEnabled(enabled); ^~~~~~~~~~~~~~~~~~~~~~~ setBeaconAPIEnabled 1707386 1 414092 aperez 2020-11-13 14:28:33 -0800 Created attachment 414092 Patch To be aplied in the webkit-2.30 branch 1707393 2 414092 mcatanzaro 2020-11-13 14:38:24 -0800 Comment on attachment 414092 Patch Every EWS is red! Once EWS is happy, just commit it. You don't need review for build fixes. 1707398 3 aperez 2020-11-13 14:46:43 -0800 (In reply to Michael Catanzaro from comment #2) > Comment on attachment 414092 [details] > Patch > > Every EWS is red! > > Once EWS is happy, just commit it. You don't need review for build fixes. The code touched by this was removed in trunk, note that the patch is for the webkit-2.30 branch, so of course the EWS builds *will* be red =] 1707758 4 aperez 2020-11-16 03:17:35 -0800 Thanks for the review, Carlos! I have not manually landed this in the webkit-2.30 branch 👍️ 414092 2020-11-13 14:28:33 -0800 2020-11-16 03:17:54 -0800 Patch bug-218921-20201114002831.patch text/plain 3137 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5NzgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGM4ODU0OGNhMDllNGU1 NmVkYTY1ZmYxN2U0OTI4NzUxMzViMTg4NS4uMDMxYWUwMjNiM2U3MTJjOWU0Mzg3MmI5MWU2MGEy MzZhM2Q1ZGI0NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIwLTExLTEzICBBZHJp YW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS11b V1BFXSBCdWlsZCBicm9rZW4gaW4gc3RhYmxlIDIuMzAueCByZWxlYXNlcyB3aXRoIEVOQUJMRV9W SURFTz1PRkYKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIxODkyMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IE5vIG5ldyB0ZXN0cyBuZWVkZWQuCisKKyAgICAgICAgKiBNb2R1bGVzL3dlYmF1ZGlvL0F1ZGlv Q29udGV4dC5jcHA6IEFkZCBtaXNzaW5nIERvY3VtZW50LmggaW5jbHVkZS4KKwogMjAyMC0xMC0y NyAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dT dHJlYW1lcl0gQmFkIGhhbmRsaW5nIG9mIGF1ZGlvIGZpbGVzIGluIHRoZSBJbWFnZURlY29kZXIK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggNDU4ZDZhZTc0ODQ2MzczMTFkNzFkYmE0MmY2MTBkZGQwYmIyYjg0OS4uYzkz MGVkOGMzMTEwNzY2NTNkMTEwYzAzODU5ZjE1OTA5OGIxNjdjYiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwxNSBAQAorMjAyMC0xMS0xMyAgQWRyaWFuIFBlcmV6IGRlIENhc3RybyAgPGFwZXJlekBpZ2Fs aWEuY29tPgorCisgICAgICAgIFtHVEtdW1dQRV0gQnVpbGQgYnJva2VuIGluIHN0YWJsZSAyLjMw LnggcmVsZWFzZXMgd2l0aCBFTkFCTEVfVklERU89T0ZGCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTg5MjEKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvSW5q ZWN0ZWRCdW5kbGUuY3BwOgorICAgICAgICAoV2ViS2l0OjpJbmplY3RlZEJ1bmRsZTo6b3ZlcnJp ZGVCb29sUHJlZmVyZW5jZUZvclRlc3RSdW5uZXIpOiBVc2UgRU5BQkxFKFZJREVPKQorICAgICAg ICBndWFyZCB0byBwcmV2ZW50IHVzYWdlIG9mIGZ1bmN0aW9uIHdoaWNoIGRvZXMgbm90IGdldCBj b21waWxlZCBpbiB3aGVuIHZpZGVvIHN1cHBvcnQKKyAgICAgICAgZGlzYWJsZWQKKwogMjAyMC0x MC0yMyAgQWRyaWFuIFBlcmV6IGRlIENhc3RybyAgPGFwZXJlekBpZ2FsaWEuY29tPgogCiAgICAg ICAgIFVucmV2aWV3ZWQuIFVwZGF0ZSBPcHRpb25zV1BFLmNtYWtlIGFuZCBORVdTIGZvciB0aGUg Mi4zMC4yIHJlbGVhc2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVk aW8vQXVkaW9Db250ZXh0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vQXVk aW9Db250ZXh0LmNwcAppbmRleCBhZWQzMjI4MDVlZjdhMGZjMWUwNmI2NjY2ODE1MmE1NDg3OGQz NzIzLi5iNjI3ZmFkZDNhOTRhZmIxZGExMmI3NmNiZmZlM2MyOWFiYzdlMDc2IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL0F1ZGlvQ29udGV4dC5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9BdWRpb0NvbnRleHQuY3BwCkBAIC0yOSw2 ICsyOSw3IEBACiAKICNpbmNsdWRlICJBdWRpb0NvbnRleHQuaCIKICNpbmNsdWRlICJEZWZhdWx0 QXVkaW9EZXN0aW5hdGlvbk5vZGUuaCIKKyNpbmNsdWRlICJEb2N1bWVudC5oIgogI2luY2x1ZGUg IkpTRE9NUHJvbWlzZURlZmVycmVkLmgiCiAjaW5jbHVkZSA8d3RmL0lzb01hbGxvY0lubGluZXMu aD4KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxl L0luamVjdGVkQnVuZGxlLmNwcCBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1 bmRsZS9JbmplY3RlZEJ1bmRsZS5jcHAKaW5kZXggNjEzMjZmMmU1NzMxNjg2NjQ1MmEyNTk4ZDc0 MjZmNWQxNWE1NzczMS4uZDc3NzY5OTdhYTA4ZWU4MzIxMjY0NDZlYmVhZWI4OTk1ZDVhOWJjZiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0luamVj dGVkQnVuZGxlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5k bGUvSW5qZWN0ZWRCdW5kbGUuY3BwCkBAIC0yMzYsMTIgKzIzNiwxNCBAQCB2b2lkIEluamVjdGVk QnVuZGxlOjpvdmVycmlkZUJvb2xQcmVmZXJlbmNlRm9yVGVzdFJ1bm5lcihXZWJQYWdlR3JvdXBQ cm94eSogcGFnZQogICAgICAgICBSdW50aW1lRW5hYmxlZEZlYXR1cmVzOjpzaGFyZWRGZWF0dXJl cygpLnNldFdlYlJUQ01ETlNJQ0VDYW5kaWRhdGVzRW5hYmxlZChlbmFibGVkKTsKICNlbmRpZgog CisjaWYgRU5BQkxFKFZJREVPKQogICAgIGlmIChwcmVmZXJlbmNlID09ICJXZWJLaXRHZW5lcmlj Q3VlQVBJRW5hYmxlZCIpIHsKICAgICAgICAgV2ViUHJlZmVyZW5jZXNTdG9yZTo6b3ZlcnJpZGVC b29sVmFsdWVGb3JLZXkoV2ViUHJlZmVyZW5jZXNLZXk6OmdlbmVyaWNDdWVBUElFbmFibGVkS2V5 KCksIGVuYWJsZWQpOwogICAgICAgICBmb3IgKGF1dG8qIHBhZ2UgOiBwYWdlcykKICAgICAgICAg ICAgIHBhZ2UtPnNldHRpbmdzKCkuc2V0R2VuZXJpY0N1ZUFQSUVuYWJsZWQoZW5hYmxlZCk7CiAg ICAgICAgIHJldHVybjsKICAgICB9CisjZW5kaWYKIAogI2lmIEVOQUJMRShHUFVfUFJPQ0VTUykK ICAgICBpZiAocHJlZmVyZW5jZSA9PSAiV2ViS2l0VXNlR1BVUHJvY2Vzc0Zvck1lZGlhIiB8fCBw cmVmZXJlbmNlID09ICJXZWJLaXRDYXB0dXJlQXVkaW9JbkdQVVByb2Nlc3NFbmFibGVkS2V5Iikg ewo=