21892 2008-10-25 19:22:14 -0700 nested SVGs inside html table element fail to hit-test correctly 2009-04-28 18:00:51 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Mac (Intel) OS X 10.5 RESOLVED DUPLICATE 25432 P3 Normal --- 1 bugs.webkit.org webkit-unassigned bdakin hyatt mitz oldest_to_newest 96689 0 bugs.webkit.org 2008-10-25 19:22:14 -0700 When I have an SVG document embedded inside another SVG document, and then functionality that relies on the mouse (such as click events in JavaScript, or hover attributes on CSS), then none of this is triggered for the lower document when the space above it is fill: none. 96690 1 24679 bugs.webkit.org 2008-10-25 19:24:06 -0700 Created attachment 24679 A simple test case for the problem This test case is pretty straight forward - it shows an example of an element with both a CSS :hover attribute, and a JavaScript onclick attribute. In FireFox, both 'work' as intended; in WebKit, neither does. 96692 2 bugs.webkit.org 2008-10-25 19:25:14 -0700 *** Bug 21890 has been marked as a duplicate of this bug. *** 96693 3 mitz 2008-10-25 19:26:53 -0700 Confirming based on difference from Firefox. 96695 4 mrowe 2008-10-25 19:44:58 -0700 *** Bug 21891 has been marked as a duplicate of this bug. *** 96763 5 eric 2008-10-27 13:25:32 -0700 This is about embedding SVG content in HTML. The mouse events seem to be off in that case. 96764 6 24690 eric 2008-10-27 13:26:17 -0700 Created attachment 24690 A reduction which shows this is not a problem with raw SVGs 96769 7 24692 eric 2008-10-27 13:39:45 -0700 Created attachment 24692 simpler test case (hovering the blue square should turn it green) 96771 8 eric 2008-10-27 13:51:39 -0700 Ok, the bug is that this code in RenderSVGContainer::nodeAtPoint if (!viewport().isEmpty() && style()->overflowX() == OHIDDEN && style()->overflowY() == OHIDDEN) { // Check if we need to do anything at all. IntRect overflowBox = overflowRect(false); overflowBox.move(_tx, _ty); AffineTransform ctm = RenderObject::absoluteTransform(); ctm.translate(viewport().x(), viewport().y()); double localX, localY; ctm.inverse().map(_x - _tx, _y - _ty, &localX, &localY); if (!overflowBox.contains((int)localX, (int)localY)) return false; } Is getting back an overflowBox with a height of -1. I'm not sure why, but something is wrong with the overflowBox calculation here it seems. 96773 9 eric 2008-10-27 14:09:04 -0700 The inner <svg> (RenderSVGViewportContainer) seems to be asking the outer <td> (its containing block) for its height, that's returning a length object 0, which turns into -1 based on this calculation: // We need to stop here, since we don't want to increase the height of the table // artificially. We're going to rely on this cell getting expanded to some new // height, and then when we lay out again we'll use the calculation below. if (isTableCell() && (h.isAuto() || h.isPercent())) return overrideSize() - (borderLeft() + borderRight() + paddingLeft() + paddingRight()); It seems that this "second pass" is not happening correctly for SVG content. Maybe hyatt or beth have some clue what is supposed to be going on here. 96774 10 eric 2008-10-27 14:10:01 -0700 I think the inner <svg> (RenderSVGViewportContainer) shouldn't be asking its containing block for height, or if it does, that "containing block" should be the outer <svg>. I think that's the part which is wrong here. 96776 11 eric 2008-10-27 14:11:27 -0700 We end up asking the containing block via: void RenderSVGViewportContainer::layout() which calls "calcBounds()": void RenderSVGContainer::calcBounds() { m_width = calcReplacedWidth(); m_height = calcReplacedHeight(); m_absoluteBounds = absoluteClippedOverflowRect(); } int RenderSVGContainer::calcReplacedHeight() const { switch (style()->height().type()) { case Fixed: return max(0, style()->height().value()); case Percent: { RenderBlock* cb = containingBlock(); return style()->height().calcValue(cb->availableHeight()); } default: return 0; } } It seems that containing block call is likely wrong. 96777 12 24693 bugs.webkit.org 2008-10-27 14:18:19 -0700 Created attachment 24693 Testcase using an actual table instead of display: table; Might be considered a more consice test case - display: table; isn't necessary, this happens with a real table element as well. 96779 13 eric 2008-10-27 14:21:38 -0700 I think is actually entirely an SVG problem. SVG deals with "viewport elements", unfortunately we don't really expose such in the render tree. The DOM tree can be asked for things like the nearestViewportElement() via SVGElement. SVGLength knows how to look for the closest viewport element and resolve relative to that, but width and length are not defined as SVGLength elements in this context, they're pulled from the RenderStyle as Length objects. So I think this is just yet another side-effect of having a separate SVGLength class, and not very well exposting the whole "viewport" system in the render tree. 119234 14 eric 2009-04-28 17:31:33 -0700 This looks to be fixed by http://trac.webkit.org/changeset/42960 bug 25432. We should still land these as test cases in LayoutTests. 119238 15 29873 eric 2009-04-28 17:50:53 -0700 Created attachment 29873 Add a couple table hit tests 5 files changed, 95 insertions(+), 0 deletions(-) 119239 16 29873 simon.fraser 2009-04-28 17:52:56 -0700 Comment on attachment 29873 Add a couple table hit tests > + if (window.eventSender) { > + layoutTestController.dumpAsText(); > + eventSender.mouseMoveTo(50, 50); > + eventSender.mouseDown(); > + eventSender.mouseUp(); I think using document.elementFromPoint() is preferable, because then your test works outside of DRT. 119240 17 29874 eric 2009-04-28 17:57:44 -0700 Created attachment 29874 Add a couple table hit tests 5 files changed, 81 insertions(+), 0 deletions(-) 119242 18 eric 2009-04-28 18:00:51 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog A LayoutTests/svg/hittest/svg-inside-display-table-expected.txt A LayoutTests/svg/hittest/svg-inside-display-table.xhtml A LayoutTests/svg/hittest/svg-inside-table-expected.txt A LayoutTests/svg/hittest/svg-inside-table.xhtml Committed r42977 *** This bug has been marked as a duplicate of 25432 *** 24679 2008-10-25 19:24:06 -0700 2008-10-27 13:39:45 -0700 A simple test case for the problem svg-in-svg-transparent-clickthrough-testcase.xhtml application/xhtml+xml 3189 bugs.webkit.org PD94bWwgdmVyc2lvbj0nMS4wJyBlbmNvZGluZz0nVVRGLTgnIHN0YW5kYWxvbmU9J25vJz8+Cjwh RE9DVFlQRSBodG1sIFBVQkxJQyAnLS8vVzNDLy9EVEQgWEhUTUwgMS4xIHBsdXMgTWF0aE1MIDIu MCBwbHVzIFNWRyAxLjEvL0VOJyAnaHR0cDovL3d3dy53My5vcmcvMjAwMi8wNC94aHRtZmwtbWF0 aC1zdmcveGh0bWwtbWF0aC1zdmctZmxhdC5kdGQnPgo8aHRtbCB4bWxucz0naHR0cDovL3d3dy53 My5vcmcvMTk5OS94aHRtbCcgeG1sOmxhbmc9J2VuJz4KICA8aGVhZD4KICAgIDxtZXRhIGh0dHAt ZXF1aXY9J0NvbnRlbnQtVHlwZScgY29udGVudD0nYXBwbGljYXRpb24veGh0bWwreG1sO2NoYXJz ZXQ9dXRmLTgnLz4KICAgIDx0aXRsZT5TVkctaW4tU1ZHLWluLVhIVE1MIHRyYW5zcGFyZW5jeSBt b3VzZS1mYWxsLXRocm91Z2ggdGVzdCBjYXNlPC90aXRsZT4KICAgIDxsaW5rIHJlbD0nY29weXJp Z2h0JyBocmVmPSdodHRwOi8vY3JlYXRpdmVjb21tb25zLm9yZy9saWNlbnNlcy9ieS1uYy1zYS8z LjAvJyB0eXBlPSd0ZXh0L2h0bWw7Y2hhcnNldD11dGYtOCcvPgogICAgCiAgICA8c3R5bGU+CiAg ICAgICogewogICAgICAgIG1hcmdpbjogMDsKICAgICAgICBwYWRkaW5nOiAwOwogICAgICB9CiAg ICAgIGh0bWwsIGJvZHkgewogICAgICAgIGhlaWdodDogMTAwJTsKICAgICAgfQogICAgICBodG1s IHsKICAgICAgICBiYWNrZ3JvdW5kOiAjMDAwMDAwOwogICAgICAgIGNvbG9yOiAjRkZGRkZGOwog ICAgICB9CiAgICAgIGJvZHkgewogICAgICAgIHBvc2l0aW9uOiByZWxhdGl2ZTsKICAgICAgICBk aXNwbGF5OiB0YWJsZTsKICAgICAgICBtYXJnaW46IDAgYXV0bzsKICAgICAgICB2ZXJ0aWNhbC1h bGlnbjogbWlkZGxlOwogICAgICB9CiAgICAgICNldmVyeXRoaW5nIHsKICAgICAgICB3aWR0aDog NTBlbTsKICAgICAgICBkaXNwbGF5OiB0YWJsZS1jZWxsOwogICAgICAgIHZlcnRpY2FsLWFsaWdu OiBtaWRkbGU7CiAgICAgIH0KICAgICAgCiAgICAgIHAgeyBwYWRkaW5nOiAxZW07IHRleHQtYWxp Z246IGNlbnRlcjt9CiAgICAgIAogICAgICAjb3V0ZXIgewogICAgICAgIG1hcmdpbi1sZWZ0OiBh dXRvOwogICAgICAgIG1hcmdpbi1yaWdodDogYXV0bzsKICAgICAgfQogICAgICAKICAgICAgI2Jv YXJkX2JvcmRlciB7CiAgICAgICAgZmlsbDogbm9uZTsKICAgICAgICBzdHJva2U6IHdoaXRlOwog ICAgICAgIHN0cm9rZS13aWR0aDogMTsKICAgICAgfQogICAgICAjYm9hcmRfY29ybmVycyB7CiAg ICAgICAgZmlsbDogbm9uZTsKICAgICAgICBzdHJva2U6IGJsYWNrOwogICAgICAgIHN0cm9rZS13 aWR0aDogMjU7CiAgICAgIH0KICAgICAgCiAgICAgICNhX3NxdWFyZSB7CiAgICAgICAgZmlsbDog cmVkOwogICAgICB9CiAgICAgIAogICAgICAjYV9zcXVhcmU6aG92ZXIgewogICAgICAgIGZpbGw6 IGdyZWVuOwogICAgICB9CiAgICAgIAogICAgICAjYXhlcyBwYXRoIHsKICAgICAgICBzdHJva2Ut d2lkdGg6IDU7CiAgICAgICAgc3Ryb2tlOiB3aGl0ZTsKICAgICAgICB2aXNpYmlsaXR5OiBoaWRk ZW47CiAgICAgIH0KICAgICAgI2lubmVyOmhvdmVyICNheGVzIHBhdGggewogICAgICAgIHZpc2li aWxpdHk6IHZpc2libGU7CiAgICAgIH0KICAgIDwvc3R5bGU+CiAgPC9oZWFkPgogIDxib2R5Pgog ICAgPGRpdiBpZD0nZXZlcnl0aGluZyc+CiAgICAgIDxwPgogICAgICAgIElmIHlvdSBob3ZlciB5 b3VyIG1vdXNlIG92ZXIgdGhlIHJlZCBib3ggaW4gdGhlIGNlbnRlciwgeW91ciBtb3VzZQogICAg ICAgIHNob3VsZCAiZmFsbCB0aHJvdWdoIiBhbmQgYWZmZWN0IHNhaWQgYm94IChpdCB3aWxsIHR1 cm4gZ3JlZW4pLCBldmVuCiAgICAgICAgdGhvdWdoIGl0J3MgInVuZGVyIiBhbm90aGVyIFNWRyBk b2N1bWVudCwgYmVjYXVzZSB0aGUgU1ZHIGRvY3VtZW50J3MKICAgICAgICBjb250ZW50IGF0IHRo YXQgcG9pbnQgaXMgPHR0PmZpbGw6IG5vbmU7PC90dD4uCiAgICAgIDwvcD4KICAgICAgPHA+CiAg ICAgICAgSWYgeW91IGNsaWNrIHRoZSBib3gsIHlvdXIgbW91c2UgZXZlbnQgc2hvdWxkIGFsc28g ImZhbGwgdGhyb3VnaCIsCiAgICAgICAgY2F1c2luZyBhIEphdmFzY3JpcHQgPHR0PmFsZXJ0KCk7 PC90dD4gdG8gYXJpc2UuCiAgICAgIDwvcD4KICAgICAgPHN2ZyBpZD0nb3V0ZXInIHZpZXdCb3g9 JzAgMCA0MDAgNDAwJyB3aWR0aD0nNTBlbScgaGVpZ2h0PSc1MGVtJyB6b29tQW5kUGFuPSdkaXNh YmxlJyB4bWxucz0naHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmcnIHhtbG5zOnhsaW5rPSdodHRw Oi8vd3d3LnczLm9yZy8xOTk5L3hsaW5rJz4KICAgICAgICA8c3ZnIGlkPSdpbm5lcicgdmlld0Jv eD0nLTEwMDAgLTEwMDAgMjAwMCAyMDAwJyB3aWR0aD0nMTAwJScgaGVpZ2h0PScxMDAlJyB6b29t QW5kUGFuPSdkaXNhYmxlJyB4bWxucz0naHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmcnIHhtbG5z OnhsaW5rPSdodHRwOi8vd3d3LnczLm9yZy8xOTk5L3hsaW5rJz4KICAgICAgICAgIDxyZWN0IGlk PSdhX3NxdWFyZScgeD0nLTI1MCcgeT0nLTI1MCcgd2lkdGg9JzUwMCcgaGVpZ2h0PSc1MDAnCiAg ICAgICAgICAgIG9uY2xpY2s9J2FsZXJ0KCJZb3UgY2xpY2tlZCB0aGUgc3F1YXJlISBJdCB3b3Jr ZWQhIiknLz4KICAgICAgICAgIAogICAgICAgICAgPGcgaWQ9J2F4ZXMnPgogICAgICAgICAgICA8 cGF0aCBpZD0neCcgZD0nTSAtMzUwMCwwIEwgMzUwMCwwJy8+PHBhdGggaWQ9J3knIGQ9J00gMCwt MzUwMCBMIDAsMzUwMCcvPgogICAgICAgICAgPC9nPgogICAgICAgIDwvc3ZnPgogICAgICAgIAog ICAgICAgIDxnIGlkPSdib3JkZXJzJz4KICAgICAgICAgIDxyZWN0IGlkPSdib2FyZF9ib3JkZXIn IHg9JzIuNSUnIHk9JzIuNSUnIHJ4PSczMCcgcnk9JzMwJyB3aWR0aD0nOTUlJyBoZWlnaHQ9Jzk1 JScvPgogICAgICAgICAgPHJlY3QgaWQ9J2JvYXJkX2Nvcm5lcnMnIHg9Jy0yLjUlJyB5PSctMi41 JScgcng9JzUwJyByeT0nNTAnIHdpZHRoPScxMDUlJyBoZWlnaHQ9JzEwNSUnCiAgICAgICAgICAg IG9uY2xpY2s9J2FsZXJ0KCJZb3UgY2xpY2tlZCB0aGUgYm9yZGVyISBJZiB5b3UgY2xpY2tlZCBp biB0aGUgbWlkZGxlLCB0aGVuIHRoZSBicm93c2VyIGlzIGJyb2tlbiApLToiKScvPgogICAgICAg IDwvZz4KICAgICAgPC9zdmc+CiAgICAgIAogICAgPC9kaXY+CiAgPC9ib2R5Pgo8L2h0bWw+ 24690 2008-10-27 13:26:17 -0700 2008-10-27 13:39:45 -0700 A reduction which shows this is not a problem with raw SVGs test.svg image/svg+xml 1431 eric PHN2ZyBpZD0nb3V0ZXInIHZpZXdCb3g9JzAgMCA0MDAgNDAwJyB3aWR0aD0nNTBlbScgaGVpZ2h0 PSc1MGVtJyB6b29tQW5kUGFuPSdkaXNhYmxlJyB4bWxucz0naHR0cDovL3d3dy53My5vcmcvMjAw MC9zdmcnIHhtbG5zOnhsaW5rPSdodHRwOi8vd3d3LnczLm9yZy8xOTk5L3hsaW5rJz4KCjxzdHls ZT4KICAqIHsKICAgIG1hcmdpbjogMDsKICAgIHBhZGRpbmc6IDA7CiAgfQogIAogICNvdXRlciB7 CiAgICBtYXJnaW4tbGVmdDogYXV0bzsKICAgIG1hcmdpbi1yaWdodDogYXV0bzsKICB9CiAgCiAg I2JvYXJkX2JvcmRlciB7CiAgICBmaWxsOiBub25lOwogICAgc3Ryb2tlOiB3aGl0ZTsKICAgIHN0 cm9rZS13aWR0aDogMTsKICB9CiAgI2JvYXJkX2Nvcm5lcnMgewogICAgZmlsbDogbm9uZTsKICAg IHN0cm9rZTogYmxhY2s7CiAgICBzdHJva2Utd2lkdGg6IDI1OwogIH0KICAKICAjYV9zcXVhcmUg ewogICAgZmlsbDogcmVkOwogIH0KICAKICAjYV9zcXVhcmU6aG92ZXIgewogICAgZmlsbDogZ3Jl ZW47CiAgfQogIAogICNheGVzIHBhdGggewogICAgc3Ryb2tlLXdpZHRoOiA1OwogICAgc3Ryb2tl OiB3aGl0ZTsKICAgIHZpc2liaWxpdHk6IGhpZGRlbjsKICB9CiAgI2lubmVyOmhvdmVyICNheGVz IHBhdGggewogICAgdmlzaWJpbGl0eTogdmlzaWJsZTsKICB9Cjwvc3R5bGU+CgogIDxzdmcgaWQ9 J2lubmVyJyB2aWV3Qm94PSctMTAwMCAtMTAwMCAyMDAwIDIwMDAnIHdpZHRoPScxMDAlJyBoZWln aHQ9JzEwMCUnIHpvb21BbmRQYW49J2Rpc2FibGUnIHhtbG5zPSdodHRwOi8vd3d3LnczLm9yZy8y MDAwL3N2ZycgeG1sbnM6eGxpbms9J2h0dHA6Ly93d3cudzMub3JnLzE5OTkveGxpbmsnPgogICAg PHJlY3QgaWQ9J2Ffc3F1YXJlJyB4PSctMjUwJyB5PSctMjUwJyB3aWR0aD0nNTAwJyBoZWlnaHQ9 JzUwMCcKICAgICAgb25jbGljaz0nYWxlcnQoIllvdSBjbGlja2VkIHRoZSBzcXVhcmUhIEl0IHdv cmtlZCEiKScvPgogICAgCiAgICA8ZyBpZD0nYXhlcyc+CiAgICAgIDxwYXRoIGlkPSd4JyBkPSdN IC0zNTAwLDAgTCAzNTAwLDAnLz48cGF0aCBpZD0neScgZD0nTSAwLC0zNTAwIEwgMCwzNTAwJy8+ CiAgICA8L2c+CiAgPC9zdmc+CiAgCiAgPGcgaWQ9J2JvcmRlcnMnPgogICAgPHJlY3QgaWQ9J2Jv YXJkX2JvcmRlcicgeD0nMi41JScgeT0nMi41JScgcng9JzMwJyByeT0nMzAnIHdpZHRoPSc5NSUn IGhlaWdodD0nOTUlJy8+CiAgICA8cmVjdCBpZD0nYm9hcmRfY29ybmVycycgeD0nLTIuNSUnIHk9 Jy0yLjUlJyByeD0nNTAnIHJ5PSc1MCcgd2lkdGg9JzEwNSUnIGhlaWdodD0nMTA1JScKICAgICAg b25jbGljaz0nYWxlcnQoIllvdSBjbGlja2VkIHRoZSBib3JkZXIhIElmIHlvdSBjbGlja2VkIGlu IHRoZSBtaWRkbGUsIHRoZW4gdGhlIGJyb3dzZXIgaXMgYnJva2VuICktOiIpJy8+CiAgPC9nPgo8 L3N2Zz4K 24692 2008-10-27 13:39:45 -0700 2008-10-27 13:39:45 -0700 simpler test case (hovering the blue square should turn it green) test.xhtml application/xhtml+xml 587 eric PGh0bWwgeG1sbnM9J2h0dHA6Ly93d3cudzMub3JnLzE5OTkveGh0bWwnPgogIDxoZWFkPgogICAg PHN0eWxlPgogICAgICBib2R5IHsKICAgICAgICAgIG1hcmdpbjogMHB4OwogICAgICAgICAgcGFk ZGluZzogMHB4OwogICAgICAgICAgYm9yZGVyOiAxcHggc29saWQgYmxhY2s7CiAgICAgICAgICBk aXNwbGF5OiB0YWJsZTsgLyogQ2F1c2VzIHRoZSBidWcgKi8KICAgICAgfQogICAgICAjc3F1YXJl IHsKICAgICAgICBmaWxsOiBibHVlOwogICAgICB9CiAgICAgICNzcXVhcmU6aG92ZXIgewogICAg ICAgIGZpbGw6IGdyZWVuOwogICAgICB9CiAgICA8L3N0eWxlPgogIDwvaGVhZD4KICA8Ym9keT4K ICAgICAgPHN2ZyB3aWR0aD0nMTAwcHgnIGhlaWdodD0nMTAwcHgnIHhtbG5zPSdodHRwOi8vd3d3 LnczLm9yZy8yMDAwL3N2Zyc+CiAgICAgICAgPHN2Zz4KICAgICAgICAgIDxyZWN0IGlkPSdzcXVh cmUnIHdpZHRoPScxMDAnIGhlaWdodD0nMTAwJyBvbmNsaWNrPSdhbGVydCgiWW91IGNsaWNrZWQg dGhlIHNxdWFyZSEgSXQgd29ya2VkISIpJy8+CiAgICAgICAgPC9zdmc+CiAgICAgIDwvc3ZnPgog IDwvYm9keT4KPC9odG1sPgo= 24693 2008-10-27 14:18:19 -0700 2008-10-27 14:18:19 -0700 Testcase using an actual table instead of display: table; testcase.xhtml application/xhtml+xml 582 bugs.webkit.org PGh0bWwgeG1sbnM9J2h0dHA6Ly93d3cudzMub3JnLzE5OTkveGh0bWwnPgogIDxoZWFkPgogICAg PHN0eWxlPgogICAgICBib2R5IHsKICAgICAgICAgIG1hcmdpbjogMHB4OwogICAgICAgICAgcGFk ZGluZzogMHB4OwogICAgICAgICAgYm9yZGVyOiAxcHggc29saWQgYmxhY2s7CiAgICAgIH0KICAg ICAgI3NxdWFyZSB7CiAgICAgICAgZmlsbDogYmx1ZTsKICAgICAgfQogICAgICAjc3F1YXJlOmhv dmVyIHsKICAgICAgICBmaWxsOiBncmVlbjsKICAgICAgfQogICAgPC9zdHlsZT4KICA8L2hlYWQ+ CiAgPGJvZHk+CiAgCTx0YWJsZT48dHI+PHRkPgogICAgICA8c3ZnIHdpZHRoPScxMDBweCcgaGVp Z2h0PScxMDBweCcgeG1sbnM9J2h0dHA6Ly93d3cudzMub3JnLzIwMDAvc3ZnJz4KICAgICAgICA8 c3ZnPgogICAgICAgICAgPHJlY3QgaWQ9J3NxdWFyZScgd2lkdGg9JzEwMCcgaGVpZ2h0PScxMDAn IG9uY2xpY2s9J2FsZXJ0KCJZb3UgY2xpY2tlZCB0aGUgc3F1YXJlISBJdCB3b3JrZWQhIiknLz4K ICAgICAgICA8L3N2Zz4KICAgICAgPC9zdmc+CiAgICA8L3RkPjwvdHI+PC90YWJsZT4KICA8L2Jv ZHk+CjwvaHRtbD4K 29873 2009-04-28 17:50:53 -0700 2009-04-28 17:52:56 -0700 Add a couple table hit tests Add-a-couple-table-hit-tests.patch text/plain 3690 eric MTQxNmMxMjBlMDczYzk3Yzg1ZjkyYWU0ZWU2M2ZkY2RjOWE2Y2YzMApkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDU1OWJmZTQu Ljc4MjBiYjIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRU ZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAwOS0wNC0yOCAgRXJpYyBTZWlkZWwg IDxlcmljQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQWRkIGEgY291cGxlIHRhYmxlIGhpdCB0ZXN0cworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE4OTIKKworICAgICAgICAqIHN2Zy9o aXR0ZXN0L3N2Zy1pbnNpZGUtZGlzcGxheS10YWJsZS1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAg ICAgICAqIHN2Zy9oaXR0ZXN0L3N2Zy1pbnNpZGUtZGlzcGxheS10YWJsZS54aHRtbDogQWRkZWQu CisgICAgICAgICogc3ZnL2hpdHRlc3Qvc3ZnLWluc2lkZS10YWJsZS1leHBlY3RlZC50eHQ6IEFk ZGVkLgorICAgICAgICAqIHN2Zy9oaXR0ZXN0L3N2Zy1pbnNpZGUtdGFibGUueGh0bWw6IEFkZGVk LgorCiAyMDA5LTA0LTI4ICBBZGVsZSBQZXRlcnNvbiAgPGFkZWxlQGFwcGxlLmNvbT4KIAogICAg ICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3N2 Zy9oaXR0ZXN0L3N2Zy1pbnNpZGUtZGlzcGxheS10YWJsZS1leHBlY3RlZC50eHQgYi9MYXlvdXRU ZXN0cy9zdmcvaGl0dGVzdC9zdmctaW5zaWRlLWRpc3BsYXktdGFibGUtZXhwZWN0ZWQudHh0Cm5l dyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLjUzY2RmMWUKLS0tIC9kZXYvbnVsbAor KysgYi9MYXlvdXRUZXN0cy9zdmcvaGl0dGVzdC9zdmctaW5zaWRlLWRpc3BsYXktdGFibGUtZXhw ZWN0ZWQudHh0CkBAIC0wLDAgKzEgQEAKK1BBU1NFRApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv c3ZnL2hpdHRlc3Qvc3ZnLWluc2lkZS1kaXNwbGF5LXRhYmxlLnhodG1sIGIvTGF5b3V0VGVzdHMv c3ZnL2hpdHRlc3Qvc3ZnLWluc2lkZS1kaXNwbGF5LXRhYmxlLnhodG1sCm5ldyBmaWxlIG1vZGUg MTAwNjQ0CmluZGV4IDAwMDAwMDAuLjk4ZWQ4MDMKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRU ZXN0cy9zdmcvaGl0dGVzdC9zdmctaW5zaWRlLWRpc3BsYXktdGFibGUueGh0bWwKQEAgLTAsMCAr MSw0MCBAQAorPGh0bWwgeG1sbnM9J2h0dHA6Ly93d3cudzMub3JnLzE5OTkveGh0bWwnPgorICA8 aGVhZD4KKyAgICA8c3R5bGU+CisgICAgICBib2R5IHsKKyAgICAgICAgICBtYXJnaW46IDBweDsK KyAgICAgICAgICBwYWRkaW5nOiAwcHg7CisgICAgICAgICAgYm9yZGVyOiAxcHggc29saWQgYmxh Y2s7CisgICAgICAgICAgZGlzcGxheTogdGFibGU7IC8qIENhdXNlcyB0aGUgYnVnICovCisgICAg ICB9CisgICAgICAjc3F1YXJlIHsKKyAgICAgICAgZmlsbDogYmx1ZTsKKyAgICAgIH0KKyAgICAg ICNzcXVhcmU6aG92ZXIgeworICAgICAgICBmaWxsOiBncmVlbjsKKyAgICAgIH0KKyAgICA8L3N0 eWxlPgorICA8L2hlYWQ+CisgIDxib2R5PgorICAgICAgPHN2ZyB3aWR0aD0nMTAwcHgnIGhlaWdo dD0nMTAwcHgnIHhtbG5zPSdodHRwOi8vd3d3LnczLm9yZy8yMDAwL3N2Zyc+CisgICAgICAgIDxz dmc+CisgICAgICAgICAgPHJlY3QgaWQ9J3NxdWFyZScgd2lkdGg9JzEwMCcgaGVpZ2h0PScxMDAn IG9uY2xpY2s9J2dvdENsaWNrKCknLz4KKyAgICAgICAgPC9zdmc+CisgICAgICA8L3N2Zz4KKyAg PC9ib2R5PgorICA8c2NyaXB0PgorICBmdW5jdGlvbiBnb3RDbGljaygpIHsKKyAgICBpZiAod2lu ZG93LmV2ZW50U2VuZGVyKSB7CisgICAgICBkb2N1bWVudC5ib2R5LmlubmVySFRNTCA9ICJQQVNT RUQiOworICAgIH0gZWxzZSB7CisgICAgICBhbGVydCgiWW91IGNsaWNrZWQgdGhlIHNxdWFyZSEg SXQgd29ya2VkISIpOworICAgIH0KKyAgfQorICBpZiAod2luZG93LmV2ZW50U2VuZGVyKSB7Cisg ICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworICAgIGV2ZW50U2VuZGVyLm1v dXNlTW92ZVRvKDUwLCA1MCk7CisgICAgZXZlbnRTZW5kZXIubW91c2VEb3duKCk7CisgICAgZXZl bnRTZW5kZXIubW91c2VVcCgpOworICB9CisgIDwvc2NyaXB0PgorPC9odG1sPgpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvc3ZnL2hpdHRlc3Qvc3ZnLWluc2lkZS10YWJsZS1leHBlY3RlZC50eHQg Yi9MYXlvdXRUZXN0cy9zdmcvaGl0dGVzdC9zdmctaW5zaWRlLXRhYmxlLWV4cGVjdGVkLnR4dApu ZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi41M2NkZjFlCi0tLSAvZGV2L251bGwK KysrIGIvTGF5b3V0VGVzdHMvc3ZnL2hpdHRlc3Qvc3ZnLWluc2lkZS10YWJsZS1leHBlY3RlZC50 eHQKQEAgLTAsMCArMSBAQAorUEFTU0VECmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9zdmcvaGl0 dGVzdC9zdmctaW5zaWRlLXRhYmxlLnhodG1sIGIvTGF5b3V0VGVzdHMvc3ZnL2hpdHRlc3Qvc3Zn LWluc2lkZS10YWJsZS54aHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi4z MjY4ODlhCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvc3ZnL2hpdHRlc3Qvc3ZnLWlu c2lkZS10YWJsZS54aHRtbApAQCAtMCwwICsxLDQxIEBACis8aHRtbCB4bWxucz0naHR0cDovL3d3 dy53My5vcmcvMTk5OS94aHRtbCc+CisgIDxoZWFkPgorICAgIDxzdHlsZT4KKyAgICAgIGJvZHkg eworICAgICAgICAgIG1hcmdpbjogMHB4OworICAgICAgICAgIHBhZGRpbmc6IDBweDsKKyAgICAg ICAgICBib3JkZXI6IDFweCBzb2xpZCBibGFjazsKKyAgICAgIH0KKyAgICAgICNzcXVhcmUgewor ICAgICAgICBmaWxsOiBibHVlOworICAgICAgfQorICAgICAgI3NxdWFyZTpob3ZlciB7CisgICAg ICAgIGZpbGw6IGdyZWVuOworICAgICAgfQorICAgIDwvc3R5bGU+CisgIDwvaGVhZD4KKyAgPGJv ZHk+CisgIAk8dGFibGU+PHRyPjx0ZD4KKyAgICAgIDxzdmcgd2lkdGg9JzEwMHB4JyBoZWlnaHQ9 JzEwMHB4JyB4bWxucz0naHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmcnPgorICAgICAgICA8c3Zn PgorICAgICAgICAgIDxyZWN0IGlkPSdzcXVhcmUnIHdpZHRoPScxMDAnIGhlaWdodD0nMTAwJyBv bmNsaWNrPSdnb3RDbGljaygpJy8+CisgICAgICAgIDwvc3ZnPgorICAgICAgPC9zdmc+CisgICAg PC90ZD48L3RyPjwvdGFibGU+CisgICAgPHNjcmlwdD4KKyAgICBmdW5jdGlvbiBnb3RDbGljaygp IHsKKyAgICAgIGlmICh3aW5kb3cuZXZlbnRTZW5kZXIpIHsKKyAgICAgICAgZG9jdW1lbnQuYm9k eS5pbm5lckhUTUwgPSAiUEFTU0VEIjsKKyAgICAgIH0gZWxzZSB7CisgICAgICAgIGFsZXJ0KCJZ b3UgY2xpY2tlZCB0aGUgc3F1YXJlISBJdCB3b3JrZWQhIik7CisgICAgICB9CisgICAgfQorICAg IGlmICh3aW5kb3cuZXZlbnRTZW5kZXIpIHsKKyAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1 bXBBc1RleHQoKTsKKyAgICAgIGV2ZW50U2VuZGVyLm1vdXNlTW92ZVRvKDUwLCA1MCk7CisgICAg ICBldmVudFNlbmRlci5tb3VzZURvd24oKTsKKyAgICAgIGV2ZW50U2VuZGVyLm1vdXNlVXAoKTsK KyAgICB9CisgICAgPC9zY3JpcHQ+CisgIDwvYm9keT4KKzwvaHRtbD4K 29874 2009-04-28 17:57:44 -0700 2009-04-28 17:58:15 -0700 Add a couple table hit tests Add-a-couple-table-hit-tests.patch text/plain 3702 eric NWNiZmI5MjNiMDJhMDU3ODY2ZTBiNTdkM2MxNWZhNzkzZjNkZWNjYgpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDU1OWJmZTQu Ljc4MjBiYjIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRU ZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAwOS0wNC0yOCAgRXJpYyBTZWlkZWwg IDxlcmljQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQWRkIGEgY291cGxlIHRhYmxlIGhpdCB0ZXN0cworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE4OTIKKworICAgICAgICAqIHN2Zy9o aXR0ZXN0L3N2Zy1pbnNpZGUtZGlzcGxheS10YWJsZS1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAg ICAgICAqIHN2Zy9oaXR0ZXN0L3N2Zy1pbnNpZGUtZGlzcGxheS10YWJsZS54aHRtbDogQWRkZWQu CisgICAgICAgICogc3ZnL2hpdHRlc3Qvc3ZnLWluc2lkZS10YWJsZS1leHBlY3RlZC50eHQ6IEFk ZGVkLgorICAgICAgICAqIHN2Zy9oaXR0ZXN0L3N2Zy1pbnNpZGUtdGFibGUueGh0bWw6IEFkZGVk LgorCiAyMDA5LTA0LTI4ICBBZGVsZSBQZXRlcnNvbiAgPGFkZWxlQGFwcGxlLmNvbT4KIAogICAg ICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3N2 Zy9oaXR0ZXN0L3N2Zy1pbnNpZGUtZGlzcGxheS10YWJsZS1leHBlY3RlZC50eHQgYi9MYXlvdXRU ZXN0cy9zdmcvaGl0dGVzdC9zdmctaW5zaWRlLWRpc3BsYXktdGFibGUtZXhwZWN0ZWQudHh0Cm5l dyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLjUzY2RmMWUKLS0tIC9kZXYvbnVsbAor KysgYi9MYXlvdXRUZXN0cy9zdmcvaGl0dGVzdC9zdmctaW5zaWRlLWRpc3BsYXktdGFibGUtZXhw ZWN0ZWQudHh0CkBAIC0wLDAgKzEgQEAKK1BBU1NFRApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv c3ZnL2hpdHRlc3Qvc3ZnLWluc2lkZS1kaXNwbGF5LXRhYmxlLnhodG1sIGIvTGF5b3V0VGVzdHMv c3ZnL2hpdHRlc3Qvc3ZnLWluc2lkZS1kaXNwbGF5LXRhYmxlLnhodG1sCm5ldyBmaWxlIG1vZGUg MTAwNjQ0CmluZGV4IDAwMDAwMDAuLmE1MjY1YWYKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRU ZXN0cy9zdmcvaGl0dGVzdC9zdmctaW5zaWRlLWRpc3BsYXktdGFibGUueGh0bWwKQEAgLTAsMCAr MSwzMyBAQAorPGh0bWwgeG1sbnM9J2h0dHA6Ly93d3cudzMub3JnLzE5OTkveGh0bWwnPgorICA8 aGVhZD4KKyAgICA8c3R5bGU+CisgICAgICBib2R5IHsKKyAgICAgICAgICBtYXJnaW46IDBweDsK KyAgICAgICAgICBwYWRkaW5nOiAwcHg7CisgICAgICAgICAgYm9yZGVyOiAxcHggc29saWQgYmxh Y2s7CisgICAgICAgICAgZGlzcGxheTogdGFibGU7IC8qIENhdXNlcyB0aGUgYnVnICovCisgICAg ICB9CisgICAgICAjc3F1YXJlIHsKKyAgICAgICAgZmlsbDogYmx1ZTsKKyAgICAgIH0KKyAgICAg ICNzcXVhcmU6aG92ZXIgeworICAgICAgICBmaWxsOiBncmVlbjsKKyAgICAgIH0KKyAgICA8L3N0 eWxlPgorICA8L2hlYWQ+CisgIDxib2R5PgorICAgICAgPHN2ZyB3aWR0aD0nMTAwcHgnIGhlaWdo dD0nMTAwcHgnIHhtbG5zPSdodHRwOi8vd3d3LnczLm9yZy8yMDAwL3N2Zyc+CisgICAgICAgIDxz dmc+CisgICAgICAgICAgPHJlY3QgaWQ9J3NxdWFyZScgd2lkdGg9JzEwMCcgaGVpZ2h0PScxMDAn IG9uY2xpY2s9J2FsZXJ0KCJZb3UgY2xpY2tlZCB0aGUgc3F1YXJlISBJdCB3b3JrZWQhIiknLz4K KyAgICAgICAgPC9zdmc+CisgICAgICA8L3N2Zz4KKyAgPC9ib2R5PgorICA8c2NyaXB0PjwhW0NE QVRBWworICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKSB7CisgICAgbGF5b3V0VGVz dENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworICB9CisgIHZhciBoaXRFbGVtZW50ID0gZG9jdW1l bnQuZWxlbWVudEZyb21Qb2ludCg1MCwgNTApOworICB2YXIgaGl0U3VjY2VzcyA9IGhpdEVsZW1l bnQgJiYgaGl0RWxlbWVudCA9PSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgic3F1YXJlIik7Cisg IGRvY3VtZW50LmJvZHkuaW5uZXJIVE1MID0gaGl0U3VjY2VzcyA/ICJQQVNTRUQiIDogIkZBSUws IGhpdCAiICsgaGl0RWxlbWVudCArICIgQCA1MCwgNTAiOworICBdXT48L3NjcmlwdD4KKzwvaHRt bD4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3N2Zy9oaXR0ZXN0L3N2Zy1pbnNpZGUtdGFibGUt ZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvc3ZnL2hpdHRlc3Qvc3ZnLWluc2lkZS10YWJsZS1l eHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uNTNjZGYxZQot LS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL3N2Zy9oaXR0ZXN0L3N2Zy1pbnNpZGUtdGFi bGUtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEgQEAKK1BBU1NFRApkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvc3ZnL2hpdHRlc3Qvc3ZnLWluc2lkZS10YWJsZS54aHRtbCBiL0xheW91dFRlc3RzL3N2 Zy9oaXR0ZXN0L3N2Zy1pbnNpZGUtdGFibGUueGh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5k ZXggMDAwMDAwMC4uOTk3YTcwMwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL3N2Zy9o aXR0ZXN0L3N2Zy1pbnNpZGUtdGFibGUueGh0bWwKQEAgLTAsMCArMSwzNCBAQAorPGh0bWwgeG1s bnM9J2h0dHA6Ly93d3cudzMub3JnLzE5OTkveGh0bWwnPgorICA8aGVhZD4KKyAgICA8c3R5bGU+ CisgICAgICBib2R5IHsKKyAgICAgICAgICBtYXJnaW46IDBweDsKKyAgICAgICAgICBwYWRkaW5n OiAwcHg7CisgICAgICAgICAgYm9yZGVyOiAxcHggc29saWQgYmxhY2s7CisgICAgICB9CisgICAg ICAjc3F1YXJlIHsKKyAgICAgICAgZmlsbDogYmx1ZTsKKyAgICAgIH0KKyAgICAgICNzcXVhcmU6 aG92ZXIgeworICAgICAgICBmaWxsOiBncmVlbjsKKyAgICAgIH0KKyAgICA8L3N0eWxlPgorICA8 L2hlYWQ+CisgIDxib2R5PgorICAJPHRhYmxlPjx0cj48dGQ+CisgICAgICA8c3ZnIHdpZHRoPScx MDBweCcgaGVpZ2h0PScxMDBweCcgeG1sbnM9J2h0dHA6Ly93d3cudzMub3JnLzIwMDAvc3ZnJz4K KyAgICAgICAgPHN2Zz4KKyAgICAgICAgICA8cmVjdCBpZD0nc3F1YXJlJyB3aWR0aD0nMTAwJyBo ZWlnaHQ9JzEwMCcgb25jbGljaz0nYWxlcnQoIllvdSBjbGlja2VkIHRoZSBzcXVhcmUhIEl0IHdv cmtlZCEiKScvPgorICAgICAgICA8L3N2Zz4KKyAgICAgIDwvc3ZnPgorICAgIDwvdGQ+PC90cj48 L3RhYmxlPgorICAgIDxzY3JpcHQ+PCFbQ0RBVEFbCisgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0 Q29udHJvbGxlcikgeworICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOwor ICAgIH0KKyAgICB2YXIgaGl0RWxlbWVudCA9IGRvY3VtZW50LmVsZW1lbnRGcm9tUG9pbnQoNTAs IDUwKTsKKyAgICB2YXIgaGl0U3VjY2VzcyA9IGhpdEVsZW1lbnQgJiYgaGl0RWxlbWVudCA9PSBk b2N1bWVudC5nZXRFbGVtZW50QnlJZCgic3F1YXJlIik7CisgICAgZG9jdW1lbnQuYm9keS5pbm5l ckhUTUwgPSBoaXRTdWNjZXNzID8gIlBBU1NFRCIgOiAiRkFJTCwgaGl0ICIgKyBoaXRFbGVtZW50 ICsgIiBAIDUwLCA1MCI7CisgICAgXV0+PC9zY3JpcHQ+CisgIDwvYm9keT4KKzwvaHRtbD4K