218903 2020-11-13 07:36:45 -0800 [WPE] Prevent elements getting stuck in a pressed state when scrolling on a touchscreen 2020-11-19 05:56:03 -0800 1 1 1 Unclassified WebKit WPE WebKit WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 JPEW.hacker webkit-unassigned aperez bugs-noreply cgarcia pnormand zan oldest_to_newest 1707230 0 JPEW.hacker 2020-11-13 07:36:45 -0800 [WPE] Prevent elements getting stuck in a pressed state when scrolling on a touchscreen 1707231 1 414042 JPEW.hacker 2020-11-13 07:37:12 -0800 Created attachment 414042 Patch 1707232 2 JPEW.hacker 2020-11-13 07:40:57 -0800 If the scroll controller prevents touch up events from propagating to the page, the underlying elements (e.g. buttons) get stuck in the "pressed" state. This is particularly noticeable on sensitive touchscreens where a small amount of movement (which triggers a scroll) is unavoidable. 1708229 3 pnormand 2020-11-17 07:50:24 -0800 This would at least need a ChangeLog entry, see this page for the full procedure :) https://webkit.org/contributing-code/ 1708233 4 414342 JPEW.hacker 2020-11-17 08:05:09 -0800 Created attachment 414342 Patch 1709062 5 414342 aperez 2020-11-19 05:53:36 -0800 Comment on attachment 414342 Patch Thanks! The explanation in the ChangeLog makes sense to me and Carlos García also thinks the change is correct :) 1709063 6 ews-feeder 2020-11-19 05:56:02 -0800 Committed r270022: <https://trac.webkit.org/changeset/270022> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414342. 414042 2020-11-13 07:37:12 -0800 2020-11-17 08:05:06 -0800 Patch bug-218903-20201113093712.patch text/plain 673 JPEW.hacker U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5NzQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9BUEkvd3BlL1Njcm9sbEdlc3R1cmVDb250cm9sbGVyLmNwcCBiL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL0FQSS93cGUvU2Nyb2xsR2VzdHVyZUNvbnRyb2xsZXIuY3BwCmluZGV4IDk2 MjYzZWRmZGRmYTNmMzc0YjdkODg3NmUwNDBiZGExY2EzNGE1MGYuLjk1YTY2MjFhOTQyMzQyNjlh ZGM5NDIxYzA3YWI0MjA3ZTc2OTU0OTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL0FQSS93cGUvU2Nyb2xsR2VzdHVyZUNvbnRyb2xsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL0FQSS93cGUvU2Nyb2xsR2VzdHVyZUNvbnRyb2xsZXIuY3BwCkBAIC0xMTgs NyArMTE4LDYgQEAgYm9vbCBTY3JvbGxHZXN0dXJlQ29udHJvbGxlcjo6aGFuZGxlRXZlbnQoY29u c3Qgc3RydWN0IHdwZV9pbnB1dF90b3VjaF9ldmVudF9yYXcKICNlbmRpZgogICAgICAgICAgICAg bV9vZmZzZXQueCA9IG1fb2Zmc2V0LnkgPSAwOwogICAgICAgICAgICAgbV9waGFzZSA9IFdlYldo ZWVsRXZlbnQ6OlBoYXNlOjpQaGFzZUVuZGVkOwotICAgICAgICAgICAgcmV0dXJuIHRydWU7CiAg ICAgICAgIH0KICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIGRlZmF1bHQ6Cg== 414342 2020-11-17 08:05:09 -0800 2020-11-19 05:56:03 -0800 Patch bug-218903-20201117100508.patch text/plain 1808 JPEW.hacker U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5NzQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGYzOWYxMDFiMDljZGQ2NGE0 YjNlNTJmNGU5MjgzZWViMjdmOWNlMjguLjIwN2IxODg0Yzc3ZDBmNjUwNzYyOTI2MmIwYTgxZDY0 NDA3ZDIxZDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMjAtMTEtMTMgIEpvc2h1YSBX YXR0ICA8SlBFVy5oYWNrZXJAZ21haWwuY29tPgorCisgICAgICAgIFtXUEVdIFByZXZlbnQgZWxl bWVudHMgZ2V0dGluZyBzdHVjayBpbiBhIHByZXNzZWQgc3RhdGUgd2hlbiBzY3JvbGxpbmcgb24g YSB0b3VjaHNjcmVlbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjE4OTAzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgU3RvcHMgdGhlIHNjcm9sbCBnZXN0dXJlIGNvbnRyb2xsZXIgZnJvbSBlYXRpbmcgdG91 Y2ggdXAgZXZlbnRzIGFuZAorICAgICAgICBwcmV2ZW50aW5nIHRoZW0gZnJvbSBwcm9wYWdhdGlu ZyB0byB0aGUgcGFnZSB3aGVuIHRoZSBjb250cm9sbGVyIGlzCisgICAgICAgIGhhbmRsaW5nIGEg c2Nyb2xsIGV2ZW50LiBJZiB0aGUgc2Nyb2xsIGxvZ2ljIHByZXZlbnRzIHRoZSBldmVudHMgZnJv bQorICAgICAgICBwcm9wYWdhdGluZyB0byB0aGUgcGFnZSwgZWxlbWVudHMgb24gdGhlIHBhZ2Ug KGUuZy4gYnV0dG9ucykgY2FuIGdldAorICAgICAgICBzdHVjayBpbiBhIHByZXNzZWQgc3RhdGUg d2hlbiB0aGUgdXNlciBsaWZ0cyB0aGVpciBmaW5nZXIuCisKKyAgICAgICAgKiBVSVByb2Nlc3Mv QVBJL3dwZS9TY3JvbGxHZXN0dXJlQ29udHJvbGxlci5jcHA6CisgICAgICAgIChXZWJLaXQ6OlNj cm9sbEdlc3R1cmVDb250cm9sbGVyOjpoYW5kbGVFdmVudCk6CisKIDIwMjAtMTEtMTIgIFlvdWVu biBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYlByb2Nlc3Mgc2hvdWxk IHByb2Nlc3MgV2ViUlRDIGNvZGVjcyBJUEMgbWVzc2FnZXMgZnJvbSB0aGUgR1BVIFByb2Nlc3Mg aW4gYSBiYWNrZ3JvdW5kIHRocmVhZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nl c3MvQVBJL3dwZS9TY3JvbGxHZXN0dXJlQ29udHJvbGxlci5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9BUEkvd3BlL1Njcm9sbEdlc3R1cmVDb250cm9sbGVyLmNwcAppbmRleCA5NjI2M2Vk ZmRkZmEzZjM3NGI3ZDg4NzZlMDQwYmRhMWNhMzRhNTBmLi45NWE2NjIxYTk0MjM0MjY5YWRjOTQy MWMwN2FiNDIwN2U3Njk1NDk4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9B UEkvd3BlL1Njcm9sbEdlc3R1cmVDb250cm9sbGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9BUEkvd3BlL1Njcm9sbEdlc3R1cmVDb250cm9sbGVyLmNwcApAQCAtMTE4LDcgKzEx OCw2IEBAIGJvb2wgU2Nyb2xsR2VzdHVyZUNvbnRyb2xsZXI6OmhhbmRsZUV2ZW50KGNvbnN0IHN0 cnVjdCB3cGVfaW5wdXRfdG91Y2hfZXZlbnRfcmF3CiAjZW5kaWYKICAgICAgICAgICAgIG1fb2Zm c2V0LnggPSBtX29mZnNldC55ID0gMDsKICAgICAgICAgICAgIG1fcGhhc2UgPSBXZWJXaGVlbEV2 ZW50OjpQaGFzZTo6UGhhc2VFbmRlZDsKLSAgICAgICAgICAgIHJldHVybiB0cnVlOwogICAgICAg ICB9CiAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICBkZWZhdWx0Ogo=