<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>218899</bug_id>
          
          <creation_ts>2020-11-13 06:04:32 -0800</creation_ts>
          <short_desc>AudioSampleDataSource::pullSamplesInternal does not need to pass its sampleCount parameter as in/out</short_desc>
          <delta_ts>2020-11-15 09:48:19 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebRTC</component>
          <version>WebKit Local Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="youenn fablet">youennf</reporter>
          <assigned_to name="youenn fablet">youennf</assigned_to>
          <cc>eric.carlson</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>glenn</cc>
    
    <cc>jer.noble</cc>
    
    <cc>philipj</cc>
    
    <cc>sergio</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>youennf</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1707210</commentid>
    <comment_count>0</comment_count>
    <who name="youenn fablet">youennf</who>
    <bug_when>2020-11-13 06:04:32 -0800</bug_when>
    <thetext>AudioSampleDataSource::pullSamplesInternal does not need to pass its sampleCount parameter as in/out</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1707211</commentid>
    <comment_count>1</comment_count>
      <attachid>414036</attachid>
    <who name="youenn fablet">youennf</who>
    <bug_when>2020-11-13 06:06:46 -0800</bug_when>
    <thetext>Created attachment 414036
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1707612</commentid>
    <comment_count>2</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2020-11-15 09:47:39 -0800</bug_when>
    <thetext>Committed r269829: &lt;https://trac.webkit.org/changeset/269829&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 414036.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1707613</commentid>
    <comment_count>3</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2020-11-15 09:48:19 -0800</bug_when>
    <thetext>&lt;rdar://problem/71415851&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>414036</attachid>
            <date>2020-11-13 06:06:46 -0800</date>
            <delta_ts>2020-11-15 09:47:40 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-218899-20201113150644.patch</filename>
            <type>text/plain</type>
            <size>3779</size>
            <attacher name="youenn fablet">youennf</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5NjQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGRmNDViYjliMTg2M2Q5
ZTk5NDJjZmVjMjg4YmJlZWY0NTIwMTI3ZS4uNzMxOTlkMDg2M2I1ZDgxM2ViYTM2NjkwOTM0ZTMz
NDg4NGYxYjZiOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIwLTExLTEzICBZb3Vl
bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBBdWRpb1NhbXBsZURhdGFT
b3VyY2U6OnB1bGxTYW1wbGVzSW50ZXJuYWwgZG9lcyBub3QgbmVlZCB0byBwYXNzIGl0cyBzYW1w
bGVDb3VudCBwYXJhbWV0ZXIgYXMgaW4vb3V0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu
b3JnL3Nob3dfYnVnLmNnaT9pZD0yMTg4OTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg
KE9PUFMhKS4KKworICAgICAgICBwdWxsU2FtcGxlc0ludGVybmFsIHNldHMgc2FtcGxlQ291bnQg
dG8gemVybyBpbiBzb21lIGNhc2VzIHdoZXJlIHB1bGxTYW1wbGVzSW50ZXJuYWwgcmV0dXJucyBm
YWxzZS4KKyAgICAgICAgcHVsbFNhbXBsZXNJbnRlcm5hbCBjYWxsZXJzIGRvIG5vdCB1c2UgdGhl
IHNhbXBsZUNvdW50IHBhcmFtZXRlciBpZiBwdWxsU2FtcGxlc0ludGVybmFsIHJldHVybnMgZmFs
c2UuCisgICAgICAgIFBhc3Mgc2FtcGxlQ291bnQgYnkgdmFsdWUgdG8gY2xhcmlmeSB0aGUgYmVo
YXZpb3IgYW5kIHJlbW92ZSBzZXR0aW5nIHNhbXBsZUNvdW50IHRvIHplcm8gaW4gcHVsbFNhbXBs
ZXNJbnRlcm5hbCByZXR1cm4gZmFsc2UgY2FzZS4KKworICAgICAgICBObyBjaGFuZ2Ugb2YgYmVo
YXZpb3IuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9hdWRpby9jb2NvYS9BdWRpb1NhbXBsZURhdGFT
b3VyY2UuaDoKKyAgICAgICAgKiBwbGF0Zm9ybS9hdWRpby9jb2NvYS9BdWRpb1NhbXBsZURhdGFT
b3VyY2UubW06CisgICAgICAgIChXZWJDb3JlOjpBdWRpb1NhbXBsZURhdGFTb3VyY2U6OnB1bGxT
YW1wbGVzSW50ZXJuYWwpOgorCiAyMDIwLTExLTEzICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFw
cGxlLmNvbT4KIAogICAgICAgICBSZWR1Y2UgY3JhY2tsaW5nIGF0IHN0YXJ0IG9mIHBsYXlpbmcg
YSBsaXZlIGF1ZGlvIHRyYWNrCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9h
dWRpby9jb2NvYS9BdWRpb1NhbXBsZURhdGFTb3VyY2UuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm
b3JtL2F1ZGlvL2NvY29hL0F1ZGlvU2FtcGxlRGF0YVNvdXJjZS5oCmluZGV4IDk1ZmIyZjdhMzQx
YzRmZGY2YzhmODJjZmM0MWI5Mjg5MmE3ODM1ZDQuLjgzNmMxNGJlNjdhNTllZTViOTczMjM2NWE4
MTMxYjgxNTlhOTUwZTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlv
L2NvY29hL0F1ZGlvU2FtcGxlRGF0YVNvdXJjZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm
b3JtL2F1ZGlvL2NvY29hL0F1ZGlvU2FtcGxlRGF0YVNvdXJjZS5oCkBAIC04Myw3ICs4Myw3IEBA
IHByaXZhdGU6CiAgICAgQXVkaW9TYW1wbGVEYXRhU291cmNlKHNpemVfdCwgTG9nZ2VySGVscGVy
Jik7CiAKICAgICBPU1N0YXR1cyBzZXR1cENvbnZlcnRlcigpOwotICAgIGJvb2wgcHVsbFNhbXBs
ZXNJbnRlcm5hbChBdWRpb0J1ZmZlckxpc3QmLCBzaXplX3QmLCB1aW50NjRfdCwgZG91YmxlLCBQ
dWxsTW9kZSk7CisgICAgYm9vbCBwdWxsU2FtcGxlc0ludGVybmFsKEF1ZGlvQnVmZmVyTGlzdCYs
IHNpemVfdCwgdWludDY0X3QsIGRvdWJsZSwgUHVsbE1vZGUpOwogCiAgICAgdm9pZCBwdXNoU2Ft
cGxlc0ludGVybmFsKGNvbnN0IEF1ZGlvQnVmZmVyTGlzdCYsIGNvbnN0IE1lZGlhVGltZSYsIHNp
emVfdCBmcmFtZUNvdW50KTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v
YXVkaW8vY29jb2EvQXVkaW9TYW1wbGVEYXRhU291cmNlLm1tIGIvU291cmNlL1dlYkNvcmUvcGxh
dGZvcm0vYXVkaW8vY29jb2EvQXVkaW9TYW1wbGVEYXRhU291cmNlLm1tCmluZGV4IGZkYTMwYjBk
YjBjYjUzYmVlNmRjYmJiNmFkZmFlMDJmYzI1YmQ0ZjYuLmI1MzUzYzBmYmQyOGUxMzc3ZWZkM2M2
NjI3OTY2OWJjNjQ5OGM4ZDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1
ZGlvL2NvY29hL0F1ZGlvU2FtcGxlRGF0YVNvdXJjZS5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9w
bGF0Zm9ybS9hdWRpby9jb2NvYS9BdWRpb1NhbXBsZURhdGFTb3VyY2UubW0KQEAgLTE5MiwyMCAr
MTkyLDE4IEBAIHZvaWQgQXVkaW9TYW1wbGVEYXRhU291cmNlOjpwdXNoU2FtcGxlcyhjb25zdCBN
ZWRpYVRpbWUmIHNhbXBsZVRpbWUsIGNvbnN0IFBsYXRmCiAgICAgcHVzaFNhbXBsZXNJbnRlcm5h
bCgqZG93bmNhc3Q8V2ViQXVkaW9CdWZmZXJMaXN0PihhdWRpb0RhdGEpLmxpc3QoKSwgc2FtcGxl
VGltZSwgc2FtcGxlQ291bnQpOwogfQogCi1ib29sIEF1ZGlvU2FtcGxlRGF0YVNvdXJjZTo6cHVs
bFNhbXBsZXNJbnRlcm5hbChBdWRpb0J1ZmZlckxpc3QmIGJ1ZmZlciwgc2l6ZV90JiBzYW1wbGVD
b3VudCwgdWludDY0X3QgdGltZVN0YW1wLCBkb3VibGUgLypob3N0VGltZSovLCBQdWxsTW9kZSBt
b2RlKQorYm9vbCBBdWRpb1NhbXBsZURhdGFTb3VyY2U6OnB1bGxTYW1wbGVzSW50ZXJuYWwoQXVk
aW9CdWZmZXJMaXN0JiBidWZmZXIsIHNpemVfdCBzYW1wbGVDb3VudCwgdWludDY0X3QgdGltZVN0
YW1wLCBkb3VibGUgLypob3N0VGltZSovLCBQdWxsTW9kZSBtb2RlKQogewogICAgIHNpemVfdCBi
eXRlQ291bnQgPSBzYW1wbGVDb3VudCAqIG1fb3V0cHV0RGVzY3JpcHRpb24tPmJ5dGVzUGVyRnJh
bWUoKTsKIAogICAgIEFTU0VSVChidWZmZXIubU51bWJlckJ1ZmZlcnMgPT0gbV9yaW5nQnVmZmVy
LT5jaGFubmVsQ291bnQoKSk7CiAgICAgaWYgKGJ1ZmZlci5tTnVtYmVyQnVmZmVycyAhPSBtX3Jp
bmdCdWZmZXItPmNoYW5uZWxDb3VudCgpKSB7CiAgICAgICAgIEF1ZGlvU2FtcGxlQnVmZmVyTGlz
dDo6emVyb0FCTChidWZmZXIsIGJ5dGVDb3VudCk7Ci0gICAgICAgIHNhbXBsZUNvdW50ID0gMDsK
ICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIH0KIAogICAgIGlmICghbV9yaW5nQnVmZmVyIHx8
IG1fbXV0ZWQgfHwgbV9pbnB1dFNhbXBsZU9mZnNldCA9PSBNZWRpYVRpbWU6OmludmFsaWRUaW1l
KCkpIHsKICAgICAgICAgQXVkaW9TYW1wbGVCdWZmZXJMaXN0Ojp6ZXJvQUJMKGJ1ZmZlciwgYnl0
ZUNvdW50KTsKLSAgICAgICAgc2FtcGxlQ291bnQgPSAwOwogICAgICAgICByZXR1cm4gZmFsc2U7
CiAgICAgfQogCkBAIC0yMTcsNyArMjE1LDYgQEAgYm9vbCBBdWRpb1NhbXBsZURhdGFTb3VyY2U6
OnB1bGxTYW1wbGVzSW50ZXJuYWwoQXVkaW9CdWZmZXJMaXN0JiBidWZmZXIsIHNpemVfdCYKICAg
ICAgICAgdWludDY0X3QgYnVmZmVyZWQgPSBlbmRGcmFtZSAtIHN0YXJ0RnJhbWU7CiAgICAgICAg
IGlmIChidWZmZXJlZCA8IHNhbXBsZUNvdW50ICogMiB8fCAobV9lbmRGcmFtZVdoZW5Ob3RFbm91
Z2hEYXRhICYmIG1fZW5kRnJhbWVXaGVuTm90RW5vdWdoRGF0YSA9PSBlbmRGcmFtZSkpIHsKICAg
ICAgICAgICAgIEF1ZGlvU2FtcGxlQnVmZmVyTGlzdDo6emVyb0FCTChidWZmZXIsIGJ5dGVDb3Vu
dCk7Ci0gICAgICAgICAgICBzYW1wbGVDb3VudCA9IDA7CiAgICAgICAgICAgICByZXR1cm4gZmFs
c2U7CiAgICAgICAgIH0KIAo=
</data>

          </attachment>
      

    </bug>

</bugzilla>