21888 2008-10-25 15:05:00 -0700 REGRESSION: [Canvas] Transparent fillStyle stops line rendering 2008-11-12 23:20:01 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Mac (Intel) OS X 10.5 RESOLVED FIXED http://www.marcuscobden.co.uk/stuff/2008-10/webkit-canvas-fillstyle/ Regression P1 Normal --- 1 bugs webkit-unassigned oldest_to_newest 96683 0 bugs 2008-10-25 15:05:00 -0700 If the fillStyle of the 2d context is set to a fully transparent colour, lines will not render, if it is set to anything else, the line renders correctly. Lines should (iirc) be affected by strokeStyle rather than fillStyle. This is a regression, as the testcase works in Safari 3.1. See the provided link for a testcase. (Also, apologies if I've selected the wrong component.) 96684 1 ap 2008-10-25 15:08:06 -0700 Confirmed with r37887. 96697 2 24680 krit 2008-10-25 23:55:50 -0700 Created attachment 24680 fixed strokePath() fixed strokePath() in GraphicsContextCg. 96782 3 24680 darin 2008-10-27 14:23:50 -0700 Comment on attachment 24680 fixed strokePath() Great fix, but we also need a regression test! 96952 4 24680 eric 2008-10-28 23:07:44 -0700 Comment on attachment 24680 fixed strokePath() LGTM. 96953 5 24680 eric 2008-10-28 23:12:24 -0700 Comment on attachment 24680 fixed strokePath() Ah true... we do need a regression test. You can make one with getImageData so it doesn't need pixel tests. 96960 6 24742 krit 2008-10-29 03:15:31 -0700 Created attachment 24742 strokPath() fix with LayoutTest added a LayoutTest to the patch. 96986 7 24742 darin 2008-10-29 09:12:25 -0700 Comment on attachment 24742 strokPath() fix with LayoutTest Excellent! r=me 98591 8 krit 2008-11-12 23:20:01 -0800 landed in r38364. 24680 2008-10-25 23:55:50 -0700 2008-10-29 03:15:31 -0700 fixed strokePath() strokeColor.patch text/plain 1276 krit SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzNzg5NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDgtMTAtMjUgIERpcmsgU2NodWx6ZSAgPHZiczg1QGdteC5kZT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICB1c2Ugc3Ry b2tlQ29sb3IuYWxwaGEoKSBpbnN0ZWFkIG9mIGZpbGxDb2xvci5hbHBoYSgpCisgICAgICAgIG9u IEdyYXBoaWNzQ29udGV4dDo6c3Ryb2tlUGF0aCgpCisKKyAgICAgICAgW0NhbnZhc10gVHJhbnNw YXJlbnQgZmlsbFN0eWxlIHN0b3BzIGxpbmUgcmVuZGVyaW5nCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTg4OAorCisgICAgICAgICogcGxhdGZvcm0v Z3JhcGhpY3MvY2cvR3JhcGhpY3NDb250ZXh0Q0cuY3BwOgorICAgICAgICAoV2ViQ29yZTo6R3Jh cGhpY3NDb250ZXh0OjpzdHJva2VQYXRoKToKKwogMjAwOC0xMC0yNSAgR2VvZmZyZXkgR2FyZW4g IDxnZ2FyZW5AYXBwbGUuY29tPgogCiAgICAgICAgIE5vdCByZXZpZXdlZC4KSW5kZXg6IFdlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2cvR3JhcGhpY3NDb250ZXh0Q0cuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2cvR3JhcGhpY3NDb250ZXh0Q0cuY3BwCShy ZXZpc2lvbiAzNzg4OCkKKysrIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2cvR3JhcGhpY3ND b250ZXh0Q0cuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01MTIsNyArNTEyLDcgQEAgdm9pZCBHcmFw aGljc0NvbnRleHQ6OnN0cm9rZVBhdGgoKQogICAgIENHQ29udGV4dFJlZiBjb250ZXh0ID0gcGxh dGZvcm1Db250ZXh0KCk7CiAgICAgc3dpdGNoIChtX2NvbW1vbi0+c3RhdGUuc3Ryb2tlQ29sb3JT cGFjZSkgewogICAgIGNhc2UgU29saWRDb2xvclNwYWNlOgotICAgICAgICBpZiAoZmlsbENvbG9y KCkuYWxwaGEoKSkKKyAgICAgICAgaWYgKHN0cm9rZUNvbG9yKCkuYWxwaGEoKSkKICAgICAgICAg ICAgIENHQ29udGV4dFN0cm9rZVBhdGgoY29udGV4dCk7CiAgICAgICAgIGJyZWFrOwogICAgIGNh c2UgUGF0dGVybkNvbG9yU3BhY2U6Cg== 24742 2008-10-29 03:15:31 -0700 2008-10-29 09:12:25 -0700 strokPath() fix with LayoutTest strokeColor.patch text/plain 4196 krit SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzNzk2NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMDgtMTAtMjkgIERpcmsgU2NodWx6ZSAgPHZiczg1QGdteC5kZT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICB1c2Ugc3Ry b2tlQ29sb3IuYWxwaGEoKSBpbnN0ZWFkIG9mIGZpbGxDb2xvci5hbHBoYSgpCisgICAgICAgIG9u IEdyYXBoaWNzQ29udGV4dDo6c3Ryb2tlUGF0aCgpCisKKyAgICAgICAgW0NhbnZhc10gVHJhbnNw YXJlbnQgZmlsbFN0eWxlIHN0b3BzIGxpbmUgcmVuZGVyaW5nCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTg4OAorCisgICAgICAgIFRlc3Q6IGZhc3Qv Y2FudmFzL2NhbnZhcy1zdHJva2UtZW1wdHktZmlsbC5odG1sCisKKyAgICAgICAgKiBDaGFuZ2VM b2c6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2cvR3JhcGhpY3NDb250ZXh0Q0cuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0OjpzdHJva2VQYXRoKToKKwogMjAw OC0xMC0yOCAgQWxwIFRva2VyICA8YWxwQG51YW50aS5jb20+CiAKICAgICAgICAgTGlzdCBuZXds eS1hZGRlZCBJbWFnZUJ1ZmZlckRhdGEuaCBpbiBidWlsZCBzeXN0ZW0uCkluZGV4OiBXZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2NnL0dyYXBoaWNzQ29udGV4dENHLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NnL0dyYXBoaWNzQ29udGV4dENHLmNwcAkocmV2 aXNpb24gMzc4ODgpCisrKyBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NnL0dyYXBoaWNzQ29u dGV4dENHLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTEyLDcgKzUxMiw3IEBAIHZvaWQgR3JhcGhp Y3NDb250ZXh0OjpzdHJva2VQYXRoKCkKICAgICBDR0NvbnRleHRSZWYgY29udGV4dCA9IHBsYXRm b3JtQ29udGV4dCgpOwogICAgIHN3aXRjaCAobV9jb21tb24tPnN0YXRlLnN0cm9rZUNvbG9yU3Bh Y2UpIHsKICAgICBjYXNlIFNvbGlkQ29sb3JTcGFjZToKLSAgICAgICAgaWYgKGZpbGxDb2xvcigp LmFscGhhKCkpCisgICAgICAgIGlmIChzdHJva2VDb2xvcigpLmFscGhhKCkpCiAgICAgICAgICAg ICBDR0NvbnRleHRTdHJva2VQYXRoKGNvbnRleHQpOwogICAgICAgICBicmVhazsKICAgICBjYXNl IFBhdHRlcm5Db2xvclNwYWNlOgpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMzc5NjUpCisrKyBMYXlvdXRU ZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAwOC0xMC0y OSAgRGlyayBTY2h1bHplICA8dmJzODVAZ214LmRlPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIENoZWNrIGJlaGF2aW9yIG9mIGNhbnZhcy5zdHJva2Uo KSBvbiB0cmFuc3BhcmVudCBmaWxsU3R5bGUoKQorCisgICAgICAgICogZmFzdC9jYW52YXMvY2Fu dmFzLXN0cm9rZS1lbXB0eS1maWxsLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFz dC9jYW52YXMvY2FudmFzLXN0cm9rZS1lbXB0eS1maWxsLmh0bWw6IEFkZGVkLgorICAgICAgICAq IGZhc3QvY2FudmFzL2NhbnZhcy1zdHJva2UtZW1wdHktZmlsbC5qczogQWRkZWQuCisKIDIwMDgt MTAtMjggIFRpbW90aHkgSGF0Y2hlciAgPHRpbW90aHlAYXBwbGUuY29tPgogCiAgICAgICAgIFJl bW92ZSBmYXN0L3Byb2ZpbGVyIGZyb20gdGhlIHNraXBwZWQgbGlzdCBmb3IgVGlnZXIgc2luY2Ug dGhlIGZpeApJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvY2FudmFzLXN0cm9rZS1lbXB0 eS1maWxsLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2NhbnZh cy9jYW52YXMtc3Ryb2tlLWVtcHR5LWZpbGwtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysg TGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvY2FudmFzLXN0cm9rZS1lbXB0eS1maWxsLWV4cGVjdGVk LnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSw5IEBACitTZXJpZXMgb2YgdGVzdHMgdG8gZW5z dXJlIGNvcnJlY3QgYmVoYXZpb3VyIGZvciBzdHJva2UoKSBvbiBhbiBlbXB0eSBmaWxsU3R5bGUo KSAoYWxwaGE9MCkKKworT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNT IiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgorUEFTUyBpbWdkYXRhWzRd IGlzIDAKK1BBU1MgaW1nZGF0YVs1XSBpcyAxMjgKK1BBU1MgaW1nZGF0YVs2XSBpcyAwCitQQVNT IHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKSW5kZXg6IExheW91 dFRlc3RzL2Zhc3QvY2FudmFzL2NhbnZhcy1zdHJva2UtZW1wdHktZmlsbC5odG1sCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvY2FudmFzL2NhbnZhcy1zdHJva2UtZW1wdHktZmlsbC5o dG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvY2FudmFzLXN0cm9r ZS1lbXB0eS1maWxsLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMTQgQEAKKzwhRE9DVFlQ RSBIVE1MIFBVQkxJQyAiLS8vSUVURi8vRFREIEhUTUwvL0VOIj4KKzxodG1sPgorPGhlYWQ+Cis8 bGluayByZWw9InN0eWxlc2hlZXQiIGhyZWY9Ii4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXN0eWxl LmNzcyI+Cis8c2NyaXB0IHNyYz0iLi4vanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3Nj cmlwdD4KKzwvaGVhZD4KKzxib2R5PgorPHAgaWQ9ImRlc2NyaXB0aW9uIj48L3A+Cis8ZGl2IGlk PSJjb25zb2xlIj48L2Rpdj4KKzxjYW52YXMgaWQ9ImNhbnZhcyIgd2lkdGg9IjIwMCIgaGVpZ2h0 PSIyMDAiPjwvY2FudmFzPgorPHNjcmlwdCBzcmM9ImNhbnZhcy1zdHJva2UtZW1wdHktZmlsbC5q cyI+PC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iLi4vanMvcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5q cyI+PC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+CkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2Nh bnZhcy9jYW52YXMtc3Ryb2tlLWVtcHR5LWZpbGwuanMKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVz dHMvZmFzdC9jYW52YXMvY2FudmFzLXN0cm9rZS1lbXB0eS1maWxsLmpzCShyZXZpc2lvbiAwKQor KysgTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvY2FudmFzLXN0cm9rZS1lbXB0eS1maWxsLmpzCShy ZXZpc2lvbiAwKQpAQCAtMCwwICsxLDE1IEBACitkZXNjcmlwdGlvbigiU2VyaWVzIG9mIHRlc3Rz IHRvIGVuc3VyZSBjb3JyZWN0IGJlaGF2aW91ciBmb3Igc3Ryb2tlKCkgb24gYW4gZW1wdHkgZmls bFN0eWxlKCkgKGFscGhhPTApIik7Cit2YXIgY3R4ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQo J2NhbnZhcycpLmdldENvbnRleHQoJzJkJyk7CitjdHguZmlsbFN0eWxlID0gJ3JnYmEoMCwwLDAs MCknOworY3R4LnN0cm9rZVN0eWxlID0gJ2dyZWVuJzsKK2N0eC5saW5lV2lkdGggPSAyMDA7Citj dHgubW92ZVRvKDAsMTAwKTsKK2N0eC5saW5lVG8oMjAwLDEwMCk7CitjdHguc3Ryb2tlKCk7Cit2 YXIgaW1hZ2VEYXRhID0gY3R4LmdldEltYWdlRGF0YSgwLCAwLCAyMDAsIDIwMCk7Cit2YXIgaW1n ZGF0YSA9IGltYWdlRGF0YS5kYXRhOworc2hvdWxkQmUoImltZ2RhdGFbNF0iLCAiMCIpOworc2hv dWxkQmUoImltZ2RhdGFbNV0iLCAiMTI4Iik7CitzaG91bGRCZSgiaW1nZGF0YVs2XSIsICIwIik7 CisKK3ZhciBzdWNjZXNzZnVsbHlQYXJzZWQgPSB0cnVlOwo=