218854 2020-11-12 09:51:45 -0800 [GTK][WPE] FilterInfo must cleared when reusing BitmapTextureGL 2020-11-13 00:22:53 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 magomez magomez bugs-noreply cgarcia cmarcelo ews-watchlist fujii kondapallykalyan luiz oldest_to_newest 1706897 0 magomez 2020-11-12 09:51:45 -0800 When a BitmapTextureGL is reused, its internal values are reset (flags, internal texture, and content). But the FilterInfo variable is not, so the every time that BitmapTextureGL is painted it will use the the old filter, altering the result. 1706901 1 413946 magomez 2020-11-12 09:55:02 -0800 Created attachment 413946 Patch 1706999 2 fujii 2020-11-12 13:33:09 -0800 Good catch. Are there any existing tests failing? If so, please add a comment about it. If not, can you add a new test? 1707130 3 cgarcia 2020-11-12 23:46:40 -0800 I think this will fix tests but on top pach attached to bug #215445. So, it will be covered by backdrop filter tests. 1707135 4 magomez 2020-11-13 00:05:49 -0800 (In reply to Carlos Garcia Campos from comment #3) > I think this will fix tests but on top pach attached to bug #215445. So, it > will be covered by backdrop filter tests. Yes, this together with the fix to bug #215445 will fix several backdrop filter related bugs. 1707137 5 ews-feeder 2020-11-13 00:22:51 -0800 Committed r269765: <https://trac.webkit.org/changeset/269765> All reviewed patches have been landed. Closing bug and clearing flags on attachment 413946. 413946 2020-11-12 09:55:02 -0800 2020-11-13 00:22:52 -0800 Patch bug-218854-20201112185500.patch text/plain 1382 magomez U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5NzMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDEyZjFhOGY3ODZmNWRm MGM4NWI5ZjlhNGUyZWFkZTc3ZjNlOWE4ZC4uMWFjZjg2OTQzNjhmOGVlMTczZWFhMzQxODJiMTBm ZTk3ZTNhZDY1MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIwLTExLTEyICBNaWd1 ZWwgR29tZXogIDxtYWdvbWV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS11bV1BFXSBGaWx0 ZXJJbmZvIG11c3QgY2xlYXJlZCB3aGVuIHJldXNpbmcgQml0bWFwVGV4dHVyZUdMCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTg4NTQKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDbGVhciB0aGUgRmlsdGVy SW5mbyBhdHRyaWJ1dGUgd2hlbiByZXVzaW5nIGEgQml0bWFwVGV4dHVyZUdMLgorCisgICAgICAg ICogcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL0JpdG1hcFRleHR1cmVHTC5jcHA6CisgICAgICAg IChXZWJDb3JlOjpCaXRtYXBUZXh0dXJlR0w6OmRpZFJlc2V0KToKKwogMjAyMC0xMS0xMiAgU2Vy Z2lvIFZpbGxhciBTZW5pbiAgPHN2aWxsYXJAaWdhbGlhLmNvbT4KIAogICAgICAgICBDcmFzaCBp biBSZW5kZXJCb3g6Om92ZXJyaWRlQ29udGFpbmluZ0Jsb2NrQ29udGVudEhlaWdodCgpCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvQml0bWFwVGV4 dHVyZUdMLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9CaXRt YXBUZXh0dXJlR0wuY3BwCmluZGV4IGE2MTEwOTJlYzkxNDcwMDkyMjYwZDhiMDRiN2NhMzUxYzc2 ZjQ2ZmYuLjM2MmI2NDJlNTA4YjgwNzkwMTNlZmRhZmUwZDRhODFlYWFhMTdmMWYgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9CaXRtYXBUZXh0dXJl R0wuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9CaXRt YXBUZXh0dXJlR0wuY3BwCkBAIC04MCw2ICs4MCw3IEBAIHZvaWQgQml0bWFwVGV4dHVyZUdMOjpk aWRSZXNldCgpCiAKICAgICBtX3Nob3VsZENsZWFyID0gdHJ1ZTsKICAgICBtX2NvbG9yQ29udmVy dEZsYWdzID0gVGV4dHVyZU1hcHBlckdMOjpOb0ZsYWc7CisgICAgbV9maWx0ZXJJbmZvID0gRmls dGVySW5mbygpOwogICAgIGlmIChtX3RleHR1cmVTaXplID09IGNvbnRlbnRTaXplKCkpCiAgICAg ICAgIHJldHVybjsKIAo=