218850 2020-11-12 08:49:39 -0800 configure-xcode-for-embedded-development breaks @available in Swift files 2020-11-12 14:20:18 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ajuma ajuma jbedard webkit-bug-importer oldest_to_newest 1706861 0 ajuma 2020-11-12 08:49:39 -0800 The changes applied by configure-xcode-for-embedded-development leave Xcode in state where using @available in a Swift class breaks compilation of Objective-C methods marked with API_AVAILABLE that call into that class. Specifically, suppose we have: -a Swift class Foo marked @available(iOS 14.0, *) -an ObjC class Bar with a method myMethod marked API_AVAILABLE(ios(14)) The changes applied by configure-xcode-for-embedded-development for AvailabilityProhibitedInternal.h cause API_AVAILABLE to be ignored, but @available is not ignored. This means that calling from myMethod into Foo, which should be fine since both are available only in iOS 14+, results in a build failure when building with -Werror -Wunguarded-availability, since after pre-processing, myMethod has no availability notation. I ran into this when trying to build Chrome for iOS using the same Xcode that I use for building WebKit. 1706867 1 413939 ajuma 2020-11-12 08:59:43 -0800 Created attachment 413939 Patch 1706870 2 413939 jbedard 2020-11-12 09:04:30 -0800 Comment on attachment 413939 Patch I think this is correct, but I want to verify that our embedded builds still work after this change, which will take some time. Unfortunately, EWS isn't going to test the changes here. 1707007 3 413939 jbedard 2020-11-12 14:06:51 -0800 Comment on attachment 413939 Patch Tested with out embedded builds, should be good to go! 1707008 4 ajuma 2020-11-12 14:09:45 -0800 (In reply to Jonathan Bedard from comment #3) > Comment on attachment 413939 [details] > Patch > > Tested with out embedded builds, should be good to go! Thanks for the review and for testing this! 1707013 5 ews-feeder 2020-11-12 14:19:10 -0800 Committed r269752: <https://trac.webkit.org/changeset/269752> All reviewed patches have been landed. Closing bug and clearing flags on attachment 413939. 1707014 6 webkit-bug-importer 2020-11-12 14:20:18 -0800 <rdar://problem/71343631> 413939 2020-11-12 08:59:43 -0800 2020-11-12 14:19:11 -0800 Patch bug-218850-20201112115942.patch text/plain 1959 ajuma U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5NzMyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNjdmODYxMTIzYTY4MzMyODhlM2RiNDE0NmRiMzVhOGU2 MGVjOWE5Yy4uMGIyNjA0YzEzYzNkYjU3ZTAwYzkwNDg4NzcwMDEwNzFjOGFjNGFmOCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIy IEBACisyMDIwLTExLTEyICBBbGkgSnVtYSAgPGFqdW1hQGNocm9taXVtLm9yZz4KKworICAgICAg ICBjb25maWd1cmUteGNvZGUtZm9yLWVtYmVkZGVkLWRldmVsb3BtZW50IGJyZWFrcyBAYXZhaWxh YmxlIGluIFN3aWZ0IGZpbGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMTg4NTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBUaGUgY2hhbmdlcyBhcHBsaWVkIGJ5IGNvbmZpZ3VyZS14Y29kZS1mb3ItZW1i ZWRkZWQtZGV2ZWxvcG1lbnQKKyAgICAgICAgZm9yIEF2YWlsYWJpbGl0eVByb2hpYml0ZWRJbnRl cm5hbC5oIGNhdXNlIEFQSV9BVkFJTEFCTEUgdG8gYmUgaWdub3JlZAorICAgICAgICBpbiBPYmpl Y3RpdmUtQywgYnV0IEBhdmFpbGFibGUgaXMgbm90IGlnbm9yZWQgaW4gU3dpZnQuIEFzIGEgcmVz dWx0LAorICAgICAgICBpZiBhbiBPYmplY3RpdmUtQyBtZXRob2QgbWFya2VkIHdpdGggQVBJX0FW QUlMQUJMRSBtYWtlcyBhIGNhbGwKKyAgICAgICAgaW50byBhIFN3aWZ0IGNsYXNzIG1hcmtlZCB3 aXRoIEBhdmFpbGFibGUsIHRoaXMgY2FuIGxlYWQgdG8gYW4KKyAgICAgICAgYXZhaWxhYmlsaXR5 IHdhcm5pbmcgZXZlbiB3aGVuIHRoZSBjYWxsaW5nIG1ldGhvZCBpcyBvbmx5IGF2YWlsYWJsZQor ICAgICAgICB3aGVuIHRoZSBjYWxsZWUgaXMgYXZhaWxhYmxlLgorCisgICAgICAgIFRvIGZpeCB0 aGlzLCBlbnN1cmUgdGhhdCBAYXZhaWxhYmxlIGlzIGFsc28gaWdub3JlZCBpbiBTd2lmdC4KKwor ICAgICAgICAqIFNjcmlwdHMvY29uZmlndXJlLXhjb2RlLWZvci1lbWJlZGRlZC1kZXZlbG9wbWVu dDoKKwogMjAyMC0xMS0xMiAgQWFrYXNoIEphaW4gIDxhYWthc2hfamFpbkBhcHBsZS5jb20+CiAK ICAgICAgICAgW2J1aWxkLndlYmtpdC5vcmddIFVwZGF0ZSBDaGVja091dFNvdXJjZSBzdGVwIGZv ciBuZXcgYnVpbGRib3QgKGZvbGxvdy11cCBmaXgpCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRz L2NvbmZpZ3VyZS14Y29kZS1mb3ItZW1iZWRkZWQtZGV2ZWxvcG1lbnQgYi9Ub29scy9TY3JpcHRz L2NvbmZpZ3VyZS14Y29kZS1mb3ItZW1iZWRkZWQtZGV2ZWxvcG1lbnQKaW5kZXggMzFmZDc0OTZj NDEzOGU0YTZlZDBjMGY1ODI0YWJkZGU2ODU1N2NmMy4uNjhkZTVhMmYwMzkxYjc5NmJhYTkzYjY1 YTAwMjJiNTlhNTUxNWY1OSAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9jb25maWd1cmUteGNv ZGUtZm9yLWVtYmVkZGVkLWRldmVsb3BtZW50CisrKyBiL1Rvb2xzL1NjcmlwdHMvY29uZmlndXJl LXhjb2RlLWZvci1lbWJlZGRlZC1kZXZlbG9wbWVudApAQCAtOTcsNiArOTcsOSBAQCBBVkFJTEFC SUxUWV9URVhUID0gIiIiXAogI3VuZGVmIF9fQVBJX0FWQUlMQUJMRV9HRVRfTUFDUk8KICNkZWZp bmUgX19BUElfQVZBSUxBQkxFX0dFVF9NQUNSTyguLi4pIF9fTlVMTF9BVkFJTEFCSUxJVFkKIAor I3VuZGVmIFNXSUZUX0FWQUlMQUJJTElUWQorI2RlZmluZSBTV0lGVF9BVkFJTEFCSUxJVFkgX19O VUxMX0FWQUlMQUJJTElUWQorCiAvLyBUYWtlIGNhcmUgb2Yge0EsU31QSV9ERVBSRUNBVEVEeyxX SVRIX1JFUExBQ0VNRU5UfXssX0JFR0lOLF9FTkR9CiAjdW5kZWYgX19BUElfREVQUkVDQVRFRF9N U0dfR0VUX01BQ1JPCiAjZGVmaW5lIF9fQVBJX0RFUFJFQ0FURURfTVNHX0dFVF9NQUNSTyguLi4p IF9fTlVMTF9BVkFJTEFCSUxJVFkK