218838 2020-11-11 19:38:13 -0800 REGRESSION(r267411): Unable to "Start Element Selection" with Web Inspector closed 2020-11-11 22:30:35 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 bburg bburg bburg ews-watchlist hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1706738 0 bburg 2020-11-11 19:38:13 -0800 <rdar://problem/71158215> 1706739 1 413901 bburg 2020-11-11 19:41:37 -0800 Created attachment 413901 Patch This is a partial revert of r276411. 1706740 2 413902 bburg 2020-11-11 19:44:45 -0800 Created attachment 413902 Patch (better ChangeLog) 1706767 3 413902 hi 2020-11-11 22:26:09 -0800 Comment on attachment 413902 Patch (better ChangeLog) rs=me 1706770 4 ews-feeder 2020-11-11 22:30:34 -0800 Committed r269718: <https://trac.webkit.org/changeset/269718> All reviewed patches have been landed. Closing bug and clearing flags on attachment 413902. 413901 2020-11-11 19:41:37 -0800 2020-11-11 19:44:41 -0800 Patch bug-218838-20201111194137.patch text/plain 3386 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5Njg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDM2ZTkxYTJmOWIzN2Y2M2Yz MWE1YTQzNjlhYzRiYjFiNDMwMzM2ODguLjQ0MmY3ZWQ0YzE2OTc4ZjQyNjMxOGRmMDNiYmQwMGY0 ZmYwMjU3ZGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMjAtMTEtMTEgIEJyaWFuIEJ1 cmcgIDxiYnVyZ0BhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTihyMjY3NDExKTogVW5h YmxlIHRvICJTdGFydCBFbGVtZW50IFNlbGVjdGlvbiIgd2l0aCBXZWIgSW5zcGVjdG9yIGNsb3Nl ZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE4ODM4 CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83MTE1ODIxNT4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgV2ViUHJvY2Vzcy1zaWRlIG9mIHRoZSBj b25uZWN0aW9uIGJldHdlZW4gaW5zcGVjdGVkIFdlYlByb2Nlc3MgYW5kCisgICAgICAgIGluc3Bl Y3RvciBXZWJQcm9jZXNzIHdhcyBtaXN0YWtlbmx5IHJlbW92ZWQgaW4gcjI2NzQxMS4gUmV2ZXJ0 IHRob3NlIGNoYW5nZXMuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL0luc3BlY3Rvci9XZWJJbnNw ZWN0b3JVSS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYkluc3BlY3RvclVJOjp1cGRhdGVDb25u ZWN0aW9uKToKKyAgICAgICAgKFdlYktpdDo6V2ViSW5zcGVjdG9yVUk6OmNsb3NlV2luZG93KToK KyAgICAgICAgKiBXZWJQcm9jZXNzL0luc3BlY3Rvci9XZWJJbnNwZWN0b3JVSS5oOgorCiAyMDIw LTExLTExICBCcmlhbiBCdXJnICA8YmJ1cmdAYXBwbGUuY29tPgogCiAgICAgICAgIFtDb2NvYV0g SW5zcGVjdG9yIEV4dGVuc2lvbnM6IEFkZCBfV0tJbnNwZWN0b3JFeHRlbnNpb24gYW5kIHJlbGF0 ZWQgcGx1bWJpbmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9JbnNwZWN0 b3IvV2ViSW5zcGVjdG9yVUkuY3BwIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0luc3BlY3Rv ci9XZWJJbnNwZWN0b3JVSS5jcHAKaW5kZXggMDBmOTQxZTc0NTg2N2NmZGUxZWU1ZTNkNjA2Y2E4 ZTlkMzA3NzY0YS4uMWEyZDcxMDBhNWViMjhmNzVhODQ1ZWYyOWJhMDE5MjUyNzM5Y2NlMyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0luc3BlY3Rvci9XZWJJbnNwZWN0b3JV SS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0luc3BlY3Rvci9XZWJJbnNwZWN0 b3JVSS5jcHAKQEAgLTkzLDYgKzkzLDExIEBAIHZvaWQgV2ViSW5zcGVjdG9yVUk6OmVzdGFibGlz aENvbm5lY3Rpb24oV2ViUGFnZVByb3h5SWRlbnRpZmllciBpbnNwZWN0ZWRQYWdlSWRlCiAKIHZv aWQgV2ViSW5zcGVjdG9yVUk6OnVwZGF0ZUNvbm5lY3Rpb24oKQogeworICAgIGlmIChtX2JhY2tl bmRDb25uZWN0aW9uKSB7CisgICAgICAgIG1fYmFja2VuZENvbm5lY3Rpb24tPmludmFsaWRhdGUo KTsKKyAgICAgICAgbV9iYWNrZW5kQ29ubmVjdGlvbiA9IG51bGxwdHI7CisgICAgfQorCiAjaWYg VVNFKFVOSVhfRE9NQUlOX1NPQ0tFVFMpCiAgICAgSVBDOjpDb25uZWN0aW9uOjpTb2NrZXRQYWly IHNvY2tldFBhaXIgPSBJUEM6OkNvbm5lY3Rpb246OmNyZWF0ZVBsYXRmb3JtQ29ubmVjdGlvbigp OwogICAgIElQQzo6Q29ubmVjdGlvbjo6SWRlbnRpZmllciBjb25uZWN0aW9uSWRlbnRpZmllcihz b2NrZXRQYWlyLnNlcnZlcik7CkBAIC0xMTgsNiArMTIzLDExIEBAIHZvaWQgV2ViSW5zcGVjdG9y VUk6OnVwZGF0ZUNvbm5lY3Rpb24oKQogICAgIHJldHVybjsKICNlbmRpZgogCisjaWYgVVNFKFVO SVhfRE9NQUlOX1NPQ0tFVFMpIHx8IE9TKERBUldJTikgfHwgUExBVEZPUk0oV0lOKQorICAgIG1f YmFja2VuZENvbm5lY3Rpb24gPSBJUEM6OkNvbm5lY3Rpb246OmNyZWF0ZVNlcnZlckNvbm5lY3Rp b24oY29ubmVjdGlvbklkZW50aWZpZXIsICp0aGlzKTsKKyAgICBtX2JhY2tlbmRDb25uZWN0aW9u LT5vcGVuKCk7CisjZW5kaWYKKwogICAgIFdlYlByb2Nlc3M6OnNpbmdsZXRvbigpLnBhcmVudFBy b2Nlc3NDb25uZWN0aW9uKCktPnNlbmQoTWVzc2FnZXM6OldlYkluc3BlY3RvclByb3h5OjpTZXRG cm9udGVuZENvbm5lY3Rpb24oY29ubmVjdGlvbkNsaWVudFBvcnQpLCBtX2luc3BlY3RlZFBhZ2VJ ZGVudGlmaWVyKTsKIH0KIApAQCAtMTY2LDYgKzE3NiwxMSBAQCB2b2lkIFdlYkluc3BlY3RvclVJ OjpjbG9zZVdpbmRvdygpCiB7CiAgICAgV2ViUHJvY2Vzczo6c2luZ2xldG9uKCkucGFyZW50UHJv Y2Vzc0Nvbm5lY3Rpb24oKS0+c2VuZChNZXNzYWdlczo6V2ViSW5zcGVjdG9yUHJveHk6OkRpZENs b3NlKCksIG1faW5zcGVjdGVkUGFnZUlkZW50aWZpZXIpOwogCisgICAgaWYgKG1fYmFja2VuZENv bm5lY3Rpb24pIHsKKyAgICAgICAgbV9iYWNrZW5kQ29ubmVjdGlvbi0+aW52YWxpZGF0ZSgpOwor ICAgICAgICBtX2JhY2tlbmRDb25uZWN0aW9uID0gbnVsbHB0cjsKKyAgICB9CisKICAgICBpZiAo bV9mcm9udGVuZENvbnRyb2xsZXIpIHsKICAgICAgICAgbV9mcm9udGVuZENvbnRyb2xsZXItPnNl dEluc3BlY3RvckZyb250ZW5kQ2xpZW50KG51bGxwdHIpOwogICAgICAgICBtX2Zyb250ZW5kQ29u dHJvbGxlciA9IG51bGxwdHI7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3Mv SW5zcGVjdG9yL1dlYkluc3BlY3RvclVJLmggYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvSW5z cGVjdG9yL1dlYkluc3BlY3RvclVJLmgKaW5kZXggMjRjMWFiNDY5ZTgwZDViMzc3YjA2MDlmNzA1 ZmRlNmZlMGU5ZDIwYy4uOTk1YzIyMjQ1YmZmYTRlNWRhMjg2ZjNkY2I2NjYxMDUzMzJkYTgyMSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0luc3BlY3Rvci9XZWJJbnNwZWN0 b3JVSS5oCisrKyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9JbnNwZWN0b3IvV2ViSW5zcGVj dG9yVUkuaApAQCAtMTcyLDYgKzE3Miw4IEBAIHByaXZhdGU6CiAgICAgc3RkOjp1bmlxdWVfcHRy PFdlYkluc3BlY3RvclVJRXh0ZW5zaW9uQ29udHJvbGxlcj4gbV9leHRlbnNpb25Db250cm9sbGVy OwogI2VuZGlmCiAKKyAgICBSZWZQdHI8SVBDOjpDb25uZWN0aW9uPiBtX2JhY2tlbmRDb25uZWN0 aW9uOworCiAgICAgV2ViUGFnZVByb3h5SWRlbnRpZmllciBtX2luc3BlY3RlZFBhZ2VJZGVudGlm aWVyOwogICAgIGJvb2wgbV91bmRlclRlc3QgeyBmYWxzZSB9OwogICAgIERlYnVnZ2FibGVJbmZv RGF0YSBtX2RlYnVnZ2FibGVJbmZvOwo= 413902 2020-11-11 19:44:45 -0800 2020-11-11 22:30:35 -0800 Patch (better ChangeLog) bug-218838-20201111194441.patch text/plain 3569 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5Njg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDM2ZTkxYTJmOWIzN2Y2M2Yz MWE1YTQzNjlhYzRiYjFiNDMwMzM2ODguLjI1NWNiNDNmN2E4OTg3NjZiZDQ3NjRjODgzNjY2YWRh NmQ1ZjI5NDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMjAtMTEtMTEgIEJyaWFuIEJ1 cmcgIDxiYnVyZ0BhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTihyMjY3NDExKTogVW5h YmxlIHRvICJTdGFydCBFbGVtZW50IFNlbGVjdGlvbiIgd2l0aCBXZWIgSW5zcGVjdG9yIGNsb3Nl ZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE4ODM4 CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83MTE1ODIxNT4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgaW5zcGVjdG9yIHNpZGUgb2YgdGhlIGNv bm5lY3Rpb24gYmV0d2VlbiBXZWJJbnNwZWN0b3IgKGluc3BlY3RlZCBXZWJQcm9jZXNzKSBhbmQK KyAgICAgICAgV2ViSW5zcGVjdG9yVUkgKGluc3BlY3RvciBXZWJQcm9jZXNzKSB3YXMgbWlzdGFr ZW5seSByZW1vdmVkIGluIHIyNjc0MTEuIFJldmVydCB0aG9zZSBjaGFuZ2VzLgorICAgICAgICBX aXRob3V0IGEgdmFsaWQgZnJvbnRlbmQgY29ubmVjdGlvbiwgV2ViSW5zcGVjdG9yIGNhbm5vdCBm b3J3YXJkIHNvbWUgSVBDIG1lc3NhZ2VzCisgICAgICAgIHRvIFdlYkluc3BlY3RvclVJIGluY2x1 ZGluZyBTdGFydEVsZW1lbnRTZWxlY3Rpb24uCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL0luc3Bl Y3Rvci9XZWJJbnNwZWN0b3JVSS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYkluc3BlY3RvclVJ Ojp1cGRhdGVDb25uZWN0aW9uKToKKyAgICAgICAgKFdlYktpdDo6V2ViSW5zcGVjdG9yVUk6OmNs b3NlV2luZG93KToKKyAgICAgICAgKiBXZWJQcm9jZXNzL0luc3BlY3Rvci9XZWJJbnNwZWN0b3JV SS5oOgorCiAyMDIwLTExLTExICBCcmlhbiBCdXJnICA8YmJ1cmdAYXBwbGUuY29tPgogCiAgICAg ICAgIFtDb2NvYV0gSW5zcGVjdG9yIEV4dGVuc2lvbnM6IEFkZCBfV0tJbnNwZWN0b3JFeHRlbnNp b24gYW5kIHJlbGF0ZWQgcGx1bWJpbmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJv Y2Vzcy9JbnNwZWN0b3IvV2ViSW5zcGVjdG9yVUkuY3BwIGIvU291cmNlL1dlYktpdC9XZWJQcm9j ZXNzL0luc3BlY3Rvci9XZWJJbnNwZWN0b3JVSS5jcHAKaW5kZXggMDBmOTQxZTc0NTg2N2NmZGUx ZWU1ZTNkNjA2Y2E4ZTlkMzA3NzY0YS4uMWEyZDcxMDBhNWViMjhmNzVhODQ1ZWYyOWJhMDE5MjUy NzM5Y2NlMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0luc3BlY3Rvci9X ZWJJbnNwZWN0b3JVSS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0luc3BlY3Rv ci9XZWJJbnNwZWN0b3JVSS5jcHAKQEAgLTkzLDYgKzkzLDExIEBAIHZvaWQgV2ViSW5zcGVjdG9y VUk6OmVzdGFibGlzaENvbm5lY3Rpb24oV2ViUGFnZVByb3h5SWRlbnRpZmllciBpbnNwZWN0ZWRQ YWdlSWRlCiAKIHZvaWQgV2ViSW5zcGVjdG9yVUk6OnVwZGF0ZUNvbm5lY3Rpb24oKQogeworICAg IGlmIChtX2JhY2tlbmRDb25uZWN0aW9uKSB7CisgICAgICAgIG1fYmFja2VuZENvbm5lY3Rpb24t PmludmFsaWRhdGUoKTsKKyAgICAgICAgbV9iYWNrZW5kQ29ubmVjdGlvbiA9IG51bGxwdHI7Cisg ICAgfQorCiAjaWYgVVNFKFVOSVhfRE9NQUlOX1NPQ0tFVFMpCiAgICAgSVBDOjpDb25uZWN0aW9u OjpTb2NrZXRQYWlyIHNvY2tldFBhaXIgPSBJUEM6OkNvbm5lY3Rpb246OmNyZWF0ZVBsYXRmb3Jt Q29ubmVjdGlvbigpOwogICAgIElQQzo6Q29ubmVjdGlvbjo6SWRlbnRpZmllciBjb25uZWN0aW9u SWRlbnRpZmllcihzb2NrZXRQYWlyLnNlcnZlcik7CkBAIC0xMTgsNiArMTIzLDExIEBAIHZvaWQg V2ViSW5zcGVjdG9yVUk6OnVwZGF0ZUNvbm5lY3Rpb24oKQogICAgIHJldHVybjsKICNlbmRpZgog CisjaWYgVVNFKFVOSVhfRE9NQUlOX1NPQ0tFVFMpIHx8IE9TKERBUldJTikgfHwgUExBVEZPUk0o V0lOKQorICAgIG1fYmFja2VuZENvbm5lY3Rpb24gPSBJUEM6OkNvbm5lY3Rpb246OmNyZWF0ZVNl cnZlckNvbm5lY3Rpb24oY29ubmVjdGlvbklkZW50aWZpZXIsICp0aGlzKTsKKyAgICBtX2JhY2tl bmRDb25uZWN0aW9uLT5vcGVuKCk7CisjZW5kaWYKKwogICAgIFdlYlByb2Nlc3M6OnNpbmdsZXRv bigpLnBhcmVudFByb2Nlc3NDb25uZWN0aW9uKCktPnNlbmQoTWVzc2FnZXM6OldlYkluc3BlY3Rv clByb3h5OjpTZXRGcm9udGVuZENvbm5lY3Rpb24oY29ubmVjdGlvbkNsaWVudFBvcnQpLCBtX2lu c3BlY3RlZFBhZ2VJZGVudGlmaWVyKTsKIH0KIApAQCAtMTY2LDYgKzE3NiwxMSBAQCB2b2lkIFdl Ykluc3BlY3RvclVJOjpjbG9zZVdpbmRvdygpCiB7CiAgICAgV2ViUHJvY2Vzczo6c2luZ2xldG9u KCkucGFyZW50UHJvY2Vzc0Nvbm5lY3Rpb24oKS0+c2VuZChNZXNzYWdlczo6V2ViSW5zcGVjdG9y UHJveHk6OkRpZENsb3NlKCksIG1faW5zcGVjdGVkUGFnZUlkZW50aWZpZXIpOwogCisgICAgaWYg KG1fYmFja2VuZENvbm5lY3Rpb24pIHsKKyAgICAgICAgbV9iYWNrZW5kQ29ubmVjdGlvbi0+aW52 YWxpZGF0ZSgpOworICAgICAgICBtX2JhY2tlbmRDb25uZWN0aW9uID0gbnVsbHB0cjsKKyAgICB9 CisKICAgICBpZiAobV9mcm9udGVuZENvbnRyb2xsZXIpIHsKICAgICAgICAgbV9mcm9udGVuZENv bnRyb2xsZXItPnNldEluc3BlY3RvckZyb250ZW5kQ2xpZW50KG51bGxwdHIpOwogICAgICAgICBt X2Zyb250ZW5kQ29udHJvbGxlciA9IG51bGxwdHI7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L1dlYlByb2Nlc3MvSW5zcGVjdG9yL1dlYkluc3BlY3RvclVJLmggYi9Tb3VyY2UvV2ViS2l0L1dl YlByb2Nlc3MvSW5zcGVjdG9yL1dlYkluc3BlY3RvclVJLmgKaW5kZXggMjRjMWFiNDY5ZTgwZDVi Mzc3YjA2MDlmNzA1ZmRlNmZlMGU5ZDIwYy4uOTk1YzIyMjQ1YmZmYTRlNWRhMjg2ZjNkY2I2NjYx MDUzMzJkYTgyMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0luc3BlY3Rv ci9XZWJJbnNwZWN0b3JVSS5oCisrKyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9JbnNwZWN0 b3IvV2ViSW5zcGVjdG9yVUkuaApAQCAtMTcyLDYgKzE3Miw4IEBAIHByaXZhdGU6CiAgICAgc3Rk Ojp1bmlxdWVfcHRyPFdlYkluc3BlY3RvclVJRXh0ZW5zaW9uQ29udHJvbGxlcj4gbV9leHRlbnNp b25Db250cm9sbGVyOwogI2VuZGlmCiAKKyAgICBSZWZQdHI8SVBDOjpDb25uZWN0aW9uPiBtX2Jh Y2tlbmRDb25uZWN0aW9uOworCiAgICAgV2ViUGFnZVByb3h5SWRlbnRpZmllciBtX2luc3BlY3Rl ZFBhZ2VJZGVudGlmaWVyOwogICAgIGJvb2wgbV91bmRlclRlc3QgeyBmYWxzZSB9OwogICAgIERl YnVnZ2FibGVJbmZvRGF0YSBtX2RlYnVnZ2FibGVJbmZvOwo=