218836 2020-11-11 17:50:49 -0800 Web Inspector: Uncaught Exception: TypeError: undefined is not an object (evaluating 'target.DOMAgent.hideHighlight') 2020-11-12 14:53:13 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=218678 InRadar P2 Normal --- 1 hi hi bburg hi inspector-bugzilla-changes simon.fraser webkit-bug-importer oldest_to_newest 1706715 0 hi 2020-11-11 17:50:49 -0800 # STEPS TO REPRODUCE 1. inspect any page 2. go to the Graphics Tab 3. close Web Inspector 4. open Web Inspector Uncaught Exceptions: ----------------------- - TypeError: undefined is not an object (evaluating 'target.DOMAgent.hideHighlight') (at DOMManager.js:576:24) hideDOMNodeHighlight @ DOMManager.js:576:24 detached @ GraphicsOverviewContentView.js:81:43 _didMoveToWindow @ View.js:267:26 _didMoveToParent @ View.js:239:30 removeSubview @ View.js:129:30 _hideEntry @ ContentViewContainer.js:464:31 showBackForwardEntryForIndex @ ContentViewContainer.js:161:28 showContentView @ ContentViewContainer.js:141:42 initialLayout @ GraphicsTabContentView.js:206:44 _layoutSubtree @ View.js:281:31 _layoutSubtree @ View.js:304:32 _layoutSubtree @ View.js:304:32 updateLayout @ View.js:160:28 ? @ Main.js:1908:31 ? @ Main.js:1927:32 dispatch @ Object.js:130:35 dispatchEventToListeners @ Object.js:138:17 collapsed @ Sidebar.js:131:38 showDetailsSidebarPanels @ ContentBrowserTabContentView.js:196:30 _contentBrowserCurrentRepresentedObjectsDidChange @ ContentBrowserTabContentView.js:316:38 dispatch @ Object.js:130:35 dispatchEventToListeners @ Object.js:138:17 ? @ ContentBrowser.js:96:42 _execute @ Debouncer.js:132:29 force @ Debouncer.js:63:22 _currentContentViewDidChange @ ContentBrowser.js:542:72 dispatch @ Object.js:130:35 dispatchEventToListeners @ Object.js:138:17 showBackForwardEntryForIndex @ ContentViewContainer.js:164:38 showContentView @ ContentViewContainer.js:141:42 initialLayout @ GraphicsTabContentView.js:206:44 _layoutSubtree @ View.js:281:31 _layoutSubtree @ View.js:304:32 _layoutSubtree @ View.js:304:32 updateLayout @ View.js:160:28 ? @ Main.js:1908:31 ? @ Main.js:1927:32 dispatch @ Object.js:130:35 dispatchEventToListeners @ Object.js:138:17 _handleSidebarWidthDidChange @ MultiSidebar.js:315:38 dispatch @ Object.js:130:35 dispatchEventToListeners @ Object.js:138:17 _recalculateWidth @ SingleSidebar.js:185:38 width @ SingleSidebar.js:73:31 _showDetailsSidebarPanelsForTabContentView @ TabBrowser.js:455:20 _tabBarItemSelected @ TabBrowser.js:254:56 dispatch @ Object.js:130:35 dispatchEventToListeners @ Object.js:138:17 selectTabBarItem @ TabBar.js:414:38 selectedTabBarItem @ TabBar.js:386:30 ? @ Main.js:527:18 ----------------------- Notes: Inspected URL: (unknown) Loading completed: false Frontend User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) I encountered this while living on bug 218678, so this may be fallout (or a preemptive fix depending on how you look at it) from that. 1706716 1 413894 hi 2020-11-11 17:55:04 -0800 Created attachment 413894 Patch 1707024 2 413894 bburg 2020-11-12 14:35:43 -0800 Comment on attachment 413894 Patch r=me Does this need to be changed in other places as well? 1707032 3 webkit-bug-importer 2020-11-12 14:48:01 -0800 <rdar://problem/71345058> 1707035 4 ews-feeder 2020-11-12 14:53:12 -0800 Committed r269756: <https://trac.webkit.org/changeset/269756> All reviewed patches have been landed. Closing bug and clearing flags on attachment 413894. 413894 2020-11-11 17:55:04 -0800 2020-11-12 14:53:13 -0800 Patch 218836.diff text/plain 1820 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDVhMDU4NjZkZGU1Yi4uNDFmMjdjZTUxMDk5IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAyMC0xMS0xMSAgRGV2 aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3Rvcjog VW5jYXVnaHQgRXhjZXB0aW9uOiBUeXBlRXJyb3I6IHVuZGVmaW5lZCBpcyBub3QgYW4gb2JqZWN0 IChldmFsdWF0aW5nICd0YXJnZXQuRE9NQWdlbnQuaGlkZUhpZ2hsaWdodCcpCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTg4MzYKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvQ29u dHJvbGxlcnMvRE9NTWFuYWdlci5qczoKKyAgICAgICAgKFdJLkRPTU1hbmFnZXIucHJvdG90eXBl LmhpZGVET01Ob2RlSGlnaGxpZ2h0KToKKyAgICAgICAgU29tZSB2aWV3cyBlYWdlcmx5IGNhbGwg dGhpcyB3aGVuIGBkZXRhY2hlZGAsIHBvc3NpYmx5IGV2ZW4gYmVmb3JlIHRoZSBgV0kubWFpblRh cmdldGAgaGFzCisgICAgICAgIGJlZW4gZXN0YWJsaXNoZWQgKGkuZS4gaXQncyBzdGlsbCBhIGBX SS5NdWx0aXBsZXhpbmdCYWNrZW5kVGFyZ2V0YCkuIFJhdGhlciB0aGFuIGFkZCBhCisgICAgICAg IHNwZWNpZmljIGNoZWNrIGZvciB0aGUgYFdJLm1haW5UYXJnZXRgLCBqdXN0IGl0ZXJhdGUgb3Zl ciBgV0kudGFyZ2V0c2AgYW5kIGNoZWNrIGVhY2ggdGFyZ2V0CisgICAgICAgIHNpbmNlIHRoYXQn cyBldmVudHVhbGx5IHdoYXQncyBnb2luZyB0byBuZWVkIHRvIGJlIGRvbmUgYW55d2F5cy4KKwog MjAyMC0xMS0wNiAgRGV2aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CiAKICAgICAgICAg V2ViIEluc3BlY3RvcjogU291cmNlczogZGVmYXVsdCBicmVha3BvaW50IGFjdGlvbiBzaG91bGQg YmUgZXZhbHVhdGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL0NvbnRyb2xsZXJzL0RPTU1hbmFnZXIuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9Db250cm9sbGVycy9ET01NYW5hZ2VyLmpzCmluZGV4IDRiNWRmNGEwZmFiNC4u ZjM1MmI2ZDgxMjhhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9Db250cm9sbGVycy9ET01NYW5hZ2VyLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL0RPTU1hbmFnZXIuanMKQEAgLTU3Miw4ICs1NzIs MTAgQEAgV0kuRE9NTWFuYWdlciA9IGNsYXNzIERPTU1hbmFnZXIgZXh0ZW5kcyBXSS5PYmplY3QK IAogICAgIGhpZGVET01Ob2RlSGlnaGxpZ2h0KCkKICAgICB7Ci0gICAgICAgIGxldCB0YXJnZXQg PSBXSS5hc3N1bWluZ01haW5UYXJnZXQoKTsKLSAgICAgICAgdGFyZ2V0LkRPTUFnZW50LmhpZGVI aWdobGlnaHQoKTsKKyAgICAgICAgZm9yIChsZXQgdGFyZ2V0IG9mIFdJLnRhcmdldHMpIHsKKyAg ICAgICAgICAgIGlmICh0YXJnZXQuaGFzQ29tbWFuZCgiRE9NLmhpZGVIaWdobGlnaHQiKSkKKyAg ICAgICAgICAgICAgICB0YXJnZXQuRE9NQWdlbnQuaGlkZUhpZ2hsaWdodCgpOworICAgICAgICB9 CiAgICAgfQogCiAgICAgaGlnaGxpZ2h0RE9NTm9kZUZvclR3b1NlY29uZHMobm9kZUlkKQo=