218820 2020-11-11 13:14:56 -0800 [iOS] IOKit sandbox violation when enabling all GPU runtime flags 2020-11-12 14:12:46 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan webkit-unassigned bfulgham simon.fraser webkit-bug-importer wenson_hsieh oldest_to_newest 1706592 0 pvollan 2020-11-11 13:14:56 -0800 When enabling all GPU runtime flags on iOS, there is an iokit-open sandbox violation in the WebContent process. 1706594 1 webkit-bug-importer 2020-11-11 13:16:18 -0800 <rdar://problem/71296116> 1706603 2 413859 pvollan 2020-11-11 13:38:01 -0800 Created attachment 413859 Patch 1706606 3 413860 pvollan 2020-11-11 13:40:07 -0800 Created attachment 413860 Patch 1707004 4 413860 bfulgham 2020-11-12 14:02:45 -0800 Comment on attachment 413860 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=413860&action=review r=me > Source/WebKit/ChangeLog:9 > + When enabling all GPU runtime flags on iOS, there is an iokit-open sandbox violation for the IOKit class AGXDeviceUserClient Is it a violation? Or just a violation report indicating that the access was allowed? I suspect it's the latter (i.e., we always allowed it, but we were logging in a case where we expected the access). 1707005 5 pvollan 2020-11-12 14:04:54 -0800 (In reply to Brent Fulgham from comment #4) > Comment on attachment 413860 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=413860&action=review > > r=me > > > Source/WebKit/ChangeLog:9 > > + When enabling all GPU runtime flags on iOS, there is an iokit-open sandbox violation for the IOKit class AGXDeviceUserClient > > Is it a violation? Or just a violation report indicating that the access was > allowed? I suspect it's the latter (i.e., we always allowed it, but we were > logging in a case where we expected the access). This was actually an IOKit open violation, which caused a crash. Thanks for reviewing! 1707011 6 ews-feeder 2020-11-12 14:12:45 -0800 Committed r269751: <https://trac.webkit.org/changeset/269751> All reviewed patches have been landed. Closing bug and clearing flags on attachment 413860. 413859 2020-11-11 13:38:01 -0800 2020-11-11 13:39:48 -0800 Patch 218820.patch text/plain 2824 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNjk3MDApCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDIwLTExLTExICBQZXIgQXJuZSBW b2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbaU9TXSBJT0tpdCBzYW5kYm94 IHZpb2xhdGlvbiB3aGVuIGVuYWJsaW5nIGFsbCBHUFUgcnVudGltZSBmbGFncworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE4ODIwCisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS83MTI5NjExNj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBXaGVuIGVuYWJsaW5nIGFsbCBHUFUgcnVudGltZSBmbGFncyBvbiBp T1MsIHRoZXJlIGlzIGFuIGlva2l0LW9wZW4gc2FuZGJveCB2aW9sYXRpb24gZm9yIHRoZSBJT0tp dCBjbGFzcyBBR1hEZXZpY2VVc2VyQ2xpZW50CisgICAgICAgIGluIHRoZSBXZWJDb250ZW50IHBy b2Nlc3MuIFdoZW4gYWxsIEdQVSBydW50aW1lIGZsYWdzIGFyZSBlbmFibGVkLCBJT0tpdCBleHRl bnNpb25zIGFyZSBub3QgcHJvdmlkZWQgdG8gdGhlIFdlYkNvbnRlbnQgcHJvY2VzcywKKyAgICAg ICAgd2hpY2ggc2hvdWxkIHRoZW4gZmFsbCBiYWNrIHRvIGEgc2V0IG9mIHJ1bGVzIGFsbG93aW5n IHVzZSBvZiB0aGVzZSBJT0tpdCBjbGFzc2VzLCB3aXRoIGxvZ2dpbmcuIFRoZXJlIHNlZW1zIHRv IGJlIGEgcHJvYmxlbQorICAgICAgICB3aXRoIHRoZSBmYWxsYmFjayBmb3IgdGhpcyBzcGVjaWZp YyBJT0tpdCBjbGFzcywgd2hpY2ggdGhpcyBwYXRjaCBhZGRyZXNzZXMgYnkgYWRkaW5nIGFuIGV4 dHJhIHJlcXVpcmVtZW50IHRvIHRoZSBydWxlLiBUaGUKKyAgICAgICAgZXh0cmEgcmVxdWlyZW1l bnQgaXMgdGhhdCBJT0tpdCBleHRlbnNpb25zIGhhdmUgbm90IGJlZW4gcHJvdmlkZWQgZm9yIHRo ZXNlIElPS2l0IGNsYXNzZXMuCisKKyAgICAgICAgKiBSZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVz L2lvcy9jb20uYXBwbGUuV2ViS2l0LldlYkNvbnRlbnQuc2I6CisKIDIwMjAtMTEtMTEgIEFsZXgg Q2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBEZWZpbmUg VVNFKExFR0FDWV9DRk5FVFdPUktfRE9XTkxPQURTKQpJbmRleDogU291cmNlL1dlYktpdC9SZXNv dXJjZXMvU2FuZGJveFByb2ZpbGVzL2lvcy9jb20uYXBwbGUuV2ViS2l0LldlYkNvbnRlbnQuc2IK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9SZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVzL2lv cy9jb20uYXBwbGUuV2ViS2l0LldlYkNvbnRlbnQuc2IJKHJldmlzaW9uIDI2OTU5NikKKysrIFNv dXJjZS9XZWJLaXQvUmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9pb3MvY29tLmFwcGxlLldlYktp dC5XZWJDb250ZW50LnNiCSh3b3JraW5nIGNvcHkpCkBAIC00NzMsMTQgKzQ3Myw2IEBACiAgICht b2JpbGUtcHJlZmVyZW5jZXMtcmVhZCAiY29tLmFwcGxlLlByb3RvdHlwZVRvb2xzIikpCiAKIChh bGxvdyBpb2tpdC1vcGVuICh3aXRoIHJlcG9ydCkgKHdpdGggdGVsZW1ldHJ5LWJhY2t0cmFjZSkK LSAgICAoaW9raXQtdXNlci1jbGllbnQtY2xhc3MgIklPTW9iaWxlRnJhbWVidWZmZXJVc2VyQ2xp ZW50IikKLSAgICAoaW9raXQtdXNlci1jbGllbnQtY2xhc3MgIkFHWERldmljZVVzZXJDbGllbnQi KQotICAgIChpb2tpdC11c2VyLWNsaWVudC1jbGFzcyAiQXBwbGVKUEVHRHJpdmVyVXNlckNsaWVu dCIpCi0gICAgKGlva2l0LXVzZXItY2xpZW50LWNsYXNzICJJT1N1cmZhY2VBY2NlbGVyYXRvckNs aWVudCIpCi0gICAgKGlva2l0LXVzZXItY2xpZW50LWNsYXNzICJJT1N1cmZhY2VSb290VXNlckNs aWVudCIpCi0pCi0KLShhbGxvdyBpb2tpdC1vcGVuICh3aXRoIHJlcG9ydCkgKHdpdGggdGVsZW1l dHJ5LWJhY2t0cmFjZSkKICAgICAoaW9raXQtY29ubmVjdGlvbiAiSU9HUFUiKQogKQogCkBAIC05 ODMsNiArOTc1LDIwIEBACiAgICAgKGdsb2JhbC1uYW1lICJjb20uYXBwbGUubW9iaWxlZ2VzdGFs dC54cGMiKQogKQogCis7OyBGSVhNRTogVGhpcyBpcyBqdXN0IGZvciBsb2dnaW5nLiBSZW1vdmUg d2hlbiB0aGUgR1BVIHByb2Nlc3MgaXMgZW5hYmxlZCBieSBkZWZhdWx0LgorKGFsbG93IGlva2l0 LW9wZW4gKHdpdGggcmVwb3J0KSAod2l0aCB0ZWxlbWV0cnktYmFja3RyYWNlKQorICAgIChyZXF1 aXJlLWFsbAorICAgICAgICAocmVxdWlyZS1ub3QgKGV4dGVuc2lvbiAiY29tLmFwcGxlLndlYmtp dC5leHRlbnNpb24uaW9raXQiKSkKKyAgICAgICAgKGlva2l0LXVzZXItY2xpZW50LWNsYXNzCisg ICAgICAgICAgICAiSU9Nb2JpbGVGcmFtZWJ1ZmZlclVzZXJDbGllbnQiCisgICAgICAgICAgICAi QUdYRGV2aWNlVXNlckNsaWVudCIKKyAgICAgICAgICAgICJBcHBsZUpQRUdEcml2ZXJVc2VyQ2xp ZW50IgorICAgICAgICAgICAgIklPU3VyZmFjZUFjY2VsZXJhdG9yQ2xpZW50IgorICAgICAgICAg ICAgIklPU3VyZmFjZVJvb3RVc2VyQ2xpZW50IgorICAgICAgICApCisgICAgKQorKQorCiAoYWxs b3cgbWFjaC1sb29rdXAKICAgICAocmVxdWlyZS1hbGwKICAgICAgICAgKGV4dGVuc2lvbiAiY29t LmFwcGxlLndlYmtpdC5leHRlbnNpb24ubWFjaCIpCg== 413860 2020-11-11 13:40:07 -0800 2020-11-12 14:12:45 -0800 Patch 218820.patch text/plain 3150 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNjk3MDApCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDIwLTExLTExICBQZXIgQXJuZSBW b2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbaU9TXSBJT0tpdCBzYW5kYm94 IHZpb2xhdGlvbiB3aGVuIGVuYWJsaW5nIGFsbCBHUFUgcnVudGltZSBmbGFncworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE4ODIwCisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS83MTI5NjExNj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBXaGVuIGVuYWJsaW5nIGFsbCBHUFUgcnVudGltZSBmbGFncyBvbiBp T1MsIHRoZXJlIGlzIGFuIGlva2l0LW9wZW4gc2FuZGJveCB2aW9sYXRpb24gZm9yIHRoZSBJT0tp dCBjbGFzcyBBR1hEZXZpY2VVc2VyQ2xpZW50CisgICAgICAgIGluIHRoZSBXZWJDb250ZW50IHBy b2Nlc3MuIFdoZW4gYWxsIEdQVSBydW50aW1lIGZsYWdzIGFyZSBlbmFibGVkLCBJT0tpdCBleHRl bnNpb25zIGFyZSBub3QgcHJvdmlkZWQgdG8gdGhlIFdlYkNvbnRlbnQgcHJvY2VzcywKKyAgICAg ICAgd2hpY2ggc2hvdWxkIHRoZW4gZmFsbCBiYWNrIHRvIGEgc2V0IG9mIHJ1bGVzIGFsbG93aW5n IHVzZSBvZiB0aGVzZSBJT0tpdCBjbGFzc2VzLCB3aXRoIGxvZ2dpbmcuIFRoZXJlIHNlZW1zIHRv IGJlIGEgcHJvYmxlbQorICAgICAgICB3aXRoIHRoZSBmYWxsYmFjayBmb3IgdGhpcyBzcGVjaWZp YyBJT0tpdCBjbGFzcywgd2hpY2ggdGhpcyBwYXRjaCBhZGRyZXNzZXMgYnkgYWRkaW5nIGFuIGV4 dHJhIHJlcXVpcmVtZW50IHRvIHRoZSBydWxlLiBUaGUKKyAgICAgICAgZXh0cmEgcmVxdWlyZW1l bnQgaXMgdGhhdCBJT0tpdCBleHRlbnNpb25zIGhhdmUgbm90IGJlZW4gcHJvdmlkZWQgZm9yIHRo ZXNlIElPS2l0IGNsYXNzZXMuCisKKyAgICAgICAgKiBSZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVz L2lvcy9jb20uYXBwbGUuV2ViS2l0LldlYkNvbnRlbnQuc2I6CisKIDIwMjAtMTEtMTEgIEFsZXgg Q2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBEZWZpbmUg VVNFKExFR0FDWV9DRk5FVFdPUktfRE9XTkxPQURTKQpJbmRleDogU291cmNlL1dlYktpdC9SZXNv dXJjZXMvU2FuZGJveFByb2ZpbGVzL2lvcy9jb20uYXBwbGUuV2ViS2l0LldlYkNvbnRlbnQuc2IK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9SZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVzL2lv cy9jb20uYXBwbGUuV2ViS2l0LldlYkNvbnRlbnQuc2IJKHJldmlzaW9uIDI2OTU5NikKKysrIFNv dXJjZS9XZWJLaXQvUmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9pb3MvY29tLmFwcGxlLldlYktp dC5XZWJDb250ZW50LnNiCSh3b3JraW5nIGNvcHkpCkBAIC00NzIsMTggKzQ3Miw2IEBACiAod2l0 aC1maWx0ZXIgKHN5c3RlbS1hdHRyaWJ1dGUgYXBwbGUtaW50ZXJuYWwpCiAgIChtb2JpbGUtcHJl ZmVyZW5jZXMtcmVhZCAiY29tLmFwcGxlLlByb3RvdHlwZVRvb2xzIikpCiAKLShhbGxvdyBpb2tp dC1vcGVuICh3aXRoIHJlcG9ydCkgKHdpdGggdGVsZW1ldHJ5LWJhY2t0cmFjZSkKLSAgICAoaW9r aXQtdXNlci1jbGllbnQtY2xhc3MgIklPTW9iaWxlRnJhbWVidWZmZXJVc2VyQ2xpZW50IikKLSAg ICAoaW9raXQtdXNlci1jbGllbnQtY2xhc3MgIkFHWERldmljZVVzZXJDbGllbnQiKQotICAgIChp b2tpdC11c2VyLWNsaWVudC1jbGFzcyAiQXBwbGVKUEVHRHJpdmVyVXNlckNsaWVudCIpCi0gICAg KGlva2l0LXVzZXItY2xpZW50LWNsYXNzICJJT1N1cmZhY2VBY2NlbGVyYXRvckNsaWVudCIpCi0g ICAgKGlva2l0LXVzZXItY2xpZW50LWNsYXNzICJJT1N1cmZhY2VSb290VXNlckNsaWVudCIpCi0p Ci0KLShhbGxvdyBpb2tpdC1vcGVuICh3aXRoIHJlcG9ydCkgKHdpdGggdGVsZW1ldHJ5LWJhY2t0 cmFjZSkKLSAgICAoaW9raXQtY29ubmVjdGlvbiAiSU9HUFUiKQotKQotCiAod2l0aC1lbGV2YXRl ZC1wcmVjZWRlbmNlCiAgICAgKGFsbG93IGZpbGUtcmVhZCoKICAgICAgICAgICAgKHN1YnBhdGgg Ii91c3IvbGliIgpAQCAtOTgzLDYgKzk3MSwyNyBAQAogICAgIChnbG9iYWwtbmFtZSAiY29tLmFw cGxlLm1vYmlsZWdlc3RhbHQueHBjIikKICkKIAorOzsgRklYTUU6IFRoaXMgaXMganVzdCBmb3Ig bG9nZ2luZy4gUmVtb3ZlIHdoZW4gdGhlIEdQVSBwcm9jZXNzIGlzIGVuYWJsZWQgYnkgZGVmYXVs dC4KKyhhbGxvdyBpb2tpdC1vcGVuICh3aXRoIHJlcG9ydCkgKHdpdGggdGVsZW1ldHJ5LWJhY2t0 cmFjZSkKKyAgICAocmVxdWlyZS1hbGwKKyAgICAgICAgKHJlcXVpcmUtbm90IChleHRlbnNpb24g ImNvbS5hcHBsZS53ZWJraXQuZXh0ZW5zaW9uLmlva2l0IikpCisgICAgICAgIChpb2tpdC11c2Vy LWNsaWVudC1jbGFzcworICAgICAgICAgICAgIklPTW9iaWxlRnJhbWVidWZmZXJVc2VyQ2xpZW50 IgorICAgICAgICAgICAgIkFHWERldmljZVVzZXJDbGllbnQiCisgICAgICAgICAgICAiQXBwbGVK UEVHRHJpdmVyVXNlckNsaWVudCIKKyAgICAgICAgICAgICJJT1N1cmZhY2VBY2NlbGVyYXRvckNs aWVudCIKKyAgICAgICAgICAgICJJT1N1cmZhY2VSb290VXNlckNsaWVudCIKKyAgICAgICAgKQor ICAgICkKKykKKworKGFsbG93IGlva2l0LW9wZW4gKHdpdGggcmVwb3J0KSAod2l0aCB0ZWxlbWV0 cnktYmFja3RyYWNlKQorICAgIChyZXF1aXJlLWFsbAorICAgICAgICAocmVxdWlyZS1ub3QgKGV4 dGVuc2lvbiAiY29tLmFwcGxlLndlYmtpdC5leHRlbnNpb24uaW9raXQiKSkKKyAgICAgICAgKGlv a2l0LWNvbm5lY3Rpb24gIklPR1BVIikKKyAgICApCispCisKIChhbGxvdyBtYWNoLWxvb2t1cAog ICAgIChyZXF1aXJlLWFsbAogICAgICAgICAoZXh0ZW5zaW9uICJjb20uYXBwbGUud2Via2l0LmV4 dGVuc2lvbi5tYWNoIikK