218814 2020-11-11 11:47:43 -0800 Define USE(LEGACY_CFNETWORK_DOWNLOADS) 2020-11-11 13:12:36 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen benjamin cdumez cmarcelo ews-watchlist ggaren webkit-bug-importer oldest_to_newest 1706542 0 achristensen 2020-11-11 11:47:43 -0800 Define HAVE(MOJAVE_CFNETWORK) 1706544 1 413845 achristensen 2020-11-11 11:49:28 -0800 Created attachment 413845 Patch 1706557 2 413845 ggaren 2020-11-11 12:01:45 -0800 Comment on attachment 413845 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=413845&action=review > Source/WTF/wtf/PlatformHave.h:423 > +#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED < 101500 > +#define HAVE_MOJAVE_CFNETWORK 1 > +#endif The new name here is still a statement about an OS version ("Mojave"), so not much has changed. Also, we usually use "HAVE(X)" to mean that a feature is present, not that a bug must be worked around. This is a tricky case. Our existing macro patterns don't fit super well. I think a better fit might be one of: ENABLE(CFNETWORK_DOWNLOAD_WORKAROUNDS) USE(LEGACY_CFNETWORK_DOWNLOADS) or inverted: HAVE(MODERN_CFNETWORK_DOWNLOADS) 1706559 3 413848 achristensen 2020-11-11 12:06:28 -0800 Created attachment 413848 Patch 1706585 4 413848 ggaren 2020-11-11 13:03:28 -0800 Comment on attachment 413848 Patch r=me 1706587 5 achristensen 2020-11-11 13:10:16 -0800 http://trac.webkit.org/r269700 1706589 6 webkit-bug-importer 2020-11-11 13:12:36 -0800 <rdar://problem/71296010> 413845 2020-11-11 11:49:28 -0800 2020-11-11 12:06:26 -0800 Patch bug-218814-20201111114927.patch text/plain 3072 achristensen U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5NjcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDVmMDRmNjY2ZmEzMmMwMjdlZDQ1ODQz MzU1OTEzOTA4ZDJmOGVhNzkuLmVkODE1YjM0ZTY0OTBhNzRkOTU1YTRiMGE2NTc5ZDE1MzVmZDUz ZTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMjAtMTEtMTEgIEFsZXggQ2hyaXN0ZW5zZW4gIDxh Y2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBEZWZpbmUgSEFWRShNT0pBVkVfQ0ZO RVRXT1JLKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjE4ODE0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiB3dGYvUGxhdGZvcm1IYXZlLmg6CisKIDIwMjAtMTEtMTAgIEpvaG4gV2lsYW5kZXIgIDx3aWxh bmRlckBhcHBsZS5jb20+CiAKICAgICAgICAgUENNOiBDaGFuZ2UgZnJvbSBhZC1jbGljay1hdHRy aWJ1dGlvbiB0byBwcml2YXRlLWNsaWNrLW1lYXN1cmVtZW50IChpbiBhbGwgZm9ybXMsIGluY2x1 ZGluZyAud2VsbC1rbm93biBVUkwpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxv ZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDNjNWYyYzZkNjQ2MmY1NjcxNTQwNjZi OWJhMTU5ZDNkNDAwYWJlNWMuLjMyYTRhNDA0ZmI4OWI4ZTQxYTU3ODE5OTY5MWZkN2JkMTgwNTVh ZDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjAtMTEtMTEgIEFsZXggQ2hyaXN0ZW5z ZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBEZWZpbmUgSEFWRShNT0pB VkVfQ0ZORVRXT1JLKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjE4ODE0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgTW9qYXZlIENGTmV0d29yayBoYXMgYSBmZXcgZG93bmxvYWQgYnVncyBJJ2xsIG5lZWQg dG8gd29yayBhcm91bmQuCisgICAgICAgIFdpdGggdGhpcyBjaGFuZ2UgSSBjYW4gdXNlIEhBVkUo TU9KQVZFX0NGTkVUV09SSykgaW5zdGVhZCBvZiBfX01BQ19PU19YX1ZFUlNJT05fTUlOX1JFUVVJ UkVELAorICAgICAgICB3aGljaCBpcyBtb3JlIGluIGxpbmUgd2l0aCBXZWJLaXQgc3R5bGUuICBU aGlzIHdpbGwgYmUgdXNlZCBtb3JlIGluIGJ1ZyAyMTc3NDcuCisKKyAgICAgICAgKiBOZXR3b3Jr UHJvY2Vzcy9Eb3dubG9hZHMvY29jb2EvRG93bmxvYWRDb2NvYS5tbToKKyAgICAgICAgKFdlYktp dDo6RG93bmxvYWQ6OnJlc3VtZSk6CisKIDIwMjAtMTEtMTAgIFBlciBBcm5lIFZvbGxhbiAgPHB2 b2xsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFttYWNPU10gRW5mb3JjZSBtZXNzYWdlIGZpbHRl cmluZyBpbiB0aGUgV2ViQ29udGVudCBwcm9jZXNzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0 Zi9QbGF0Zm9ybUhhdmUuaCBiL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtSGF2ZS5oCmluZGV4IDUy OGJjNzYyNzI1NDYwM2E2YTMzODEzN2FkODIyMDIyNzRhOGM0OWQuLmFiYzE0NzRiNzliNmY1MTY0 OTZlMjExOTc4ZTljZTFkMjdiZTk1MmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL1BsYXRm b3JtSGF2ZS5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtSGF2ZS5oCkBAIC00MTgsNiAr NDE4LDEwIEBACiAjZGVmaW5lIEhBVkVfQ1NDSEVDS0ZJWERJU0FCTEUgMQogI2VuZGlmCiAKKyNp ZiBQTEFURk9STShNQUMpICYmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPCAxMDE1 MDAKKyNkZWZpbmUgSEFWRV9NT0pBVkVfQ0ZORVRXT1JLIDEKKyNlbmRpZgorCiAjaWYgUExBVEZP Uk0oQ09DT0EpICYmICEoUExBVEZPUk0oTUFDKSAmJiBfX01BQ19PU19YX1ZFUlNJT05fTUlOX1JF UVVJUkVEIDwgMTAxNTAwKSAmJiAhUExBVEZPUk0oV0FUQ0hPUykgJiYgIVBMQVRGT1JNKEFQUExF VFYpCiAjZGVmaW5lIEhBVkVfTUROU19GQVNUX1JFR0lTVFJBVElPTiAxCiAjZW5kaWYKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvRG93bmxvYWRzL2NvY29hL0Rvd25s b2FkQ29jb2EubW0gYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL0Rvd25sb2Fkcy9jb2Nv YS9Eb3dubG9hZENvY29hLm1tCmluZGV4IDA4YjU1ZjBiMmZkZDliZjUyZTQxYmYwMTdhYmM0ZGM5 NDMwMmYwN2IuLmI0MTI3OTY1OWFkNzVhNmJmMGE1OGQzYjgzMjBjNzE5YmM5ZWY3YjAgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvRG93bmxvYWRzL2NvY29hL0Rvd25s b2FkQ29jb2EubW0KKysrIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9Eb3dubG9hZHMv Y29jb2EvRG93bmxvYWRDb2NvYS5tbQpAQCAtNTAsNyArNTAsNyBAQCB2b2lkIERvd25sb2FkOjpy ZXN1bWUoY29uc3QgSVBDOjpEYXRhUmVmZXJlbmNlJiByZXN1bWVEYXRhLCBjb25zdCBTdHJpbmcm IHBhdGgsCiAgICAgYXV0byBuc0RhdGEgPSBhZG9wdE5TKFtbTlNEYXRhIGFsbG9jXSBpbml0V2l0 aEJ5dGVzOnJlc3VtZURhdGEuZGF0YSgpIGxlbmd0aDpyZXN1bWVEYXRhLnNpemUoKV0pOwogCiAg ICAgLy8gRklYTUU6IFRoaXMgaXMgYSB0ZW1wb3Jhcnkgd29ya2Fyb3VuZCBmb3IgPHJkYXI6Ly9w cm9ibGVtLzM0NzQ1MTcxPi4gRml4ZWQgaW4gaU9TIDEzIGFuZCBtYWNPUyAxMC4xNSwgYnV0IHdl IHN0aWxsIG5lZWQgdG8gc3VwcG9ydCBtYWNPUyAxMC4xNCBmb3Igbm93LgotI2lmIFBMQVRGT1JN KE1BQykgJiYgX19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA8IDEwMTUwMAorI2lmIEhB VkUoTU9KQVZFX0NGTkVUV09SSykKICAgICBzdGF0aWMgTlNTZXQ8Q2xhc3M+ICpwbGlzdENsYXNz ZXMgPSBuaWw7CiAgICAgc3RhdGljIGRpc3BhdGNoX29uY2VfdCBvbmNlVG9rZW47CiAK 413848 2020-11-11 12:06:28 -0800 2020-11-11 13:03:28 -0800 Patch bug-218814-20201111120627.patch text/plain 3016 achristensen U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5NjcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDVmMDRmNjY2ZmEzMmMwMjdlZDQ1ODQz MzU1OTEzOTA4ZDJmOGVhNzkuLjNlZTliZjY2MTYwMzhjZDZhYmZjYmQ2YmZkMDU2OWZhZTMxZjY4 OTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMjAtMTEtMTEgIEFsZXggQ2hyaXN0ZW5zZW4gIDxh Y2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBEZWZpbmUgVVNFKExFR0FDWV9DRk5F VFdPUktfRE9XTkxPQURTKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjE4ODE0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiB3dGYvUGxhdGZvcm1Vc2UuaDoKKwogMjAyMC0xMS0xMCAgSm9obiBXaWxhbmRl ciAgPHdpbGFuZGVyQGFwcGxlLmNvbT4KIAogICAgICAgICBQQ006IENoYW5nZSBmcm9tIGFkLWNs aWNrLWF0dHJpYnV0aW9uIHRvIHByaXZhdGUtY2xpY2stbWVhc3VyZW1lbnQgKGluIGFsbCBmb3Jt cywgaW5jbHVkaW5nIC53ZWxsLWtub3duIFVSTCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv Q2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKaW5kZXggM2M1ZjJjNmQ2NDYyZjU2 NzE1NDA2NmI5YmExNTlkM2Q0MDBhYmU1Yy4uNmM2NWE1OTFiOWE5YTgzNGI3NTAxOGJjZmI5OTk3 MmFkNjY4YmJhOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYktpdC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAyMC0xMS0xMSAgQWxleCBD aHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgorCisgICAgICAgIERlZmluZSBV U0UoTEVHQUNZX0NGTkVUV09SS19ET1dOTE9BRFMpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTg4MTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBNb2phdmUgQ0ZOZXR3b3JrIGhhcyBhIGZldyBkb3dubG9h ZCBidWdzIEknbGwgbmVlZCB0byB3b3JrIGFyb3VuZC4KKyAgICAgICAgV2l0aCB0aGlzIGNoYW5n ZSBJIGNhbiB1c2UgVVNFKExFR0FDWV9DRk5FVFdPUktfRE9XTkxPQURTKSBpbnN0ZWFkIG9mIF9f TUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQsCisgICAgICAgIHdoaWNoIGlzIG1vcmUgaW4g bGluZSB3aXRoIFdlYktpdCBzdHlsZS4gIFRoaXMgd2lsbCBiZSB1c2VkIG1vcmUgaW4gYnVnIDIx Nzc0Ny4KKworICAgICAgICAqIE5ldHdvcmtQcm9jZXNzL0Rvd25sb2Fkcy9jb2NvYS9Eb3dubG9h ZENvY29hLm1tOgorICAgICAgICAoV2ViS2l0OjpEb3dubG9hZDo6cmVzdW1lKToKKwogMjAyMC0x MS0xMCAgUGVyIEFybmUgVm9sbGFuICA8cHZvbGxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW21h Y09TXSBFbmZvcmNlIG1lc3NhZ2UgZmlsdGVyaW5nIGluIHRoZSBXZWJDb250ZW50IHByb2Nlc3MK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtVXNlLmggYi9Tb3VyY2UvV1RGL3d0 Zi9QbGF0Zm9ybVVzZS5oCmluZGV4IGZjZTllZGExMzNjOWJiMzE2NzBlMzJlOWRmM2EwN2E0YTJk YzM4Y2QuLmE3YWUyODk1ZTYzNjdmNmIwMzkwMzAzMDliYjFjY2Y3ZjYyMGMxOTEgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtVXNlLmgKKysrIGIvU291cmNlL1dURi93dGYvUGxh dGZvcm1Vc2UuaApAQCAtMzA5LDYgKzMwOSwxMCBAQAogI2RlZmluZSBVU0VfQ1RGT05UR0VUQURW QU5DRVNfV09SS0FST1VORCAxCiAjZW5kaWYKIAorI2lmIFBMQVRGT1JNKE1BQykgJiYgX19NQUNf T1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA8IDEwMTUwMAorI2RlZmluZSBVU0VfTEVHQUNZX0NG TkVUV09SS19ET1dOTE9BRFMgMQorI2VuZGlmCisKICNpZiBDUFUoQVJNNjQpICYmIENQVShBRERS RVNTNjQpCiAjZGVmaW5lIFVTRV9KVU1QX0lTTEFORFMgMQogI2VuZGlmCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL0Rvd25sb2Fkcy9jb2NvYS9Eb3dubG9hZENvY29h Lm1tIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9Eb3dubG9hZHMvY29jb2EvRG93bmxv YWRDb2NvYS5tbQppbmRleCAwOGI1NWYwYjJmZGQ5YmY1MmU0MWJmMDE3YWJjNGRjOTQzMDJmMDdi Li45NWY4ZGVjMzAyNTFiODBiYWEyOWNlNTkwODczYTdhYmFlZmRhOWNlIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL0Rvd25sb2Fkcy9jb2NvYS9Eb3dubG9hZENvY29h Lm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvRG93bmxvYWRzL2NvY29hL0Rv d25sb2FkQ29jb2EubW0KQEAgLTUwLDcgKzUwLDcgQEAgdm9pZCBEb3dubG9hZDo6cmVzdW1lKGNv bnN0IElQQzo6RGF0YVJlZmVyZW5jZSYgcmVzdW1lRGF0YSwgY29uc3QgU3RyaW5nJiBwYXRoLAog ICAgIGF1dG8gbnNEYXRhID0gYWRvcHROUyhbW05TRGF0YSBhbGxvY10gaW5pdFdpdGhCeXRlczpy ZXN1bWVEYXRhLmRhdGEoKSBsZW5ndGg6cmVzdW1lRGF0YS5zaXplKCldKTsKIAogICAgIC8vIEZJ WE1FOiBUaGlzIGlzIGEgdGVtcG9yYXJ5IHdvcmthcm91bmQgZm9yIDxyZGFyOi8vcHJvYmxlbS8z NDc0NTE3MT4uIEZpeGVkIGluIGlPUyAxMyBhbmQgbWFjT1MgMTAuMTUsIGJ1dCB3ZSBzdGlsbCBu ZWVkIHRvIHN1cHBvcnQgbWFjT1MgMTAuMTQgZm9yIG5vdy4KLSNpZiBQTEFURk9STShNQUMpICYm IF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPCAxMDE1MDAKKyNpZiBVU0UoTEVHQUNZ X0NGTkVUV09SS19ET1dOTE9BRFMpCiAgICAgc3RhdGljIE5TU2V0PENsYXNzPiAqcGxpc3RDbGFz c2VzID0gbmlsOwogICAgIHN0YXRpYyBkaXNwYXRjaF9vbmNlX3Qgb25jZVRva2VuOwogCg==