218812 2020-11-11 11:02:22 -0800 Font::platformBoundsForGlyph() should provide a boundingRect pointer to CTFontGetBoundingRectsForGlyphs() 2020-11-18 10:59:06 -0800 1 1 1 Unclassified WebKit Text WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 julian_a_gonzalez webkit-unassigned darin koivisto mmaxfield rniwa simon.fraser zalan oldest_to_newest 1706523 0 julian_a_gonzalez 2020-11-11 11:02:22 -0800 Pass a pointer to a stack-allocated boundingRect to CTFontGetBoundingRectsForGlyphs() in Font::platformBoundsForGlyph(). Also take a look at Font::isProbablyOnlyUsedToRenderIcons(), as it has the same issue. <rdar://problem/70738704> 1706535 1 413843 julian_a_gonzalez 2020-11-11 11:30:04 -0800 Created attachment 413843 Patch 1707581 2 ews-feeder 2020-11-15 00:56:45 -0800 Committed r269823: <https://trac.webkit.org/changeset/269823> All reviewed patches have been landed. Closing bug and clearing flags on attachment 413843. 1707665 3 413843 darin 2020-11-15 15:52:39 -0800 Comment on attachment 413843 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=413843&action=review > Source/WebCore/ChangeLog:9 > + Provide a zero CGRect boundingRect pointer in two places where the count argument > + to CTFontGetBoundingRectsForGlyphs() is already 1. The code below provides an *uninitialized* CGRect, not a zero CGRect. Do we need a zero CGRect? 1708683 4 julian_a_gonzalez 2020-11-18 10:59:06 -0800 Good catch, it is just a plain struct. I will add code to zero this. 413843 2020-11-11 11:30:04 -0800 2020-11-15 00:56:46 -0800 Patch bug-218812-20201111113004.patch text/plain 2707 julian_a_gonzalez U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5Mzc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTZmYTQ1ZjFmZTJkYjMz ZDBlZTEwZjRhN2YxOWUwNmNjMDFhZjUwMy4uMmVjNDczZTA2YWQ0ZmM4NjM1MGZmNmJkOTRkYjg1 MmY3ZTRlYTk5YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIwLTExLTExICBKdWxp YW4gR29uemFsZXogIDxqdWxpYW5fYV9nb256YWxlekBhcHBsZS5jb20+CisKKyAgICAgICAgRm9u dDo6cGxhdGZvcm1Cb3VuZHNGb3JHbHlwaCgpIHNob3VsZCBwcm92aWRlIGEgYm91bmRpbmdSZWN0 IHBvaW50ZXIgdG8gQ1RGb250R2V0Qm91bmRpbmdSZWN0c0ZvckdseXBocygpCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTg4MTIKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQcm92aWRlIGEgemVybyBDR1Jl Y3QgYm91bmRpbmdSZWN0IHBvaW50ZXIgaW4gdHdvIHBsYWNlcyB3aGVyZSB0aGUgY291bnQgYXJn dW1lbnQKKyAgICAgICAgdG8gQ1RGb250R2V0Qm91bmRpbmdSZWN0c0ZvckdseXBocygpIGlzIGFs cmVhZHkgMS4KKworICAgICAgICBObyBuZXcgdGVzdHMsIG5vIGJlaGF2aW9yIGNoYW5nZXMuCisK KyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jb3JldGV4dC9Gb250Q29yZVRleHQuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6Rm9udDo6cGxhdGZvcm1Cb3VuZHNGb3JHbHlwaCBjb25zdCk6Cisg ICAgICAgIChXZWJDb3JlOjpGb250Ojppc1Byb2JhYmx5T25seVVzZWRUb1JlbmRlckljb25zIGNv bnN0KToKKwogMjAyMC0xMS0wNCAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNv bT4KIAogICAgICAgICBBIHByb2dyYW1tYXRpYyBzY3JvbGwgc2hvdWxkIHN0b3AgYW55IHJ1YmJl cmJhbmRpbmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nv cmV0ZXh0L0ZvbnRDb3JlVGV4dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9jb3JldGV4dC9Gb250Q29yZVRleHQuY3BwCmluZGV4IDMzZWQ1YjljYWM3ZTc3ZTVmZDhjOTEx OTVlNDc3ZGFiMmJhYmE3ZmUuLjU5NDNhNjFhYzZhMDE4MGU2YzdiNGIwMTFhYzFiOThhNDE1ZjNm MTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NvcmV0ZXh0 L0ZvbnRDb3JlVGV4dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Y29yZXRleHQvRm9udENvcmVUZXh0LmNwcApAQCAtNjk5LDcgKzY5OSw4IEBAIHZvaWQgRm9udDo6 ZGV0ZXJtaW5lUGl0Y2goKQogRmxvYXRSZWN0IEZvbnQ6OnBsYXRmb3JtQm91bmRzRm9yR2x5cGgo R2x5cGggZ2x5cGgpIGNvbnN0CiB7CiAgICAgRmxvYXRSZWN0IGJvdW5kaW5nQm94OwotICAgIGJv dW5kaW5nQm94ID0gQ1RGb250R2V0Qm91bmRpbmdSZWN0c0ZvckdseXBocyhtX3BsYXRmb3JtRGF0 YS5jdEZvbnQoKSwgcGxhdGZvcm1EYXRhKCkub3JpZW50YXRpb24oKSA9PSBGb250T3JpZW50YXRp b246OlZlcnRpY2FsID8ga0NURm9udE9yaWVudGF0aW9uVmVydGljYWwgOiBrQ1RGb250T3JpZW50 YXRpb25Ib3Jpem9udGFsLCAmZ2x5cGgsIDAsIDEpOworICAgIENHUmVjdCBlbXB0eVJlY3Q7Cisg ICAgYm91bmRpbmdCb3ggPSBDVEZvbnRHZXRCb3VuZGluZ1JlY3RzRm9yR2x5cGhzKG1fcGxhdGZv cm1EYXRhLmN0Rm9udCgpLCBwbGF0Zm9ybURhdGEoKS5vcmllbnRhdGlvbigpID09IEZvbnRPcmll bnRhdGlvbjo6VmVydGljYWwgPyBrQ1RGb250T3JpZW50YXRpb25WZXJ0aWNhbCA6IGtDVEZvbnRP cmllbnRhdGlvbkhvcml6b250YWwsICZnbHlwaCwgJmVtcHR5UmVjdCwgMSk7CiAgICAgYm91bmRp bmdCb3guc2V0WSgtYm91bmRpbmdCb3gubWF4WSgpKTsKICAgICBpZiAobV9zeW50aGV0aWNCb2xk T2Zmc2V0KQogICAgICAgICBib3VuZGluZ0JveC5zZXRXaWR0aChib3VuZGluZ0JveC53aWR0aCgp ICsgbV9zeW50aGV0aWNCb2xkT2Zmc2V0KTsKQEAgLTc0Myw3ICs3NDQsOCBAQCBib29sIEZvbnQ6 OmlzUHJvYmFibHlPbmx5VXNlZFRvUmVuZGVySWNvbnMoKSBjb25zdAogICAgIFVuaUNoYXIgbG93 ZXJjYXNlQUNoYXJhY3RlciA9ICdhJzsKICAgICBDR0dseXBoIGxvd2VyY2FzZUFHbHlwaDsKICAg ICBpZiAoQ1RGb250R2V0R2x5cGhzRm9yQ2hhcmFjdGVycyhwbGF0Zm9ybUZvbnQsICZsb3dlcmNh c2VBQ2hhcmFjdGVyLCAmbG93ZXJjYXNlQUdseXBoLCAxKSkgewotICAgICAgICBpZiAoIUNHUmVj dElzRW1wdHkoQ1RGb250R2V0Qm91bmRpbmdSZWN0c0ZvckdseXBocyhwbGF0Zm9ybUZvbnQsIGtD VEZvbnRPcmllbnRhdGlvbkRlZmF1bHQsICZsb3dlcmNhc2VBR2x5cGgsIG51bGxwdHIsIDEpKSkK KyAgICAgICAgQ0dSZWN0IGVtcHR5UmVjdDsKKyAgICAgICAgaWYgKCFDR1JlY3RJc0VtcHR5KENU Rm9udEdldEJvdW5kaW5nUmVjdHNGb3JHbHlwaHMocGxhdGZvcm1Gb250LCBrQ1RGb250T3JpZW50 YXRpb25EZWZhdWx0LCAmbG93ZXJjYXNlQUdseXBoLCAmZW1wdHlSZWN0LCAxKSkpCiAgICAgICAg ICAgICByZXR1cm4gZmFsc2U7CiAgICAgfQogCg==