218810 2020-11-11 10:20:36 -0800 Use _CFURLConnectionSetFrameworkStubs instead of DYLD_INTERPOSE on Intel Macs 2020-11-12 11:14:28 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen ggaren webkit-bug-importer oldest_to_newest 1706509 0 achristensen 2020-11-11 10:20:36 -0800 Use _CFURLConnectionSetFrameworkStubs instead of DYLD_INTERPOSE on Intel Macs 1706510 1 413837 achristensen 2020-11-11 10:24:54 -0800 Created attachment 413837 Patch 1706546 2 413837 ggaren 2020-11-11 11:50:23 -0800 Comment on attachment 413837 Patch r=me 1706562 3 ews-feeder 2020-11-11 12:15:29 -0800 Committed r269697: <https://trac.webkit.org/changeset/269697> All reviewed patches have been landed. Closing bug and clearing flags on attachment 413837. 1706564 4 webkit-bug-importer 2020-11-11 12:16:24 -0800 <rdar://problem/71293705> 1706672 5 ap 2020-11-11 16:43:55 -0800 And if this breaks something, it's good to have identical behavior between Intel and Apple Silicon. I think that initially, we couldn't use CFNetworks shims on macOS because of in-process CoreMedia resource loading, but that should not be a problem any more. But isn't there a lot more icky code that can be removed now? 1706906 6 achristensen 2020-11-12 09:57:57 -0800 There is, but I chose to keep it to make it easier to revert if needed. Now that I think about it, we should just remove it and revert that too if needed. 1706938 7 achristensen 2020-11-12 11:14:28 -0800 https://bugs.webkit.org/show_bug.cgi?id=218862 413837 2020-11-11 10:24:54 -0800 2020-11-11 12:15:30 -0800 Patch bug-218810-20201111102453.patch text/plain 2719 achristensen U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5NTg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDc0ZTRhNzNlMTQxNjVmYTk1 MmI3YzAzNDZkYTYyNjdmYmYwNzZhYmIuLjA3YTkyMzdkZWU5ZTU4ZDkyZDA2NTc2ZGE5NzcxYTc0 OWMyZjhiNmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMjAtMTEtMTEgIEFsZXggQ2hy aXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBVc2UgX0NGVVJM Q29ubmVjdGlvblNldEZyYW1ld29ya1N0dWJzIGluc3RlYWQgb2YgRFlMRF9JTlRFUlBPU0Ugb24g SW50ZWwgTWFjcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjE4ODEwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgQSBsb25nLCBsb25nIHRpbWUgYWdvLCB3ZSByZWFsaXplZCB0aGF0IENGTmV0d29yayB3YXMg bG9va2luZyBpbiB0aGUga2V5Y2hhaW4gZm9yIHBlcnNpc3RlbnQgY3JlZGVudGlhbHMsCisgICAg ICAgIGFuZCBpbiBvcmRlciB0byBtYWtlIHRoZSBuZXR3b3JrIHByb2Nlc3MgZ2V0IGNyZWRlbnRp YWxzIGFzIHRoZSBVSSBwcm9jZXNzLCB3ZSBpbnRyb2R1Y2VkIFNlY0l0ZW1TaGltIHdoaWNoCisg ICAgICAgIHVzZWQgRFlMRF9JTlRFUlBPU0UgdG8gaW50ZXJjZXB0IHRoZSBjYWxscyB0byB0aGUg c2VjdXJpdHkgZnJhbWV3b3JrIGFuZCBzeW5jaHJvbm91c2x5IG1lc3NhZ2UgdGhlIFVJIHByb2Nl c3MKKyAgICAgICAgZm9yIHRob3NlIGNhbGxzLiAgT3ZlciB0aGUgbGFzdCA2IHllYXJzIHdlIGhh dmUgcmVhbGl6ZWQgdGhhdCBkb2Vzbid0IHdvcmsgb24gaU9TIG9yIEFwcGxlIHNpbGljb24gTWFj cywgc28KKyAgICAgICAgd2UgdXNlIF9DRlVSTENvbm5lY3Rpb25TZXRGcmFtZXdvcmtTdHVicyBp bnN0ZWFkLiAgVGhhdCB3b3JrcyBvbiBJbnRlbCBNYWNzLCB0b28sIGFuZCBJJ20gcmVhc29uYWJs eSBjZXJ0YWluCisgICAgICAgIHRoYXQgdXNpbmcgaXQgZXZlcnl3aGVyZSB3b24ndCBicmVhayBh bnl0aGluZywgc28gYXMgYSBzdGVwIHRvd2FyZHMgcmRhcjovL3Byb2JsZW0vMTU1ODgxNzQgd2hp Y2ggc2hvdWxkIGFsbG93CisgICAgICAgIHVzIHRvIHVzZSBhc3luY2hyb25vdXMgbWVzc2FnZXMg YW5kIG5vIG1vcmUgZ2xvYmFsTmV0d29ya1Byb2Nlc3MgcG9pbnRlciwgbGV0J3Mgc3RvcCB1c2lu ZyBEWUxEX0lOVEVSUE9TRS4KKworICAgICAgICAqIFNoYXJlZC9tYWMvU2VjSXRlbVNoaW0uY3Bw OgorICAgICAgICAoV2ViS2l0Ojppbml0aWFsaXplU2VjSXRlbVNoaW0pOgorCiAyMDIwLTExLTA5 ICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBbbWFjT1Nd IFNldCBwcmVmZXJlbmNlIGZvciBvdmVycmlkZGVuIGxhbmd1YWdlcyBpbiB0aGUgV2ViQ29udGVu dCBwcm9jZXNzIGFmdGVyIGVudGVyaW5nIHRoZSBzYW5kYm94LgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9TaGFyZWQvbWFjL1NlY0l0ZW1TaGltLmNwcCBiL1NvdXJjZS9XZWJLaXQvU2hhcmVk L21hYy9TZWNJdGVtU2hpbS5jcHAKaW5kZXggMTM0ZmFkZjJlYTJkYmJjMjA5M2E2ZjAyNTkzY2U3 ZTQzYjE0NzhkZC4uYzM5NTEwMzI0ODgyZTBkOGExMmRkZTE3Mjc3NjBhZmNmNDMxOWQ2YyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9TaGFyZWQvbWFjL1NlY0l0ZW1TaGltLmNwcAorKysgYi9T b3VyY2UvV2ViS2l0L1NoYXJlZC9tYWMvU2VjSXRlbVNoaW0uY3BwCkBAIC0xNDMsNyArMTQzLDYg QEAgdm9pZCBpbml0aWFsaXplU2VjSXRlbVNoaW0oTmV0d29ya1Byb2Nlc3MmIHByb2Nlc3MpCiB7 CiAgICAgZ2xvYmFsTmV0d29ya1Byb2Nlc3MoKSA9IG1ha2VXZWFrUHRyKHByb2Nlc3MpOwogCi0j aWYgUExBVEZPUk0oSU9TX0ZBTUlMWSkgfHwgKFBMQVRGT1JNKE1BQykgJiYgIUNQVShYODZfNjQp KQogICAgIHN0cnVjdCBfQ0ZORnJhbWV3b3Jrc1N0dWJzIHN0dWJzID0gewogICAgICAgICAudmVy c2lvbiA9IDAsCiAgICAgICAgIC5TZWNJdGVtX3N0dWJfQ29weU1hdGNoaW5nID0gd2ViU2VjSXRl bUNvcHlNYXRjaGluZywKQEAgLTE1MywxOSArMTUyLDYgQEAgdm9pZCBpbml0aWFsaXplU2VjSXRl bVNoaW0oTmV0d29ya1Byb2Nlc3MmIHByb2Nlc3MpCiAgICAgfTsKIAogICAgIF9DRlVSTENvbm5l Y3Rpb25TZXRGcmFtZXdvcmtTdHVicygmc3R1YnMpOwotI2VuZGlmCi0KLSNpZiBQTEFURk9STShN QUMpICYmIENQVShYODZfNjQpCi0gICAgY29uc3QgU2VjSXRlbVNoaW1DYWxsYmFja3MgY2FsbGJh Y2tzID0gewotICAgICAgICB3ZWJTZWNJdGVtQ29weU1hdGNoaW5nLAotICAgICAgICB3ZWJTZWNJ dGVtQWRkLAotICAgICAgICB3ZWJTZWNJdGVtVXBkYXRlLAotICAgICAgICB3ZWJTZWNJdGVtRGVs ZXRlCi0gICAgfTsKLSAgICAKLSAgICBTZWNJdGVtU2hpbUluaXRpYWxpemVGdW5jIGZ1bmMgPSBy ZWludGVycHJldF9jYXN0PFNlY0l0ZW1TaGltSW5pdGlhbGl6ZUZ1bmM+KGRsc3ltKFJUTERfREVG QVVMVCwgIldlYktpdFNlY0l0ZW1TaGltSW5pdGlhbGl6ZSIpKTsKLSAgICBmdW5jKGNhbGxiYWNr cyk7Ci0jZW5kaWYKIH0KIAogfSAvLyBuYW1lc3BhY2UgV2ViS2l0Cg==