218807 2020-11-11 09:15:40 -0800 REGRESSION (r269657): ASSERTION FAILED: Completion handler should always be called under WebKit::GPUProcessProxy::~GPUProcessProxy 2020-11-11 10:44:12 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=218769 InRadar P2 Normal --- 1 ryanhaddad cdumez cdumez darin eric.carlson ggaren jer.noble sam thorton webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1706478 0 ryanhaddad 2020-11-11 09:15:40 -0800 Seeing the following assertion failure on iOS Debug bots with various layout tests, as well as TestWebKitAPI.GPUProcess.RelaunchOnCrash ASSERTION FAILED: Completion handler should always be called !m_function /Volumes/Data/slave/ios-simulator-14-debug/build/WebKitBuild/Debug-iphonesimulator/usr/local/include/wtf/CompletionHandler.h(58) : WTF::CompletionHandler<void ()>::~CompletionHandler() 1 0x10765e3e9 WTFCrash 2 0x10f18a627 WTF::CompletionHandler<void ()>::~CompletionHandler() 3 0x10f187bd5 WTF::CompletionHandler<void ()>::~CompletionHandler() 4 0x10fff553f WebKit::ProcessThrottler::sendPrepareToSuspendIPC(WebKit::IsSuspensionImminent) 5 0x10fff41d9 WebKit::ProcessThrottler::updateAssertionIfNeeded() 6 0x10fff4332 WebKit::ProcessThrottler::removeActivity(WebKit::ProcessThrottler::Activity<(WebKit::ProcessThrottler::ActivityType)1>&) 7 0x10fe3f7e8 WebKit::ProcessThrottler::Activity<(WebKit::ProcessThrottler::ActivityType)1>::invalidate() 8 0x10fe3f652 WebKit::ProcessThrottler::Activity<(WebKit::ProcessThrottler::ActivityType)1>::~Activity() 9 0x10fe3f5f5 WebKit::ProcessThrottler::Activity<(WebKit::ProcessThrottler::ActivityType)1>::~Activity() 10 0x10fe3f5ab std::__1::default_delete<WebKit::ProcessThrottler::Activity<(WebKit::ProcessThrottler::ActivityType)1> >::operator()(WebKit::ProcessThrottler::Activity<(WebKit::ProcessThrottler::ActivityType)1>*) const 11 0x10fe3f52f std::__1::unique_ptr<WebKit::ProcessThrottler::Activity<(WebKit::ProcessThrottler::ActivityType)1>, std::__1::default_delete<WebKit::ProcessThrottler::Activity<(WebKit::ProcessThrottler::ActivityType)1> > >::reset(WebKit::ProcessThrottler::Activity<(WebKit::ProcessThrottler::ActivityType)1>*) 12 0x10fe3f4c9 std::__1::unique_ptr<WebKit::ProcessThrottler::Activity<(WebKit::ProcessThrottler::ActivityType)1>, std::__1::default_delete<WebKit::ProcessThrottler::Activity<(WebKit::ProcessThrottler::ActivityType)1> > >::~unique_ptr() 13 0x10fe3f4a5 std::__1::unique_ptr<WebKit::ProcessThrottler::Activity<(WebKit::ProcessThrottler::ActivityType)1>, std::__1::default_delete<WebKit::ProcessThrottler::Activity<(WebKit::ProcessThrottler::ActivityType)1> > >::~unique_ptr() 14 0x10fe3f485 WTF::UniqueRef<WebKit::ProcessThrottler::Activity<(WebKit::ProcessThrottler::ActivityType)1> >::~UniqueRef() 15 0x10fe3f465 WTF::UniqueRef<WebKit::ProcessThrottler::Activity<(WebKit::ProcessThrottler::ActivityType)1> >::~UniqueRef() 16 0x10fe3f42d WTF::__storage_wrapper<WTF::UniqueRef<WebKit::ProcessThrottler::Activity<(WebKit::ProcessThrottler::ActivityType)1> > >::__destroy() 17 0x10fe3f405 WTF::__variant_storage<WTF::UniqueRef<WebKit::ProcessThrottler::Activity<(WebKit::ProcessThrottler::ActivityType)1> >, false>::__destroy(WTF::__storage_wrapper<WTF::UniqueRef<WebKit::ProcessThrottler::Activity<(WebKit::ProcessThrottler::ActivityType)1> > >&) 18 0x10fe3f3dc WTF::__variant_data<WTF::UniqueRef<WebKit::ProcessThrottler::Activity<(WebKit::ProcessThrottler::ActivityType)1> > >::__destroy(WTF::in_place_tag (&)(WTF::__in_place_private::__value_holder<0ul>&)) 19 0x10fe3f3b3 void WTF::__variant_data<WTF::UniqueRef<WebKit::ProcessThrottler::Activity<(WebKit::ProcessThrottler::ActivityType)0> >, WTF::UniqueRef<WebKit::ProcessThrottler::Activity<(WebKit::ProcessThrottler::ActivityType)1> > >::__destroy<1ul>(WTF::in_place_tag (&)(WTF::__in_place_private::__value_holder<1ul>&)) 20 0x10fe3f383 void WTF::__variant_data<std::nullptr_t, WTF::UniqueRef<WebKit::ProcessThrottler::Activity<(WebKit::ProcessThrottler::ActivityType)0> >, WTF::UniqueRef<WebKit::ProcessThrottler::Activity<(WebKit::ProcessThrottler::ActivityType)1> > >::__destroy<2ul>(WTF::in_place_tag (&)(WTF::__in_place_private::__value_holder<2ul>&)) 21 0x10fe3f09d void WTF::__destroy_op_table<WTF::Variant<std::nullptr_t, WTF::UniqueRef<WebKit::ProcessThrottler::Activity<(WebKit::ProcessThrottler::ActivityType)0> >, WTF::UniqueRef<WebKit::ProcessThrottler::Activity<(WebKit::ProcessThrottler::ActivityType)1> > >, WTF::__index_sequence<0l, 1l, 2l> >::__destroy_func<2l>(WTF::Variant<std::nullptr_t, WTF::UniqueRef<WebKit::ProcessThrottler::Activity<(WebKit::ProcessThrottler::ActivityType)0> >, WTF::UniqueRef<WebKit::ProcessThrottler::Activity<(WebKit::ProcessThrottler::ActivityType)1> > >*) 22 0x10fe3ef95 WTF::Variant<std::nullptr_t, WTF::UniqueRef<WebKit::ProcessThrottler::Activity<(WebKit::ProcessThrottler::ActivityType)0> >, WTF::UniqueRef<WebKit::ProcessThrottler::Activity<(WebKit::ProcessThrottler::ActivityType)1> > >::__destroy_self() 23 0x10fe3ef08 WTF::__variant_base<WTF::Variant<std::nullptr_t, WTF::UniqueRef<WebKit::ProcessThrottler::Activity<(WebKit::ProcessThrottler::ActivityType)0> >, WTF::UniqueRef<WebKit::ProcessThrottler::Activity<(WebKit::ProcessThrottler::ActivityType)1> > >, false>::~__variant_base() 24 0x10fe3f878 WTF::Variant<std::nullptr_t, WTF::UniqueRef<WebKit::ProcessThrottler::Activity<(WebKit::ProcessThrottler::ActivityType)0> >, WTF::UniqueRef<WebKit::ProcessThrottler::Activity<(WebKit::ProcessThrottler::ActivityType)1> > >::~Variant() 25 0x10fe340f5 WTF::Variant<std::nullptr_t, WTF::UniqueRef<WebKit::ProcessThrottler::Activity<(WebKit::ProcessThrottler::ActivityType)0> >, WTF::UniqueRef<WebKit::ProcessThrottler::Activity<(WebKit::ProcessThrottler::ActivityType)1> > >::~Variant() 26 0x1104431c5 WebKit::GPUProcessProxy::~GPUProcessProxy() 27 0x110443295 WebKit::GPUProcessProxy::~GPUProcessProxy() 28 0x110255b1b std::__1::default_delete<WebKit::GPUProcessProxy>::operator()(WebKit::GPUProcessProxy*) const 29 0x110255ae2 WTF::RefCounted<WebKit::GPUProcessProxy, std::__1::default_delete<WebKit::GPUProcessProxy> >::deref() const 30 0x110255a67 WTF::DefaultRefDerefTraits<WebKit::GPUProcessProxy>::derefIfNotNull(WebKit::GPUProcessProxy*) 31 0x110255a29 WTF::RefPtr<WebKit::GPUProcessProxy, WTF::RawPtrTraits<WebKit::GPUProcessProxy>, WTF::DefaultRefDerefTraits<WebKit::GPUProcessProxy> >::~RefPtr() https://build.webkit.org/results/Apple-iOS-14-Simulator-Debug-WK2-Tests/r269657%20(619)/results.html https://build.webkit.org/builders/Apple-iOS-14-Simulator-Debug-WK2-Tests/builds/628/steps/run-api-tests/logs/stdio 1706479 1 cdumez 2020-11-11 09:16:32 -0800 Will investigate now, thanks. 1706481 2 webkit-bug-importer 2020-11-11 09:17:06 -0800 <rdar://problem/71285627> 1706482 3 cdumez 2020-11-11 09:18:58 -0800 In GPUProcessProxy: // ProcessThrottlerClient void sendPrepareToSuspend(IsSuspensionImminent, CompletionHandler<void()>&&) final { } The dummy implementation fails to call the CompletionHandler.. 1706483 4 cdumez 2020-11-11 09:19:58 -0800 Will have a fix shortly. 1706486 5 413828 cdumez 2020-11-11 09:26:45 -0800 Created attachment 413828 Patch 1706491 6 413830 cdumez 2020-11-11 09:34:13 -0800 Created attachment 413830 Patch 1706500 7 413830 ggaren 2020-11-11 09:46:01 -0800 Comment on attachment 413830 Patch r=me 1706517 8 ews-feeder 2020-11-11 10:44:11 -0800 Committed r269690: <https://trac.webkit.org/changeset/269690> All reviewed patches have been landed. Closing bug and clearing flags on attachment 413830. 413828 2020-11-11 09:26:45 -0800 2020-11-11 09:34:13 -0800 Patch bug-218807-20201111092644.patch text/plain 3930 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5NjU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDZlODNlNjY3MTQxMmE5MTA4 Y2Y5M2U5MjIxM2IzMzIzYzVhNDM3NjIuLmZhMWVhNzgwZDM3ZDA3YmQwZTEwMTZjZDA3MzIyMDg1 NWNlNjdkNDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMjAtMTEtMTEgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMjY5NjU3KTog QVNTRVJUSU9OIEZBSUxFRDogQ29tcGxldGlvbiBoYW5kbGVyIHNob3VsZCBhbHdheXMgYmUgY2Fs bGVkIHVuZGVyIFdlYktpdDo6R1BVUHJvY2Vzc1Byb3h5Ojp+R1BVUHJvY2Vzc1Byb3h5CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTg4MDcKKyAgICAg ICAgPHJkYXI6Ly9wcm9ibGVtLzcxMjg1NjI3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEdQVVByb2Nlc3NQcm94eTo6c2VuZFByZXBhcmVUb1N1c3Bl bmQoKSB3YXMgZmFpbGluZyB0byBzZW5kIHRoZSBJUEMgdG8gdGhlIEdQVVByb2Nlc3MgYW5kIHdh cyBhbHNvCisgICAgICAgIGZhaWxpbmcgdG8gY2FsbCBpdHMgY29tcGxldGlvbiBoYW5kbGVyLCB0 aHVzIGFzc2VydGluZyBpbiBEZWJ1Zy4gVXBkYXRlIEdQVVByb2Nlc3NQcm94eSB0byBhY3R1YWxs eQorICAgICAgICBzZW5kIHRoZSBQcmVwYXJlVG9TdXNwZW5kIC8gUHJvY2Vzc0RpZFJlc3VtZSBJ UENzIHRvIHRoZSBHUFVQcm9jZXNzLiBUaGUgR1BVUHJvY2VzcyBhY3R1YWxseSBhbHJlYWR5Cisg ICAgICAgIGhhZCBhbiBpbXBsZW1lbnRhdGlvbiB0byBkZWFsIHdpdGggdGhvc2UgSVBDcy4KKwor ICAgICAgICBObyBuZXcgdGVzdHMsIGNvdmVyZWQgYnkgZXhpc3RpbmcgdGVzdHMgdGhhdCBhcmUg Y3Jhc2hpbmcgaW4gZGVidWcuCisKKyAgICAgICAgKiBHUFVQcm9jZXNzL0dQVVByb2Nlc3MubWVz c2FnZXMuaW46CisgICAgICAgICogVUlQcm9jZXNzL0dQVS9HUFVQcm9jZXNzUHJveHkuY3BwOgor ICAgICAgICAoV2ViS2l0OjpHUFVQcm9jZXNzUHJveHk6OnNlbmRQcmVwYXJlVG9TdXNwZW5kKToK KyAgICAgICAgKFdlYktpdDo6R1BVUHJvY2Vzc1Byb3h5OjpzZW5kUHJvY2Vzc0RpZFJlc3VtZSk6 CisgICAgICAgICogVUlQcm9jZXNzL0dQVS9HUFVQcm9jZXNzUHJveHkuaDoKKwogMjAyMC0xMS0x MSAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFtHUFVQcm9jZXNz XSBTZWFtbGVzc2x5IHJlc3VtZSBXZWJBdWRpbyBwbGF5YmFjayBpZiB0aGUgR1BVIFByb2Nlc3Mg Y3Jhc2hlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9HUFVQcm9jZXNzL0dQVVByb2Nlc3Mu bWVzc2FnZXMuaW4gYi9Tb3VyY2UvV2ViS2l0L0dQVVByb2Nlc3MvR1BVUHJvY2Vzcy5tZXNzYWdl cy5pbgppbmRleCAwNTExNDkzODYzYjczY2ZhNWVhOGQ2ZjExNTdlZmQ2ODBmYTM3NTVmLi43ODY5 NDdjMjhjNDgwNWE4ZWU4YmFmZjhhZjEwYTBiOTU4NzRkMWNiIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0dQVVByb2Nlc3MvR1BVUHJvY2Vzcy5tZXNzYWdlcy5pbgorKysgYi9Tb3VyY2UvV2Vi S2l0L0dQVVByb2Nlc3MvR1BVUHJvY2Vzcy5tZXNzYWdlcy5pbgpAQCAtMzAsNiArMzAsOSBAQCBt ZXNzYWdlcyAtPiBHUFVQcm9jZXNzIHsKICAgICBQcm9jZXNzRGlkVHJhbnNpdGlvblRvRm9yZWdy b3VuZCgpCiAgICAgUHJvY2Vzc0RpZFRyYW5zaXRpb25Ub0JhY2tncm91bmQoKQogCisgICAgUHJl cGFyZVRvU3VzcGVuZChib29sIGlzU3VzcGVuc2lvbkltbWluZW50KSAtPiAoKSBBc3luYworICAg IFByb2Nlc3NEaWRSZXN1bWUoKQorCiAgICAgQWRkU2Vzc2lvbihQQUw6OlNlc3Npb25JRCBzZXNz aW9uSUQsIHN0cnVjdCBXZWJLaXQ6OkdQVVByb2Nlc3NTZXNzaW9uUGFyYW1ldGVycyBwYXJhbWV0 ZXJzKQogICAgIFJlbW92ZVNlc3Npb24oUEFMOjpTZXNzaW9uSUQgc2Vzc2lvbklEKQogCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9HUFUvR1BVUHJvY2Vzc1Byb3h5LmNwcCBi L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0dQVS9HUFVQcm9jZXNzUHJveHkuY3BwCmluZGV4IDJm OTNiMjdlZGVmMzYyMWY2ZjdhMTE4YmU4YmI0ZDhlYTZhNmMzOTEuLjE0ZDE5NTE4ZDdmZDM4NmQ0 MjgzOWYxMWI0NGQ1MDVlZTIzMTg5MmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL0dQVS9HUFVQcm9jZXNzUHJveHkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L0dQVS9HUFVQcm9jZXNzUHJveHkuY3BwCkBAIC0zMjQsNiArMzI0LDE3IEBAIHZvaWQgR1BVUHJv Y2Vzc1Byb3h5OjpyZW1vdmVTZXNzaW9uKFBBTDo6U2Vzc2lvbklEIHNlc3Npb25JRCkKICAgICAg ICAgc2VuZChNZXNzYWdlczo6R1BVUHJvY2Vzczo6UmVtb3ZlU2Vzc2lvbiB7IHNlc3Npb25JRCB9 LCAwKTsKIH0KIAordm9pZCBHUFVQcm9jZXNzUHJveHk6OnNlbmRQcmVwYXJlVG9TdXNwZW5kKElz U3VzcGVuc2lvbkltbWluZW50IGlzU3VzcGVuc2lvbkltbWluZW50LCBDb21wbGV0aW9uSGFuZGxl cjx2b2lkKCk+JiYgY29tcGxldGlvbkhhbmRsZXIpCit7CisgICAgc2VuZFdpdGhBc3luY1JlcGx5 KE1lc3NhZ2VzOjpHUFVQcm9jZXNzOjpQcmVwYXJlVG9TdXNwZW5kKGlzU3VzcGVuc2lvbkltbWlu ZW50ID09IElzU3VzcGVuc2lvbkltbWluZW50OjpZZXMpLCBXVEZNb3ZlKGNvbXBsZXRpb25IYW5k bGVyKSwgMCwgeyB9LCBTaG91bGRTdGFydFByb2Nlc3NUaHJvdHRsZXJBY3Rpdml0eTo6Tm8pOwor fQorCit2b2lkIEdQVVByb2Nlc3NQcm94eTo6c2VuZFByb2Nlc3NEaWRSZXN1bWUoKQoreworICAg IGlmIChjYW5TZW5kTWVzc2FnZSgpKQorICAgICAgICBzZW5kKE1lc3NhZ2VzOjpHUFVQcm9jZXNz OjpQcm9jZXNzRGlkUmVzdW1lKCksIDApOworfQorCiAjaWYgSEFWRShWSVNJQklMSVRZX1BST1BB R0FUSU9OX1ZJRVcpCiB2b2lkIEdQVVByb2Nlc3NQcm94eTo6ZGlkQ3JlYXRlQ29udGV4dEZvclZp c2liaWxpdHlQcm9wYWdhdGlvbihMYXllckhvc3RpbmdDb250ZXh0SUQgY29udGV4dElEKQogewpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvR1BVL0dQVVByb2Nlc3NQcm94eS5o IGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvR1BVL0dQVVByb2Nlc3NQcm94eS5oCmluZGV4IDQ1 NWMwMDJkMjFjZmFiOTZlZGYyNmI2YzdmN2QxOTI1ZDM5ZTE2M2IuLmVjMTExZjI4MmQ5N2Q0NDRk M2ExNTRkN2ExYzFjMTMyNTI2N2U3ZjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL0dQVS9HUFVQcm9jZXNzUHJveHkuaAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9H UFUvR1BVUHJvY2Vzc1Byb3h5LmgKQEAgLTkyLDcgKzkyLDggQEAgcHJpdmF0ZToKICAgICB2b2lk IGdwdVByb2Nlc3NDcmFzaGVkKCk7CiAKICAgICAvLyBQcm9jZXNzVGhyb3R0bGVyQ2xpZW50Ci0g ICAgdm9pZCBzZW5kUHJlcGFyZVRvU3VzcGVuZChJc1N1c3BlbnNpb25JbW1pbmVudCwgQ29tcGxl dGlvbkhhbmRsZXI8dm9pZCgpPiYmKSBmaW5hbCB7IH0KKyAgICB2b2lkIHNlbmRQcmVwYXJlVG9T dXNwZW5kKElzU3VzcGVuc2lvbkltbWluZW50LCBDb21wbGV0aW9uSGFuZGxlcjx2b2lkKCk+JiYp IGZpbmFsOworICAgIHZvaWQgc2VuZFByb2Nlc3NEaWRSZXN1bWUoKSBmaW5hbDsKIAogICAgIC8v IFByb2Nlc3NMYXVuY2hlcjo6Q2xpZW50CiAgICAgdm9pZCBkaWRGaW5pc2hMYXVuY2hpbmcoUHJv Y2Vzc0xhdW5jaGVyKiwgSVBDOjpDb25uZWN0aW9uOjpJZGVudGlmaWVyKSBvdmVycmlkZTsK 413830 2020-11-11 09:34:13 -0800 2020-11-11 10:44:11 -0800 Patch bug-218807-20201111093412.patch text/plain 4407 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5NjU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDZlODNlNjY3MTQxMmE5MTA4 Y2Y5M2U5MjIxM2IzMzIzYzVhNDM3NjIuLmZhMWVhNzgwZDM3ZDA3YmQwZTEwMTZjZDA3MzIyMDg1 NWNlNjdkNDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMjAtMTEtMTEgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMjY5NjU3KTog QVNTRVJUSU9OIEZBSUxFRDogQ29tcGxldGlvbiBoYW5kbGVyIHNob3VsZCBhbHdheXMgYmUgY2Fs bGVkIHVuZGVyIFdlYktpdDo6R1BVUHJvY2Vzc1Byb3h5Ojp+R1BVUHJvY2Vzc1Byb3h5CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTg4MDcKKyAgICAg ICAgPHJkYXI6Ly9wcm9ibGVtLzcxMjg1NjI3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEdQVVByb2Nlc3NQcm94eTo6c2VuZFByZXBhcmVUb1N1c3Bl bmQoKSB3YXMgZmFpbGluZyB0byBzZW5kIHRoZSBJUEMgdG8gdGhlIEdQVVByb2Nlc3MgYW5kIHdh cyBhbHNvCisgICAgICAgIGZhaWxpbmcgdG8gY2FsbCBpdHMgY29tcGxldGlvbiBoYW5kbGVyLCB0 aHVzIGFzc2VydGluZyBpbiBEZWJ1Zy4gVXBkYXRlIEdQVVByb2Nlc3NQcm94eSB0byBhY3R1YWxs eQorICAgICAgICBzZW5kIHRoZSBQcmVwYXJlVG9TdXNwZW5kIC8gUHJvY2Vzc0RpZFJlc3VtZSBJ UENzIHRvIHRoZSBHUFVQcm9jZXNzLiBUaGUgR1BVUHJvY2VzcyBhY3R1YWxseSBhbHJlYWR5Cisg ICAgICAgIGhhZCBhbiBpbXBsZW1lbnRhdGlvbiB0byBkZWFsIHdpdGggdGhvc2UgSVBDcy4KKwor ICAgICAgICBObyBuZXcgdGVzdHMsIGNvdmVyZWQgYnkgZXhpc3RpbmcgdGVzdHMgdGhhdCBhcmUg Y3Jhc2hpbmcgaW4gZGVidWcuCisKKyAgICAgICAgKiBHUFVQcm9jZXNzL0dQVVByb2Nlc3MubWVz c2FnZXMuaW46CisgICAgICAgICogVUlQcm9jZXNzL0dQVS9HUFVQcm9jZXNzUHJveHkuY3BwOgor ICAgICAgICAoV2ViS2l0OjpHUFVQcm9jZXNzUHJveHk6OnNlbmRQcmVwYXJlVG9TdXNwZW5kKToK KyAgICAgICAgKFdlYktpdDo6R1BVUHJvY2Vzc1Byb3h5OjpzZW5kUHJvY2Vzc0RpZFJlc3VtZSk6 CisgICAgICAgICogVUlQcm9jZXNzL0dQVS9HUFVQcm9jZXNzUHJveHkuaDoKKwogMjAyMC0xMS0x MSAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFtHUFVQcm9jZXNz XSBTZWFtbGVzc2x5IHJlc3VtZSBXZWJBdWRpbyBwbGF5YmFjayBpZiB0aGUgR1BVIFByb2Nlc3Mg Y3Jhc2hlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9HUFVQcm9jZXNzL0dQVVByb2Nlc3Mu bWVzc2FnZXMuaW4gYi9Tb3VyY2UvV2ViS2l0L0dQVVByb2Nlc3MvR1BVUHJvY2Vzcy5tZXNzYWdl cy5pbgppbmRleCAwNTExNDkzODYzYjczY2ZhNWVhOGQ2ZjExNTdlZmQ2ODBmYTM3NTVmLi43ODY5 NDdjMjhjNDgwNWE4ZWU4YmFmZjhhZjEwYTBiOTU4NzRkMWNiIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0dQVVByb2Nlc3MvR1BVUHJvY2Vzcy5tZXNzYWdlcy5pbgorKysgYi9Tb3VyY2UvV2Vi S2l0L0dQVVByb2Nlc3MvR1BVUHJvY2Vzcy5tZXNzYWdlcy5pbgpAQCAtMzAsNiArMzAsOSBAQCBt ZXNzYWdlcyAtPiBHUFVQcm9jZXNzIHsKICAgICBQcm9jZXNzRGlkVHJhbnNpdGlvblRvRm9yZWdy b3VuZCgpCiAgICAgUHJvY2Vzc0RpZFRyYW5zaXRpb25Ub0JhY2tncm91bmQoKQogCisgICAgUHJl cGFyZVRvU3VzcGVuZChib29sIGlzU3VzcGVuc2lvbkltbWluZW50KSAtPiAoKSBBc3luYworICAg IFByb2Nlc3NEaWRSZXN1bWUoKQorCiAgICAgQWRkU2Vzc2lvbihQQUw6OlNlc3Npb25JRCBzZXNz aW9uSUQsIHN0cnVjdCBXZWJLaXQ6OkdQVVByb2Nlc3NTZXNzaW9uUGFyYW1ldGVycyBwYXJhbWV0 ZXJzKQogICAgIFJlbW92ZVNlc3Npb24oUEFMOjpTZXNzaW9uSUQgc2Vzc2lvbklEKQogCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9HUFUvR1BVUHJvY2Vzc1Byb3h5LmNwcCBi L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0dQVS9HUFVQcm9jZXNzUHJveHkuY3BwCmluZGV4IDJm OTNiMjdlZGVmMzYyMWY2ZjdhMTE4YmU4YmI0ZDhlYTZhNmMzOTEuLjE0ZDE5NTE4ZDdmZDM4NmQ0 MjgzOWYxMWI0NGQ1MDVlZTIzMTg5MmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL0dQVS9HUFVQcm9jZXNzUHJveHkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L0dQVS9HUFVQcm9jZXNzUHJveHkuY3BwCkBAIC0zMjQsNiArMzI0LDE3IEBAIHZvaWQgR1BVUHJv Y2Vzc1Byb3h5OjpyZW1vdmVTZXNzaW9uKFBBTDo6U2Vzc2lvbklEIHNlc3Npb25JRCkKICAgICAg ICAgc2VuZChNZXNzYWdlczo6R1BVUHJvY2Vzczo6UmVtb3ZlU2Vzc2lvbiB7IHNlc3Npb25JRCB9 LCAwKTsKIH0KIAordm9pZCBHUFVQcm9jZXNzUHJveHk6OnNlbmRQcmVwYXJlVG9TdXNwZW5kKElz U3VzcGVuc2lvbkltbWluZW50IGlzU3VzcGVuc2lvbkltbWluZW50LCBDb21wbGV0aW9uSGFuZGxl cjx2b2lkKCk+JiYgY29tcGxldGlvbkhhbmRsZXIpCit7CisgICAgc2VuZFdpdGhBc3luY1JlcGx5 KE1lc3NhZ2VzOjpHUFVQcm9jZXNzOjpQcmVwYXJlVG9TdXNwZW5kKGlzU3VzcGVuc2lvbkltbWlu ZW50ID09IElzU3VzcGVuc2lvbkltbWluZW50OjpZZXMpLCBXVEZNb3ZlKGNvbXBsZXRpb25IYW5k bGVyKSwgMCwgeyB9LCBTaG91bGRTdGFydFByb2Nlc3NUaHJvdHRsZXJBY3Rpdml0eTo6Tm8pOwor fQorCit2b2lkIEdQVVByb2Nlc3NQcm94eTo6c2VuZFByb2Nlc3NEaWRSZXN1bWUoKQoreworICAg IGlmIChjYW5TZW5kTWVzc2FnZSgpKQorICAgICAgICBzZW5kKE1lc3NhZ2VzOjpHUFVQcm9jZXNz OjpQcm9jZXNzRGlkUmVzdW1lKCksIDApOworfQorCiAjaWYgSEFWRShWSVNJQklMSVRZX1BST1BB R0FUSU9OX1ZJRVcpCiB2b2lkIEdQVVByb2Nlc3NQcm94eTo6ZGlkQ3JlYXRlQ29udGV4dEZvclZp c2liaWxpdHlQcm9wYWdhdGlvbihMYXllckhvc3RpbmdDb250ZXh0SUQgY29udGV4dElEKQogewpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvR1BVL0dQVVByb2Nlc3NQcm94eS5o IGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvR1BVL0dQVVByb2Nlc3NQcm94eS5oCmluZGV4IDQ1 NWMwMDJkMjFjZmFiOTZlZGYyNmI2YzdmN2QxOTI1ZDM5ZTE2M2IuLjFjMGE0ZTMwZmMwMTA5ZDAw MWI5MTg0ODk2NThmOTYzZmJlOWJlYzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL0dQVS9HUFVQcm9jZXNzUHJveHkuaAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9H UFUvR1BVUHJvY2Vzc1Byb3h5LmgKQEAgLTYxLDEwICs2MSw2IEBAIHB1YmxpYzoKICAgICBQcm9j ZXNzVGhyb3R0bGVyJiB0aHJvdHRsZXIoKSBmaW5hbCB7IHJldHVybiBtX3Rocm90dGxlcjsgfQog ICAgIHZvaWQgdXBkYXRlUHJvY2Vzc0Fzc2VydGlvbigpOwogCi0gICAgLy8gUHJvY2Vzc1Rocm90 dGxlckNsaWVudAotICAgIHZvaWQgc2VuZFByb2Nlc3NEaWRSZXN1bWUoKSBmaW5hbCB7IH0KLSAg ICBBU0NJSUxpdGVyYWwgY2xpZW50TmFtZSgpIGNvbnN0IGZpbmFsIHsgcmV0dXJuICJHUFVQcm9j ZXNzIl9zOyB9Ci0KICNpZiBFTkFCTEUoTUVESUFfU1RSRUFNKQogICAgIHZvaWQgc2V0VXNlTW9j a0NhcHR1cmVEZXZpY2VzKGJvb2wpOwogICAgIHZvaWQgc2V0T3JpZW50YXRpb25Gb3JNZWRpYUNh cHR1cmUodWludDY0X3Qgb3JpZW50YXRpb24pOwpAQCAtOTIsNyArODgsOSBAQCBwcml2YXRlOgog ICAgIHZvaWQgZ3B1UHJvY2Vzc0NyYXNoZWQoKTsKIAogICAgIC8vIFByb2Nlc3NUaHJvdHRsZXJD bGllbnQKLSAgICB2b2lkIHNlbmRQcmVwYXJlVG9TdXNwZW5kKElzU3VzcGVuc2lvbkltbWluZW50 LCBDb21wbGV0aW9uSGFuZGxlcjx2b2lkKCk+JiYpIGZpbmFsIHsgfQorICAgIEFTQ0lJTGl0ZXJh bCBjbGllbnROYW1lKCkgY29uc3QgZmluYWwgeyByZXR1cm4gIkdQVVByb2Nlc3MiX3M7IH0KKyAg ICB2b2lkIHNlbmRQcmVwYXJlVG9TdXNwZW5kKElzU3VzcGVuc2lvbkltbWluZW50LCBDb21wbGV0 aW9uSGFuZGxlcjx2b2lkKCk+JiYpIGZpbmFsOworICAgIHZvaWQgc2VuZFByb2Nlc3NEaWRSZXN1 bWUoKSBmaW5hbDsKIAogICAgIC8vIFByb2Nlc3NMYXVuY2hlcjo6Q2xpZW50CiAgICAgdm9pZCBk aWRGaW5pc2hMYXVuY2hpbmcoUHJvY2Vzc0xhdW5jaGVyKiwgSVBDOjpDb25uZWN0aW9uOjpJZGVu dGlmaWVyKSBvdmVycmlkZTsK