218781 2020-11-10 19:18:53 -0800 [JSC] wasm fault trampoline should be C code since it is tagged as CFunctionPtr 2020-11-11 11:52:17 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki ews-watchlist keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1706314 0 ysuzuki 2020-11-10 19:18:53 -0800 [JSC] wasm fault trampoline should be C code since it is tagged as CFunctionPtr 1706315 1 413762 ysuzuki 2020-11-10 19:20:12 -0800 Created attachment 413762 Patch 1706502 2 413762 mark.lam 2020-11-11 09:58:40 -0800 Comment on attachment 413762 Patch In AirIRGenerator::AirIRGenerator(), for the MemoryMode::Signaling case, it checks if (UNLIKELY(!Thunks::singleton().stub(throwExceptionFromWasmThunkGenerator))). Is that still needed, or is it now obsolete? Ditto for B3IRGenerator::B3IRGenerator(). 1706534 3 ysuzuki 2020-11-11 11:23:39 -0800 (In reply to Mark Lam from comment #2) > Comment on attachment 413762 [details] > Patch > > In AirIRGenerator::AirIRGenerator(), for the MemoryMode::Signaling case, it > checks if > (UNLIKELY(!Thunks::singleton().stub(throwExceptionFromWasmThunkGenerator))). > Is that still needed, or is it now obsolete? > > Ditto for B3IRGenerator::B3IRGenerator(). Right! This is not necessary. Removed. 1706547 4 ysuzuki 2020-11-11 11:51:26 -0800 Committed r269694: <https://trac.webkit.org/changeset/269694> 1706548 5 webkit-bug-importer 2020-11-11 11:52:17 -0800 <rdar://problem/71292659> 413762 2020-11-10 19:20:12 -0800 2020-11-11 09:41:25 -0800 Patch bug-218781-20201110192011.patch text/plain 5470 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5NjY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAy ZDYwN2QxMGE3ZGExY2EyZWRlMGQyMDc1YjJhOTY5ZTgzMWM2MTkxLi5jODc5Y2IyYjczMmFhYmE4 ZGQyM2ZiNmU1OTJmNTI2MmY1MDc3NDY0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAyMC0xMS0xMCAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIHdhc20gZmF1bHQgdHJhbXBvbGluZSBzaG91bGQgYmUgQyBjb2Rl IHNpbmNlIGl0IGlzIHRhZ2dlZCBhcyBDRnVuY3Rpb25QdHIKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxODc4MQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoZW4gcmV0dXJuaW5nIGZyb20gc2lnbmFsIGhh bmRsZXIsIGhhbmRsZXIgcmVxdWlyZXMgdGhhdCBpbnN0cnVjdGlvbiBwb2ludGVyIGlzIENGdW5j dGlvblB0clRhZy1lZC4KKyAgICAgICAgU28gd2Ugc2hvdWxkIHNldCBDIHRyYW1wb2xpbmUgaW5z dGVhZCBvZiBKSVQgdHJhbXBvbGluZSBoZXJlLgorICAgICAgICBUaGlzIHBhdGNoIGltcGxlbWVu dHMgdHJhbXBvbGluZSBpbiBMTEludCBXYXNtIGNvZGUgc28gdGhhdCB3ZSBjYW4gdXNlIENGdW5j dGlvblB0clRhZy4KKworICAgICAgICAqIGJ5dGVjb2RlL0J5dGVjb2RlTGlzdC5yYjoKKyAgICAg ICAgKiBsbGludC9XZWJBc3NlbWJseS5hc206CisgICAgICAgICogd2FzbS9XYXNtRmF1bHRTaWdu YWxIYW5kbGVyLmNwcDoKKyAgICAgICAgKEpTQzo6V2FzbTo6dHJhcEhhbmRsZXIpOgorCiAyMDIw LTExLTEwICBKb2huIFdpbGFuZGVyICA8d2lsYW5kZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFBD TTogQ2hhbmdlIGZyb20gYWQtY2xpY2stYXR0cmlidXRpb24gdG8gcHJpdmF0ZS1jbGljay1tZWFz dXJlbWVudCAoaW4gYWxsIGZvcm1zLCBpbmNsdWRpbmcgLndlbGwta25vd24gVVJMKQpkaWZmIC0t Z2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0J5dGVjb2RlTGlzdC5yYiBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9CeXRlY29kZUxpc3QucmIKaW5kZXggMDU3YjMw NzhjMmI3ZTg2OTM5MzJiOTA1ZjE5NGQzZjc3YjQ2NDE4Yi4uNzQ2M2EzMjFhMTk0NzI2NzkwZDdk NDUyY2MwNDJiODFlMDIxY2VhNiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5 dGVjb2RlL0J5dGVjb2RlTGlzdC5yYgorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNv ZGUvQnl0ZWNvZGVMaXN0LnJiCkBAIC0xNDY3LDYgKzE0NjcsNyBAQAogIyBIZWxwZXJzCiAKIG9w IDp0aHJvd19mcm9tX3Nsb3dfcGF0aF90cmFtcG9saW5lCitvcCA6dGhyb3dfZnJvbV9mYXVsdF9o YW5kbGVyX3RyYW1wb2xpbmUKIAogb3AgOmNhbGxfcmV0dXJuX2xvY2F0aW9uCiBvcCA6Y2FsbF9u b190bHNfcmV0dXJuX2xvY2F0aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv bGxpbnQvV2ViQXNzZW1ibHkuYXNtIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L1dlYkFz c2VtYmx5LmFzbQppbmRleCA5MGE3MzdiNzc1Njc3Mjk2MGE3OWRiNTEyNDc0YWVjNTBmMmI4ZWM0 Li44YmZmYzhhNjk3ZDJlNmU0ZjIwZGU5NjQwNWE1ZjNkMjRmOGExZWJjIDEwMDY0NAotLS0gYS9T b3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvV2ViQXNzZW1ibHkuYXNtCisrKyBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9sbGludC9XZWJBc3NlbWJseS5hc20KQEAgLTIxNCw5ICsyMTQsMTcgQEAg bWFjcm8gcmVzdG9yZUNhbGxlZVNhdmVzVXNlZEJ5V2FzbSgpCiAgICAgZW5kCiBlbmQKIAorbWFj cm8gbG9hZFdhc21JbnN0YW5jZUZyb21UTFNUbyhyZWcpCitpZiAgSEFWRV9GQVNUX1RMUworICAg IHRsc19sb2FkcCBXVEZfV0FTTV9DT05URVhUX0tFWSwgcmVnCitlbHNlCisgICAgY3Jhc2goKQor ZW5kCitlbmQKKwogbWFjcm8gbG9hZFdhc21JbnN0YW5jZUZyb21UTFMoKQogaWYgIEhBVkVfRkFT VF9UTFMKLSAgICB0bHNfbG9hZHAgV1RGX1dBU01fQ09OVEVYVF9LRVksIHdhc21JbnN0YW5jZQor ICAgIGxvYWRXYXNtSW5zdGFuY2VGcm9tVExTVG8od2FzbUluc3RhbmNlKQogZWxzZQogICAgIGNy YXNoKCkKIGVuZApAQCAtNTE5LDYgKzUyNywzMCBAQCBvcCh3YXNtX3Rocm93X2Zyb21fc2xvd19w YXRoX3RyYW1wb2xpbmUsIG1hY3JvICgpCiAgICAgZW5kCiBlbmQpCiAKK29wKHdhc21fdGhyb3df ZnJvbV9mYXVsdF9oYW5kbGVyX3RyYW1wb2xpbmUsIG1hY3JvICgpCisgICAgbW92ZSB3YXNtSW5z dGFuY2UsIGEyCisgICAgYnRxeiBhMSwgLmluc3RhbmNlUmVhZHkgIyBhMSBpcyBub24temVybyBp ZiBGYXN0VExTIGlzIGVuYWJsZWQuCisgICAgbG9hZFdhc21JbnN0YW5jZUZyb21UTFNUbyhhMikK Ky5pbnN0YW5jZVJlYWR5OgorICAgIGxvYWRwIFdhc206Okluc3RhbmNlOjptX3BvaW50ZXJUb1Rv cEVudHJ5RnJhbWVbYTJdLCBhMAorICAgIGxvYWRwIFthMF0sIGEwCisgICAgY29weUNhbGxlZVNh dmVzVG9FbnRyeUZyYW1lQ2FsbGVlU2F2ZXNCdWZmZXIoYTApCisKKyAgICBtb3ZlIGNvbnN0ZXhw ciBXYXNtOjpFeGNlcHRpb25UeXBlOjpPdXRPZkJvdW5kc01lbW9yeUFjY2VzcywgYTMKKyAgICAj IGEyIGlzIFdhc206Okluc3RhbmNlCisgICAgbW92ZSAwLCBhMQorICAgIG1vdmUgY2ZyLCBhMAor ICAgIGNDYWxsNChfc2xvd19wYXRoX3dhc21fdGhyb3dfZXhjZXB0aW9uKQorCisgICAgaWYgQVJN NjRFCisgICAgICAgIG1vdmUgcjAsIGEwCisgICAgICAgIGxlYXAgSlNDQ29uZmlnICsgY29uc3Rl eHByIEpTQzo6b2Zmc2V0T2ZKU0NDb25maWdHYXRlTWFwICsgKGNvbnN0ZXhwciBHYXRlOjpleGNl cHRpb25IYW5kbGVyKSAqIFB0clNpemUsIGExCisgICAgICAgIGptcCBbYTFdLCBOYXRpdmVUb0pJ VEdhdGVQdHJUYWcgIyBFeGNlcHRpb25IYW5kbGVyUHRyVGFnCisgICAgZWxzZQorICAgICAgICBq bXAgcjAsIEV4Y2VwdGlvbkhhbmRsZXJQdHJUYWcKKyAgICBlbmQKK2VuZCkKKwogIyBEaXNhYmxl IHdpZGUgdmVyc2lvbiBvZiBuYXJyb3ctb25seSBvcGNvZGVzCiBub1dpZGUod2FzbV9lbnRlcikK IG5vV2lkZSh3YXNtX3dpZGUxNikKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93 YXNtL1dhc21GYXVsdFNpZ25hbEhhbmRsZXIuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3dh c20vV2FzbUZhdWx0U2lnbmFsSGFuZGxlci5jcHAKaW5kZXggYmU4NjRjYTY1ODhmNDk2NTFhZmFk MWNkNzI2ZDQyMDVkMmYwZjI3Yy4uM2VhMDA4ODkwMWI2YzI3Y2Y2NWIwYjQ3NGRkOGRjOTVjNzgx NTFmZiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3dhc20vV2FzbUZhdWx0U2ln bmFsSGFuZGxlci5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3dhc20vV2FzbUZhdWx0 U2lnbmFsSGFuZGxlci5jcHAKQEAgLTI5LDEwICsyOSwxMiBAQAogI2lmIEVOQUJMRShXRUJBU1NF TUJMWSkKIAogI2luY2x1ZGUgIkV4ZWN1dGFibGVBbGxvY2F0b3IuaCIKKyNpbmNsdWRlICJMTElu dERhdGEuaCIKICNpbmNsdWRlICJNYWNoaW5lQ29udGV4dC5oIgogI2luY2x1ZGUgIldhc21DYWxs ZWUuaCIKICNpbmNsdWRlICJXYXNtQ2FsbGVlUmVnaXN0cnkuaCIKICNpbmNsdWRlICJXYXNtQ2Fw YWJpbGl0aWVzLmgiCisjaW5jbHVkZSAiV2FzbUNvbnRleHRJbmxpbmVzLmgiCiAjaW5jbHVkZSAi V2FzbUV4Y2VwdGlvblR5cGUuaCIKICNpbmNsdWRlICJXYXNtTWVtb3J5LmgiCiAjaW5jbHVkZSAi V2FzbVRodW5rcy5oIgpAQCAtODAsMTMgKzgyLDggQEAgc3RhdGljIFNpZ25hbEFjdGlvbiB0cmFw SGFuZGxlcihTaWduYWwsIFNpZ0luZm8mIHNpZ0luZm8sIFBsYXRmb3JtUmVnaXN0ZXJzJiBjb24K ICAgICAgICAgICAgICAgICBkYXRhTG9nTG5JZihXYXNtRmF1bHRTaWduYWxIYW5kbGVySW50ZXJu YWw6OnZlcmJvc2UsICJmdW5jdGlvbiBzdGFydDogIiwgUmF3UG9pbnRlcihzdGFydCksICIgZW5k OiAiLCBSYXdQb2ludGVyKGVuZCkpOwogICAgICAgICAgICAgICAgIGlmIChzdGFydCA8PSBmYXVs dGluZ0luc3RydWN0aW9uICYmIGZhdWx0aW5nSW5zdHJ1Y3Rpb24gPCBlbmQpIHsKICAgICAgICAg ICAgICAgICAgICAgZGF0YUxvZ0xuSWYoV2FzbUZhdWx0U2lnbmFsSGFuZGxlckludGVybmFsOjp2 ZXJib3NlLCAiZm91bmQgbWF0Y2giKTsKLSAgICAgICAgICAgICAgICAgICAgTWFjcm9Bc3NlbWJs ZXJDb2RlUmVmPEpJVFRodW5rUHRyVGFnPiBleGNlcHRpb25TdHViID0gVGh1bmtzOjpzaW5nbGV0 b24oKS5leGlzdGluZ1N0dWIodGhyb3dFeGNlcHRpb25Gcm9tV2FzbVRodW5rR2VuZXJhdG9yKTsK LSAgICAgICAgICAgICAgICAgICAgLy8gSWYgZm9yIHdoYXRldmVyIHJlYXNvbiB3ZSBkb24ndCBo YXZlIGEgc3R1YiB0aGVuIHdlIHNob3VsZCBqdXN0IHRyZWF0IHRoaXMgbGlrZSBhIHJlZ3VsYXIg Y3Jhc2guCi0gICAgICAgICAgICAgICAgICAgIGlmICghZXhjZXB0aW9uU3R1YikKLSAgICAgICAg ICAgICAgICAgICAgICAgIGJyZWFrOwotICAgICAgICAgICAgICAgICAgICBkYXRhTG9nTG5JZihX YXNtRmF1bHRTaWduYWxIYW5kbGVySW50ZXJuYWw6OnZlcmJvc2UsICJmb3VuZCBzdHViOiAiLCBS YXdQb2ludGVyKGV4Y2VwdGlvblN0dWIuY29kZSgpLmV4ZWN1dGFibGVBZGRyZXNzKCkpKTsKLSAg ICAgICAgICAgICAgICAgICAgTWFjaGluZUNvbnRleHQ6OmFyZ3VtZW50UG9pbnRlcjwxPihjb250 ZXh0KSA9IHJlaW50ZXJwcmV0X2Nhc3Q8dm9pZCo+KEV4Y2VwdGlvblR5cGU6Ok91dE9mQm91bmRz TWVtb3J5QWNjZXNzKTsKLSAgICAgICAgICAgICAgICAgICAgTWFjaGluZUNvbnRleHQ6OnNldElu c3RydWN0aW9uUG9pbnRlcihjb250ZXh0LCBleGNlcHRpb25TdHViLmNvZGUoKS5yZXRhZ2dlZDxD RnVuY3Rpb25QdHJUYWc+KCkpOworICAgICAgICAgICAgICAgICAgICBNYWNoaW5lQ29udGV4dDo6 YXJndW1lbnRQb2ludGVyPDE+KGNvbnRleHQpID0gcmVpbnRlcnByZXRfY2FzdDx2b2lkKj4oc3Rh dGljX2Nhc3Q8dWludHB0cl90PihXYXNtOjpDb250ZXh0Ojp1c2VGYXN0VExTKCkpKTsKKyAgICAg ICAgICAgICAgICAgICAgTWFjaGluZUNvbnRleHQ6OnNldEluc3RydWN0aW9uUG9pbnRlcihjb250 ZXh0LCBMTEludDo6Z2V0Q29kZVB0cjxDRnVuY3Rpb25QdHJUYWc+KHdhc21fdGhyb3dfZnJvbV9m YXVsdF9oYW5kbGVyX3RyYW1wb2xpbmUpKTsKICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIFNp Z25hbEFjdGlvbjo6SGFuZGxlZDsKICAgICAgICAgICAgICAgICB9CiAgICAgICAgICAgICB9Cg==