218777 2020-11-10 15:53:21 -0800 ContentfulPaintChecker should not trigger plugin snapshotting 2020-11-11 09:23:35 -0800 1 1 1 Unclassified WebKit Layout and Rendering Safari Technology Preview Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser noam bfulgham noam simon.fraser webkit-bug-importer zalan oldest_to_newest 1706261 0 simon.fraser 2020-11-10 15:53:21 -0800 This can happen: + 2610 WebCore::Page::updateRendering() (in WebCore) + 1102 [0x1099c501e] + 2610 WebCore::Page::forEachDocument(WTF::Function<void (WebCore::Document&)> const&) const (in WebCore) + 366 [0x1099be51e] + 2610 WebCore::Document::enqueuePaintTimingEntryIfNeeded() (in WebCore) + 208 [0x10938a9e0] + 2610 WebCore::ContentfulPaintChecker::qualifiesForContentfulPaint(WebCore::FrameView&) (in WebCore) + 259 [0x109c46273] + 2610 WebCore::ScrollView::paint(WebCore::GraphicsContext&, WebCore::IntRect const&, WebCore::Widget::SecurityOriginPaintPolicy, WebCore::EventRegionContext*) (in WebCore) + 1039 [0x109a6161f] + 2610 WebCore::FrameView::paintContents(WebCore::GraphicsContext&, WebCore::IntRect const&, WebCore::Widget::SecurityOriginPaintPolicy, WebCore::EventRegionContext*) (in WebCore) + 760 [0x1099a6788] + 2610 WebCore::FrameView::willPaintContents(WebCore::GraphicsContext&, WebCore::IntRect const&, WebCore::FrameView::PaintingState&) (in WebCore) + 447 [0x1099a6baf] + 2610 WebKit::PluginView::notifyWidget(WebCore::WidgetNotification) (in WebKit) + 134 [0x106501f0a] + 2610 WebKit::PDFPlugin::snapshot() (in WebKit) + 297 [0x1069433d7] + 2610 -[PDFLayerController snapshotInContext:] (in PDFKit) + 1753 [0x7fff3ebf963b] + 2610 -[PDFPage drawWithBox:toContext:] (in PDFKit) + 141 [0x7fff3ec34edd] Plugin snapshotting here is just a waste of cycles. 1706263 1 simon.fraser 2020-11-10 15:53:53 -0800 <rdar://problem/71256352> 1706367 2 413787 noam 2020-11-10 23:24:38 -0800 Created attachment 413787 Patch 1706485 3 ews-feeder 2020-11-11 09:23:33 -0800 Committed r269687: <https://trac.webkit.org/changeset/269687> All reviewed patches have been landed. Closing bug and clearing flags on attachment 413787. 413787 2020-11-10 23:24:38 -0800 2020-11-11 09:23:34 -0800 Patch bug-218777-20201111092437.patch text/plain 1534 noam SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI2OTY3MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDIwLTExLTEwICBOb2FtIFJv c2VudGhhbCAgPG5vYW1Ad2Via2l0Lm9yZz4KKworICAgICAgICBDb250ZW50ZnVsUGFpbnRDaGVj a2VyIHNob3VsZCBub3QgdHJpZ2dlciBwbHVnaW4gc25hcHNob3R0aW5nCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTg3NzcKKyAgICAgICAgPHJkYXI6 Ly9wcm9ibGVtLzcxMjU2MzUyPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFdpZGdldHMgc2hvdWxkIG5vdCBiZSBub3RpZmllZCB3aGVuIGRldGVjdGlu ZyBjb250ZW50ZnVsIHBhaW50LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgYSBtaW5vciBvcHRp bWl6YXRpb24uCisKKyAgICAgICAgKiBwYWdlL0ZyYW1lVmlldy5jcHA6CisgICAgICAgIChXZWJD b3JlOjpGcmFtZVZpZXc6OndpbGxQYWludENvbnRlbnRzKToKKwogMjAyMC0xMS0xMCAgQ29tbWl0 IFF1ZXVlICA8Y29tbWl0LXF1ZXVlQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwg cmV2ZXJ0aW5nIHIyNjk2NjAuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCShyZXZp c2lvbiAyNjk2NzMpCisrKyBTb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTQyNjEsNyArNDI2MSw3IEBAIHZvaWQgRnJhbWVWaWV3Ojp3aWxsUGFpbnRD b250ZW50cyhHcmFwaGkKICAgICAgICAgbV9wYWludEJlaGF2aW9yLmFkZChQYWludEJlaGF2aW9y OjpTbmFwc2hvdHRpbmcpOwogICAgIH0KIAotICAgIHBhaW50aW5nU3RhdGUuaXNGbGF0dGVuaW5n UGFpbnRPZlJvb3RGcmFtZSA9IChtX3BhaW50QmVoYXZpb3IgJiBQYWludEJlaGF2aW9yOjpGbGF0 dGVuQ29tcG9zaXRpbmdMYXllcnMpICYmICFmcmFtZSgpLm93bmVyRWxlbWVudCgpOworICAgIHBh aW50aW5nU3RhdGUuaXNGbGF0dGVuaW5nUGFpbnRPZlJvb3RGcmFtZSA9IChtX3BhaW50QmVoYXZp b3IgJiBQYWludEJlaGF2aW9yOjpGbGF0dGVuQ29tcG9zaXRpbmdMYXllcnMpICYmICFmcmFtZSgp Lm93bmVyRWxlbWVudCgpICYmICFjb250ZXh0LmRldGVjdGluZ0NvbnRlbnRmdWxQYWludCgpOwog ICAgIGlmIChwYWludGluZ1N0YXRlLmlzRmxhdHRlbmluZ1BhaW50T2ZSb290RnJhbWUpCiAgICAg ICAgIG5vdGlmeVdpZGdldHNJbkFsbEZyYW1lcyhXaWxsUGFpbnRGbGF0dGVuZWQpOwogCg==