218771 2020-11-10 13:30:37 -0800 [macCatalyst] Fix various build breaks 2020-11-10 14:58:44 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sabouhallawa sabouhallawa eric.carlson ews-watchlist glenn jer.noble mifenton philipj ryanhaddad sergio thorton webkit-bug-importer oldest_to_newest 1706196 0 sabouhallawa 2020-11-10 13:30:37 -0800 For example r269614 caused the following compilation error: ./editing/cocoa/DictionaryLookup.mm:249:31: error: no viable conversion from 'RefPtr<WebCore::NativeImage>' to 'RetainPtr<CGImageRef>' (aka 'RetainPtr<CGImage *>') 1706197 1 413730 sabouhallawa 2020-11-10 13:32:06 -0800 Created attachment 413730 Patch 1706215 2 413730 thorton 2020-11-10 14:06:17 -0800 Comment on attachment 413730 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=413730&action=review > Source/WebKitLegacy/mac/WebView/WebPreferences.mm:2067 > -- (void)setAVKitEnabled:(bool)flag > +- (void)setAVKitEnabled:(BOOL)flag What does the header say?? 1706225 3 413730 sabouhallawa 2020-11-10 14:29:49 -0800 Comment on attachment 413730 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=413730&action=review >> Source/WebKitLegacy/mac/WebView/WebPreferences.mm:2067 >> +- (void)setAVKitEnabled:(BOOL)flag > > What does the header say?? In Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h, there is this definition: @property (nonatomic, getter=avKitEnabled) BOOL AVKitEnabled; 1706234 4 ryanhaddad 2020-11-10 14:58:28 -0800 rdar://71251933 1706235 5 ews-feeder 2020-11-10 14:58:43 -0800 Committed r269648: <https://trac.webkit.org/changeset/269648> All reviewed patches have been landed. Closing bug and clearing flags on attachment 413730. 413730 2020-11-10 13:32:06 -0800 2020-11-10 14:58:44 -0800 Patch bug-218771-20201110133206.patch text/plain 6124 sabouhallawa U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5NjQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWE4YzRmY2VmZmI3N2Q2 NjYzNjY5MWNhNzYxMzljOWI3ZGE2MjgxMy4uYzk3NGZjMmVjZmYzZTg2NTFiOTU2MzFjYzUxMTMy MDA1MjdlN2Y5OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIwLTExLTEwICBTYWlk IEFib3UtSGFsbGF3YSAgPHNhaWRAYXBwbGUuY29tPgorCisgICAgICAgIFttYWNDYXRhbHlzdF0g Rml4IHZhcmlvdXMgYnVpbGQgYnJlYWtzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMTg3NzEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBVc2UgUGxhdGZvcm1JbWFnZVB0ciB3aGljaCBpcyBlbmNhcHN1bGF0 ZWQgaW4gTmF0aXZlSW1hZ2UuCisKKyAgICAgICAgKiBlZGl0aW5nL2NvY29hL0RpY3Rpb25hcnlM b29rdXAubW06CisgICAgICAgICgtW1dlYlJldmVhbEhpZ2hsaWdodCBkcmF3SGlnaGxpZ2h0Q29u dGVudEZvckl0ZW06Y29udGV4dDpdKToKKwogMjAyMC0xMS0xMCAgV2Vuc29uIEhzaWVoICA8d2Vu c29uX2hzaWVoQGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OIChyMjY5NTI1KTogTWFu eSBsYXlvdXQgdGVzdHMgY3Jhc2ggd2hlbiBydW4gdW5kZXIgQVNhbgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwppbmRleCBjMWFk NjEwMmQ4NDE5MmQzNjEzMjcyMTgxM2ExYzBlOGYwYzE1YTNiLi4yODVlODRmYWUzMTZlZTUxZWY2 NDJkODUwMDk2N2MzYjlmMjI0ZjBhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxv ZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIwLTEx LTEwICBTYWlkIEFib3UtSGFsbGF3YSAgPHNhaWRAYXBwbGUuY29tPgorCisgICAgICAgIFttYWND YXRhbHlzdF0gRml4IHZhcmlvdXMgYnVpbGQgYnJlYWtzCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTg3NzEKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVc2UgTk9fUkVUVVJOX0RVRV9UT19BU1NFUlQgZm9y IHVucmVhY2hhYmxlIGZ1bmN0aW9uLgorCisgICAgICAgICogVUlQcm9jZXNzL0NvY29hL1VzZXJN ZWRpYVBlcm1pc3Npb25SZXF1ZXN0UHJveHkubW06CisgICAgICAgIChXZWJLaXQ6OlVzZXJNZWRp YVBlcm1pc3Npb25SZXF1ZXN0UHJveHk6OmRvRGVmYXVsdEFjdGlvbik6CisgICAgICAgICogVUlQ cm9jZXNzL1VzZXJNZWRpYVBlcm1pc3Npb25SZXF1ZXN0UHJveHkuaDoKKwogMjAyMC0xMS0xMCAg V2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNT SU9OIChyMjY5NTI1KTogTWFueSBsYXlvdXQgdGVzdHMgY3Jhc2ggd2hlbiBydW4gdW5kZXIgQVNh bgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdExlZ2FjeS9tYWMvQ2hhbmdlTG9nIGIvU291cmNl L1dlYktpdExlZ2FjeS9tYWMvQ2hhbmdlTG9nCmluZGV4IDhhZmUxYzM4MzZmMTZmZjUzNGEyZmE0 ZWYwODk3YmQ3OThmZTU1NDcuLmJhNWUyYTExOWE3ZDZkZTkzZmU2ZjE0NjY3NDg2YjhlZDIxMWVj NWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL0NoYW5nZUxvZworKysgYi9T b3VyY2UvV2ViS2l0TGVnYWN5L21hYy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAyMC0x MS0xMCAgU2FpZCBBYm91LUhhbGxhd2EgIDxzYWlkQGFwcGxlLmNvbT4KKworICAgICAgICBbbWFj Q2F0YWx5c3RdIEZpeCB2YXJpb3VzIGJ1aWxkIGJyZWFrcworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE4NzcxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXNlICdCT09MJyBpbnN0ZWFkIG9mICdib29sJyBm b3IgdGhlIGZ1bmN0aW9ucyBhcmd1bWVudHMgdG8gcmVzb2x2ZSB0aGUgCisgICAgICAgIGNvbmZs aWN0IHdpdGggX3NldEJvb2xWYWx1ZSB3aGljaCB0YWtlcyAnQk9PTCcuCisKKyAgICAgICAgKiBX ZWJWaWV3L1dlYlByZWZlcmVuY2VzLm1tOgorICAgICAgICAoLVtXZWJQcmVmZXJlbmNlcyBzZXRB VktpdEVuYWJsZWQ6XSk6CisgICAgICAgICgtW1dlYlByZWZlcmVuY2VzIHNldE5ldHdvcmtEYXRh VXNhZ2VUcmFja2luZ0VuYWJsZWQ6XSk6CisKIDIwMjAtMTEtMDkgIFNhaWQgQWJvdS1IYWxsYXdh ICA8c2FpZEBhcHBsZS5jb20+CiAKICAgICAgICAgW0dQVSBQcm9jZXNzXSBDb250cm9sIHRoZSBs aWZlIGN5Y2xlIG9mIHRoZSBwbGF0Zm9ybSBpbWFnZSBieSBhIG5ldyBjbGFzcyBuYW1lZCBOYXRp dmVJbWFnZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZWRpdGluZy9jb2NvYS9EaWN0aW9u YXJ5TG9va3VwLm1tIGIvU291cmNlL1dlYkNvcmUvZWRpdGluZy9jb2NvYS9EaWN0aW9uYXJ5TG9v a3VwLm1tCmluZGV4IDlmMDE0OTY1ZGEwOTNjYjJlYjlmMGY5OWNiNTE0NmVkNzVkZDNhMTAuLjEw ZWE3NzViZmIyZmQzYjhkN2NjN2E4MzQyMWU1N2FkYTYyMjFhZjQgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2VkaXRpbmcvY29jb2EvRGljdGlvbmFyeUxvb2t1cC5tbQorKysgYi9Tb3VyY2Uv V2ViQ29yZS9lZGl0aW5nL2NvY29hL0RpY3Rpb25hcnlMb29rdXAubW0KQEAgLTI0Niw5ICsyNDYs OSBAQCBTT0ZUX0xJTktfQ0xBU1NfT1BUSU9OQUwoUmV2ZWFsQ29yZSwgUlZTZWxlY3Rpb24pCiAg ICAgCiAgICAgZm9yIChOU1ZhbHVlICp2IGluIHJlY3RzKSB7CiAgICAgICAgIENHUmVjdCBpbWdT cmNSZWN0ID0gW192aWV3IGNvbnZlcnRSZWN0OnYuQ0dSZWN0VmFsdWUgZnJvbVZpZXc6bmlsXTsK LSAgICAgICAgUmV0YWluUHRyPENHSW1hZ2VSZWY+IGltYWdlUmVmID0gX2ltYWdlLT5uYXRpdmVJ bWFnZSgpOworICAgICAgICBhdXRvIG5hdGl2ZUltYWdlID0gX2ltYWdlLT5uYXRpdmVJbWFnZSgp OwogICAgICAgICBDR1JlY3Qgb3JpZ2luID0gQ0dSZWN0TWFrZShpbWdTcmNSZWN0Lm9yaWdpbi54 IC0gaGlnaGxpZ2h0UmVjdC5vcmlnaW4ueCwgaW1nU3JjUmVjdC5vcmlnaW4ueSAtIGhpZ2hsaWdo dFJlY3Qub3JpZ2luLnksIGhpZ2hsaWdodFJlY3Quc2l6ZS53aWR0aCwgaGlnaGxpZ2h0UmVjdC5z aXplLmhlaWdodCk7Ci0gICAgICAgIENHQ29udGV4dERyYXdJbWFnZShjb250ZXh0LCBvcmlnaW4s IGltYWdlUmVmLmdldCgpKTsKKyAgICAgICAgQ0dDb250ZXh0RHJhd0ltYWdlKGNvbnRleHQsIG9y aWdpbiwgbmF0aXZlSW1hZ2UtPnBsYXRmb3JtSW1hZ2UoKS5nZXQoKSk7CiAgICAgfQogfQogCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9Vc2VyTWVkaWFQZXJtaXNz aW9uUmVxdWVzdFByb3h5Lm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvVXNlck1l ZGlhUGVybWlzc2lvblJlcXVlc3RQcm94eS5tbQppbmRleCA3NjVlMWFlMTkyNjZkYjEwYzRjOGQw ZTZkOTdlMzRlMGQ5M2I5MGIyLi41Y2MyZmFkNTc5MDQxMTQ2MGU1NTZhYjliMjZkNDhmY2RmOTMw YTMzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9Vc2VyTWVkaWFQ ZXJtaXNzaW9uUmVxdWVzdFByb3h5Lm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0Nv Y29hL1VzZXJNZWRpYVBlcm1pc3Npb25SZXF1ZXN0UHJveHkubW0KQEAgLTEyMiw3ICsxMjIsNyBA QCB2b2lkIFVzZXJNZWRpYVBlcm1pc3Npb25SZXF1ZXN0UHJveHk6OmRvRGVmYXVsdEFjdGlvbigp CiAKIG5hbWVzcGFjZSBXZWJLaXQgewogCi12b2lkIFVzZXJNZWRpYVBlcm1pc3Npb25SZXF1ZXN0 UHJveHk6OmRvRGVmYXVsdEFjdGlvbigpCitOT19SRVRVUk5fRFVFX1RPX0FTU0VSVCB2b2lkIFVz ZXJNZWRpYVBlcm1pc3Npb25SZXF1ZXN0UHJveHk6OmRvRGVmYXVsdEFjdGlvbigpCiB7CiAgICAg QVNTRVJUX05PVF9SRUFDSEVEKCk7CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9Vc2VyTWVkaWFQZXJtaXNzaW9uUmVxdWVzdFByb3h5LmggYi9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9Vc2VyTWVkaWFQZXJtaXNzaW9uUmVxdWVzdFByb3h5LmgKaW5kZXggODkyN2E2NjFl MmE2MTNjY2ViZTJhNTZkNGI5ZDE1NmYyMjJmYzkzMC4uMTUzY2JjMmVlZDQ3OWU3YWE0NjgxY2Q1 YWQ5MDdkMmJiZDExNmFlMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvVXNl ck1lZGlhUGVybWlzc2lvblJlcXVlc3RQcm94eS5oCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL1VzZXJNZWRpYVBlcm1pc3Npb25SZXF1ZXN0UHJveHkuaApAQCAtNDgsOCArNDgsNiBAQCBw dWJsaWM6CiAgICAgZW51bSBjbGFzcyBVc2VyTWVkaWFBY2Nlc3NEZW5pYWxSZWFzb24geyBOb0Nv bnN0cmFpbnRzLCBVc2VyTWVkaWFEaXNhYmxlZCwgTm9DYXB0dXJlRGV2aWNlcywgSW52YWxpZENv bnN0cmFpbnQsIEhhcmR3YXJlRXJyb3IsIFBlcm1pc3Npb25EZW5pZWQsIE90aGVyRmFpbHVyZSB9 OwogICAgIHZvaWQgZGVueShVc2VyTWVkaWFBY2Nlc3NEZW5pYWxSZWFzb24gPSBVc2VyTWVkaWFB Y2Nlc3NEZW5pYWxSZWFzb246OlVzZXJNZWRpYURpc2FibGVkKTsKIAotICAgIHZvaWQgZG9EZWZh dWx0QWN0aW9uKCk7Ci0KICAgICB2b2lkIGludmFsaWRhdGUoKTsKICAgICBib29sIGlzUGVuZGlu ZygpIGNvbnN0IHsgcmV0dXJuIG1fbWFuYWdlcjsgfQogCkBAIC04OSw2ICs4Nyw5IEBAIHB1Ymxp YzoKIAogI2lmIEVOQUJMRShNRURJQV9TVFJFQU0pCiAgICAgYm9vbCBpc1VzZXJHZXN0dXJlUHJp dmlsZWRnZWQoKSBjb25zdCB7IHJldHVybiBtX3JlcXVlc3QuaXNVc2VyR2VzdHVyZVByaXZpbGVk Z2VkOyB9CisgICAgdm9pZCBkb0RlZmF1bHRBY3Rpb24oKTsKKyNlbHNlCisgICAgTk9fUkVUVVJO X0RVRV9UT19BU1NFUlQgdm9pZCBkb0RlZmF1bHRBY3Rpb24oKTsKICNlbmRpZgogCiBwcml2YXRl OgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdExlZ2FjeS9tYWMvV2ViVmlldy9XZWJQcmVmZXJl bmNlcy5tbSBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL1dlYlZpZXcvV2ViUHJlZmVyZW5jZXMu bW0KaW5kZXggNTdjMGQzNDQwNmVjMTkxYjFjYWM2NjM0ZDc1YmJkMGQ5ZjEzNGRiMS4uMDg0OGE3 MmFiOGFhYjY2ZmIyOTRmZjM0MWZkNTQwYjI5NWQ1M2FjNCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdExlZ2FjeS9tYWMvV2ViVmlldy9XZWJQcmVmZXJlbmNlcy5tbQorKysgYi9Tb3VyY2UvV2Vi S2l0TGVnYWN5L21hYy9XZWJWaWV3L1dlYlByZWZlcmVuY2VzLm1tCkBAIC0yMDY0LDcgKzIwNjQs NyBAQCBzdGF0aWMgTlNTdHJpbmcgKmNsYXNzSUJDcmVhdG9ySUQgPSBuaWw7CiAgICAgcmV0dXJu IFtzZWxmIF9ib29sVmFsdWVGb3JLZXk6V2ViS2l0QVZLaXRFbmFibGVkXTsKIH0KIAotLSAodm9p ZClzZXRBVktpdEVuYWJsZWQ6KGJvb2wpZmxhZworLSAodm9pZClzZXRBVktpdEVuYWJsZWQ6KEJP T0wpZmxhZwogewogI2lmIEhBVkUoQVZLSVQpCiAgICAgW3NlbGYgX3NldEJvb2xWYWx1ZTpmbGFn IGZvcktleTpXZWJLaXRBVktpdEVuYWJsZWRdOwpAQCAtMjA3Niw3ICsyMDc2LDcgQEAgc3RhdGlj IE5TU3RyaW5nICpjbGFzc0lCQ3JlYXRvcklEID0gbmlsOwogICAgIHJldHVybiBbc2VsZiBfYm9v bFZhbHVlRm9yS2V5OldlYktpdE5ldHdvcmtEYXRhVXNhZ2VUcmFja2luZ0VuYWJsZWRQcmVmZXJl bmNlS2V5XTsKIH0KIAotLSAodm9pZClzZXROZXR3b3JrRGF0YVVzYWdlVHJhY2tpbmdFbmFibGVk Oihib29sKXRyYWNraW5nRW5hYmxlZAorLSAodm9pZClzZXROZXR3b3JrRGF0YVVzYWdlVHJhY2tp bmdFbmFibGVkOihCT09MKXRyYWNraW5nRW5hYmxlZAogewogICAgIFtzZWxmIF9zZXRCb29sVmFs dWU6dHJhY2tpbmdFbmFibGVkIGZvcktleTpXZWJLaXROZXR3b3JrRGF0YVVzYWdlVHJhY2tpbmdF bmFibGVkUHJlZmVyZW5jZUtleV07CiB9Cg==