218739 2020-11-09 21:58:17 -0800 Fix crashes when mapping shared display list item data into display lists in the GPU process 2020-11-10 00:07:43 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh sabouhallawa thorton webkit-bug-importer oldest_to_newest 1705983 0 wenson_hsieh 2020-11-09 21:58:17 -0800 <rdar://problem/71212909> 1705984 1 wenson_hsieh 2020-11-09 21:59:34 -0800 Addresses a bug in the placeholder mechanism I landed to act as a "halfway point" between Ref-counted display list items and fully concurrent display list processing. 1705987 2 413663 wenson_hsieh 2020-11-09 22:14:10 -0800 Created attachment 413663 Patch 1706004 3 413663 wenson_hsieh 2020-11-09 23:51:08 -0800 Comment on attachment 413663 Patch Thanks for the review! 1706006 4 ews-feeder 2020-11-10 00:07:42 -0800 Committed r269617: <https://trac.webkit.org/changeset/269617> All reviewed patches have been landed. Closing bug and clearing flags on attachment 413663. 413663 2020-11-09 22:14:10 -0800 2020-11-10 00:07:42 -0800 Patch bug-218739-20201109221407.patch text/plain 2838 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5NjEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGFlYmM5ZGY0NmYwM2ZmNzgz MjYyMDhjMWYxOTg4MTQ2ZWJiNzFjN2QuLmYxZjI2MDFjYWJkYjcyMmY2NDQ0NDdiYTk1MTU3MzJj ZmFhZDc5ODcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMjAtMTEtMDkgIFdlbnNvbiBI c2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgRml4IGNyYXNoZXMgd2hl biBtYXBwaW5nIHNoYXJlZCBkaXNwbGF5IGxpc3QgaXRlbSBkYXRhIGludG8gZGlzcGxheSBsaXN0 cyBpbiB0aGUgR1BVIHByb2Nlc3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTIxODczOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIEkgYWRkZWQgYSAic3RvcC1nYXAiIG1lY2hhbmlzbSBpbiByMjY5NTI1IHRv IGFsbG93IHRoZSBHUFUgcHJvY2VzcyB0byBoYW5kbGUgbmV3bHkgcmVmYWN0b3JlZCBkaXNwbGF5 IGxpc3QKKyAgICAgICAgaXRlbXMgYnkgZW5jb2RpbmcgZGlzcGxheSBsaXN0IGl0ZW1zIGRpcmVj dGx5IGludG8gc2hhcmVkIG1lbW9yeSBidWZmZXJzIGluIHRoZSB3ZWIgcHJvY2VzcyBhbmQgcmVh ZGluZyB0aGVtCisgICAgICAgIGJhY2sgaW4gdGhlIEdQVSBwcm9jZXNzLCB1c2luZyBzdGFuZGFy ZCBJUEMgbWVzc2FnZXMgb25seSwgYW5kIGFsc28gd2l0aG91dCByZXVzaW5nIGFueSBzaGFyZWQg bWVtb3J5IGJ1ZmZlcnMuCisKKyAgICAgICAgSG93ZXZlciwgSSBpbnRyb2R1Y2VkIGEgYnVnIGlu IHRoaXMgInN0b3AtZ2FwIiBtZWNoYW5pc20gd2hlbiBJIHRyaWVkIHRvIGNsZWFuIHVwIHNvbWUg R1BVLXByb2Nlc3Mtc2lkZSBsb2dpYworICAgICAgICBmb3IgdW5yZWdpc3RlcmluZyB0aGVzZSBz aGFyZWQgbWVtb3J5IGJ1ZmZlcnMgaW4gdGhlIEdQVSBwcm9jZXNzLCBieSB0YWtpbmcgc2hhcmVk IG1lbW9yeSBidWZmZXJzIG91dCBvZiB0aGUKKyAgICAgICAgbWFwIGluIHRoZSBHUFUgcHJvY2Vz cyB3aXRob3V0IGVuc3VyaW5nIHRoYXQgdGhleSdyZSBrZXB0IGFsaXZlIG92ZXIgdGhlIGNvdXJz ZSBvZiBhcHBseWluZyB0aGUgZGlzcGxheSBsaXN0LgorCisgICAgICAgIFRoaXMgY29kZSBpcyBn b2luZyBhd2F5IHNvb24gYW55d2F5cyAoc2VlIHdlYmtpdC5vcmcvYi8yMTg0MjYpLCBidXQgaW4g dGhlIG1lYW50aW1lLCB3ZSBzaG91bGQgYXQgbGVhc3QgZW5zdXJlCisgICAgICAgIHRoYXQgdGhp cyB0ZW1wb3Jhcnkgc2hhcmVkIG1lbW9yeSBtZWNoYW5pc20gZG9lc24ndCBjYXVzZSBodWdlIHdh dmVzIG9mIGxheW91dCB0ZXN0IGZhaWx1cmVzLgorCisgICAgICAgICogR1BVUHJvY2Vzcy9ncmFw aGljcy9SZW1vdGVSZW5kZXJpbmdCYWNrZW5kLmNwcDoKKyAgICAgICAgKFdlYktpdDo6UmVtb3Rl UmVuZGVyaW5nQmFja2VuZDo6YXBwbHlEaXNwbGF5TGlzdCk6CisKIDIwMjAtMTEtMDkgIFdlbnNv biBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTiAo cjI2OTUyNSk6IE1hbnkgbGF5b3V0IHRlc3RzIGNyYXNoIHdoZW4gcnVuIHVuZGVyIEFTYW4KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvR1BVUHJvY2Vzcy9ncmFwaGljcy9SZW1vdGVSZW5kZXJp bmdCYWNrZW5kLmNwcCBiL1NvdXJjZS9XZWJLaXQvR1BVUHJvY2Vzcy9ncmFwaGljcy9SZW1vdGVS ZW5kZXJpbmdCYWNrZW5kLmNwcAppbmRleCBiZTE4MDY0OTA3ZTU1ZWUxYzVhYjQwNGYyMWJmNWYw N2I1ZGM4NTgyLi5kMjM3YTYzYjg4Njk2NDIxYmI5YTI1N2VmOWRiMjE3Y2ZlOWY5Y2Y4IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0L0dQVVByb2Nlc3MvZ3JhcGhpY3MvUmVtb3RlUmVuZGVyaW5n QmFja2VuZC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9HUFVQcm9jZXNzL2dyYXBoaWNzL1JlbW90 ZVJlbmRlcmluZ0JhY2tlbmQuY3BwCkBAIC0xMjYsOSArMTI2LDEyIEBAIHZvaWQgUmVtb3RlUmVu ZGVyaW5nQmFja2VuZDo6Y3JlYXRlSW1hZ2VCdWZmZXIoY29uc3QgRmxvYXRTaXplJiBsb2dpY2Fs U2l6ZSwgUmVuCiAKIHZvaWQgUmVtb3RlUmVuZGVyaW5nQmFja2VuZDo6YXBwbHlEaXNwbGF5TGlz dChjb25zdCBTaGFyZWREaXNwbGF5TGlzdEhhbmRsZSYgaGFuZGxlLCBSZW5kZXJpbmdSZXNvdXJj ZUlkZW50aWZpZXIgcmVuZGVyaW5nUmVzb3VyY2VJZGVudGlmaWVyLCBTaG91bGRGbHVzaENvbnRl eHQgZmx1c2hDb250ZXh0KQogeworICAgIFZlY3RvcjxSZWY8U2hhcmVkTWVtb3J5Pj4gcmVtb3Zl ZEl0ZW1CdWZmZXJzOwogICAgIGF1dG8gZGlzcGxheUxpc3QgPSBoYW5kbGUuY3JlYXRlRGlzcGxh eUxpc3QoWyZdIChEaXNwbGF5TGlzdDo6SXRlbUJ1ZmZlcklkZW50aWZpZXIgaWRlbnRpZmllcikg LT4gdWludDhfdCogewotICAgICAgICBpZiAoYXV0byBzaGFyZWRNZW1vcnkgPSBtX3NoYXJlZEl0 ZW1CdWZmZXJzLnRha2UoaWRlbnRpZmllcikpCisgICAgICAgIGlmIChhdXRvIHNoYXJlZE1lbW9y eSA9IG1fc2hhcmVkSXRlbUJ1ZmZlcnMudGFrZShpZGVudGlmaWVyKSkgeworICAgICAgICAgICAg cmVtb3ZlZEl0ZW1CdWZmZXJzLmFwcGVuZCgqc2hhcmVkTWVtb3J5KTsKICAgICAgICAgICAgIHJl dHVybiByZWludGVycHJldF9jYXN0PHVpbnQ4X3QqPihzaGFyZWRNZW1vcnktPmRhdGEoKSk7Cisg ICAgICAgIH0KICAgICAgICAgcmV0dXJuIG51bGxwdHI7CiAgICAgfSk7CiAK