218736 2020-11-09 19:31:30 -0800 [LFC Display] A ContainerBox can establish an inline formatting context and have box children 2020-12-13 08:45:54 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser bfulgham sam simon.fraser webkit-bug-importer zalan oldest_to_newest 1705966 0 simon.fraser 2020-11-09 19:31:30 -0800 [LFC Display] A ContainerBox can have establish and inline formatting context and have box children 1705967 1 413656 simon.fraser 2020-11-09 19:32:26 -0800 Created attachment 413656 Patch 1705968 2 413656 zalan 2020-11-09 19:34:43 -0800 Comment on attachment 413656 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=413656&action=review > Source/WebCore/ChangeLog:3 > + [LFC Display] A ContainerBox can have establish and inline formatting context and have box children :) 1708099 3 webkit-bug-importer 2020-11-16 19:32:15 -0800 <rdar://problem/71470058> 1710324 4 414951 simon.fraser 2020-11-27 09:32:19 -0800 Created attachment 414951 Patch 1710327 5 simon.fraser 2020-11-27 09:46:58 -0800 https://trac.webkit.org/r270198 1710437 6 414951 sam 2020-11-28 11:51:09 -0800 Comment on attachment 414951 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414951&action=review > Source/WebCore/display/DisplayTreeBuilder.cpp:157 > + switch (boxInclusion) { > + case DescendantBoxInclusion::AllBoxes: return true; > + case DescendantBoxInclusion::OutOfFlowOnly: return !box.isInFlow(); > + } Not a fan of this one line style. Can you move the returns to their own line. > Source/WebCore/display/DisplayTreeBuilder.cpp:158 > + return false; There can probably a be an ASSERT_NOT_REACHED here for good measure. 1710438 7 sam 2020-11-28 11:51:23 -0800 Should this still be up for review? 413656 2020-11-09 19:32:26 -0800 2020-11-27 09:32:17 -0800 Patch bug-218736-20201109193225.patch text/plain 1796 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5NjEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2Y3N2I2MDEwZmU4ZWIz NWMxOWE3NDI5OTBhODkzMTYxOTJmOTUyYy4uNGRjYTUwNWY5ZTBjYjk4OWY1ZTk0Y2YzY2EyOTgy YzAzODc4OTU3ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIwLTExLTA5ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIFtMRkMgRGlzcGxh eV0gQSBDb250YWluZXJCb3ggY2FuIGhhdmUgZXN0YWJsaXNoIGFuZCBpbmxpbmUgZm9ybWF0dGlu ZyBjb250ZXh0IGFuZCBoYXZlIGJveCBjaGlsZHJlbgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE4NzM2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgRG9uJ3QgZWFybHkgcmV0dXJuIHdoZW4gYSBDb250YWlu ZXJCb3ggZXN0YWJsaXNoZXMgYW4gaW5saW5lIGZvcm1hdHRpbmcgY29udGV4dC4KKworICAgICAg ICAqIGRpc3BsYXkvRGlzcGxheVRyZWVCdWlsZGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRp c3BsYXk6OlRyZWVCdWlsZGVyOjpyZWN1cnNpdmVCdWlsZERpc3BsYXlUcmVlIGNvbnN0KToKKwog MjAyMC0xMS0wOSAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFVu ZXhwb3NlIG9ic29sZXRlIEhUTUxBcHBsZXRFbGVtZW50IGludGVyZmFjZQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvZGlzcGxheS9EaXNwbGF5VHJlZUJ1aWxkZXIuY3BwIGIvU291cmNlL1dl YkNvcmUvZGlzcGxheS9EaXNwbGF5VHJlZUJ1aWxkZXIuY3BwCmluZGV4IGUxYTUzY2U5ZjBjYTIy ZGUyNDhmNDk2NjAxYzk0OWE0YzBkNmQxOTYuLmMzOGMwODgzZGUyYzMwNGY0MWUzZDdlMWZiZjdi MGU0MzcyNTU4NzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Rpc3BsYXkvRGlzcGxheVRy ZWVCdWlsZGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kaXNwbGF5L0Rpc3BsYXlUcmVlQnVp bGRlci5jcHAKQEAgLTEzNSwxMCArMTM1LDggQEAgdm9pZCBUcmVlQnVpbGRlcjo6cmVjdXJzaXZl QnVpbGREaXNwbGF5VHJlZShjb25zdCBMYXlvdXQ6OkxheW91dFN0YXRlJiBsYXlvdXRTdGEKIAog ICAgIGF1dG8gcG9zaXRpb25Gb3JDaGlsZHJlbiA9IEluc2VydGlvblBvc2l0aW9uIHsgZG93bmNh c3Q8Q29udGFpbmVyQm94PigqaW5zZXJ0aW9uUG9zaXRpb24uY3VycmVudENoaWxkKSB9OwogICAg IAotICAgIGlmIChsYXlvdXRDb250YWluZXJCb3guZXN0YWJsaXNoZXNJbmxpbmVGb3JtYXR0aW5n Q29udGV4dCgpKSB7CisgICAgaWYgKGxheW91dENvbnRhaW5lckJveC5lc3RhYmxpc2hlc0lubGlu ZUZvcm1hdHRpbmdDb250ZXh0KCkpCiAgICAgICAgIGJ1aWxkSW5saW5lRGlzcGxheVRyZWUobGF5 b3V0U3RhdGUsIG9mZnNldEZyb21Sb290LCBkb3duY2FzdDxMYXlvdXQ6OkNvbnRhaW5lckJveD4o bGF5b3V0Q29udGFpbmVyQm94KSwgcG9zaXRpb25Gb3JDaGlsZHJlbik7Ci0gICAgICAgIHJldHVy bjsKLSAgICB9CiAKICAgICBmb3IgKGF1dG8mIGNoaWxkIDogTGF5b3V0OjpjaGlsZHJlbk9mVHlw ZTxMYXlvdXQ6OkJveD4obGF5b3V0Q29udGFpbmVyQm94KSkgewogICAgICAgICBpZiAobGF5b3V0 U3RhdGUuaGFzQm94R2VvbWV0cnkoY2hpbGQpKQo= 414951 2020-11-27 09:32:19 -0800 2020-12-13 08:45:54 -0800 Patch bug-218736-20201127093218.patch text/plain 2641 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjcwMTk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjc3Y2ZlYzk5NTUxODQx YzVhNmFjZjI1MjJlOWYwM2UwMDIxZDg1NC4uNGNhZDI4OGYwMzA0ZDNmMDA3MTQ2YjFhYjdlZmJh YmY2NWQ4OTliNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIwLTExLTI3ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIFtMRkMgRGlzcGxh eV0gQSBDb250YWluZXJCb3ggY2FuIGVzdGFibGlzaCBhbiBpbmxpbmUgZm9ybWF0dGluZyBjb250 ZXh0IGFuZCBoYXZlIGJveCBjaGlsZHJlbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjE4NzM2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgSWYgYSBsYXlvdXQgYm94IGVzdGFibGlzaGVzIGFuIGlubGluZSBm b3JtYXR0aW5nIGNvbnRleHQsIHRoZW4gdGhlIG9ubHkgZGVzY2VuZGFudCBjb250YWluZXIKKyAg ICAgICAgYm94ZXMgdGhhdCB3ZSBzaG91bGQgbWFrZSBkaXNwbGF5IGJveGVzIGZvciB3aGlsZSB0 cmF2ZXJzaW5nIG5vbi1pbmxpbmUgZGVzY2VuZGFudHMKKyAgICAgICAgYXJlIHRob3NlIHdoaWNo IGFyZSBvdXQgb2YgZmxvdy4KKworICAgICAgICAqIGRpc3BsYXkvRGlzcGxheVRyZWVCdWlsZGVy LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRpc3BsYXk6OlRyZWVCdWlsZGVyOjpyZWN1cnNpdmVC dWlsZERpc3BsYXlUcmVlIGNvbnN0KToKKwogMjAyMC0xMS0yNyAgQWRyaWFuIFBlcmV6IGRlIENh c3RybyAgPGFwZXJlekBpZ2FsaWEuY29tPgogCiAgICAgICAgIE5vbi11bmlmaWVkIGJ1aWxkIGZp eGVzLCBsYXRlIE5vdmVtYmVyIDIwMjAgZWRpdGlvbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvZGlzcGxheS9EaXNwbGF5VHJlZUJ1aWxkZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvZGlzcGxh eS9EaXNwbGF5VHJlZUJ1aWxkZXIuY3BwCmluZGV4IGYyNjg1YWY5ZDM4NmQwNWM1MGNiNmIwNWI5 YTM0Zjg1MTYyZTIyNWUuLjZmNDU1ZjUyMjczYmZlOGI5ZDJkNWIzODc1YjAxNzQzZTk5Y2NjY2Mg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Rpc3BsYXkvRGlzcGxheVRyZWVCdWlsZGVyLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kaXNwbGF5L0Rpc3BsYXlUcmVlQnVpbGRlci5jcHAKQEAg LTE0MSwxNCArMTQxLDI1IEBAIHZvaWQgVHJlZUJ1aWxkZXI6OnJlY3Vyc2l2ZUJ1aWxkRGlzcGxh eVRyZWUoY29uc3QgTGF5b3V0OjpMYXlvdXRTdGF0ZSYgbGF5b3V0U3RhCiAgICAgb2Zmc2V0RnJv bVJvb3QgKz0gdG9MYXlvdXRTaXplKGJvcmRlckJveFJlY3QubG9jYXRpb24oKSk7CiAKICAgICBh dXRvIHBvc2l0aW9uRm9yQ2hpbGRyZW4gPSBJbnNlcnRpb25Qb3NpdGlvbiB7IGRvd25jYXN0PENv bnRhaW5lckJveD4oKmluc2VydGlvblBvc2l0aW9uLmN1cnJlbnRDaGlsZCkgfTsKLSAgICAKKwor ICAgIGVudW0gY2xhc3MgRGVzY2VuZGFudEJveEluY2x1c2lvbiB7IEFsbEJveGVzLCBPdXRPZkZs b3dPbmx5IH07CisgICAgYXV0byBib3hJbmNsdXNpb24gPSBEZXNjZW5kYW50Qm94SW5jbHVzaW9u OjpBbGxCb3hlczsKKwogICAgIGlmIChsYXlvdXRDb250YWluZXJCb3guZXN0YWJsaXNoZXNJbmxp bmVGb3JtYXR0aW5nQ29udGV4dCgpKSB7CiAgICAgICAgIGJ1aWxkSW5saW5lRGlzcGxheVRyZWUo bGF5b3V0U3RhdGUsIG9mZnNldEZyb21Sb290LCBkb3duY2FzdDxMYXlvdXQ6OkNvbnRhaW5lckJv eD4obGF5b3V0Q29udGFpbmVyQm94KSwgcG9zaXRpb25Gb3JDaGlsZHJlbik7Ci0gICAgICAgIHJl dHVybjsKKyAgICAgICAgYm94SW5jbHVzaW9uID0gRGVzY2VuZGFudEJveEluY2x1c2lvbjo6T3V0 T2ZGbG93T25seTsKICAgICB9CiAKKyAgICBhdXRvIGluY2x1ZGVCb3ggPSBbXShEZXNjZW5kYW50 Qm94SW5jbHVzaW9uIGJveEluY2x1c2lvbiwgY29uc3QgTGF5b3V0OjpCb3gmIGJveCkgeworICAg ICAgICBzd2l0Y2ggKGJveEluY2x1c2lvbikgeworICAgICAgICBjYXNlIERlc2NlbmRhbnRCb3hJ bmNsdXNpb246OkFsbEJveGVzOiByZXR1cm4gdHJ1ZTsKKyAgICAgICAgY2FzZSBEZXNjZW5kYW50 Qm94SW5jbHVzaW9uOjpPdXRPZkZsb3dPbmx5OiByZXR1cm4gIWJveC5pc0luRmxvdygpOworICAg ICAgICB9CisgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICB9OworCiAgICAgZm9yIChhdXRvJiBj aGlsZCA6IExheW91dDo6Y2hpbGRyZW5PZlR5cGU8TGF5b3V0OjpCb3g+KGxheW91dENvbnRhaW5l ckJveCkpIHsKLSAgICAgICAgaWYgKGxheW91dFN0YXRlLmhhc0JveEdlb21ldHJ5KGNoaWxkKSkK KyAgICAgICAgaWYgKGluY2x1ZGVCb3goYm94SW5jbHVzaW9uLCBjaGlsZCkgJiYgbGF5b3V0U3Rh dGUuaGFzQm94R2VvbWV0cnkoY2hpbGQpKQogICAgICAgICAgICAgcmVjdXJzaXZlQnVpbGREaXNw bGF5VHJlZShsYXlvdXRTdGF0ZSwgb2Zmc2V0RnJvbVJvb3QsIGNoaWxkLCBwb3NpdGlvbkZvckNo aWxkcmVuKTsKICAgICB9CiB9Cg==