218722 2020-11-09 13:34:02 -0800 REGRESSION (r269557): ASSERTION FAILED: Completion handler should always be called under WebCore::HTMLMediaElement::exitFullscreen 2020-11-10 13:15:55 -0800 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=218419 InRadar P2 Normal --- 1 ryanhaddad peng.liu6 eric.carlson ews-watchlist glenn jer.noble peng.liu6 philipj ryanhaddad sergio webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1705855 0 ryanhaddad 2020-11-09 13:34:02 -0800 Seeing the following assertion failure with media/element-containing-pip-video-going-into-fullscreen.html macOS debug bots after https://trac.webkit.org/changeset/269557/webkit: ASSERTION FAILED: Completion handler should always be called !m_function /Volumes/Data/slave/catalina-debug/build/WebKitBuild/Debug/usr/local/include/wtf/CompletionHandler.h(58) : WTF::CompletionHandler<void (bool)>::~CompletionHandler() 1 0x7cecbff29 WTFCrash 2 0x7ae97cdb7 WTF::CompletionHandler<void (bool)>::~CompletionHandler() 3 0x7ae96ad25 WTF::CompletionHandler<void (bool)>::~CompletionHandler() 4 0x7b1973601 WebCore::HTMLMediaElement::exitFullscreen() 5 0x7b1a52f77 WebCore::HTMLVideoElement::setPresentationMode(WebCore::HTMLVideoElement::VideoPresentationMode) 6 0x7b007656f WebCore::VideoFullscreenModelVideoElement::fullscreenModeChanged(unsigned int) 7 0x7a16aad6a WebKit::VideoFullscreenManager::fullscreenModeChanged(WTF::ObjectIdentifier<WebKit::PlaybackSessionContextIdentifierType>, unsigned int) 8 0x7a1a907ab void IPC::callMemberFunctionImpl<WebKit::VideoFullscreenManager, void (WebKit::VideoFullscreenManager::*)(WTF::ObjectIdentifier<WebKit::PlaybackSessionContextIdentifierType>, unsigned int), std::__1::tuple<WTF::ObjectIdentifier<WebKit::PlaybackSessionContextIdentifierType>, unsigned int>, 0ul, 1ul>(WebKit::VideoFullscreenManager*, void (WebKit::VideoFullscreenManager::*)(WTF::ObjectIdentifier<WebKit::PlaybackSessionContextIdentifierType>, unsigned int), std::__1::tuple<WTF::ObjectIdentifier<WebKit::PlaybackSessionContextIdentifierType>, unsigned int>&&, std::__1::integer_sequence<unsigned long, 0ul, 1ul>) 9 0x7a1a8fd40 void IPC::callMemberFunction<WebKit::VideoFullscreenManager, void (WebKit::VideoFullscreenManager::*)(WTF::ObjectIdentifier<WebKit::PlaybackSessionContextIdentifierType>, unsigned int), std::__1::tuple<WTF::ObjectIdentifier<WebKit::PlaybackSessionContextIdentifierType>, unsigned int>, std::__1::integer_sequence<unsigned long, 0ul, 1ul> >(std::__1::tuple<WTF::ObjectIdentifier<WebKit::PlaybackSessionContextIdentifierType>, unsigned int>&&, WebKit::VideoFullscreenManager*, void (WebKit::VideoFullscreenManager::*)(WTF::ObjectIdentifier<WebKit::PlaybackSessionContextIdentifierType>, unsigned int)) 10 0x7a1a8b216 void IPC::handleMessage<Messages::VideoFullscreenManager::FullscreenModeChanged, WebKit::VideoFullscreenManager, void (WebKit::VideoFullscreenManager::*)(WTF::ObjectIdentifier<WebKit::PlaybackSessionContextIdentifierType>, unsigned int)>(IPC::Decoder&, WebKit::VideoFullscreenManager*, void (WebKit::VideoFullscreenManager::*)(WTF::ObjectIdentifier<WebKit::PlaybackSessionContextIdentifierType>, unsigned int)) 11 0x7a1a8a910 WebKit::VideoFullscreenManager::didReceiveMessage(IPC::Connection&, IPC::Decoder&) 12 0x7a0458dd1 IPC::MessageReceiverMap::dispatchMessage(IPC::Connection&, IPC::Decoder&) 13 0x7a16e71f7 WebKit::WebProcess::didReceiveMessage(IPC::Connection&, IPC::Decoder&) 14 0x7a0075faa IPC::Connection::dispatchMessage(IPC::Decoder&) 15 0x7a0077090 IPC::Connection::dispatchMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >) 16 0x7a0077720 IPC::Connection::dispatchOneIncomingMessage() 17 0x7a0098478 IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >)::$_8::operator()() 18 0x7a009838e WTF::Detail::CallableWrapper<IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >)::$_8, void>::call() 19 0x7ceceb792 WTF::Function<void ()>::operator()() const 20 0x7ced6a7e5 WTF::RunLoop::performWork() 21 0x7ced6ee71 WTF::RunLoop::performWork(void*) 22 0x7fff35035d52 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ 23 0x7fff35035cf1 __CFRunLoopDoSource0 24 0x7fff35035b0b __CFRunLoopDoSources0 25 0x7fff3503483a __CFRunLoopRun 26 0x7fff35033e3e CFRunLoopRunSpecific 27 0x7fff376cf1c8 -[NSRunLoop(NSRunLoop) runMode:beforeDate:] 28 0x7fff37781c6f -[NSRunLoop(NSRunLoop) run] 29 0x7fff6f2ee4ea _xpc_objc_main.cold.4 30 0x7fff6f2ee430 _xpc_objc_main 31 0x7fff6f2edf63 _xpc_copy_xpcservice_dictionary LEAK: 1 WebPageProxy https://results.webkit.org/?suite=layout-tests&test=media%2Felement-containing-pip-video-going-into-fullscreen.html 1705856 1 webkit-bug-importer 2020-11-09 13:34:42 -0800 <rdar://problem/71208005> 1705876 2 413629 peng.liu6 2020-11-09 13:58:56 -0800 Created attachment 413629 Patch 1705910 3 ews-feeder 2020-11-09 15:48:35 -0800 Committed r269610: <https://trac.webkit.org/changeset/269610> All reviewed patches have been landed. Closing bug and clearing flags on attachment 413629. 413629 2020-11-09 13:58:56 -0800 2020-11-09 15:48:36 -0800 Patch bug-218722-20201109135855.patch text/plain 1980 peng.liu6 U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5NTU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGU2M2RjZjg2NTgxZmIzNTFm ZjE4OTU5Y2ViMGY0NWU5OTczODM3YjkuLjg4NDEwYjk1NjgyNTU0ZDUzMTAyMTNhMWU1MGQxYzBj MjY5YzRmYmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjAtMTEtMDkgIFBlbmcgTGl1 ICA8cGVuZy5saXU2QGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMjY5NTU3KTog QVNTRVJUSU9OIEZBSUxFRDogQ29tcGxldGlvbiBoYW5kbGVyIHNob3VsZCBhbHdheXMgYmUgY2Fs bGVkIHVuZGVyIFdlYkNvcmU6OkhUTUxNZWRpYUVsZW1lbnQ6OmV4aXRGdWxsc2NyZWVuCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTg3MjIKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMs IGNvdmVyZWQgYnkgYW4gZXhpc3RpbmcgdGVzdCB0aGF0IGlzIGNyYXNoaW5nIG9uIHRoZSBib3Rz LgorCisgICAgICAgICogV2ViUHJvY2Vzcy9jb2NvYS9WaWRlb0Z1bGxzY3JlZW5NYW5hZ2VyLm1t OgorICAgICAgICAoV2ViS2l0OjpWaWRlb0Z1bGxzY3JlZW5NYW5hZ2VyOjpleGl0VmlkZW9GdWxs c2NyZWVuRm9yVmlkZW9FbGVtZW50KToKKwogMjAyMC0xMS0wNiAgUGVuZyBMaXUgIDxwZW5nLmxp dTZAYXBwbGUuY29tPgogCiAgICAgICAgIFBpUCByZXR1cm4gdG8gZWxlbWVudCBmdWxsIHNjcmVl biBpcyBub3Qgc21vb3RoIG9uIHNvbWUgd2Vic2l0ZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvV2ViUHJvY2Vzcy9jb2NvYS9WaWRlb0Z1bGxzY3JlZW5NYW5hZ2VyLm1tIGIvU291cmNlL1dl YktpdC9XZWJQcm9jZXNzL2NvY29hL1ZpZGVvRnVsbHNjcmVlbk1hbmFnZXIubW0KaW5kZXggOGNl ZThmOGRiM2ViZmQzN2YwMWVlZjdhNWY0ZmM0M2E1NGVkMjFlOC4uZGZjNjkxNjBmM2I4OWM1NWM0 NzU1ODRlNWZiNmQ5NDhlZWM2YTQzOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9XZWJQcm9j ZXNzL2NvY29hL1ZpZGVvRnVsbHNjcmVlbk1hbmFnZXIubW0KKysrIGIvU291cmNlL1dlYktpdC9X ZWJQcm9jZXNzL2NvY29hL1ZpZGVvRnVsbHNjcmVlbk1hbmFnZXIubW0KQEAgLTMwMCw4ICszMDAs MTAgQEAgdm9pZCBWaWRlb0Z1bGxzY3JlZW5NYW5hZ2VyOjpleGl0VmlkZW9GdWxsc2NyZWVuRm9y VmlkZW9FbGVtZW50KFdlYkNvcmU6OkhUTUxWaWQKIAogICAgIGF1dG8gY29udGV4dElkID0gbV92 aWRlb0VsZW1lbnRzLmdldCgmdmlkZW9FbGVtZW50KTsKICAgICBhdXRvJiBpbnRlcmZhY2UgPSBl bnN1cmVJbnRlcmZhY2UoY29udGV4dElkKTsKLSAgICBpZiAoaW50ZXJmYWNlLmFuaW1hdGlvblN0 YXRlKCkgIT0gVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlQ29udGV4dDo6QW5pbWF0aW9uVHlwZTo6 Tm9uZSkKKyAgICBpZiAoaW50ZXJmYWNlLmFuaW1hdGlvblN0YXRlKCkgIT0gVmlkZW9GdWxsc2Ny ZWVuSW50ZXJmYWNlQ29udGV4dDo6QW5pbWF0aW9uVHlwZTo6Tm9uZSkgeworICAgICAgICBjb21w bGV0aW9uSGFuZGxlcihmYWxzZSk7CiAgICAgICAgIHJldHVybjsKKyAgICB9CiAKICAgICBtX3Bh Z2UtPnNlbmRXaXRoQXN5bmNSZXBseShNZXNzYWdlczo6VmlkZW9GdWxsc2NyZWVuTWFuYWdlclBy b3h5OjpFeGl0RnVsbHNjcmVlbihjb250ZXh0SWQsIGlubGluZVZpZGVvRnJhbWUodmlkZW9FbGVt ZW50KSksIFtwcm90ZWN0ZWRUaGlzID0gbWFrZVJlZlB0cih0aGlzKSwgdGhpcywgY29udGV4dElk LCBjb21wbGV0aW9uSGFuZGxlciA9IFdURk1vdmUoY29tcGxldGlvbkhhbmRsZXIpXShhdXRvIHN1 Y2Nlc3MpIG11dGFibGUgewogICAgICAgICBpZiAoIXN1Y2Nlc3MpIHsK