218703 2020-11-09 03:53:20 -0800 [JSC] Tests with an '-e' parameters in requireOptions fail with bytecode cache enabled 2022-05-19 23:20:00 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 xan.lopez webkit-unassigned smoley xan.lopez ysuzuki oldest_to_newest 1705689 0 xan.lopez 2020-11-09 03:53:20 -0800 Some stress tests have a line like: //@ requireOptions("-e", "let iterations=1e5") if ["mips"].include?($architecture) to reduce the number of iterations on MIPS (since its bots are slower). This causes bugs with the bytecode cache enabled, seemingly because issues with (lack of) double quoting: stress/generator-cell-with-type.js.bytecode-cache: Could not open file: iterations=1e5 stress/generator-cell-with-type.js.bytecode-cache: Exception: ReferenceError: Can't find variable: let stress/generator-cell-with-type.js.bytecode-cache: global code@[Command Line]:1:4 This is a blocker to enable bytecode cache support on MIPS. 1870317 1 xan.lopez 2022-05-19 03:09:25 -0700 I'm pretty sure now this is just a generic bug in how parameters are dealt with in the bytecode cache helper script. Patch incoming. 1870322 2 459580 xan.lopez 2022-05-19 03:38:05 -0700 Created attachment 459580 v1 1870631 3 459580 ysuzuki 2022-05-19 22:37:35 -0700 Comment on attachment 459580 v1 r=me 1870637 4 ews-feeder 2022-05-19 23:19:58 -0700 Committed r294532 (250787@main): <https://commits.webkit.org/250787@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 459580. 459580 2022-05-19 03:38:05 -0700 2022-05-19 23:19:59 -0700 v1 0001-JSC-Tests-with-an-e-parameters-in-requireOptions-fai.patch text/plain 2174 xan.lopez RnJvbSA5MGRjMDIyZTNhYTE3ZGJjYmYwNjQ2YWIyMjJhMGMzYjczZjJkN2ZjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/WGFuPTIwTD1DMz1CM3Blej89IDx4YW5AaWdh bGlhLmNvbT4KRGF0ZTogVGh1LCAxOSBNYXkgMjAyMiAxMjozMToyOSArMDIwMApTdWJqZWN0OiBb UEFUQ0hdIFtKU0NdIFRlc3RzIHdpdGggYW4gJy1lJyBwYXJhbWV0ZXJzIGluIHJlcXVpcmVPcHRp b25zIGZhaWwKIHdpdGggYnl0ZWNvZGUgY2FjaGUgZW5hYmxlZCBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE4NzAzCgpSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K CkRvIG5vdCB0cnkgdG8gZnVydGhlciB0b2tlbml6ZSB0aGUgY29tbWFuZCBwYXJhbWV0ZXJzIHRv IHRoZSB0ZXN0IHJ1bgppbiB0aGUgYnl0ZWNvZGUgY2FjaGUgaGVscGVyIHNjcmlwdC4gVGhpcyB3 aWxsIGp1c3QgbWVzcyB1cCB0aGluZ3MKbGlrZSB0aGUgJy1lICJmb28gYmFyIicgZXh0cmEgb3B0 aW9ucywgYW5kIGl0J3Mgbm90IG5lZWRlZC4KCiogU2NyaXB0cy9qc2Mtc3RyZXNzLXRlc3QtaGVs cGVycy9ieXRlY29kZS1jYWNoZS10ZXN0LWhlbHBlci5zaDogZG8gbm90IHRva2VuaXplIHRoZSBh cmd1bWVudHMgdG8gdGhlIHNjcmlwdC4KKiBTY3JpcHRzL3J1bi1qc2Mtc3RyZXNzLXRlc3RzOiBh bHNvIHJ1biB0aGUgYnl0ZWNvZGUgY2FjaGUgdGVzdHMgb24gTUlQUy4KLS0tCiAuLi4vanNjLXN0 cmVzcy10ZXN0LWhlbHBlcnMvYnl0ZWNvZGUtY2FjaGUtdGVzdC1oZWxwZXIuc2ggICAgfCA1ICsr LS0tCiBUb29scy9TY3JpcHRzL3J1bi1qc2Mtc3RyZXNzLXRlc3RzICAgICAgICAgICAgICAgICAg ICAgICAgICAgfCAzICstLQogMiBmaWxlcyBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKyksIDUgZGVs ZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy9qc2Mtc3RyZXNzLXRlc3QtaGVs cGVycy9ieXRlY29kZS1jYWNoZS10ZXN0LWhlbHBlci5zaCBiL1Rvb2xzL1NjcmlwdHMvanNjLXN0 cmVzcy10ZXN0LWhlbHBlcnMvYnl0ZWNvZGUtY2FjaGUtdGVzdC1oZWxwZXIuc2gKaW5kZXggNGE0 YjNlOGRjNDNkLi5lZWU2MDhiZTJiN2QgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvanNjLXN0 cmVzcy10ZXN0LWhlbHBlcnMvYnl0ZWNvZGUtY2FjaGUtdGVzdC1oZWxwZXIuc2gKKysrIGIvVG9v bHMvU2NyaXB0cy9qc2Mtc3RyZXNzLXRlc3QtaGVscGVycy9ieXRlY29kZS1jYWNoZS10ZXN0LWhl bHBlci5zaApAQCAtMjUsMTcgKzI1LDE2IEBAIHNldCAtZQogCiBteXN5cygpIHsKICAgICBzZXQg K2UKLSAgICBldmFsICIkKiIKKyAgICAiJEAiCiAgICAgZXhpdENvZGU9JD8KICAgICBpZiBbICRl eGl0Q29kZSAhPSAwIF07IHRoZW4KLSAgICAgICAgZWNobyAiQ29tbWFuZCAnJConIGZhaWxlZCIK KyAgICAgICAgZWNobyAiQ29tbWFuZCAnJEAnIGZhaWxlZCIKICAgICAgICAgZXhpdCAkZXhpdENv ZGUKICAgICBmaQogfQogCiBmaWxlVGVtcGxhdGU9JDEKIHNoaWZ0Ci1yZXN0PSIkQCIKIAogZGlz a0NhY2hlUGF0aD0kKG1rdGVtcCAtZCAtdCAiJGZpbGVUZW1wbGF0ZSIpCiAKZGlmZiAtLWdpdCBh L1Rvb2xzL1NjcmlwdHMvcnVuLWpzYy1zdHJlc3MtdGVzdHMgYi9Ub29scy9TY3JpcHRzL3J1bi1q c2Mtc3RyZXNzLXRlc3RzCmluZGV4IDM0MzIyOWIxOTFmNC4uNDc3M2ExYWY3MGIzIDEwMDc1NQot LS0gYS9Ub29scy9TY3JpcHRzL3J1bi1qc2Mtc3RyZXNzLXRlc3RzCisrKyBiL1Rvb2xzL1Njcmlw dHMvcnVuLWpzYy1zdHJlc3MtdGVzdHMKQEAgLTEwMDQsOCArMTAwNCw3IEBAIGVuZAogZGVmIGJ5 dGVjb2RlQ2FjaGVUZW1wbGF0ZQogICAgIGlmICgkaG9zdE9TID09ICJkYXJ3aW4iKQogICAgICAg ICByZXR1cm4gImJ5dGVjb2RlLWNhY2hlIgotICAgIGVsc2lmICgkaG9zdE9TID09ICJsaW51eCIg JiYgJGFyY2hpdGVjdHVyZSAhPSAibWlwcyIpCi0gICAgICAgICMgRklYTUU6IG5lZWQgdG8gZml4 IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTg3MDMgdG8gZW5hYmxl IHRoaXMgb24gTGludXgvTUlQUy4KKyAgICBlbHNpZiAoJGhvc3RPUyA9PSAibGludXgiKQogICAg ICAgICByZXR1cm4gImJ5dGVjb2RlLWNhY2hlWFhYWFhYIgogICAgIGVuZAogICAgIG5pbAotLSAK Mi4zNi4xCgo=