218633 2020-11-05 13:22:40 -0800 [macOS] Remove mdnsresponder access from WebKit processes 2020-11-05 19:07:34 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham ap bfulgham pvollan webkit-bug-importer oldest_to_newest 1704993 0 bfulgham 2020-11-05 13:22:40 -0800 Now that all network loading (including media) happens in the Network process, we can remove an old permission to open outbound connections to mdnsresponder. 1704994 1 bfulgham 2020-11-05 13:23:40 -0800 Note: This is also not needed in the GPU Process. 1704996 2 413348 bfulgham 2020-11-05 13:25:45 -0800 Created attachment 413348 Patch 1704997 3 bfulgham 2020-11-05 13:26:26 -0800 <rdar://problem/69133548> 1705003 4 413348 pvollan 2020-11-05 13:35:49 -0800 Comment on attachment 413348 Patch Great! R=me. 1705039 5 413348 ap 2020-11-05 15:50:51 -0800 Comment on attachment 413348 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=413348&action=review > Source/WebKit/WebAuthnProcess/mac/com.apple.WebKit.WebAuthnProcess.sb.in:-388 > - (literal "/private/var/run/mDNSResponder") Is this OK to do even though <rdar://problem/38240572> is NOT fixed? Looking as what it says, I suspect that mDNSResponder is still needed. 1705050 6 bfulgham 2020-11-05 16:26:34 -0800 (In reply to Alexey Proskuryakov from comment #5) > Comment on attachment 413348 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=413348&action=review > > > Source/WebKit/WebAuthnProcess/mac/com.apple.WebKit.WebAuthnProcess.sb.in:-388 > > - (literal "/private/var/run/mDNSResponder") > > Is this OK to do even though <rdar://problem/38240572> is NOT fixed? Looking > as what it says, I suspect that mDNSResponder is still needed. Yes. Although that particular CoreMedia bug is not fixed, we have moved all network loads out of the media process into WebKit. I found that trace (and filed the radar), and was not able to produce the same issue under modern WebKit. 1705053 7 ews-feeder 2020-11-05 16:32:07 -0800 Committed r269491: <https://trac.webkit.org/changeset/269491> All reviewed patches have been landed. Closing bug and clearing flags on attachment 413348. 1705095 8 bfulgham 2020-11-05 18:24:35 -0800 Reopening to attach new patch. 1705096 9 413382 bfulgham 2020-11-05 18:24:36 -0800 Created attachment 413382 Patch for landing 1705101 10 ews-feeder 2020-11-05 19:07:33 -0800 Committed r269501: <https://trac.webkit.org/changeset/269501> All reviewed patches have been landed. Closing bug and clearing flags on attachment 413382. 413348 2020-11-05 13:25:45 -0800 2020-11-05 18:24:33 -0800 Patch bug-218633-20201105132544.patch text/plain 3790 bfulgham U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5MzM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDYzODhiOWMzYTJhZGE3MTk4 MDJhOTEyN2Y1YTYwNWE1OWY5OGEwODIuLjNhYzg4ZTEwMjg5ZDcxY2JiMzM2NWVjYjVmNjEyMDcw OGIwNDBiNmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMjAtMTEtMDUgIEJyZW50IEZ1 bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgW21hY09TXSBSZW1vdmUgbWRu c3Jlc3BvbmRlciBhY2Nlc3MgZnJvbSBXZWJLaXQgcHJvY2Vzc2VzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTg2MzMKKyAgICAgICAgPHJkYXI6Ly9w cm9ibGVtLzY5MTMzNTQ4PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIE5vdyB0aGF0IGFsbCBuZXR3b3JrIGxvYWRpbmcgKGluY2x1ZGluZyBtZWRpYSkg aGFwcGVucyBpbiB0aGUgTmV0d29yayBwcm9jZXNzLAorICAgICAgICB3ZSBjYW4gcmVtb3ZlIGFu IG9sZCBwZXJtaXNzaW9uIHRvIG9wZW4gb3V0Ym91bmQgY29ubmVjdGlvbnMgdG8gbWRuc3Jlc3Bv bmRlci4KKyAgICAgICAgVGhpcyBpcyBhbHNvIHVubmVlZGVkIGluIHRoZSBHUFUgcHJvY2Vzcywg Zm9yIHRoZSBzYW1lIHJlYXNvbi4KKworICAgICAgICBJIG5vdGljZWQgdGhhdCB0aGUgbmV3IFdl YkF1dGhuIHByb2Nlc3Mgc2FuZGJveCBtaXN0YWtlbmx5IGluY2x1ZGVkIHRoaXMsCisgICAgICAg IGFuZCByZW1vdmVkIGl0IHRoZXJlLCB0b28uCisKKyAgICAgICAgKiBHUFVQcm9jZXNzL21hYy9j b20uYXBwbGUuV2ViS2l0LkdQVVByb2Nlc3Muc2IuaW46CisgICAgICAgICogV2ViQXV0aG5Qcm9j ZXNzL21hYy9jb20uYXBwbGUuV2ViS2l0LldlYkF1dGhuUHJvY2Vzcy5zYi5pbjoKKyAgICAgICAg KiBXZWJQcm9jZXNzL2NvbS5hcHBsZS5XZWJQcm9jZXNzLnNiLmluOgorCiAyMDIwLTExLTAzICBC cmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgogCiAgICAgICAgIFttYWNPU10gcmVt b3ZlIHN5c2N0bC5vaWRmbXQuIGFjY2VzcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9HUFVQ cm9jZXNzL21hYy9jb20uYXBwbGUuV2ViS2l0LkdQVVByb2Nlc3Muc2IuaW4gYi9Tb3VyY2UvV2Vi S2l0L0dQVVByb2Nlc3MvbWFjL2NvbS5hcHBsZS5XZWJLaXQuR1BVUHJvY2Vzcy5zYi5pbgppbmRl eCBlMjhhZTNmYzgzYzg2MjJhMTMxNGEyMTA5ZjU2YTY3NGYxYTkxZmRhLi4zYWUyZWMzZmJlNmRj MTg1MGZmMmFlYjQ3ZmRlN2FmNjQ0ZmIxOWNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L0dQ VVByb2Nlc3MvbWFjL2NvbS5hcHBsZS5XZWJLaXQuR1BVUHJvY2Vzcy5zYi5pbgorKysgYi9Tb3Vy Y2UvV2ViS2l0L0dQVVByb2Nlc3MvbWFjL2NvbS5hcHBsZS5XZWJLaXQuR1BVUHJvY2Vzcy5zYi5p bgpAQCAtNjY5LDEwICs2NjksNiBAQAogCiA7OyBOZXR3b3JraW5nCiAoYWxsb3cgbmV0d29yay1v dXRib3VuZAotICAgICAgIDs7IExvY2FsIG1ETlNSZXNwb25kZXIgZm9yIEROUywgYXJiaXRyYXJ5 IG91dGJvdW5kIFRDUAotICAgICAgIDs7IE5vdGU6IFRoaXMgaXMgbmVlZGVkIGZvciBzb21lIG1l ZGlhIHBsYXliYWNrIGZlYXR1cmVzLiA8cmRhcjovL3Byb2JsZW0vMzgxOTE1NzQ+Ci0gICAgICAg OzsgUmVtb3ZlIHRoaXMgcGVybWlzc2lvbiB3aGVuIDxyZGFyOi8vcHJvYmxlbS8zODI0MDU3Mj4g aXMgZml4ZWQuCi0gICAgICAgKGxpdGVyYWwgIi9wcml2YXRlL3Zhci9ydW4vbUROU1Jlc3BvbmRl ciIpCiAgICAgICAgOzsgT2JqQyBtYXBfaW1hZ2VzIG5lZWRzIHRvIHNlbmQgbG9nZ2luZyBkYXRh IHRvIHN5c2xvZy4gPHJkYXI6Ly9wcm9ibGVtLzM5Nzc4OTE4PgogICAgICAgIChsaXRlcmFsICIv cHJpdmF0ZS92YXIvcnVuL3N5c2xvZyIpCiAgICAgICAgKHJlbW90ZSB0Y3ApKQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9XZWJBdXRoblByb2Nlc3MvbWFjL2NvbS5hcHBsZS5XZWJLaXQuV2Vi QXV0aG5Qcm9jZXNzLnNiLmluIGIvU291cmNlL1dlYktpdC9XZWJBdXRoblByb2Nlc3MvbWFjL2Nv bS5hcHBsZS5XZWJLaXQuV2ViQXV0aG5Qcm9jZXNzLnNiLmluCmluZGV4IDc0YmYxNzc4MTU1NGZi YmFlZGNlNjU2YWJmZWE5ZjJiY2EyOGYzMDAuLmZjNWFlNjViMzc2NGFhNmE3ZGIwMmEwMmY5MmZm MzQzYWUzMTQ0ZTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViQXV0aG5Qcm9jZXNzL21h Yy9jb20uYXBwbGUuV2ViS2l0LldlYkF1dGhuUHJvY2Vzcy5zYi5pbgorKysgYi9Tb3VyY2UvV2Vi S2l0L1dlYkF1dGhuUHJvY2Vzcy9tYWMvY29tLmFwcGxlLldlYktpdC5XZWJBdXRoblByb2Nlc3Mu c2IuaW4KQEAgLTM4MiwxMCArMzgyLDYgQEAKIAogOzsgTmV0d29ya2luZwogKGFsbG93IG5ldHdv cmstb3V0Ym91bmQKLSAgICAgICA7OyBMb2NhbCBtRE5TUmVzcG9uZGVyIGZvciBETlMsIGFyYml0 cmFyeSBvdXRib3VuZCBUQ1AKLSAgICAgICA7OyBOb3RlOiBUaGlzIGlzIG5lZWRlZCBmb3Igc29t ZSBtZWRpYSBwbGF5YmFjayBmZWF0dXJlcy4gPHJkYXI6Ly9wcm9ibGVtLzM4MTkxNTc0PgotICAg ICAgIDs7IFJlbW92ZSB0aGlzIHBlcm1pc3Npb24gd2hlbiA8cmRhcjovL3Byb2JsZW0vMzgyNDA1 NzI+IGlzIGZpeGVkLgotICAgICAgIChsaXRlcmFsICIvcHJpdmF0ZS92YXIvcnVuL21ETlNSZXNw b25kZXIiKQogICAgICAgIDs7IE9iakMgbWFwX2ltYWdlcyBuZWVkcyB0byBzZW5kIGxvZ2dpbmcg ZGF0YSB0byBzeXNsb2cuIDxyZGFyOi8vcHJvYmxlbS8zOTc3ODkxOD4KICAgICAgICAobGl0ZXJh bCAiL3ByaXZhdGUvdmFyL3J1bi9zeXNsb2ciKQogICAgICAgIChyZW1vdGUgdGNwKSkKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9jb20uYXBwbGUuV2ViUHJvY2Vzcy5zYi5p biBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9jb20uYXBwbGUuV2ViUHJvY2Vzcy5zYi5pbgpp bmRleCBmZGNlMzg0NDFjZDJjYmQ3MGJkMTY5NTFjMWNkZWFjZWMwNTA4MTk5Li42NzhlY2NkZTdi ZmZkMTQwZmY4Y2Q0NDRiOGNiMTEyY2E0M2M2MzUzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L1dlYlByb2Nlc3MvY29tLmFwcGxlLldlYlByb2Nlc3Muc2IuaW4KKysrIGIvU291cmNlL1dlYktp dC9XZWJQcm9jZXNzL2NvbS5hcHBsZS5XZWJQcm9jZXNzLnNiLmluCkBAIC04MzYsMTAgKzgzNiw2 IEBACiAKIDs7IE5ldHdvcmtpbmcKIChhbGxvdyBuZXR3b3JrLW91dGJvdW5kCi0gICAgICAgOzsg TG9jYWwgbUROU1Jlc3BvbmRlciBmb3IgRE5TLCBhcmJpdHJhcnkgb3V0Ym91bmQgVENQCi0gICAg ICAgOzsgTm90ZTogVGhpcyBpcyBuZWVkZWQgZm9yIHNvbWUgbWVkaWEgcGxheWJhY2sgZmVhdHVy ZXMuIDxyZGFyOi8vcHJvYmxlbS8zODE5MTU3ND4KLSAgICAgICA7OyBSZW1vdmUgdGhpcyBwZXJt aXNzaW9uIHdoZW4gPHJkYXI6Ly9wcm9ibGVtLzM4MjQwNTcyPiBpcyBmaXhlZC4KLSAgICAgICAo bGl0ZXJhbCAiL3ByaXZhdGUvdmFyL3J1bi9tRE5TUmVzcG9uZGVyIikKICAgICAgICA7OyBPYmpD IG1hcF9pbWFnZXMgbmVlZHMgdG8gc2VuZCBsb2dnaW5nIGRhdGEgdG8gc3lzbG9nLiA8cmRhcjov L3Byb2JsZW0vMzk3Nzg5MTg+CiAgICAgICAgKGxpdGVyYWwgIi9wcml2YXRlL3Zhci9ydW4vc3lz bG9nIikKICAgICAgICAocmVtb3RlIHRjcCkpCg== 413382 2020-11-05 18:24:36 -0800 2020-11-05 19:07:33 -0800 Patch for landing bug-218633-20201105182436.patch text/plain 2664 bfulgham U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5NTAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDRkNjVjODY5M2RlNjg5N2Zi YmIzZDUyNmY1MTdlY2I0MWMwYWNmOWIuLjRkNTVkM2JlNDExZDM4ZGRkMzhiYzZlYWRjN2M2ZTYz ZDM0MzI4ZTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjAtMTEtMDUgIEJyZW50IEZ1 bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgW21hY09TXSBSZW1vdmUgbWRu c3Jlc3BvbmRlciBhY2Nlc3MgZnJvbSBXZWJLaXQgcHJvY2Vzc2VzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTg2MzMKKyAgICAgICAgPHJkYXI6Ly9w cm9ibGVtLzY5MTMzNTQ4PgorCisgICAgICAgIFVucmV2aWV3ZWQgZm9sbG93LXVwOiBNYWtlIHRo ZSBzYW5kYm94IHJ1bGUgY29uZGl0aW9uYWwgb24gcmVjZW50IG1hY09TIHRvCisgICAgICAgIGF2 b2lkIGJyZWFraW5nIFNUUCB1c2Ugb24gb2xkZXIgbWFjT1MgcmVsZWFzZXMuCisKKyAgICAgICAg KiBHUFVQcm9jZXNzL21hYy9jb20uYXBwbGUuV2ViS2l0LkdQVVByb2Nlc3Muc2IuaW46CisgICAg ICAgICogV2ViUHJvY2Vzcy9jb20uYXBwbGUuV2ViUHJvY2Vzcy5zYi5pbjoKKwogMjAyMC0xMS0w NSAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAg IEFkZCBudWxsIGNoZWNrcyBlZmZlY3RpdmVseSBpbiBVc2VySW5wdXRCcmlkZ2UKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQvR1BVUHJvY2Vzcy9tYWMvY29tLmFwcGxlLldlYktpdC5HUFVQcm9j ZXNzLnNiLmluIGIvU291cmNlL1dlYktpdC9HUFVQcm9jZXNzL21hYy9jb20uYXBwbGUuV2ViS2l0 LkdQVVByb2Nlc3Muc2IuaW4KaW5kZXggM2FlMmVjM2ZiZTZkYzE4NTBmZjJhZWI0N2ZkZTdhZjY0 NGZiMTljYS4uZjcyMzBiMzIwZjllNGM3MjcyZmM2MzJiZjJiOWE5ZWMyMjEwMDFlMiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdC9HUFVQcm9jZXNzL21hYy9jb20uYXBwbGUuV2ViS2l0LkdQVVBy b2Nlc3Muc2IuaW4KKysrIGIvU291cmNlL1dlYktpdC9HUFVQcm9jZXNzL21hYy9jb20uYXBwbGUu V2ViS2l0LkdQVVByb2Nlc3Muc2IuaW4KQEAgLTY2OSw2ICs2NjksMTIgQEAKIAogOzsgTmV0d29y a2luZwogKGFsbG93IG5ldHdvcmstb3V0Ym91bmQKKyNpZiBfX01BQ19PU19YX1ZFUlNJT05fTUlO X1JFUVVJUkVEIDw9IDEwMTUwMAorICAgICAgIDs7IExvY2FsIG1ETlNSZXNwb25kZXIgZm9yIERO UywgYXJiaXRyYXJ5IG91dGJvdW5kIFRDUAorICAgICAgIDs7IE5vdGU6IFRoaXMgaXMgbmVlZGVk IGZvciBzb21lIG1lZGlhIHBsYXliYWNrIGZlYXR1cmVzLiA8cmRhcjovL3Byb2JsZW0vMzgxOTE1 NzQ+CisgICAgICAgOzsgUmVtb3ZlIHRoaXMgcGVybWlzc2lvbiB3aGVuIDxyZGFyOi8vcHJvYmxl bS8zODI0MDU3Mj4gaXMgZml4ZWQuCisgICAgICAgKGxpdGVyYWwgIi9wcml2YXRlL3Zhci9ydW4v bUROU1Jlc3BvbmRlciIpCisjZW5kaWYKICAgICAgICA7OyBPYmpDIG1hcF9pbWFnZXMgbmVlZHMg dG8gc2VuZCBsb2dnaW5nIGRhdGEgdG8gc3lzbG9nLiA8cmRhcjovL3Byb2JsZW0vMzk3Nzg5MTg+ CiAgICAgICAgKGxpdGVyYWwgIi9wcml2YXRlL3Zhci9ydW4vc3lzbG9nIikKICAgICAgICAocmVt b3RlIHRjcCkpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvY29tLmFwcGxl LldlYlByb2Nlc3Muc2IuaW4gYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvY29tLmFwcGxlLldl YlByb2Nlc3Muc2IuaW4KaW5kZXggNTY5ODdhNDgwODFmZmY2MTg0OWNhOGQ2OGQ4ZTJkM2I4MTYw Y2NiMi4uZjQxOWVhYTIyNDc4OTgwY2JmNjIzYWNhYTQwNmViMzFkMTY1ZWQxYyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL2NvbS5hcHBsZS5XZWJQcm9jZXNzLnNiLmluCisr KyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9jb20uYXBwbGUuV2ViUHJvY2Vzcy5zYi5pbgpA QCAtODM2LDYgKzgzNiwxMiBAQAogCiA7OyBOZXR3b3JraW5nCiAoYWxsb3cgbmV0d29yay1vdXRi b3VuZAorI2lmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPD0gMTAxNTAwCisgICAg ICAgOzsgTG9jYWwgbUROU1Jlc3BvbmRlciBmb3IgRE5TLCBhcmJpdHJhcnkgb3V0Ym91bmQgVENQ CisgICAgICAgOzsgTm90ZTogVGhpcyBpcyBuZWVkZWQgZm9yIHNvbWUgbWVkaWEgcGxheWJhY2sg ZmVhdHVyZXMuIDxyZGFyOi8vcHJvYmxlbS8zODE5MTU3ND4KKyAgICAgICA7OyBSZW1vdmUgdGhp cyBwZXJtaXNzaW9uIHdoZW4gPHJkYXI6Ly9wcm9ibGVtLzM4MjQwNTcyPiBpcyBmaXhlZC4KKyAg ICAgICAobGl0ZXJhbCAiL3ByaXZhdGUvdmFyL3J1bi9tRE5TUmVzcG9uZGVyIikKKyNlbmRpZgog ICAgICAgIDs7IE9iakMgbWFwX2ltYWdlcyBuZWVkcyB0byBzZW5kIGxvZ2dpbmcgZGF0YSB0byBz eXNsb2cuIDxyZGFyOi8vcHJvYmxlbS8zOTc3ODkxOD4KICAgICAgICAobGl0ZXJhbCAiL3ByaXZh dGUvdmFyL3J1bi9zeXNsb2ciKQogICAgICAgIChyZW1vdGUgdGNwKSkK