218624 2020-11-05 10:39:15 -0800 Change RELEASE_ASSERT to use branch+crash inside HashTable.h 2020-11-05 15:02:50 -0800 1 1 1 Unclassified WebKit JavaScriptCore Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam benjamin cdumez cmarcelo ews-watchlist mark.lam tzagallo webkit-bug-importer oldest_to_newest 1704921 0 saam 2020-11-05 10:39:15 -0800 ... 1704922 1 saam 2020-11-05 10:42:27 -0800 <rdar://problem/70901101> 1704929 2 413324 saam 2020-11-05 10:56:36 -0800 Created attachment 413324 patch 1704935 3 413324 mark.lam 2020-11-05 11:02:55 -0800 Comment on attachment 413324 patch r=me. Can you introduce a HASH_TABLE_ASSERT macro to encapsulate this instead? You can #undef it at the end of the file. 1704936 4 mark.lam 2020-11-05 11:03:28 -0800 /HASH_TABLE_ASSERT/HASH_TABLE_RELEASE_ASSERT/ 1704940 5 413328 saam 2020-11-05 11:12:02 -0800 Created attachment 413328 patch for landing 1705022 6 ews-feeder 2020-11-05 15:02:46 -0800 Committed r269478: <https://trac.webkit.org/changeset/269478> All reviewed patches have been landed. Closing bug and clearing flags on attachment 413328. 413324 2020-11-05 10:56:36 -0800 2020-11-05 11:12:02 -0800 patch c-backup.diff text/plain 2954 saam SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyNjk0NTApCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDIwLTExLTA1ICBTYWFtIEJhcmF0aSAgPHNiYXJh dGlAYXBwbGUuY29tPgorCisgICAgICAgIENoYW5nZSBSRUxFQVNFX0FTU0VSVCB0byB1c2UgYnJh bmNoK2NyYXNoIGluc2lkZSBIYXNoVGFibGUuaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE4NjI0CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83MDkw MTEwMT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBU aGUgYXNzZXJ0aW9ucyBhZGRlZCBpbiByMjY5MDE3IHVzZWQgUkVMRUFTRV9BU1NFUlQuIFJFTEVB U0VfQVNTRVJUCisgICAgICAgIGlzIGltcGxlbWVudGVkIGFzIGludm9raW5nIFdURkNyYXNoV2l0 aEluZm8sIHdoaWNoIGRvZXMgYSBidW5jaCBvZiByZWdpc3RlcgorICAgICAgICBhcmd1bWVudC9t b3Zlcy4gRG9pbmcgdGhpcyBpbiBpbmxpbmVkIGhhc2ggdGFibGUgY29kZSBibG9hdHMgV0sgYmlu YXJpZXMKKyAgICAgICAgYnkgYSBsb3QuIFRoaXMgcGF0Y2ggY2hhbmdlcyBpdCBzbyB3ZSBqdXN0 IGJyYW5jaCtjcmFzaCBvbiB0aGUgc2FtZSBjb25kaXRpb24uCisKKyAgICAgICAgKiB3dGYvSGFz aFRhYmxlLmg6CisgICAgICAgIChXVEY6OktleVRyYWl0cz46OmlubGluZUxvb2t1cCk6CisgICAg ICAgIChXVEY6OktleVRyYWl0cz46Omxvb2t1cEZvcldyaXRpbmcpOgorICAgICAgICAoV1RGOjpL ZXlUcmFpdHM+OjpmdWxsTG9va3VwRm9yV3JpdGluZyk6CisgICAgICAgIChXVEY6OktleVRyYWl0 cz46OmFkZFVuaXF1ZUZvckluaXRpYWxpemF0aW9uKToKKyAgICAgICAgKFdURjo6S2V5VHJhaXRz Pjo6YWRkKToKKwogMjAyMC0xMS0wNSAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+ CiAKICAgICAgICAgQ29uc2lkZXIgYmxvY2tpbmcgcG9ydHMgNTA2MCBhbmQgNTA2MQpJbmRleDog U291cmNlL1dURi93dGYvSGFzaFRhYmxlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dURi93dGYv SGFzaFRhYmxlLmgJKHJldmlzaW9uIDI2OTM5MSkKKysrIFNvdXJjZS9XVEYvd3RmL0hhc2hUYWJs ZS5oCSh3b3JraW5nIGNvcHkpCkBAIC03MTUsNyArNzE1LDggQEAgREVDTEFSRV9BTExPQ0FUT1Jf V0lUSF9IRUFQX0lERU5USUZJRVIoSAogICAgICAgICAgICAgaWYgKGsgPT0gMCkKICAgICAgICAg ICAgICAgICBrID0gMSB8IGRvdWJsZUhhc2goaCk7CiAgICAgICAgICAgICBpID0gKGkgKyBrKSAm IHNpemVNYXNrOwotICAgICAgICAgICAgUkVMRUFTRV9BU1NFUlQoaSAhPSBpbml0aWFsSW5kZXgp OworICAgICAgICAgICAgaWYgKFVOTElLRUxZKGkgPT0gaW5pdGlhbEluZGV4KSkKKyAgICAgICAg ICAgICAgICBDUkFTSCgpOwogICAgICAgICB9CiAgICAgfQogCkBAIC03NzgsNyArNzc5LDggQEAg REVDTEFSRV9BTExPQ0FUT1JfV0lUSF9IRUFQX0lERU5USUZJRVIoSAogICAgICAgICAgICAgaWYg KGsgPT0gMCkKICAgICAgICAgICAgICAgICBrID0gMSB8IGRvdWJsZUhhc2goaCk7CiAgICAgICAg ICAgICBpID0gKGkgKyBrKSAmIHNpemVNYXNrOwotICAgICAgICAgICAgUkVMRUFTRV9BU1NFUlQo aSAhPSBpbml0aWFsSW5kZXgpOworICAgICAgICAgICAgaWYgKFVOTElLRUxZKGkgPT0gaW5pdGlh bEluZGV4KSkKKyAgICAgICAgICAgICAgICBDUkFTSCgpOwogICAgICAgICB9CiAgICAgfQogCkBA IC04NDEsNyArODQzLDggQEAgREVDTEFSRV9BTExPQ0FUT1JfV0lUSF9IRUFQX0lERU5USUZJRVIo SAogICAgICAgICAgICAgaWYgKGsgPT0gMCkKICAgICAgICAgICAgICAgICBrID0gMSB8IGRvdWJs ZUhhc2goaCk7CiAgICAgICAgICAgICBpID0gKGkgKyBrKSAmIHNpemVNYXNrOwotICAgICAgICAg ICAgUkVMRUFTRV9BU1NFUlQoaSAhPSBpbml0aWFsSW5kZXgpOworICAgICAgICAgICAgaWYgKFVO TElLRUxZKGkgPT0gaW5pdGlhbEluZGV4KSkKKyAgICAgICAgICAgICAgICBDUkFTSCgpOwogICAg ICAgICB9CiAgICAgfQogCkBAIC04OTIsNyArODk1LDggQEAgREVDTEFSRV9BTExPQ0FUT1JfV0lU SF9IRUFQX0lERU5USUZJRVIoSAogICAgICAgICAgICAgaWYgKGsgPT0gMCkKICAgICAgICAgICAg ICAgICBrID0gMSB8IGRvdWJsZUhhc2goaCk7CiAgICAgICAgICAgICBpID0gKGkgKyBrKSAmIHNp emVNYXNrOwotICAgICAgICAgICAgUkVMRUFTRV9BU1NFUlQoaSAhPSBpbml0aWFsSW5kZXgpOwor ICAgICAgICAgICAgaWYgKFVOTElLRUxZKGkgPT0gaW5pdGlhbEluZGV4KSkKKyAgICAgICAgICAg ICAgICBDUkFTSCgpOwogICAgICAgICB9CiAKICAgICAgICAgSGFzaFRyYW5zbGF0b3I6OnRyYW5z bGF0ZSgqZW50cnksIHN0ZDo6Zm9yd2FyZDxUPihrZXkpLCBzdGQ6OmZvcndhcmQ8RXh0cmE+KGV4 dHJhKSk7CkBAIC05OTIsNyArOTk2LDggQEAgREVDTEFSRV9BTExPQ0FUT1JfV0lUSF9IRUFQX0lE RU5USUZJRVIoSAogICAgICAgICAgICAgaWYgKGsgPT0gMCkKICAgICAgICAgICAgICAgICBrID0g MSB8IGRvdWJsZUhhc2goaCk7CiAgICAgICAgICAgICBpID0gKGkgKyBrKSAmIHNpemVNYXNrOwot ICAgICAgICAgICAgUkVMRUFTRV9BU1NFUlQoaSAhPSBpbml0aWFsSW5kZXgpOworICAgICAgICAg ICAgaWYgKFVOTElLRUxZKGkgPT0gaW5pdGlhbEluZGV4KSkKKyAgICAgICAgICAgICAgICBDUkFT SCgpOwogICAgICAgICB9CiAKICAgICAgICAgaWYgKGRlbGV0ZWRFbnRyeSkgewo= 413328 2020-11-05 11:12:02 -0800 2020-11-05 15:02:48 -0800 patch for landing c-backup.diff text/plain 3343 saam SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyNjk0NTApCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDIwLTExLTA1ICBTYWFtIEJhcmF0aSAgPHNiYXJh dGlAYXBwbGUuY29tPgorCisgICAgICAgIENoYW5nZSBSRUxFQVNFX0FTU0VSVCB0byB1c2UgYnJh bmNoK2NyYXNoIGluc2lkZSBIYXNoVGFibGUuaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE4NjI0CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83MDkw MTEwMT4KKworICAgICAgICBSZXZpZXdlZCBieSBNYXJrIExhbS4KKworICAgICAgICBUaGUgYXNz ZXJ0aW9ucyBhZGRlZCBpbiByMjY5MDE3IHVzZWQgUkVMRUFTRV9BU1NFUlQuIFJFTEVBU0VfQVNT RVJUCisgICAgICAgIGlzIGltcGxlbWVudGVkIGFzIGludm9raW5nIFdURkNyYXNoV2l0aEluZm8s IHdoaWNoIGRvZXMgYSBidW5jaCBvZiByZWdpc3RlcgorICAgICAgICBhcmd1bWVudC9tb3Zlcy4g RG9pbmcgdGhpcyBpbiBpbmxpbmVkIGhhc2ggdGFibGUgY29kZSBibG9hdHMgV0sgYmluYXJpZXMK KyAgICAgICAgYnkgYSBsb3QuIFRoaXMgcGF0Y2ggY2hhbmdlcyBpdCBzbyB3ZSBqdXN0IGJyYW5j aCtjcmFzaCBvbiB0aGUgc2FtZSBjb25kaXRpb24uCisKKyAgICAgICAgKiB3dGYvSGFzaFRhYmxl Lmg6CisgICAgICAgIChXVEY6OktleVRyYWl0cz46OmlubGluZUxvb2t1cCk6CisgICAgICAgIChX VEY6OktleVRyYWl0cz46Omxvb2t1cEZvcldyaXRpbmcpOgorICAgICAgICAoV1RGOjpLZXlUcmFp dHM+OjpmdWxsTG9va3VwRm9yV3JpdGluZyk6CisgICAgICAgIChXVEY6OktleVRyYWl0cz46OmFk ZFVuaXF1ZUZvckluaXRpYWxpemF0aW9uKToKKyAgICAgICAgKFdURjo6S2V5VHJhaXRzPjo6YWRk KToKKwogMjAyMC0xMS0wNSAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAg ICAgICAgQ29uc2lkZXIgYmxvY2tpbmcgcG9ydHMgNTA2MCBhbmQgNTA2MQpJbmRleDogU291cmNl L1dURi93dGYvSGFzaFRhYmxlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dURi93dGYvSGFzaFRh YmxlLmgJKHJldmlzaW9uIDI2OTM5MSkKKysrIFNvdXJjZS9XVEYvd3RmL0hhc2hUYWJsZS5oCSh3 b3JraW5nIGNvcHkpCkBAIC01OSw2ICs1OSw4IEBAIERFQ0xBUkVfQUxMT0NBVE9SX1dJVEhfSEVB UF9JREVOVElGSUVSKEgKICNkZWZpbmUgQ0hFQ0tfSEFTSFRBQkxFX1VTRV9BRlRFUl9ERVNUUlVD VElPTiAxCiAjZW5kaWYKIAorI2RlZmluZSBIQVNIX1RBQkxFX1JFTEVBU0VfQVNTRVJUKGNvbmRp dGlvbikgaWYgKFVOTElLRUxZKCEoY29uZGl0aW9uKSkpIENSQVNIKCk7CisKICNpZiBEVU1QX0hB U0hUQUJMRV9TVEFUUwogCiAgICAgc3RydWN0IEhhc2hUYWJsZVN0YXRzIHsKQEAgLTcxNSw3ICs3 MTcsNyBAQCBERUNMQVJFX0FMTE9DQVRPUl9XSVRIX0hFQVBfSURFTlRJRklFUihICiAgICAgICAg ICAgICBpZiAoayA9PSAwKQogICAgICAgICAgICAgICAgIGsgPSAxIHwgZG91YmxlSGFzaChoKTsK ICAgICAgICAgICAgIGkgPSAoaSArIGspICYgc2l6ZU1hc2s7Ci0gICAgICAgICAgICBSRUxFQVNF X0FTU0VSVChpICE9IGluaXRpYWxJbmRleCk7CisgICAgICAgICAgICBIQVNIX1RBQkxFX1JFTEVB U0VfQVNTRVJUKGkgIT0gaW5pdGlhbEluZGV4KTsKICAgICAgICAgfQogICAgIH0KIApAQCAtNzc4 LDcgKzc4MCw3IEBAIERFQ0xBUkVfQUxMT0NBVE9SX1dJVEhfSEVBUF9JREVOVElGSUVSKEgKICAg ICAgICAgICAgIGlmIChrID09IDApCiAgICAgICAgICAgICAgICAgayA9IDEgfCBkb3VibGVIYXNo KGgpOwogICAgICAgICAgICAgaSA9IChpICsgaykgJiBzaXplTWFzazsKLSAgICAgICAgICAgIFJF TEVBU0VfQVNTRVJUKGkgIT0gaW5pdGlhbEluZGV4KTsKKyAgICAgICAgICAgIEhBU0hfVEFCTEVf UkVMRUFTRV9BU1NFUlQoaSAhPSBpbml0aWFsSW5kZXgpOwogICAgICAgICB9CiAgICAgfQogCkBA IC04NDEsNyArODQzLDcgQEAgREVDTEFSRV9BTExPQ0FUT1JfV0lUSF9IRUFQX0lERU5USUZJRVIo SAogICAgICAgICAgICAgaWYgKGsgPT0gMCkKICAgICAgICAgICAgICAgICBrID0gMSB8IGRvdWJs ZUhhc2goaCk7CiAgICAgICAgICAgICBpID0gKGkgKyBrKSAmIHNpemVNYXNrOwotICAgICAgICAg ICAgUkVMRUFTRV9BU1NFUlQoaSAhPSBpbml0aWFsSW5kZXgpOworICAgICAgICAgICAgSEFTSF9U QUJMRV9SRUxFQVNFX0FTU0VSVChpICE9IGluaXRpYWxJbmRleCk7CiAgICAgICAgIH0KICAgICB9 CiAKQEAgLTg5Miw3ICs4OTQsNyBAQCBERUNMQVJFX0FMTE9DQVRPUl9XSVRIX0hFQVBfSURFTlRJ RklFUihICiAgICAgICAgICAgICBpZiAoayA9PSAwKQogICAgICAgICAgICAgICAgIGsgPSAxIHwg ZG91YmxlSGFzaChoKTsKICAgICAgICAgICAgIGkgPSAoaSArIGspICYgc2l6ZU1hc2s7Ci0gICAg ICAgICAgICBSRUxFQVNFX0FTU0VSVChpICE9IGluaXRpYWxJbmRleCk7CisgICAgICAgICAgICBI QVNIX1RBQkxFX1JFTEVBU0VfQVNTRVJUKGkgIT0gaW5pdGlhbEluZGV4KTsKICAgICAgICAgfQog CiAgICAgICAgIEhhc2hUcmFuc2xhdG9yOjp0cmFuc2xhdGUoKmVudHJ5LCBzdGQ6OmZvcndhcmQ8 VD4oa2V5KSwgc3RkOjpmb3J3YXJkPEV4dHJhPihleHRyYSkpOwpAQCAtOTkyLDcgKzk5NCw3IEBA IERFQ0xBUkVfQUxMT0NBVE9SX1dJVEhfSEVBUF9JREVOVElGSUVSKEgKICAgICAgICAgICAgIGlm IChrID09IDApCiAgICAgICAgICAgICAgICAgayA9IDEgfCBkb3VibGVIYXNoKGgpOwogICAgICAg ICAgICAgaSA9IChpICsgaykgJiBzaXplTWFzazsKLSAgICAgICAgICAgIFJFTEVBU0VfQVNTRVJU KGkgIT0gaW5pdGlhbEluZGV4KTsKKyAgICAgICAgICAgIEhBU0hfVEFCTEVfUkVMRUFTRV9BU1NF UlQoaSAhPSBpbml0aWFsSW5kZXgpOwogICAgICAgICB9CiAKICAgICAgICAgaWYgKGRlbGV0ZWRF bnRyeSkgewpAQCAtMTY1Miw2ICsxNjU0LDggQEAgREVDTEFSRV9BTExPQ0FUT1JfV0lUSF9IRUFQ X0lERU5USUZJRVIoSAogICAgICAgICByZXR1cm4gYS5tX2ltcGwgIT0gYi5tX2ltcGw7CiAgICAg fQogCisjdW5kZWYgSEFTSF9UQUJMRV9SRUxFQVNFX0FTU0VSVAorCiB9IC8vIG5hbWVzcGFjZSBX VEYKIAogI2luY2x1ZGUgPHd0Zi9IYXNoSXRlcmF0b3JzLmg+Cg==