218622 2020-11-05 10:15:12 -0800 Add null checks effectively in UserInputBridge 2020-11-05 18:01:41 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen webkit-bug-importer wenson_hsieh oldest_to_newest 1704914 0 achristensen 2020-11-05 10:15:12 -0800 Add null checks effectively in UserInputBridge 1704915 1 413319 achristensen 2020-11-05 10:16:16 -0800 Created attachment 413319 Patch 1704916 2 achristensen 2020-11-05 10:16:19 -0800 <rdar://problem/70724960> 1705088 3 ews-feeder 2020-11-05 18:01:40 -0800 Committed r269498: <https://trac.webkit.org/changeset/269498> All reviewed patches have been landed. Closing bug and clearing flags on attachment 413319. 413319 2020-11-05 10:16:16 -0800 2020-11-05 18:01:40 -0800 Patch bug-218622-20201105101615.patch text/plain 5179 achristensen U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5NDM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTcxYzRkMjY1MWZhYTNi NzA2MWYyYzM1ODA3YmQ1ZGM5MjM5MWMxNS4uN2FjYzg4MGI0NzcxZTI4OWJhMjI5M2FmMjVjMzll NTYwMTdlOWIyMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIwLTExLTA1ICBBbGV4 IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgQWRkIG51 bGwgY2hlY2tzIGVmZmVjdGl2ZWx5IGluIFVzZXJJbnB1dEJyaWRnZQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE4NjIyCisgICAgICAgIDxyZGFyOi8v cHJvYmxlbS83MDcyNDk2MD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIHJlcGxheS9Vc2VySW5wdXRCcmlkZ2UuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6VXNlcklucHV0QnJpZGdlOjpyZWxvYWRGcmFtZSk6CisgICAgICAgIChXZWJDb3JlOjpVc2Vy SW5wdXRCcmlkZ2U6OnN0b3BMb2FkaW5nRnJhbWUpOgorICAgICAgICAqIHJlcGxheS9Vc2VySW5w dXRCcmlkZ2UuaDoKKwogMjAyMC0xMS0wNSAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNl bkB3ZWJraXQub3JnPgogCiAgICAgICAgIEZpeCBidWlsZCBhZnRlciByMjY5NDM1CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmlu ZGV4IDkxYzNhZmZiOTNlMmI1ZGQ5OWRjN2M0OGM2ZDY0MmY4YzU0ZThjY2QuLmQ0MzgwNTEwOTcw ODI3NmU3YmUxMGNmYjU1NGU2MjQwZTQzMGQyMjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv Q2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAK KzIwMjAtMTEtMDUgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4K KworICAgICAgICBBZGQgbnVsbCBjaGVja3MgZWZmZWN0aXZlbHkgaW4gVXNlcklucHV0QnJpZGdl CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTg2MjIK KyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzcwNzI0OTYwPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2Uu Y3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlOjpzdG9wTG9hZGluZ0ZyYW1lKToKKyAgICAg ICAgKFdlYktpdDo6V2ViUGFnZTo6c3RvcExvYWRpbmcpOgorICAgICAgICAoV2ViS2l0OjpXZWJQ YWdlOjpyZWxvYWQpOgorCiAyMDIwLTExLTA1ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVu c2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgU3RvcmUgV2Vha1B0cjxGcmFtZT4gaW5zdGVhZCBv ZiBGcmFtZSoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlcGxheS9Vc2VySW5wdXRCcmlk Z2UuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVwbGF5L1VzZXJJbnB1dEJyaWRnZS5jcHAKaW5kZXgg MjBiNjQxNWU2ZjQ2OGZkNjYyYThmNGRiMjA1ODZmZGM1N2YzODBiZS4uNDU1NDFmZGU4YjExNTU3 YTczYmU3MjkwZWQ3MWRmNTA1NWY4NzgxOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVw bGF5L1VzZXJJbnB1dEJyaWRnZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVwbGF5L1VzZXJJ bnB1dEJyaWRnZS5jcHAKQEAgLTExNywxNCArMTE3LDE0IEBAIHZvaWQgVXNlcklucHV0QnJpZGdl Ojpsb2FkUmVxdWVzdChGcmFtZUxvYWRSZXF1ZXN0JiYgcmVxdWVzdCwgSW5wdXRTb3VyY2UpCiAg ICAgbV9wYWdlLm1haW5GcmFtZSgpLmxvYWRlcigpLmxvYWQoV1RGTW92ZShyZXF1ZXN0KSk7CiB9 CiAKLXZvaWQgVXNlcklucHV0QnJpZGdlOjpyZWxvYWRGcmFtZShGcmFtZSogZnJhbWUsIE9wdGlv blNldDxSZWxvYWRPcHRpb24+IG9wdGlvbnMsIElucHV0U291cmNlKQordm9pZCBVc2VySW5wdXRC cmlkZ2U6OnJlbG9hZEZyYW1lKEZyYW1lJiBmcmFtZSwgT3B0aW9uU2V0PFJlbG9hZE9wdGlvbj4g b3B0aW9ucywgSW5wdXRTb3VyY2UpCiB7Ci0gICAgZnJhbWUtPmxvYWRlcigpLnJlbG9hZChvcHRp b25zKTsKKyAgICBmcmFtZS5sb2FkZXIoKS5yZWxvYWQob3B0aW9ucyk7CiB9CiAKLXZvaWQgVXNl cklucHV0QnJpZGdlOjpzdG9wTG9hZGluZ0ZyYW1lKEZyYW1lKiBmcmFtZSwgSW5wdXRTb3VyY2Up Cit2b2lkIFVzZXJJbnB1dEJyaWRnZTo6c3RvcExvYWRpbmdGcmFtZShGcmFtZSYgZnJhbWUsIElu cHV0U291cmNlKQogewotICAgIGZyYW1lLT5sb2FkZXIoKS5zdG9wRm9yVXNlckNhbmNlbCgpOwor ICAgIGZyYW1lLmxvYWRlcigpLnN0b3BGb3JVc2VyQ2FuY2VsKCk7CiB9CiAKIGJvb2wgVXNlcklu cHV0QnJpZGdlOjp0cnlDbG9zZVBhZ2UoSW5wdXRTb3VyY2UpCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9yZXBsYXkvVXNlcklucHV0QnJpZGdlLmggYi9Tb3VyY2UvV2ViQ29yZS9yZXBsYXkv VXNlcklucHV0QnJpZGdlLmgKaW5kZXggNTRjYzUyN2UxOTIyNTk4ZGY0Y2M5ZGRkNmI1MGJhMTc5 NTI0OTVlNy4uYzJlY2VjZmVjNDY3YTE0MmU3YTkxNDJiZjdjMTZiM2Q2OTkzZDE3ZCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcmVwbGF5L1VzZXJJbnB1dEJyaWRnZS5oCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3JlcGxheS9Vc2VySW5wdXRCcmlkZ2UuaApAQCAtNzYsOCArNzYsOCBAQCBwdWJs aWM6CiAKICAgICAvLyBOYXZpZ2F0aW9uIEFQSXMuCiAgICAgV0VCQ09SRV9FWFBPUlQgdm9pZCBs b2FkUmVxdWVzdChGcmFtZUxvYWRSZXF1ZXN0JiYsIElucHV0U291cmNlID0gSW5wdXRTb3VyY2U6 OlVzZXIpOwotICAgIFdFQkNPUkVfRVhQT1JUIHZvaWQgcmVsb2FkRnJhbWUoRnJhbWUqLCBPcHRp b25TZXQ8UmVsb2FkT3B0aW9uPiwgSW5wdXRTb3VyY2UgPSBJbnB1dFNvdXJjZTo6VXNlcik7Ci0g ICAgV0VCQ09SRV9FWFBPUlQgdm9pZCBzdG9wTG9hZGluZ0ZyYW1lKEZyYW1lKiwgSW5wdXRTb3Vy Y2UgPSBJbnB1dFNvdXJjZTo6VXNlcik7CisgICAgV0VCQ09SRV9FWFBPUlQgdm9pZCByZWxvYWRG cmFtZShGcmFtZSYsIE9wdGlvblNldDxSZWxvYWRPcHRpb24+LCBJbnB1dFNvdXJjZSA9IElucHV0 U291cmNlOjpVc2VyKTsKKyAgICBXRUJDT1JFX0VYUE9SVCB2b2lkIHN0b3BMb2FkaW5nRnJhbWUo RnJhbWUmLCBJbnB1dFNvdXJjZSA9IElucHV0U291cmNlOjpVc2VyKTsKICAgICBXRUJDT1JFX0VY UE9SVCBib29sIHRyeUNsb3NlUGFnZShJbnB1dFNvdXJjZSA9IElucHV0U291cmNlOjpVc2VyKTsK IAogcHJpdmF0ZToKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdl L1dlYlBhZ2UuY3BwIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5j cHAKaW5kZXggZTYwM2ZkZjg5MTEzNTVlZDI4NTVkNDY5YzM0OGRlNGYwNDZmMDI3Zi4uNjc2NDhj MTdkYTJlODAzOGUwZmI4NzE2OGM1NWNkZWJkOTY2MzZmYyAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9X ZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAKQEAgLTE3MDgsMTQgKzE3MDgsMjAgQEAgdm9p ZCBXZWJQYWdlOjpzdG9wTG9hZGluZ0ZyYW1lKEZyYW1lSWRlbnRpZmllciBmcmFtZUlEKQogICAg IGlmICghZnJhbWUpCiAgICAgICAgIHJldHVybjsKIAotICAgIGNvcmVQYWdlKCktPnVzZXJJbnB1 dEJyaWRnZSgpLnN0b3BMb2FkaW5nRnJhbWUoZnJhbWUtPmNvcmVGcmFtZSgpKTsKKyAgICBhdXRv KiBjb3JlRnJhbWUgPSBmcmFtZS0+Y29yZUZyYW1lKCk7CisgICAgaWYgKCFjb3JlRnJhbWUgfHwg IW1fcGFnZSkKKyAgICAgICAgcmV0dXJuOworCisgICAgbV9wYWdlLT51c2VySW5wdXRCcmlkZ2Uo KS5zdG9wTG9hZGluZ0ZyYW1lKCpjb3JlRnJhbWUpOwogfQogCiB2b2lkIFdlYlBhZ2U6OnN0b3BM b2FkaW5nKCkKIHsKLSAgICBTZW5kU3RvcFJlc3BvbnNpdmVuZXNzVGltZXIgc3RvcHBlcjsKKyAg ICBpZiAoIW1fcGFnZSB8fCAhbV9tYWluRnJhbWUtPmNvcmVGcmFtZSgpKQorICAgICAgICByZXR1 cm47CiAKLSAgICBjb3JlUGFnZSgpLT51c2VySW5wdXRCcmlkZ2UoKS5zdG9wTG9hZGluZ0ZyYW1l KG1fbWFpbkZyYW1lLT5jb3JlRnJhbWUoKSk7CisgICAgU2VuZFN0b3BSZXNwb25zaXZlbmVzc1Rp bWVyIHN0b3BwZXI7CisgICAgbV9wYWdlLT51c2VySW5wdXRCcmlkZ2UoKS5zdG9wTG9hZGluZ0Zy YW1lKCptX21haW5GcmFtZS0+Y29yZUZyYW1lKCkpOwogfQogCiBib29sIFdlYlBhZ2U6OmRlZmVy c0xvYWRpbmcoKSBjb25zdApAQCAtMTczNiw3ICsxNzQyLDEwIEBAIHZvaWQgV2ViUGFnZTo6cmVs b2FkKHVpbnQ2NF90IG5hdmlnYXRpb25JRCwgdWludDMyX3QgcmVsb2FkT3B0aW9ucywgU2FuZGJv eEV4dGVuCiAgICAgbV9wZW5kaW5nTmF2aWdhdGlvbklEID0gbmF2aWdhdGlvbklEOwogCiAgICAg bV9zYW5kYm94RXh0ZW5zaW9uVHJhY2tlci5iZWdpblJlbG9hZChtX21haW5GcmFtZS5wdHIoKSwg V1RGTW92ZShzYW5kYm94RXh0ZW5zaW9uSGFuZGxlKSk7Ci0gICAgY29yZVBhZ2UoKS0+dXNlcklu cHV0QnJpZGdlKCkucmVsb2FkRnJhbWUobV9tYWluRnJhbWUtPmNvcmVGcmFtZSgpLCBPcHRpb25T ZXQ8UmVsb2FkT3B0aW9uPjo6ZnJvbVJhdyhyZWxvYWRPcHRpb25zKSk7CisgICAgaWYgKG1fcGFn ZSAmJiBtX21haW5GcmFtZS0+Y29yZUZyYW1lKCkpCisgICAgICAgIG1fcGFnZS0+dXNlcklucHV0 QnJpZGdlKCkucmVsb2FkRnJhbWUoKm1fbWFpbkZyYW1lLT5jb3JlRnJhbWUoKSwgT3B0aW9uU2V0 PFJlbG9hZE9wdGlvbj46OmZyb21SYXcocmVsb2FkT3B0aW9ucykpOworICAgIGVsc2UKKyAgICAg ICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CiAKICAgICBpZiAobV9wZW5kaW5nTmF2aWdhdGlvbklE KSB7CiAgICAgICAgIC8vIFRoaXMgY2FuIGhhcHBlbiBpZiBGcmFtZUxvYWRlcjo6cmVsb2FkKCkg cmV0dXJucyBlYXJseSBiZWNhdXNlIHRoZSBkb2N1bWVudCBVUkwgaXMgZW1wdHkuCg==