218613 2020-11-05 06:14:53 -0800 Enable llint asm on aarch64 when USE(64KB_PAGE_BLOCK) is enabled 2020-11-25 15:13:17 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build PC Linux RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=217989 https://bugs.webkit.org/show_bug.cgi?id=219288 P2 Normal --- 1 mcatanzaro mcatanzaro annulen bugs-noreply clopez ews-watchlist gyuyoung.kim mcatanzaro mgorse ryuan.choi sergio xan.lopez oldest_to_newest 1704831 0 mcatanzaro 2020-11-05 06:14:53 -0800 Bug #217989 forces cloop when USE(64KB_PAGE_BLOCK) is enabled. Xan recommends we use llint's assembler backend instead, since it is faster and bugs should be rare. 1704842 1 413291 mcatanzaro 2020-11-05 06:46:55 -0800 Created attachment 413291 Patch 1704850 2 mcatanzaro 2020-11-05 07:38:05 -0800 (Mike: this reverses my previous recommendation that we should use cloop on aarch64.) 1705767 3 ews-feeder 2020-11-09 10:53:54 -0800 Committed r269586: <https://trac.webkit.org/changeset/269586> All reviewed patches have been landed. Closing bug and clearing flags on attachment 413291. 1710079 4 mcatanzaro 2020-11-25 14:36:40 -0800 This doesn't build. Turns out aarch64 llint depends on JIT due to USE(JUMP_ISLANDS). It seems this configuration is maybe not as well-tested as we had hoped? Let's follow-up in bug #219288. 413291 2020-11-05 06:46:55 -0800 2020-11-09 10:53:56 -0800 Patch bug-218613-20201105084702.patch text/plain 1964 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5NDI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvV2Vi S2l0RmVhdHVyZXMuY21ha2UgYi9Tb3VyY2UvY21ha2UvV2ViS2l0RmVhdHVyZXMuY21ha2UKaW5k ZXggZWNiZGQ4NTM0Y2IwMzFjNmFmNDc3NTI2ZjhjNzcwZDYzZmYyOGQ3Yi4uZTViMDg2NjMxNjc5 NDRlYjQyYzQ4ODBkOGQxYjljNzM5NjU1NzhjYiAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL1dl YktpdEZlYXR1cmVzLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9XZWJLaXRGZWF0dXJlcy5jbWFr ZQpAQCAtODMsOCArODMsMTQgQEAgbWFjcm8oV0VCS0lUX09QVElPTl9CRUdJTikKICAgICAgICAg c2V0KEVOQUJMRV9KSVRfREVGQVVMVCBPRkYpCiAgICAgICAgIHNldChFTkFCTEVfRlRMX0RFRkFV TFQgT0ZGKQogICAgICAgICBzZXQoVVNFX1NZU1RFTV9NQUxMT0NfREVGQVVMVCBPTikKLSAgICAg ICAgc2V0KEVOQUJMRV9DX0xPT1BfREVGQVVMVCBPTikKLSAgICAgICAgc2V0KEVOQUJMRV9TQU1Q TElOR19QUk9GSUxFUl9ERUZBVUxUIE9GRikKKyAgICAgICAgaWYgKFdURl9DUFVfQVJNNjQpCisg ICAgICAgICAgICBzZXQoRU5BQkxFX0NfTE9PUF9ERUZBVUxUIE9GRikKKyAgICAgICAgICAgIHNl dChFTkFCTEVfU0FNUExJTkdfUFJPRklMRVJfREVGQVVMVCBPTikKKyAgICAgICAgZWxzZSAoKQor ICAgICAgICAgICAgbWVzc2FnZShXQVJOSU5HICJCdWlsZGluZyB3aXRoIFVTRV82NEtCX1BBR0Vf QkxPQ0sgb24gYW4gYXJjaGl0ZWN0dXJlIG90aGVyIHRoYW4gYWFyY2g2NCBpcyB1bnVzdWFsLiBB cmUgeW91IHN1cmUgeW91IHdhbnQgVVNFXzY0S0JfUEFHRV9CTE9DSz8iKQorICAgICAgICAgICAg c2V0KEVOQUJMRV9DX0xPT1BfREVGQVVMVCBPTikKKyAgICAgICAgICAgIHNldChFTkFCTEVfU0FN UExJTkdfUFJPRklMRVJfREVGQVVMVCBPRkYpCisgICAgICAgIGVuZGlmICgpCiAgICAgZWxzZWlm IChXVEZfQ1BVX0FSTTY0IE9SIFdURl9DUFVfWDg2XzY0KQogICAgICAgICBzZXQoRU5BQkxFX0pJ VF9ERUZBVUxUIE9OKQogICAgICAgICBzZXQoRU5BQkxFX0ZUTF9ERUZBVUxUIE9OKQpkaWZmIC0t Z2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IDJmYmEzYjkxYjdkN2JmOGEzMTdlZWIz MTg1OGJmM2Q5YjJjN2Q2OTMuLjM5NTI0NTMwNDNmZDAxZDI3ODg3ODNhOGM5MDdhNDc4NmJmZmJi ZDcgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBA QAorMjAyMC0xMS0wNSAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGdub21lLm9yZz4K KworICAgICAgICBFbmFibGUgbGxpbnQgYXNtIG9uIGFhcmNoNjQgd2hlbiBVU0UoNjRLQl9QQUdF X0JMT0NLKSBpcyBlbmFibGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMTg2MTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBOb3JtYWxseSB3ZSBmYWxsIGJhY2sgdG8gY2xvb3Agd2hlbiBKSVQgaXMgbm90 IHN1cHBvcnRlZC4gQnV0IG9uIGFhcmNoNjQsIGxsaW50IGFzbSBpcyB3ZWxsLQorICAgICAgICBz dXBwb3J0ZWQsIHNvIGl0IGlzIHNhZmUgdG8gdXNlIHRoYXQgaGVyZS4gVGhpcyB3aWxsIG9ubHkg aGFwcGVuIG9uIGFhcmNoNjQsIGFuZCBvbmx5IHdoZW4KKyAgICAgICAgVVNFKDY0S0JfUEFHRV9C TE9DSykgaXMgZW5hYmxlZCwgd2hpY2ggc2hvdWxkIHByb2JhYmx5IG9ubHkgYmUgdXNlZCBieSBS SEVMIGFuZCBTVVNFLgorICAgICAgICBFdmVyeW9uZSBlbHNlIHNob3VsZCBnZXQgdGhlIEpJVC4K KworICAgICAgICAqIFNvdXJjZS9jbWFrZS9XZWJLaXRGZWF0dXJlcy5jbWFrZToKKwogMjAyMC0x MS0wNCAgU2VyZ2V5IFJ1YmFub3YgIDxjaGkxODdAZ21haWwuY29tPgogCiAgICAgICAgIEZpeCBK U0MgYnVpbGQgb24gbWFjT1MgQmlnIFN1cgo=