218611 2020-11-05 05:22:57 -0800 Test that skip_validation is effective 2020-11-05 06:45:53 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 angelos webkit-unassigned aakash_jain jbedard webkit-bug-importer oldest_to_newest 1704820 0 angelos 2020-11-05 05:22:57 -0800 Test that skip_validation is effective 1704821 1 413285 angelos 2020-11-05 05:24:05 -0800 Created attachment 413285 Patch 1704826 2 413285 aakash_jain 2020-11-05 05:55:55 -0800 Comment on attachment 413285 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=413285&action=review looks good > Tools/CISupport/ews-build/steps_unittest.py:3603 > + self.setProperty('skip_validation', '1') Better to pass Boolean here 1704828 3 413288 angelos 2020-11-05 06:01:11 -0800 Created attachment 413288 Patch 1704829 4 angelos 2020-11-05 06:02:55 -0800 (In reply to Aakash Jain from comment #2) > Comment on attachment 413285 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=413285&action=review > > looks good > > > Tools/CISupport/ews-build/steps_unittest.py:3603 > > + self.setProperty('skip_validation', '1') > > Better to pass Boolean here Fixed. 1704840 5 ews-feeder 2020-11-05 06:44:33 -0800 Committed r269429: <https://trac.webkit.org/changeset/269429> All reviewed patches have been landed. Closing bug and clearing flags on attachment 413288. 1704841 6 webkit-bug-importer 2020-11-05 06:45:53 -0800 <rdar://problem/71076634> 413285 2020-11-05 05:24:05 -0800 2020-11-05 06:00:57 -0800 Patch bug-218611-20201105142402.patch text/plain 1692 angelos U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5NDI0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYzI5ZjA2NDE1YTdhNWVlOWFjOTY0ZDA2M2I0Y2YyYTFj NDIxODYxMC4uZTdhY2QzODM0MjcxMTE5YjY1YmI2MTIxMTM5OTg1M2NmOTc4YWJhZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEy IEBACisyMDIwLTExLTA1ICBBbmdlbG9zIE9pa29ub21vcG91bG9zICA8YW5nZWxvc0BpZ2FsaWEu Y29tPgorCisgICAgICAgIFRlc3QgdGhhdCBza2lwX3ZhbGlkYXRpb24gaXMgZWZmZWN0aXZlCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTg2MTEKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIENJU3VwcG9y dC9ld3MtYnVpbGQvc3RlcHNfdW5pdHRlc3QucHk6CisKIDIwMjAtMTEtMDUgIEFuZ2Vsb3MgT2lr b25vbW9wb3Vsb3MgIDxhbmdlbG9zQGlnYWxpYS5jb20+CiAKICAgICAgICAgVGVzdCB0aGF0IFRy YW5zZmVyVG9TMyBpcyBza2lwcGVkIHByb3Blcmx5CmRpZmYgLS1naXQgYS9Ub29scy9DSVN1cHBv cnQvZXdzLWJ1aWxkL3N0ZXBzX3VuaXR0ZXN0LnB5IGIvVG9vbHMvQ0lTdXBwb3J0L2V3cy1idWls ZC9zdGVwc191bml0dGVzdC5weQppbmRleCA3MzM0ZjFlYjFkOWJmY2JmNDc4ZTBkNzdiZmRkYWYz MDQ0NDMyYjkyLi5hYzBkMzgzZTNlNjM5ZTIwNjNiODM4MzY5MzdlNWI3Y2EzOGIwMWI5IDEwMDY0 NAotLS0gYS9Ub29scy9DSVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzX3VuaXR0ZXN0LnB5CisrKyBi L1Rvb2xzL0NJU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHNfdW5pdHRlc3QucHkKQEAgLTM1ODksNiAr MzU4OSwyMiBAQCBjbGFzcyBUZXN0Q3JlYXRlTG9jYWxHSVRDb21taXQoQnVpbGRTdGVwTWl4aW5B ZGRpdGlvbnMsIHVuaXR0ZXN0LlRlc3RDYXNlKToKICAgICAgICAgcmV0dXJuIHJjCiAKIAorY2xh c3MgVGVzdFZhbGlkYXRlUGF0Y2goQnVpbGRTdGVwTWl4aW5BZGRpdGlvbnMsIHVuaXR0ZXN0LlRl c3RDYXNlKToKKyAgICBkZWYgc2V0VXAoc2VsZik6CisgICAgICAgIHJldHVybiBzZWxmLnNldFVw QnVpbGRTdGVwKCkKKworICAgIGRlZiB0ZWFyRG93bihzZWxmKToKKyAgICAgICAgcmV0dXJuIHNl bGYudGVhckRvd25CdWlsZFN0ZXAoKQorCisgICAgZGVmIHRlc3Rfc2tpcHBlZChzZWxmKToKKyAg ICAgICAgc2VsZi5zZXR1cFN0ZXAoVmFsaWRhdGVQYXRjaCgpKQorICAgICAgICBzZWxmLnNldFBy b3BlcnR5KCdwYXRjaF9pZCcsICcxMjM0JykKKyAgICAgICAgc2VsZi5zZXRQcm9wZXJ0eSgnYnVn X2lkJywgJzU2NzgnKQorICAgICAgICBzZWxmLnNldFByb3BlcnR5KCdza2lwX3ZhbGlkYXRpb24n LCAnMScpCisgICAgICAgIHNlbGYuZXhwZWN0T3V0Y29tZShyZXN1bHQ9U0tJUFBFRCwgc3RhdGVf c3RyaW5nPSdWYWxpZGF0ZWQgcGF0Y2ggKHNraXBwZWQpJykKKyAgICAgICAgcmV0dXJuIHNlbGYu cnVuU3RlcCgpCisKKwogY2xhc3MgVGVzdFZhbGlkYXRlQ29tbWl0ZXJBbmRSZXZpZXdlcihCdWls ZFN0ZXBNaXhpbkFkZGl0aW9ucywgdW5pdHRlc3QuVGVzdENhc2UpOgogICAgIGRlZiBzZXRVcChz ZWxmKToKICAgICAgICAgc2VsZi5sb25nTWVzc2FnZSA9IFRydWUK 413288 2020-11-05 06:01:11 -0800 2020-11-05 06:44:33 -0800 Patch bug-218611-20201105150109.patch text/plain 1693 angelos U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5NDI0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYzI5ZjA2NDE1YTdhNWVlOWFjOTY0ZDA2M2I0Y2YyYTFj NDIxODYxMC4uZTdhY2QzODM0MjcxMTE5YjY1YmI2MTIxMTM5OTg1M2NmOTc4YWJhZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEy IEBACisyMDIwLTExLTA1ICBBbmdlbG9zIE9pa29ub21vcG91bG9zICA8YW5nZWxvc0BpZ2FsaWEu Y29tPgorCisgICAgICAgIFRlc3QgdGhhdCBza2lwX3ZhbGlkYXRpb24gaXMgZWZmZWN0aXZlCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTg2MTEKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIENJU3VwcG9y dC9ld3MtYnVpbGQvc3RlcHNfdW5pdHRlc3QucHk6CisKIDIwMjAtMTEtMDUgIEFuZ2Vsb3MgT2lr b25vbW9wb3Vsb3MgIDxhbmdlbG9zQGlnYWxpYS5jb20+CiAKICAgICAgICAgVGVzdCB0aGF0IFRy YW5zZmVyVG9TMyBpcyBza2lwcGVkIHByb3Blcmx5CmRpZmYgLS1naXQgYS9Ub29scy9DSVN1cHBv cnQvZXdzLWJ1aWxkL3N0ZXBzX3VuaXR0ZXN0LnB5IGIvVG9vbHMvQ0lTdXBwb3J0L2V3cy1idWls ZC9zdGVwc191bml0dGVzdC5weQppbmRleCA3MzM0ZjFlYjFkOWJmY2JmNDc4ZTBkNzdiZmRkYWYz MDQ0NDMyYjkyLi4wY2Y4OGYxZDNhZWY0ZTg1YzI2YjI0NTkwYzk5OWE2YTU3OGY1YjkwIDEwMDY0 NAotLS0gYS9Ub29scy9DSVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzX3VuaXR0ZXN0LnB5CisrKyBi L1Rvb2xzL0NJU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHNfdW5pdHRlc3QucHkKQEAgLTM1ODksNiAr MzU4OSwyMiBAQCBjbGFzcyBUZXN0Q3JlYXRlTG9jYWxHSVRDb21taXQoQnVpbGRTdGVwTWl4aW5B ZGRpdGlvbnMsIHVuaXR0ZXN0LlRlc3RDYXNlKToKICAgICAgICAgcmV0dXJuIHJjCiAKIAorY2xh c3MgVGVzdFZhbGlkYXRlUGF0Y2goQnVpbGRTdGVwTWl4aW5BZGRpdGlvbnMsIHVuaXR0ZXN0LlRl c3RDYXNlKToKKyAgICBkZWYgc2V0VXAoc2VsZik6CisgICAgICAgIHJldHVybiBzZWxmLnNldFVw QnVpbGRTdGVwKCkKKworICAgIGRlZiB0ZWFyRG93bihzZWxmKToKKyAgICAgICAgcmV0dXJuIHNl bGYudGVhckRvd25CdWlsZFN0ZXAoKQorCisgICAgZGVmIHRlc3Rfc2tpcHBlZChzZWxmKToKKyAg ICAgICAgc2VsZi5zZXR1cFN0ZXAoVmFsaWRhdGVQYXRjaCgpKQorICAgICAgICBzZWxmLnNldFBy b3BlcnR5KCdwYXRjaF9pZCcsICcxMjM0JykKKyAgICAgICAgc2VsZi5zZXRQcm9wZXJ0eSgnYnVn X2lkJywgJzU2NzgnKQorICAgICAgICBzZWxmLnNldFByb3BlcnR5KCdza2lwX3ZhbGlkYXRpb24n LCBUcnVlKQorICAgICAgICBzZWxmLmV4cGVjdE91dGNvbWUocmVzdWx0PVNLSVBQRUQsIHN0YXRl X3N0cmluZz0nVmFsaWRhdGVkIHBhdGNoIChza2lwcGVkKScpCisgICAgICAgIHJldHVybiBzZWxm LnJ1blN0ZXAoKQorCisKIGNsYXNzIFRlc3RWYWxpZGF0ZUNvbW1pdGVyQW5kUmV2aWV3ZXIoQnVp bGRTdGVwTWl4aW5BZGRpdGlvbnMsIHVuaXR0ZXN0LlRlc3RDYXNlKToKICAgICBkZWYgc2V0VXAo c2VsZik6CiAgICAgICAgIHNlbGYubG9uZ01lc3NhZ2UgPSBUcnVlCg==