21859 2008-10-24 12:57:24 -0700 control rendering bugs on windows when not using SAFARI_THEME 2008-10-30 22:49:45 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 1 tony tony oldest_to_newest 96550 0 tony 2008-10-24 12:57:24 -0700 1) Checkboxes marked readonly are rendered different from other checkboxes (there's no such thing as a readonly checkbox, it should render the same) 2) If a button has focus and is pressed, it is rendered as focused rather than pressed. patch coming up 96551 1 24646 tony 2008-10-24 12:58:00 -0700 Created attachment 24646 fix control layout 96556 2 24646 hyatt 2008-10-24 13:21:07 -0700 Comment on attachment 24646 fix control layout r=me 97220 3 timothy 2008-10-30 22:49:45 -0700 Landed in r38025. 24646 2008-10-24 12:58:00 -0700 2008-10-24 13:21:07 -0700 fix control layout winthemefixes.diff text/plain 2217 tony SW5kZXg6IENoYW5nZUxvZw0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIENoYW5nZUxvZwkocmV2aXNpb24gMzc4 NTIpCisrKyBDaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNiBAQAorMjAwOC0x MC0yNCAgdG9ueSBjaGFuZyA8dG9ueUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV0FSTklORzogTk8gVEVTVCBDQVNFUyBBRERF RCBPUiBDSEFOR0VECisKKyAgICAgICAgRml4IDIgd2luZG93cyB0aGVtZSBidWdzOgorICAgICAg ICAxKSBDaGVja2JveGVzIG1hcmtlZCByZWFkb25seSB3ZXJlIHJlbmRlcmVkIGluY29ycmVjdGx5 CisgICAgICAgIDIpIElmIGEgYnV0dG9uIGhhcyBmb2N1cyBhbmQgaXMgcHJlc3NlZCwgaXQgd2Fz IHJlbmRlcmVkCisgICAgICAgICAgIGFzIGZvY3VzZWQgcmF0aGVyIHRoYW4gcHJlc3NlZC4KKwor ICAgICAgICAqIHJlbmRlcmluZ1xSZW5kZXJUaGVtZVdpbi5jcHA6CisKIDIwMDgtMTAtMjQgIFNp bW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgRGFyaW4gQWRsZXIKSW5kZXg6IHJlbmRlcmluZy9SZW5kZXJUaGVtZVdpbi5jcHANCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0NCi0tLSByZW5kZXJpbmcvUmVuZGVyVGhlbWVXaW4uY3BwCShyZXZpc2lvbiAzNzgzNCkK KysrIHJlbmRlcmluZy9SZW5kZXJUaGVtZVdpbi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM0MCwx NCArMzQwLDE1IEBAIHVuc2lnbmVkIFJlbmRlclRoZW1lV2luOjpkZXRlcm1pbmVDbGFzc2kKIHVu c2lnbmVkIFJlbmRlclRoZW1lV2luOjpkZXRlcm1pbmVTdGF0ZShSZW5kZXJPYmplY3QqIG8pCiB7 CiAgICAgdW5zaWduZWQgcmVzdWx0ID0gVFNfTk9STUFMOworICAgIENvbnRyb2xQYXJ0IGFwcGVh cmFuY2UgPSBvLT5zdHlsZSgpLT5hcHBlYXJhbmNlKCk7CiAgICAgaWYgKCFpc0VuYWJsZWQobykp CiAgICAgICAgIHJlc3VsdCA9IFRTX0RJU0FCTEVEOwotICAgIGVsc2UgaWYgKGlzUmVhZE9ubHlD b250cm9sKG8pKQorICAgIGVsc2UgaWYgKGlzUmVhZE9ubHlDb250cm9sKG8pICYmIChUZXh0Rmll bGRQYXJ0ID09IGFwcGVhcmFuY2UgfHwgVGV4dEFyZWFQYXJ0ID09IGFwcGVhcmFuY2UpKQogICAg ICAgICByZXN1bHQgPSBURlNfUkVBRE9OTFk7IC8vIFJlYWRvbmx5IGlzIHN1cHBvcnRlZCBvbiB0 ZXh0ZmllbGRzLgotICAgIGVsc2UgaWYgKHN1cHBvcnRzRm9jdXMoby0+c3R5bGUoKS0+YXBwZWFy YW5jZSgpKSAmJiBpc0ZvY3VzZWQobykpCi0gICAgICAgIHJlc3VsdCA9IFRTX0ZPQ1VTRUQ7Ci0g ICAgZWxzZSBpZiAoaXNQcmVzc2VkKG8pKQorICAgIGVsc2UgaWYgKGlzUHJlc3NlZChvKSkgLy8g QWN0aXZlIG92ZXJyaWRlcyBob3ZlciBhbmQgZm9jdXNlZC4KICAgICAgICAgcmVzdWx0ID0gVFNf QUNUSVZFOworICAgIGVsc2UgaWYgKHN1cHBvcnRzRm9jdXMoYXBwZWFyYW5jZSkgJiYgaXNGb2N1 c2VkKG8pKQorICAgICAgICByZXN1bHQgPSBUU19GT0NVU0VEOwogICAgIGVsc2UgaWYgKGlzSG92 ZXJlZChvKSkKICAgICAgICAgcmVzdWx0ID0gVFNfSE9WRVI7CiAgICAgaWYgKGlzQ2hlY2tlZChv KSkKQEAgLTM3NCwxMCArMzc1LDEwIEBAIHVuc2lnbmVkIFJlbmRlclRoZW1lV2luOjpkZXRlcm1p bmVCdXR0b24KICAgICB1bnNpZ25lZCByZXN1bHQgPSBQQlNfTk9STUFMOwogICAgIGlmICghaXNF bmFibGVkKG8pKQogICAgICAgICByZXN1bHQgPSBQQlNfRElTQUJMRUQ7Ci0gICAgZWxzZSBpZiAo c3VwcG9ydHNGb2N1cyhvLT5zdHlsZSgpLT5hcHBlYXJhbmNlKCkpICYmIGlzRm9jdXNlZChvKSkK LSAgICAgICAgcmVzdWx0ID0gUEJTX0RFRkFVTFRFRDsKICAgICBlbHNlIGlmIChpc1ByZXNzZWQo bykpCiAgICAgICAgIHJlc3VsdCA9IFBCU19QUkVTU0VEOworICAgIGVsc2UgaWYgKHN1cHBvcnRz Rm9jdXMoby0+c3R5bGUoKS0+YXBwZWFyYW5jZSgpKSAmJiBpc0ZvY3VzZWQobykpCisgICAgICAg IHJlc3VsdCA9IFBCU19ERUZBVUxURUQ7CiAgICAgZWxzZSBpZiAoaXNIb3ZlcmVkKG8pKQogICAg ICAgICByZXN1bHQgPSBQQlNfSE9UOwogICAgIGVsc2UgaWYgKGlzRGVmYXVsdChvKSkK