218568 2020-11-04 08:07:23 -0800 Add some missing header includes in media sources 2020-11-04 13:08:29 -0800 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED DoNotImportToRadar P2 Normal --- 218426 1 wenson_hsieh wenson_hsieh eric.carlson ews-watchlist glenn jer.noble peng.liu6 philipj sergio webkit-bug-importer youennf oldest_to_newest 1704425 0 wenson_hsieh 2020-11-04 08:07:23 -0800 I'm hitting some build errors when adding unified sources to the WebKit project; we need some minor adjustments to these files: - Source/WebCore/Modules/mediarecorder/MediaRecorderProvider.h - Source/WebKit/GPUProcess/media/ios/RemoteMediaSessionHelperProxy.cpp - Source/WebKit/WebProcess/GPU/webrtc/MediaRecorderPrivate.h 1704428 1 413166 wenson_hsieh 2020-11-04 08:10:51 -0800 Created attachment 413166 Patch 1704433 2 413166 wenson_hsieh 2020-11-04 08:24:38 -0800 Comment on attachment 413166 Patch Thanks for the review! 1704576 3 wenson_hsieh 2020-11-04 13:08:29 -0800 Committed r269379: <https://trac.webkit.org/changeset/269379> 413166 2020-11-04 08:10:51 -0800 2020-11-04 08:24:38 -0800 Patch bug-218568-20201104081051.patch text/plain 3338 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5MzQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWMyMTNmYmUyZTdlMWFj Mjk2MjRhNDdjYWY3M2JiMTE3MmM1ZGM3YS4uN2U2MmRjYzhjZDEzY2NhNTZlYmQxZjU2NTA3YTU5 MWJkZDc3ZDgzOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDIwLTExLTA0ICBXZW5z b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIEFkZCBzb21lIG1p c3NpbmcgaGVhZGVyIGluY2x1ZGVzIGluIG1lZGlhIHNvdXJjZXMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxODU2OAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogTW9kdWxlcy9tZWRpYXJlY29yZGVyL01l ZGlhUmVjb3JkZXJQcm92aWRlci5oOiBJbmNsdWRlIGBXVEZTdHJpbmcuaGAuCisKIDIwMjAtMTEt MDMgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CiAKICAgICAgICAgW0Nv bmN1cnJlbnQgZGlzcGxheSBsaXN0c10gRW5jb2RlIGRpc3BsYXkgbGlzdCBpdGVtcyBkaXJlY3Rs eSBpbnRvIHNoYXJlZCBtZW1vcnkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9n IGIvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKaW5kZXggMTZiZDIzZTUwZmM0YmFkY2Q1YjIyMDBl MTFhZTEzMjg2NzczODEzMi4uMjA3ZGZkNTRkOGE3Mjg5YjEyYmNkYjMzZTNmNjlhYjRmNmM4MmZl ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktp dC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAyMC0xMS0wNCAgV2Vuc29uIEhzaWVoICA8 d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgc29tZSBtaXNzaW5nIGhlYWRl ciBpbmNsdWRlcyBpbiBtZWRpYSBzb3VyY2VzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMTg1NjgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIEdQVVByb2Nlc3MvbWVkaWEvaW9zL1JlbW90ZU1lZGlhU2Vz c2lvbkhlbHBlclByb3h5LmNwcDogSW5jbHVkZSBgV2ViQ29yZUFyZ3VtZW50Q29kZXJzLmhgLCBz aW5jZSB3ZSBuZWVkIHRvCisgICAgICAgICAgICBrbm93IGhvdyB0byBlbmNvZGUgYSBgTWVkaWFQ bGF5YmFja1RhcmdldENvbnRleHRgLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9HUFUvd2VicnRj L01lZGlhUmVjb3JkZXJQcml2YXRlLmg6IEFkZCBhIG1pc3NpbmcgYFdlYkNvcmU6OmAgbmFtZXNw YWNlLgorCiAyMDIwLTExLTAzICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29t PgogCiAgICAgICAgIFtDb25jdXJyZW50IGRpc3BsYXkgbGlzdHNdIEVuY29kZSBkaXNwbGF5IGxp c3QgaXRlbXMgZGlyZWN0bHkgaW50byBzaGFyZWQgbWVtb3J5CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9Nb2R1bGVzL21lZGlhcmVjb3JkZXIvTWVkaWFSZWNvcmRlclByb3ZpZGVyLmggYi9T b3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhcmVjb3JkZXIvTWVkaWFSZWNvcmRlclByb3ZpZGVy LmgKaW5kZXggNjU0YWUyNWIwMjJlNzFkY2YzOWEzNWYwOTBlZTcyOTJkN2RkZjJkZS4uZDdkOTM0 MDhmZTNkNDlhMTY3NDE1OWUyMDE5N2NkN2NmOWI1YzExMCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvTW9kdWxlcy9tZWRpYXJlY29yZGVyL01lZGlhUmVjb3JkZXJQcm92aWRlci5oCisrKyBi L1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFyZWNvcmRlci9NZWRpYVJlY29yZGVyUHJvdmlk ZXIuaApAQCAtMjUsNiArMjUsOCBAQAogCiAjcHJhZ21hIG9uY2UKIAorI2luY2x1ZGUgPHd0Zi90 ZXh0L1dURlN0cmluZy5oPgorCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIGNsYXNzIE1lZGlhUmVj b3JkZXJQcml2YXRlOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9HUFVQcm9jZXNzL21lZGlh L2lvcy9SZW1vdGVNZWRpYVNlc3Npb25IZWxwZXJQcm94eS5jcHAgYi9Tb3VyY2UvV2ViS2l0L0dQ VVByb2Nlc3MvbWVkaWEvaW9zL1JlbW90ZU1lZGlhU2Vzc2lvbkhlbHBlclByb3h5LmNwcAppbmRl eCAyMTc1M2QwM2RmZmJjMDdlNmY2ZjgzNTMyYWM4NWY5N2U1Yjk4ODI5Li45ZTZiYzk0NjZiNTM5 OWIyNGY1ODQwMDliOTAwYmQwN2QwMDgyMTE2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L0dQ VVByb2Nlc3MvbWVkaWEvaW9zL1JlbW90ZU1lZGlhU2Vzc2lvbkhlbHBlclByb3h5LmNwcAorKysg Yi9Tb3VyY2UvV2ViS2l0L0dQVVByb2Nlc3MvbWVkaWEvaW9zL1JlbW90ZU1lZGlhU2Vzc2lvbkhl bHBlclByb3h5LmNwcApAQCAtMzEsNiArMzEsNyBAQAogI2luY2x1ZGUgIkNvbm5lY3Rpb24uaCIK ICNpbmNsdWRlICJHUFVDb25uZWN0aW9uVG9XZWJQcm9jZXNzLmgiCiAjaW5jbHVkZSAiUmVtb3Rl TWVkaWFTZXNzaW9uSGVscGVyTWVzc2FnZXMuaCIKKyNpbmNsdWRlICJXZWJDb3JlQXJndW1lbnRD b2RlcnMuaCIKIAogbmFtZXNwYWNlIFdlYktpdCB7CiB1c2luZyBuYW1lc3BhY2UgV2ViQ29yZTsK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9HUFUvd2VicnRjL01lZGlhUmVj b3JkZXJQcml2YXRlLmggYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvR1BVL3dlYnJ0Yy9NZWRp YVJlY29yZGVyUHJpdmF0ZS5oCmluZGV4IDQyYTU4NWIyM2ZmYjVhZGIxOGU1MDYwNTU2ZjZhODA5 OTlkYTRkMjkuLjI5ZmVkYzdkMDdmZDQ1M2UwZjkzYWVlYjNlYmZhZWNlMDQ4MmRjOTUgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9HUFUvd2VicnRjL01lZGlhUmVjb3JkZXJQ cml2YXRlLmgKKysrIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0dQVS93ZWJydGMvTWVkaWFS ZWNvcmRlclByaXZhdGUuaApAQCAtNjgsNyArNjgsNyBAQCBwcml2YXRlOgogICAgIHZvaWQgc3Rv cmFnZUNoYW5nZWQoU2hhcmVkTWVtb3J5Kik7CiAKICAgICBNZWRpYVJlY29yZGVySWRlbnRpZmll ciBtX2lkZW50aWZpZXI7Ci0gICAgUmVmPE1lZGlhU3RyZWFtUHJpdmF0ZT4gbV9zdHJlYW07Cisg ICAgUmVmPFdlYkNvcmU6Ok1lZGlhU3RyZWFtUHJpdmF0ZT4gbV9zdHJlYW07CiAgICAgUmVmPElQ Qzo6Q29ubmVjdGlvbj4gbV9jb25uZWN0aW9uOwogCiAgICAgc3RkOjp1bmlxdWVfcHRyPFdlYkNv cmU6OkNBUmluZ0J1ZmZlcj4gbV9yaW5nQnVmZmVyOwo=