218566 2020-11-04 07:41:49 -0800 JSC build fails on Big Sur 11.0.1 beta 2020-11-04 17:41:05 -0800 1 1 1 Unclassified WebKit CMake WebKit Nightly Build Unspecified Other RESOLVED FIXED DoNotImportToRadar P4 Trivial --- 1 chi187 webkit-unassigned annulen ap ddkilzer ews-watchlist fpizlo gyuyoung.kim krollin ryuan.choi sergio smoley ysuzuki oldest_to_newest 1704413 0 chi187 2020-11-04 07:41:49 -0800 On macOS 11 Big Sur /usr/lib/*.dylib files do not exist. That causes "Tools/Scripts/build-jsc --jsc-only" to fail (it needs /usr/lib/libicucore.dylib). > New in macOS Big Sur 11.0.1 beta, the system ships with a built-in dynamic linker cache of all system-provided libraries. As part of this change, copies of dynamic libraries are no longer present on the filesystem. Code that attempts to check for dynamic library presence by looking for a file at a path or enumerating a directory will fail. Instead, check for library presence by attempting to dlopen() the path, which will correctly check for the library in the cache. (62986286) https://developer.apple.com/documentation/macos-release-notes/macos-big-sur-11_0_1-beta-release-notes 1704414 1 413161 chi187 2020-11-04 07:47:13 -0800 Created attachment 413161 Patch 1704497 2 413161 ddkilzer 2020-11-04 10:47:51 -0800 Comment on attachment 413161 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=413161&action=review r- for the cmake minimum version change. > CMakeLists.txt:9 > -cmake_minimum_required(VERSION 3.10) > +cmake_minimum_required(VERSION 3.18) Is this needed to use the find_library() function? I only have 3.17.x installed on my macOS 10.15.6 system, so I think this would break (Apple) folks using CMake on macOS. 1704515 3 chi187 2020-11-04 11:05:20 -0800 Oh, actually cmake minimum required version update is not required, I misunderstood this issue at first https://gitlab.kitware.com/cmake/cmake/-/issues/21007 and forgot to remove this change in CMakeLists 1704518 4 413183 chi187 2020-11-04 11:10:10 -0800 Created attachment 413183 Patch 1704530 5 413183 ddkilzer 2020-11-04 11:21:54 -0800 Comment on attachment 413183 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=413183&action=review r=me > Source/cmake/WebKitFindPackage.cmake:94 > + # Apple just has a single tbd for ICU Nit: Add period at the end of the comment. (Not necessary to land, but you might want to make this change while fixing the ChangeLog.) > ChangeLog:8 > + * CMakeLists.txt: Nit: Remove this line as this file is no longer changed. 1704534 6 413190 chi187 2020-11-04 11:28:45 -0800 Created attachment 413190 Patch 1704623 7 ddkilzer 2020-11-04 15:06:49 -0800 (In reply to Sergey Rubanov from comment #6) > Created attachment 413190 [details] > Patch Can you set cq+, or do I need to do it? (I didn't want to set it if you had planned to later.) 1704635 8 chi187 2020-11-04 15:27:11 -0800 (In reply to David Kilzer (:ddkilzer) from comment #7) > (In reply to Sergey Rubanov from comment #6) > > Created attachment 413190 [details] > > Patch > > Can you set cq+, or do I need to do it? (I didn't want to set it if you had > planned to later.) Sorry, I'm new here and this is my first patch =) What is cq+ or where can I read about that? 1704672 9 413227 chi187 2020-11-04 16:57:32 -0800 Created attachment 413227 Patch for landing 1704689 10 ews-feeder 2020-11-04 17:41:04 -0800 Committed r269410: <https://trac.webkit.org/changeset/269410> All reviewed patches have been landed. Closing bug and clearing flags on attachment 413227. 413161 2020-11-04 07:47:13 -0800 2020-11-04 11:10:04 -0800 Patch bug-218566-20201104184712.patch text/plain 1976 chi187 U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5MTI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvV2Vi S2l0RmluZFBhY2thZ2UuY21ha2UgYi9Tb3VyY2UvY21ha2UvV2ViS2l0RmluZFBhY2thZ2UuY21h a2UKaW5kZXggYTM1ZDE1YTRmNDlhYTUxOGE2NGFiYjY2MWJkZjIzN2I2YjBjOTJjNS4uMjQ1YWVk MGIzNDg4OTNhY2IwYTQxNTU0NzAzNzc5NjExODZmYjZjYSAxMDA2NDQKLS0tIGEvU291cmNlL2Nt YWtlL1dlYktpdEZpbmRQYWNrYWdlLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9XZWJLaXRGaW5k UGFja2FnZS5jbWFrZQpAQCAtOTEsMTAgKzkxLDEwIEBAIG1hY3JvKGZpbmRfcGFja2FnZSBwYWNr YWdlKQogCiAgICAgICAgIHNldChJQ1VfSU5DTFVERV9ESVJTICR7Q01BS0VfQklOQVJZX0RJUn0v SUNVL0hlYWRlcnMpCiAKLSAgICAgICAgIyBBcHBsZSBqdXN0IGhhcyBhIHNpbmdsZSBkeWxpYiBm b3IgSUNVCi0gICAgICAgIHNldChJQ1VfSTE4Tl9MSUJSQVJZIC91c3IvbGliL2xpYmljdWNvcmUu ZHlsaWIpCi0gICAgICAgIHNldChJQ1VfVUNfTElCUkFSWSAvdXNyL2xpYi9saWJpY3Vjb3JlLmR5 bGliKQotICAgICAgICBzZXQoSUNVX0RBVEFfTElCUkFSWSAvdXNyL2xpYi9saWJpY3Vjb3JlLmR5 bGliKQorICAgICAgICAjIEFwcGxlIGp1c3QgaGFzIGEgc2luZ2xlIHRiZCBmb3IgSUNVCisgICAg ICAgIGZpbmRfbGlicmFyeShJQ1VfSTE4Tl9MSUJSQVJZIGljdWNvcmUpCisgICAgICAgIGZpbmRf bGlicmFyeShJQ1VfVUNfTElCUkFSWSBpY3Vjb3JlKQorICAgICAgICBmaW5kX2xpYnJhcnkoSUNV X0RBVEFfTElCUkFSWSBpY3Vjb3JlKQogCiAgICAgICAgIHNldChJQ1VfTElCUkFSSUVTICR7SUNV X1VDX0xJQlJBUll9KQogICAgICAgICBzZXQoSUNVX0ZPVU5EIE9OKQpkaWZmIC0tZ2l0IGEvQ01h a2VMaXN0cy50eHQgYi9DTWFrZUxpc3RzLnR4dAppbmRleCBjN2JlYzkwM2FiNjk0ODlmYmIzNTQ2 ZTk4ODEyYzMxODM0NDg0NmMyLi45MjA1NDM0NGNmYjhlMjUzNzhiYmIzMzg2MTVlMTU2MjM4YTkz YzI3IDEwMDY0NAotLS0gYS9DTWFrZUxpc3RzLnR4dAorKysgYi9DTWFrZUxpc3RzLnR4dApAQCAt Niw3ICs2LDcgQEAKICMgbGF0dGVyIGluIHBhcnRpY3VsYXIgaGFuZGxlcyBsb2FkaW5nIGEgYnVu Y2ggb2Ygc2hhcmVkIENNYWtlIGRlZmluaXRpb25zCiAjIGFuZCBsb2FkaW5nIHRoZSBjcm9zcy1j b21waWxhdGlvbiBzZXR0aW5ncyBmcm9tIENNQUtFX1RPT0xDSEFJTl9GSUxFLgogIwotY21ha2Vf bWluaW11bV9yZXF1aXJlZChWRVJTSU9OIDMuMTApCitjbWFrZV9taW5pbXVtX3JlcXVpcmVkKFZF UlNJT04gMy4xOCkKIHByb2plY3QoV2ViS2l0KQogCiAjIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCmRp ZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggMjI1ZjY4YTQ0YWI4NzZjNDQ0 ZTQ1ZDcwNTg1YzI3OTVhYTU0ZDMwYy4uZWM1ODBhMzQxNzA3ZDM5Mjg1NDgxNTE5MTZkZDU5ZWE5 NTFiM2ViMyAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsx LDEzIEBACisyMDIwLTExLTA0ICBTZXJnZXkgUnViYW5vdiAgPGNoaTE4N0BnbWFpbC5jb20+CisK KyAgICAgICAgSlNDIGJ1aWxkIGZhaWxzIG9uIEJpZyBTdXIgMTEuMC4xIGJldGEKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxODU2NgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQ01ha2VMaXN0cy50eHQ6 CisgICAgICAgICogU291cmNlL2NtYWtlL1dlYktpdEZpbmRQYWNrYWdlLmNtYWtlOgorCiAyMDIw LTEwLTI3ICBLZWl0aCBSb2xsaW4gIDxrcm9sbGluQGFwcGxlLmNvbT4KIAogICAgICAgICBGaXgg InVzYWdlIiBtZXNzYWdlIHdoZW4gaW52b2tpbmcgYGFyIC1WYAo= 413183 2020-11-04 11:10:10 -0800 2020-11-04 11:28:36 -0800 Patch bug-218566-20201104221009.patch text/plain 1449 chi187 U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5MTI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvV2Vi S2l0RmluZFBhY2thZ2UuY21ha2UgYi9Tb3VyY2UvY21ha2UvV2ViS2l0RmluZFBhY2thZ2UuY21h a2UKaW5kZXggYTM1ZDE1YTRmNDlhYTUxOGE2NGFiYjY2MWJkZjIzN2I2YjBjOTJjNS4uMjQ1YWVk MGIzNDg4OTNhY2IwYTQxNTU0NzAzNzc5NjExODZmYjZjYSAxMDA2NDQKLS0tIGEvU291cmNlL2Nt YWtlL1dlYktpdEZpbmRQYWNrYWdlLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9XZWJLaXRGaW5k UGFja2FnZS5jbWFrZQpAQCAtOTEsMTAgKzkxLDEwIEBAIG1hY3JvKGZpbmRfcGFja2FnZSBwYWNr YWdlKQogCiAgICAgICAgIHNldChJQ1VfSU5DTFVERV9ESVJTICR7Q01BS0VfQklOQVJZX0RJUn0v SUNVL0hlYWRlcnMpCiAKLSAgICAgICAgIyBBcHBsZSBqdXN0IGhhcyBhIHNpbmdsZSBkeWxpYiBm b3IgSUNVCi0gICAgICAgIHNldChJQ1VfSTE4Tl9MSUJSQVJZIC91c3IvbGliL2xpYmljdWNvcmUu ZHlsaWIpCi0gICAgICAgIHNldChJQ1VfVUNfTElCUkFSWSAvdXNyL2xpYi9saWJpY3Vjb3JlLmR5 bGliKQotICAgICAgICBzZXQoSUNVX0RBVEFfTElCUkFSWSAvdXNyL2xpYi9saWJpY3Vjb3JlLmR5 bGliKQorICAgICAgICAjIEFwcGxlIGp1c3QgaGFzIGEgc2luZ2xlIHRiZCBmb3IgSUNVCisgICAg ICAgIGZpbmRfbGlicmFyeShJQ1VfSTE4Tl9MSUJSQVJZIGljdWNvcmUpCisgICAgICAgIGZpbmRf bGlicmFyeShJQ1VfVUNfTElCUkFSWSBpY3Vjb3JlKQorICAgICAgICBmaW5kX2xpYnJhcnkoSUNV X0RBVEFfTElCUkFSWSBpY3Vjb3JlKQogCiAgICAgICAgIHNldChJQ1VfTElCUkFSSUVTICR7SUNV X1VDX0xJQlJBUll9KQogICAgICAgICBzZXQoSUNVX0ZPVU5EIE9OKQpkaWZmIC0tZ2l0IGEvQ2hh bmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IDIyNWY2OGE0NGFiODc2YzQ0NGU0NWQ3MDU4NWMyNzk1 YWE1NGQzMGMuLmVjNTgwYTM0MTcwN2QzOTI4NTQ4MTUxOTE2ZGQ1OWVhOTUxYjNlYjMgMTAwNjQ0 Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAyMC0x MS0wNCAgU2VyZ2V5IFJ1YmFub3YgIDxjaGkxODdAZ21haWwuY29tPgorCisgICAgICAgIEpTQyBi dWlsZCBmYWlscyBvbiBCaWcgU3VyIDExLjAuMSBiZXRhCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTg1NjYKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIENNYWtlTGlzdHMudHh0OgorICAgICAgICAqIFNv dXJjZS9jbWFrZS9XZWJLaXRGaW5kUGFja2FnZS5jbWFrZToKKwogMjAyMC0xMC0yNyAgS2VpdGgg Um9sbGluICA8a3JvbGxpbkBhcHBsZS5jb20+CiAKICAgICAgICAgRml4ICJ1c2FnZSIgbWVzc2Fn ZSB3aGVuIGludm9raW5nIGBhciAtVmAK 413190 2020-11-04 11:28:45 -0800 2020-11-04 16:57:26 -0800 Patch bug-218566-20201104222843.patch text/plain 1421 chi187 U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5MTI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvV2Vi S2l0RmluZFBhY2thZ2UuY21ha2UgYi9Tb3VyY2UvY21ha2UvV2ViS2l0RmluZFBhY2thZ2UuY21h a2UKaW5kZXggYTM1ZDE1YTRmNDlhYTUxOGE2NGFiYjY2MWJkZjIzN2I2YjBjOTJjNS4uNjJmNTBj MjgyYTdkMTczMDE2MzU3MzdjZWIyMzgwZTVkOTllMDk2NyAxMDA2NDQKLS0tIGEvU291cmNlL2Nt YWtlL1dlYktpdEZpbmRQYWNrYWdlLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9XZWJLaXRGaW5k UGFja2FnZS5jbWFrZQpAQCAtOTEsMTAgKzkxLDEwIEBAIG1hY3JvKGZpbmRfcGFja2FnZSBwYWNr YWdlKQogCiAgICAgICAgIHNldChJQ1VfSU5DTFVERV9ESVJTICR7Q01BS0VfQklOQVJZX0RJUn0v SUNVL0hlYWRlcnMpCiAKLSAgICAgICAgIyBBcHBsZSBqdXN0IGhhcyBhIHNpbmdsZSBkeWxpYiBm b3IgSUNVCi0gICAgICAgIHNldChJQ1VfSTE4Tl9MSUJSQVJZIC91c3IvbGliL2xpYmljdWNvcmUu ZHlsaWIpCi0gICAgICAgIHNldChJQ1VfVUNfTElCUkFSWSAvdXNyL2xpYi9saWJpY3Vjb3JlLmR5 bGliKQotICAgICAgICBzZXQoSUNVX0RBVEFfTElCUkFSWSAvdXNyL2xpYi9saWJpY3Vjb3JlLmR5 bGliKQorICAgICAgICAjIEFwcGxlIGp1c3QgaGFzIGEgc2luZ2xlIHRiZC9keWxpYiBmb3IgSUNV LgorICAgICAgICBmaW5kX2xpYnJhcnkoSUNVX0kxOE5fTElCUkFSWSBpY3Vjb3JlKQorICAgICAg ICBmaW5kX2xpYnJhcnkoSUNVX1VDX0xJQlJBUlkgaWN1Y29yZSkKKyAgICAgICAgZmluZF9saWJy YXJ5KElDVV9EQVRBX0xJQlJBUlkgaWN1Y29yZSkKIAogICAgICAgICBzZXQoSUNVX0xJQlJBUklF UyAke0lDVV9VQ19MSUJSQVJZfSkKICAgICAgICAgc2V0KElDVV9GT1VORCBPTikKZGlmZiAtLWdp dCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAyMjVmNjhhNDRhYjg3NmM0NDRlNDVkNzA1 ODVjMjc5NWFhNTRkMzBjLi4yOTI3YTk2Y2Y5ZDAzYzZlMDI4MGFjN2RkZjNmYmRjZjc0NzM0NTU4 IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAK KzIwMjAtMTEtMDQgIFNlcmdleSBSdWJhbm92ICA8Y2hpMTg3QGdtYWlsLmNvbT4KKworICAgICAg ICBGaXggSlNDIGJ1aWxkIG9uIG1hY09TIEJpZyBTdXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxODU2NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogU291cmNlL2NtYWtlL1dlYktpdEZpbmRQYWNrYWdl LmNtYWtlOgorCiAyMDIwLTEwLTI3ICBLZWl0aCBSb2xsaW4gIDxrcm9sbGluQGFwcGxlLmNvbT4K IAogICAgICAgICBGaXggInVzYWdlIiBtZXNzYWdlIHdoZW4gaW52b2tpbmcgYGFyIC1WYAo= 413227 2020-11-04 16:57:32 -0800 2020-11-04 17:41:05 -0800 Patch for landing bug-218566-20201105035731.patch text/plain 1419 chi187 U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5MTI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvV2Vi S2l0RmluZFBhY2thZ2UuY21ha2UgYi9Tb3VyY2UvY21ha2UvV2ViS2l0RmluZFBhY2thZ2UuY21h a2UKaW5kZXggYTM1ZDE1YTRmNDlhYTUxOGE2NGFiYjY2MWJkZjIzN2I2YjBjOTJjNS4uNjJmNTBj MjgyYTdkMTczMDE2MzU3MzdjZWIyMzgwZTVkOTllMDk2NyAxMDA2NDQKLS0tIGEvU291cmNlL2Nt YWtlL1dlYktpdEZpbmRQYWNrYWdlLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9XZWJLaXRGaW5k UGFja2FnZS5jbWFrZQpAQCAtOTEsMTAgKzkxLDEwIEBAIG1hY3JvKGZpbmRfcGFja2FnZSBwYWNr YWdlKQogCiAgICAgICAgIHNldChJQ1VfSU5DTFVERV9ESVJTICR7Q01BS0VfQklOQVJZX0RJUn0v SUNVL0hlYWRlcnMpCiAKLSAgICAgICAgIyBBcHBsZSBqdXN0IGhhcyBhIHNpbmdsZSBkeWxpYiBm b3IgSUNVCi0gICAgICAgIHNldChJQ1VfSTE4Tl9MSUJSQVJZIC91c3IvbGliL2xpYmljdWNvcmUu ZHlsaWIpCi0gICAgICAgIHNldChJQ1VfVUNfTElCUkFSWSAvdXNyL2xpYi9saWJpY3Vjb3JlLmR5 bGliKQotICAgICAgICBzZXQoSUNVX0RBVEFfTElCUkFSWSAvdXNyL2xpYi9saWJpY3Vjb3JlLmR5 bGliKQorICAgICAgICAjIEFwcGxlIGp1c3QgaGFzIGEgc2luZ2xlIHRiZC9keWxpYiBmb3IgSUNV LgorICAgICAgICBmaW5kX2xpYnJhcnkoSUNVX0kxOE5fTElCUkFSWSBpY3Vjb3JlKQorICAgICAg ICBmaW5kX2xpYnJhcnkoSUNVX1VDX0xJQlJBUlkgaWN1Y29yZSkKKyAgICAgICAgZmluZF9saWJy YXJ5KElDVV9EQVRBX0xJQlJBUlkgaWN1Y29yZSkKIAogICAgICAgICBzZXQoSUNVX0xJQlJBUklF UyAke0lDVV9VQ19MSUJSQVJZfSkKICAgICAgICAgc2V0KElDVV9GT1VORCBPTikKZGlmZiAtLWdp dCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAyMjVmNjhhNDRhYjg3NmM0NDRlNDVkNzA1 ODVjMjc5NWFhNTRkMzBjLi4xNDdkMGYxMzVmMDdmNWQyOTMyMDNlMjhiYjY1OWIyYTgwYmYzOTA3 IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAK KzIwMjAtMTEtMDQgIFNlcmdleSBSdWJhbm92ICA8Y2hpMTg3QGdtYWlsLmNvbT4KKworICAgICAg ICBGaXggSlNDIGJ1aWxkIG9uIG1hY09TIEJpZyBTdXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxODU2NgorCisgICAgICAgIFJldmlld2VkIGJ5IERh dmlkIEtpbHplci4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9XZWJLaXRGaW5kUGFja2FnZS5j bWFrZToKKwogMjAyMC0xMC0yNyAgS2VpdGggUm9sbGluICA8a3JvbGxpbkBhcHBsZS5jb20+CiAK ICAgICAgICAgRml4ICJ1c2FnZSIgbWVzc2FnZSB3aGVuIGludm9raW5nIGBhciAtVmAK