218561 2020-11-04 05:42:02 -0800 REGRESSION (r257839): Miscomputed style due to computed 'rem' value in matched declaration cache 2020-11-04 14:05:04 -0800 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 koivisto webkit-unassigned zalan oldest_to_newest 1704376 0 koivisto 2020-11-04 05:42:02 -0800 Call to focus() causes computed style update for the element’s ancestor chain before the the document has otherwise been styled (using the shortcut mechanism introduced in r257839). This style, which uses ‘rem’ unit and so depends on root element font size, gets cached in MatchedDeclarationsCache. The root font size then changes but during the resulting style update we use this cached value, failing to re-resolve ‘rem’. 1704377 1 koivisto 2020-11-04 05:42:36 -0800 <rdar://problem/70074191> 1704380 2 413157 koivisto 2020-11-04 05:48:58 -0800 Created attachment 413157 patch 1704597 3 ews-feeder 2020-11-04 14:05:03 -0800 Committed r269384: <https://trac.webkit.org/changeset/269384> All reviewed patches have been landed. Closing bug and clearing flags on attachment 413157. 413157 2020-11-04 05:48:58 -0800 2020-11-04 14:05:04 -0800 patch focus-rem-style-update.patch text/plain 4041 koivisto ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAwZDZjNjJlNmMxOGMuLmNmYzNhOTc2MGY4YSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBA CisyMDIwLTExLTA0ICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAg ICBSRUdSRVNTSU9OIChyMjU3ODM5KTogTWlzY29tcHV0ZWQgc3R5bGUgZHVlIHRvIGNvbXB1dGVk ICdyZW0nIHZhbHVlIGluIG1hdGNoZWQgZGVjbGFyYXRpb24gY2FjaGUKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxODU2MQorICAgICAgICA8cmRhcjov L3Byb2JsZW0vNzAwNzQxOTE+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBmYXN0L2RvbS9mb2N1cy1yZW0tc3R5bGUtdXBkYXRlLWV4cGVjdGVkLmh0 bWw6IEFkZGVkLgorICAgICAgICAqIGZhc3QvZG9tL2ZvY3VzLXJlbS1zdHlsZS11cGRhdGUuaHRt bDogQWRkZWQuCisKIDIwMjAtMTEtMDMgIENhcmxvcyBBbGJlcnRvIExvcGV6IFBlcmV6ICA8Y2xv cGV6QGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS11bV1BFXSBNb3ZlIHBhc3NpbmcgdGVzdHMg dG8gdGhlIHRvcCBvZiB0aGUgVGVzdEV4cGVjdGF0aW9uIGZpbGVzLgpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvZmFzdC9kb20vZm9jdXMtcmVtLXN0eWxlLXVwZGF0ZS1leHBlY3RlZC5odG1sIGIv TGF5b3V0VGVzdHMvZmFzdC9kb20vZm9jdXMtcmVtLXN0eWxlLXVwZGF0ZS1leHBlY3RlZC5odG1s Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMC4uZmI1MjNkYjcyMTBiCi0t LSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vZm9jdXMtcmVtLXN0eWxlLXVw ZGF0ZS1leHBlY3RlZC5odG1sCkBAIC0wLDAgKzEsNyBAQAorPGh0bWw+Cis8c3R5bGU+CitkaXYg eyB3aWR0aDoxMDBweDsgaGVpZ2h0OjEwMHB4OyBiYWNrZ3JvdW5kOiBncmVlbjsgfQorPC9zdHls ZT4KKzxib2R5PgorPGRpdj4KKzwvZGl2PgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9k b20vZm9jdXMtcmVtLXN0eWxlLXVwZGF0ZS5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vZm9j dXMtcmVtLXN0eWxlLXVwZGF0ZS5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAw MDAwMDAwMC4uZWQxZjg5ZjZmOGY1Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFz dC9kb20vZm9jdXMtcmVtLXN0eWxlLXVwZGF0ZS5odG1sCkBAIC0wLDAgKzEsMTQgQEAKKzxodG1s PgorPHN0eWxlPgorYm9keSB7IGZvbnQtc2l6ZTogMXB4OyB9CitkaXYgeyB3aWR0aDogNXJlbTsg aGVpZ2h0OjEwMHB4OyBiYWNrZ3JvdW5kOiBncmVlbjsgfQorPC9zdHlsZT4KKzxib2R5PgorPGRp dj4KKzxzcGFuPjwvc3Bhbj4KKzwvZGl2PgorPHNjcmlwdD4KK2RvY3VtZW50LnF1ZXJ5U2VsZWN0 b3IoJ2RpdicpLmlzQ29udGVudEVkaXRhYmxlOworZG9jdW1lbnQucXVlcnlTZWxlY3Rvcignc3Bh bicpLmZvY3VzKCk7Citkb2N1bWVudC5xdWVyeVNlbGVjdG9yKCdodG1sJykuc3R5bGUuZm9udFNp emUgPSAnMjBweCc7Cis8L3NjcmlwdD4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA4YzU2NTQyZjU1OGQuLmJlMDNl YzkxZjUxMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDIwLTExLTA0ICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMjU3ODM5 KTogTWlzY29tcHV0ZWQgc3R5bGUgZHVlIHRvIGNvbXB1dGVkICdyZW0nIHZhbHVlIGluIG1hdGNo ZWQgZGVjbGFyYXRpb24gY2FjaGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTIxODU2MQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNzAwNzQxOTE+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdDogZmFz dC9kb20vZm9jdXMtcmVtLXN0eWxlLXVwZGF0ZS5odG1sCisKKyAgICAgICAgQ2FsbCB0byBmb2N1 cygpIGNhdXNlcyBjb21wdXRlZCBzdHlsZSB1cGRhdGUgZm9yIHRoZSBlbGVtZW504oCZcyBhbmNl c3RvciBjaGFpbiBiZWZvcmUgdGhlIHRoZSBkb2N1bWVudAorICAgICAgICBoYXMgb3RoZXJ3aXNl IGJlZW4gc3R5bGVkICh1c2luZyB0aGUgc2hvcnRjdXQgbWVjaGFuaXNtIGludHJvZHVjZWQgaW4g cjI1NzgzOSkuIFRoaXMgc3R5bGUsIHdoaWNoIHVzZXMg4oCYcmVt4oCZCisgICAgICAgIHVuaXQg YW5kIHNvIGRlcGVuZHMgb24gcm9vdCBlbGVtZW50IGZvbnQgc2l6ZSwgZ2V0cyBjYWNoZWQgaW4g TWF0Y2hlZERlY2xhcmF0aW9uc0NhY2hlLiBUaGUgcm9vdCBmb250IHNpemUKKyAgICAgICAgdGhl biBjaGFuZ2VzIGJ1dCBkdXJpbmcgdGhlIHJlc3VsdGluZyBzdHlsZSB1cGRhdGUgd2UgdXNlIHRo aXMgY2FjaGVkIHZhbHVlLCBmYWlsaW5nIHRvIHJlLXJlc29sdmUg4oCYcmVt4oCZLgorCisgICAg ICAgICogc3R5bGUvU3R5bGVUcmVlUmVzb2x2ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U3R5 bGU6OlRyZWVSZXNvbHZlcjo6cmVzb2x2ZUVsZW1lbnQpOgorCisgICAgICAgIEludmFsaWRhdGUg bWF0Y2hlZCBkZWNsYXJhdGlvbnMgY2FjaGUgYWxzbyB3aGVuIHRoZXJlIGlzIG5vIGV4aXN0aW5n IGRvY3VtZW50IGVsZW1lbnQgc3R5bGUuCisKIDIwMjAtMTEtMDMgIEFudHRpIEtvaXZpc3RvICA8 YW50dGlAYXBwbGUuY29tPgogCiAgICAgICAgIFtMRkNdW0ludGVncmF0aW9uXSBSZW5kZXJUZXh0 OjphYnNvbHV0ZVF1YWRzIHNob3VsZCB1c2UgaXRlcmF0b3IKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3N0eWxlL1N0eWxlVHJlZVJlc29sdmVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3N0eWxl L1N0eWxlVHJlZVJlc29sdmVyLmNwcAppbmRleCA2MTQzNjZiOTAxMmYuLmRiZTE0NjI3MDcyMSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvc3R5bGUvU3R5bGVUcmVlUmVzb2x2ZXIuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL3N0eWxlL1N0eWxlVHJlZVJlc29sdmVyLmNwcApAQCAtMjI0LDkg KzIyNCw4IEBAIEVsZW1lbnRVcGRhdGVzIFRyZWVSZXNvbHZlcjo6cmVzb2x2ZUVsZW1lbnQoRWxl bWVudCYgZWxlbWVudCkKICAgICAgICAgbV9kb2N1bWVudEVsZW1lbnRTdHlsZSA9IFJlbmRlclN0 eWxlOjpjbG9uZVB0cigqdXBkYXRlLnN0eWxlKTsKICAgICAgICAgc2NvcGUoKS5yZXNvbHZlci5z ZXRPdmVycmlkZURvY3VtZW50RWxlbWVudFN0eWxlKG1fZG9jdW1lbnRFbGVtZW50U3R5bGUuZ2V0 KCkpOwogCi0gICAgICAgIGlmICh1cGRhdGUuY2hhbmdlICE9IENoYW5nZTo6Tm9uZSAmJiBleGlz dGluZ1N0eWxlICYmIGV4aXN0aW5nU3R5bGUtPmNvbXB1dGVkRm9udFBpeGVsU2l6ZSgpICE9IHVw ZGF0ZS5zdHlsZS0+Y29tcHV0ZWRGb250UGl4ZWxTaXplKCkpIHsKKyAgICAgICAgaWYgKCFleGlz dGluZ1N0eWxlIHx8IGV4aXN0aW5nU3R5bGUtPmNvbXB1dGVkRm9udFBpeGVsU2l6ZSgpICE9IHVw ZGF0ZS5zdHlsZS0+Y29tcHV0ZWRGb250UGl4ZWxTaXplKCkpIHsKICAgICAgICAgICAgIC8vICJy ZW0iIHVuaXRzIGFyZSByZWxhdGl2ZSB0byB0aGUgZG9jdW1lbnQgZWxlbWVudCdzIGZvbnQgc2l6 ZSBzbyB3ZSBuZWVkIHRvIHJlY29tcHV0ZSBldmVyeXRoaW5nLgotICAgICAgICAgICAgLy8gSW4g cHJhY3RpY2UgdGhpcyBpcyByYXJlLgogICAgICAgICAgICAgc2NvcGUoKS5yZXNvbHZlci5pbnZh bGlkYXRlTWF0Y2hlZERlY2xhcmF0aW9uc0NhY2hlKCk7CiAgICAgICAgICAgICBkZXNjZW5kYW50 c1RvUmVzb2x2ZSA9IERlc2NlbmRhbnRzVG9SZXNvbHZlOjpBbGw7CiAgICAgICAgIH0K