218558 2020-11-04 03:46:12 -0800 WKContentView might get KVO notifications it doesn't expect 2020-11-04 10:44:56 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dino dino thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1704365 0 dino 2020-11-04 03:46:12 -0800 WKContextView might get KVO notifications it doesn't expect 1704367 1 webkit-bug-importer 2020-11-04 03:47:00 -0800 <rdar://problem/71031491> 1704369 2 413154 dino 2020-11-04 03:55:44 -0800 Created attachment 413154 Patch 1704370 3 413154 thorton 2020-11-04 04:01:55 -0800 Comment on attachment 413154 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=413154&action=review > Source/WebKit/ChangeLog:3 > + WKContextView might get KVO notifications it doesn't expect I think the title means WKContentView > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:739 > - [self.layer addObserver:self forKeyPath:@"transform" options:NSKeyValueObservingOptionInitial context:nil]; > + [self.layer addObserver:self forKeyPath:@"transform" options:NSKeyValueObservingOptionInitial context:WKContentViewKVOTransformContext]; Should we use the context in the deregistration too? I feel like there is some documented benefit. 1704470 4 413154 dino 2020-11-04 09:42:39 -0800 Comment on attachment 413154 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=413154&action=review >> Source/WebKit/ChangeLog:3 >> + WKContextView might get KVO notifications it doesn't expect > > I think the title means WKContentView Yep! Thanks. >> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:739 >> + [self.layer addObserver:self forKeyPath:@"transform" options:NSKeyValueObservingOptionInitial context:WKContentViewKVOTransformContext]; > > Should we use the context in the deregistration too? I feel like there is some documented benefit. OK! 1704493 5 dino 2020-11-04 10:44:56 -0800 Committed r269372: <https://trac.webkit.org/changeset/269372> 413154 2020-11-04 03:55:44 -0800 2020-11-04 04:01:55 -0800 Patch bug-218558-20201104225543.patch text/plain 3069 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5MzQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDYzODhiOWMzYTJhZGE3MTk4 MDJhOTEyN2Y1YTYwNWE1OWY5OGEwODIuLjE1OTM2NjQzYWYzZWQ1NTA0Yzk3NDYzMDIwMDgzYzFk ZDUwNzE0OTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMjAtMTEtMDQgIERlYW4gSmFj a3NvbiAgPGRpbm9AYXBwbGUuY29tPgorCisgICAgICAgIFdLQ29udGV4dFZpZXcgbWlnaHQgZ2V0 IEtWTyBub3RpZmljYXRpb25zIGl0IGRvZXNuJ3QgZXhwZWN0CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTg1NTgKKyAgICAgICAgPHJkYXI6Ly9wcm9i bGVtLzcxMDMxNDkxPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEl0J3MgcG9zc2libGUgdGhhdCBjb2RlIGVsc2V3aGVyZSBpbiB0aGUgc3lzdGVtIGFk ZHMgS1ZPCisgICAgICAgIG9ic2VydmF0aW9uIHRvIHRoZSBDQUxheWVyIG9mIGEgV0tDb250ZW50 Vmlldywgd2hpY2ggaXMKKyAgICAgICAgYSBwcm9ibGVtIGJlY2F1c2Ugb3VyIGltcGxlbWVudGF0 aW9uIG9mIG9ic2VydmVWYWx1ZSBvbmx5CisgICAgICAgIGV4cGVjdHMgY2FsbHMgdGhhdCBpdCBy ZWdpc3RlcmVkIGZvci4gRml4IHRoaXMgYnkgcGFzc2luZworICAgICAgICBhIGNvbnRleHQgdG8g dGhlIHJlZ2lzdHJhdGlvbiBhbmQgcGFzc2luZyB0aGUgb2JzZXJ2YXRpb24KKyAgICAgICAgY2Fs bCBvbnRvIHRoZSBzdXBlcmNsYXNzIGlmIGl0IGlzbid0IHRoZSBleHBlY3RlZCBjb250ZXh0Lgor CisgICAgICAgICogVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW06Cisg ICAgICAgICgtW1dLQ29udGVudFZpZXcgc2V0VXBJbnRlcmFjdGlvbl0pOgorICAgICAgICAoLVtX S0NvbnRlbnRWaWV3IG9ic2VydmVWYWx1ZUZvcktleVBhdGg6b2ZPYmplY3Q6Y2hhbmdlOmNvbnRl eHQ6XSk6CisKIDIwMjAtMTEtMDMgIEJyZW50IEZ1bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+ CiAKICAgICAgICAgW21hY09TXSByZW1vdmUgc3lzY3RsLm9pZGZtdC4gYWNjZXNzCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9u Lm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlv bi5tbQppbmRleCBkZDg5YzBmMGFmYTgyYjEzMGQ1MjQyZWQxYzk5ZDZlMmJiZjU1ODg5Li5lOTky ODAwMjljOGUxZjlhMjZmZmE2ZmZjZDQwN2I3MjlhMjE2Yjk3IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCisrKyBiL1Nv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KQEAg LTE4NSw2ICsxODUsOCBAQCBzdGF0aWMgTlNTdHJpbmcgKiBjb25zdCBlZGl0YWJsZVBvaW50ZXJS ZWdpb25JZGVudGlmaWVyID0gQCJXS0VkaXRhYmxlUG9pbnRlclJlZwogQGVuZAogI2VuZGlmCiAK K3N0YXRpYyB2b2lkICpXS0NvbnRlbnRWaWV3S1ZPVHJhbnNmb3JtQ29udGV4dCA9ICZXS0NvbnRl bnRWaWV3S1ZPVHJhbnNmb3JtQ29udGV4dDsKKwogbmFtZXNwYWNlIFdlYktpdCB7CiB1c2luZyBu YW1lc3BhY2UgV2ViQ29yZTsKIHVzaW5nIG5hbWVzcGFjZSBXZWJLaXQ7CkBAIC03MzQsNyArNzM2 LDcgQEAgc3RhdGljIFdLRHJhZ1Nlc3Npb25Db250ZXh0ICplbnN1cmVMb2NhbERyYWdTZXNzaW9u Q29udGV4dChpZCA8VUlEcmFnU2Vzc2lvbj4gc2UKICAgICBfa2V5Ym9hcmRTY3JvbGxpbmdBbmlt YXRvciA9IGFkb3B0TlMoW1tXS0tleWJvYXJkU2Nyb2xsVmlld0FuaW1hdG9yIGFsbG9jXSBpbml0 V2l0aFNjcm9sbFZpZXc6c2VsZi53ZWJWaWV3LnNjcm9sbFZpZXddKTsKICAgICBbX2tleWJvYXJk U2Nyb2xsaW5nQW5pbWF0b3Igc2V0RGVsZWdhdGU6c2VsZl07CiAKLSAgICBbc2VsZi5sYXllciBh ZGRPYnNlcnZlcjpzZWxmIGZvcktleVBhdGg6QCJ0cmFuc2Zvcm0iIG9wdGlvbnM6TlNLZXlWYWx1 ZU9ic2VydmluZ09wdGlvbkluaXRpYWwgY29udGV4dDpuaWxdOworICAgIFtzZWxmLmxheWVyIGFk ZE9ic2VydmVyOnNlbGYgZm9yS2V5UGF0aDpAInRyYW5zZm9ybSIgb3B0aW9uczpOU0tleVZhbHVl T2JzZXJ2aW5nT3B0aW9uSW5pdGlhbCBjb250ZXh0OldLQ29udGVudFZpZXdLVk9UcmFuc2Zvcm1D b250ZXh0XTsKIAogICAgIF90b3VjaEFjdGlvbkxlZnRTd2lwZUdlc3R1cmVSZWNvZ25pemVyID0g YWRvcHROUyhbW1VJU3dpcGVHZXN0dXJlUmVjb2duaXplciBhbGxvY10gaW5pdFdpdGhUYXJnZXQ6 bmlsIGFjdGlvbjpuaWxdKTsKICAgICBbX3RvdWNoQWN0aW9uTGVmdFN3aXBlR2VzdHVyZVJlY29n bml6ZXIgc2V0RGlyZWN0aW9uOlVJU3dpcGVHZXN0dXJlUmVjb2duaXplckRpcmVjdGlvbkxlZnRd OwpAQCAtMTE3Myw2ICsxMTc1LDExIEBAIHN0YXRpYyBXS0RyYWdTZXNzaW9uQ29udGV4dCAqZW5z dXJlTG9jYWxEcmFnU2Vzc2lvbkNvbnRleHQoaWQgPFVJRHJhZ1Nlc3Npb24+IHNlCiAKIC0gKHZv aWQpb2JzZXJ2ZVZhbHVlRm9yS2V5UGF0aDooTlNTdHJpbmcgKilrZXlQYXRoIG9mT2JqZWN0Oihp ZClvYmplY3QgY2hhbmdlOihOU0RpY3Rpb25hcnkgKiljaGFuZ2UgY29udGV4dDoodm9pZCAqKWNv bnRleHQKIHsKKyAgICBpZiAoY29udGV4dCAhPSBXS0NvbnRlbnRWaWV3S1ZPVHJhbnNmb3JtQ29u dGV4dCkgeworICAgICAgICBbc3VwZXIgb2JzZXJ2ZVZhbHVlRm9yS2V5UGF0aDprZXlQYXRoIG9m T2JqZWN0Om9iamVjdCBjaGFuZ2U6Y2hhbmdlIGNvbnRleHQ6Y29udGV4dF07CisgICAgICAgIHJl dHVybjsKKyAgICB9CisKICAgICBBU1NFUlQoW2tleVBhdGggaXNFcXVhbFRvU3RyaW5nOkAidHJh bnNmb3JtIl0pOwogICAgIEFTU0VSVChvYmplY3QgPT0gc2VsZi5sYXllcik7CiAK