218492 2020-11-03 02:35:28 -0800 Null Ptr Deref @ WebCore::DeleteSelectionCommand::doApply+19653 2021-02-26 07:08:04 -0800 1 1 1 Unclassified WebKit HTML Editing WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 iang rbuis achristensen bfulgham cgarcia ews-feeder ews-watchlist gpoo mifenton product-security rbuis rniwa rwlbuis svillar webkit-bug-importer wenson_hsieh oldest_to_newest 1703881 0 iang 2020-11-03 02:35:28 -0800 Description: Crash found by fuzzing. Reproduces on WebKit revision 269268. Stack Trace ========= frame #0: WebCore`WebCore::DeleteSelectionCommand::doApply()+19653 frame #1: WebCore`WebCore::CompositeEditCommand::applyCommandToComposite(WTF::Ref<WebCore::EditCommand, WTF::DumbPtrTraits<WebCore::EditCommand> >&&)+79 frame #2: WebCore`WebCore::TypingCommand::deleteKeyPressed(WebCore::TextGranularity, bool)+7376 frame #3: WebCore`WebCore::CompositeEditCommand::apply()+385 frame #4: WebCore`WebCore::TypingCommand::deleteKeyPressed(WebCore::Document&, unsigned int, WebCore::TextGranularity)+331 frame #5: WebCore`WebCore::executeDelete(WebCore::Frame&, WebCore::Event*, WebCore::EditorCommandSource, WTF::String const&)+85 frame #6: WebCore`WebCore::Document::execCommand(WTF::String const&, bool, WTF::String const&)+77 frame #7: WebCore`WebCore::jsDocumentPrototypeFunctionExecCommand(JSC::JSGlobalObject*, JSC::CallFrame*)+426 frame #8: JavaScriptCore`llint_entry+102726 frame #9: JavaScriptCore`vmEntryToJavaScript+200 frame #10: JavaScriptCore`JSC::Interpreter::executeCall(JSC::JSGlobalObject*, JSC::JSObject*, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&)+582 1703882 1 webkit-bug-importer 2020-11-03 02:35:39 -0800 <rdar://problem/70987165> 1703883 2 413026 iang 2020-11-03 02:36:29 -0800 Created attachment 413026 Crashing input 1704166 3 rniwa 2020-11-03 13:07:05 -0800 <rdar://problem/67426413> 1704816 4 rbuis 2020-11-05 05:08:22 -0800 Bt on Linux GTK: ASSERTION FAILED: endingSelection().isCaretOrRange() ../../Source/WebCore/editing/CompositeEditCommand.cpp(1487) : void WebCore::CompositeEditCommand::moveParagraphs(const WebCore::VisiblePosition&, const WebCore::VisiblePosition&, const WebCore::VisiblePosition&, bool, bool) 1 0x7fa333f023d1 WTFCrash 2 0x7fa3426fa097 /app/webkit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(+0xcc39097) [0x7fa3426fa097] 3 0x7fa3474bba4a WebCore::CompositeEditCommand::moveParagraphs(WebCore::VisiblePosition const&, WebCore::VisiblePosition const&, WebCore::VisiblePosition const&, bool, bool) 4 0x7fa3474baf15 WebCore::CompositeEditCommand::moveParagraph(WebCore::VisiblePosition const&, WebCore::VisiblePosition const&, WebCore::VisiblePosition const&, bool, bool) 5 0x7fa345885316 WebCore::DeleteSelectionCommand::mergeParagraphs() 6 0x7fa345886303 WebCore::DeleteSelectionCommand::doApply() 7 0x7fa3474b556c WebCore::CompositeEditCommand::applyCommandToComposite(WTF::Ref<WebCore::EditCommand, WTF::RawPtrTraits<WebCore::EditCommand> >&&) 8 0x7fa3474b7d6c WebCore::CompositeEditCommand::deleteSelection(WebCore::VisibleSelection const&, bool, bool, bool, bool, bool) 9 0x7fa34592067f WebCore::TypingCommand::deleteKeyPressed(WebCore::TextGranularity, bool) 10 0x7fa34591e339 WebCore::TypingCommand::doApply() 11 0x7fa3474b4fde WebCore::CompositeEditCommand::apply() 12 0x7fa34591d46f WebCore::TypingCommand::deleteKeyPressed(WebCore::Document&, unsigned int, WebCore::TextGranularity) 13 0x7fa3458b8c89 /app/webkit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(+0xfdf7c89) [0x7fa3458b8c89] 14 0x7fa3458bdf66 WebCore::Editor::Command::execute(WTF::String const&, WebCore::Event*) const 15 0x7fa345653dd9 WebCore::Document::execCommand(WTF::String const&, bool, WTF::String const&) 1704817 5 413284 rbuis 2020-11-05 05:09:54 -0800 Created attachment 413284 Slightly reduced testcase 1705100 6 413384 rniwa 2020-11-05 18:50:42 -0800 Created attachment 413384 Reduced test case 1706984 7 413968 rbuis 2020-11-12 12:55:48 -0800 Created attachment 413968 Patch 1707045 8 413968 achristensen 2020-11-12 15:16:17 -0800 Comment on attachment 413968 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=413968&action=review Is this a UAF? If not, could we just include the test with the fix? > Source/WebCore/editing/DeleteSelectionCommand.cpp:764 > + if (endingSelection().start().anchorNode() && endingSelection().start().anchorNode()->isConnected()) C++17 if with initializer would be useful here so we don't have to call start and anchorNode twice. if (auto* anchorNode = endingSelection.start().anchorNode(); anchorNode && anchorNode->isConnected()) 1707118 9 413968 rniwa 2020-11-12 21:36:52 -0800 Comment on attachment 413968 Patch Yeah this doesn't look like a security issue. Please include the test. 1707183 10 414027 rbuis 2020-11-13 03:17:21 -0800 Created attachment 414027 Patch 1707219 11 413968 rbuis 2020-11-13 06:29:35 -0800 Comment on attachment 413968 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=413968&action=review >> Source/WebCore/editing/DeleteSelectionCommand.cpp:764 >> + if (endingSelection().start().anchorNode() && endingSelection().start().anchorNode()->isConnected()) > > C++17 if with initializer would be useful here so we don't have to call start and anchorNode twice. > if (auto* anchorNode = endingSelection.start().anchorNode(); anchorNode && anchorNode->isConnected()) Nice! Done. 1707220 12 414027 rbuis 2020-11-13 06:30:11 -0800 Comment on attachment 414027 Patch Testcase is added. 1707236 13 ews-feeder 2020-11-13 08:01:04 -0800 Committed r269776: <https://trac.webkit.org/changeset/269776> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414027. 1707400 14 ryanhaddad 2020-11-13 14:51:05 -0800 The test added with this change appears to be asserting on debug bots: ASSERTION FAILED: endingSelection().isCaretOrRange() ./editing/CompositeEditCommand.cpp(1487) : void WebCore::CompositeEditCommand::moveParagraphs(const WebCore::VisiblePosition &, const WebCore::VisiblePosition &, const WebCore::VisiblePosition &, bool, bool) https://build.webkit.org/results/Apple-Catalina-Debug-WK1-Tests/r269785%20(8307)/results.html https://results.webkit.org/?suite=layout-tests&test=editing%2Fdeleting%2Fdelete-contenteditable-crash.html 1707401 15 ryanhaddad 2020-11-13 14:57:17 -0800 Reverted r269776 for reason: The test added with this change is asserting Committed r269803: <https://trac.webkit.org/changeset/269803> 1708163 16 414321 rbuis 2020-11-17 01:56:35 -0800 Created attachment 414321 Patch 1708195 17 414321 rbuis 2020-11-17 05:24:08 -0800 Comment on attachment 414321 Patch As suspected, after landing 414321 the test case now passes on Debug (Mac-debug-wk1). 1708242 18 ews-feeder 2020-11-17 08:29:49 -0800 Committed r269902: <https://trac.webkit.org/changeset/269902> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414321. 413026 2020-11-03 02:36:29 -0800 2020-11-05 18:50:42 -0800 Crashing input bug218492.html text/html 1698 iang PHN0eWxlPgojaHRtbHZhcjAwMDA5LCAuY2xhc3M0LCBwYXJhbTpsYXN0LW9mLXR5cGUgeyBpbmhl cml0OyAtd2Via2l0LXVzZXItbW9kaWZ5OiByZWFkLXdyaXRlOyB9DQo8L3N0eWxlPgo8c2NyaXB0 PgpmdW5jdGlvbiBmcmVlbWVtb3J5KCkgewp9CmZ1bmN0aW9uIEdldFZhcmlhYmxlKGZ1enplcnZh cnMsIHZhcl90eXBlKSB7IHsgcmV0dXJuIGZ1enplcnZhcnNbdmFyX3R5cGVdOyB9fQpmdW5jdGlv biBTZXRWYXJpYWJsZShmdXp6ZXJ2YXJzLCB2YXJfbmFtZSwgdmFyX3R5cGUpIHsgZnV6emVydmFy c1t2YXJfdHlwZV0gPSB2YXJfbmFtZTsgfQpmdW5jdGlvbiBqc2Z1enplcigpIHsKdHJ5IHsgLyog Ki8gdmFyMDAwNDQgPSBldmVudGhhbmRsZXIzOyB2YXIwMDA2MCA9IGh0bWx2YXIwMDAxOC5zdHls ZTsgfSBjYXRjaChlKSB7IH0KdHJ5IHsgLyogKi8gdmFyMDAxMjEgPSBkb2N1bWVudC5jcmVhdGVF bGVtZW50KCJjYW52YXMiKTsgdmFyMDAxMjIgPSB2YXIwMDA0NDsgfSBjYXRjaChlKSB7IH0KdHJ5 IHsgLyogKi8gdmFyIHZhcjAwMTIzIH0gY2F0Y2goZSkgeyB9CnRyeSB7IHZhcjAwMTIxLnRvQmxv Yih2YXIwMDEyMiwiZm9vIix2YXIwMDEyMyk7IH0gY2F0Y2goZSkgeyB9CnRyeSB7IHZhcjAwMDYw LnNldFByb3BlcnR5KCItd2Via2l0LXVzZXItbW9kaWZ5IiwgInJlYWQtb25seSIpOyB9IGNhdGNo KGUpIHsgfQp9CmZ1bmN0aW9uIGV2ZW50aGFuZGxlcjMoKSB7CnZhciBmdXp6ZXJ2YXJzID0ge307 ClNldFZhcmlhYmxlKGZ1enplcnZhcnMsIHdpbmRvdywgJ1dpbmRvdycpOwp0cnkgeyAvKiAqLyB2 YXIwMDAxNiA9IHdpbmRvdy5nZXRTZWxlY3Rpb24oKTsgdmFyMDAwMjQgPSBldmVudGhhbmRsZXIz OyB9IGNhdGNoKGUpIHsgfQp0cnkgeyAvKiAqLyB2YXIwMDA5NCA9IGRvY3VtZW50LmV4ZWNDb21t YW5kKCJkZWxldGUiLCBmYWxzZSk7IH0gY2F0Y2goZSkgeyB9CnRyeSB7IHZhcjAwMDE2LnNldEJh c2VBbmRFeHRlbnQoaHRtbHZhcjAwMDIzLDYsaHRtbHZhcjAwMDIzLC0xKTsgfSBjYXRjaChlKSB7 IH0KdHJ5IHsgLyogKi8gdmFyIHZhcjAwMTEwID0gdmFyMDAxMTFbImh0bWx2YXIwMDAwOCJdOyB9 IGNhdGNoKGUpIHsgfQp0cnkgeyBpZiAoIXZhcjAwMTEwKSB7IHZhcjAwMTEwID0gR2V0VmFyaWFi bGUoZnV6emVydmFycywgJ1dpbmRvdycpOyB9IHsgU2V0VmFyaWFibGUoZnV6emVydmFycywgJ0ds b2JhbEV2ZW50SGFuZGxlcnMnKTsgU2V0VmFyaWFibGUoZnV6emVydmFycywgJ0V2ZW50VGFyZ2V0 Jyk7IH0gfSBjYXRjaChlKSB7IH0KdHJ5IHsgLyogKi8gdmFyMDAxMjUgPSB2YXIwMDAyNDsgfSBj YXRjaChlKSB7IH0KdHJ5IHsgdmFyMDAxMTAuYWRkRXZlbnRMaXN0ZW5lcigiRE9NU3VidHJlZU1v ZGlmaWVkIiwgdmFyMDAxMjUpOyB9IGNhdGNoKGUpIHsgfQp0cnkgeyBodG1sdmFyMDAwMjEuY2hh cnNldCA9ICJVVEYtOCI7IH0gY2F0Y2goZSkgeyB9Cn0KPC9zY3JpcHQ+Cjxib2R5IG9ubG9hZD1q c2Z1enplcigpPgo8bGkgY2xhc3M9ImNsYXNzNCIgcmVxdWlyZWQ9InJlcXVpcmVkIj4NCjxiYXNl Zm9udCBhZGRpdGl2ZT0ic3VtIj48L2Jhc2Vmb250Pg0KPHByb2dyZXNzIGlkPSJodG1sdmFyMDAw MTgiIHRydWVzcGVlZD0idHJ1ZSI+DQo8bGluayBpZD0iaHRtbHZhcjAwMDIxIiBydWxlcz0ibm9u ZSI+DQo8a2V5Z2VuIGlkPSJodG1sdmFyMDAwMjMiIGNvbHNwYW49Ijk2Ij4N 413284 2020-11-05 05:09:54 -0800 2020-11-05 18:50:42 -0800 Slightly reduced testcase bug218492.html text/html 1672 rbuis PHN0eWxlPgojaHRtbHZhcjAwMDA5LCAuY2xhc3M0LCBwYXJhbTpsYXN0LW9mLXR5cGUgeyBpbmhl cml0OyAtd2Via2l0LXVzZXItbW9kaWZ5OiByZWFkLXdyaXRlOyB9DQo8L3N0eWxlPgo8c2NyaXB0 PgpmdW5jdGlvbiBHZXRWYXJpYWJsZShmdXp6ZXJ2YXJzLCB2YXJfdHlwZSkgeyB7IHJldHVybiBm dXp6ZXJ2YXJzW3Zhcl90eXBlXTsgfX0KZnVuY3Rpb24gU2V0VmFyaWFibGUoZnV6emVydmFycywg dmFyX25hbWUsIHZhcl90eXBlKSB7IGZ1enplcnZhcnNbdmFyX3R5cGVdID0gdmFyX25hbWU7IH0K ZnVuY3Rpb24ganNmdXp6ZXIoKSB7CnRyeSB7IC8qICovIHZhcjAwMDQ0ID0gZXZlbnRoYW5kbGVy MzsgdmFyMDAwNjAgPSBodG1sdmFyMDAwMTguc3R5bGU7IH0gY2F0Y2goZSkgeyB9CnRyeSB7IC8q ICovIHZhcjAwMTIxID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiY2FudmFzIik7IHZhcjAwMTIy ID0gdmFyMDAwNDQ7IH0gY2F0Y2goZSkgeyB9CnRyeSB7IC8qICovIHZhciB2YXIwMDEyMyB9IGNh dGNoKGUpIHsgfQp0cnkgeyB2YXIwMDEyMS50b0Jsb2IodmFyMDAxMjIsImZvbyIsdmFyMDAxMjMp OyB9IGNhdGNoKGUpIHsgfQp0cnkgeyB2YXIwMDA2MC5zZXRQcm9wZXJ0eSgiLXdlYmtpdC11c2Vy LW1vZGlmeSIsICJyZWFkLW9ubHkiKTsgfSBjYXRjaChlKSB7IH0KfQpmdW5jdGlvbiBldmVudGhh bmRsZXIzKCkgewp2YXIgZnV6emVydmFycyA9IHt9OwpTZXRWYXJpYWJsZShmdXp6ZXJ2YXJzLCB3 aW5kb3csICdXaW5kb3cnKTsKdHJ5IHsgLyogKi8gdmFyMDAwMTYgPSB3aW5kb3cuZ2V0U2VsZWN0 aW9uKCk7IHZhcjAwMDI0ID0gZXZlbnRoYW5kbGVyMzsgfSBjYXRjaChlKSB7IH0KdHJ5IHsgLyog Ki8gdmFyMDAwOTQgPSBkb2N1bWVudC5leGVjQ29tbWFuZCgiZGVsZXRlIiwgZmFsc2UpOyB9IGNh dGNoKGUpIHsgfQp0cnkgeyB2YXIwMDAxNi5zZXRCYXNlQW5kRXh0ZW50KGh0bWx2YXIwMDAyMyw2 LGh0bWx2YXIwMDAyMywtMSk7IH0gY2F0Y2goZSkgeyB9CnRyeSB7IC8qICovIHZhciB2YXIwMDEx MCA9IHZhcjAwMTExWyJodG1sdmFyMDAwMDgiXTsgfSBjYXRjaChlKSB7IH0KdHJ5IHsgaWYgKCF2 YXIwMDExMCkgeyB2YXIwMDExMCA9IEdldFZhcmlhYmxlKGZ1enplcnZhcnMsICdXaW5kb3cnKTsg fSB7IFNldFZhcmlhYmxlKGZ1enplcnZhcnMsICdHbG9iYWxFdmVudEhhbmRsZXJzJyk7IFNldFZh cmlhYmxlKGZ1enplcnZhcnMsICdFdmVudFRhcmdldCcpOyB9IH0gY2F0Y2goZSkgeyB9CnRyeSB7 IC8qICovIHZhcjAwMTI1ID0gdmFyMDAwMjQ7IH0gY2F0Y2goZSkgeyB9CnRyeSB7IHZhcjAwMTEw LmFkZEV2ZW50TGlzdGVuZXIoIkRPTVN1YnRyZWVNb2RpZmllZCIsIHZhcjAwMTI1KTsgfSBjYXRj aChlKSB7IH0KdHJ5IHsgaHRtbHZhcjAwMDIxLmNoYXJzZXQgPSAiVVRGLTgiOyB9IGNhdGNoKGUp IHsgfQp9Cjwvc2NyaXB0Pgo8Ym9keSBvbmxvYWQ9anNmdXp6ZXIoKT4KPGxpIGNsYXNzPSJjbGFz czQiIHJlcXVpcmVkPSJyZXF1aXJlZCI+DQo8YmFzZWZvbnQgYWRkaXRpdmU9InN1bSI+PC9iYXNl Zm9udD4NCjxwcm9ncmVzcyBpZD0iaHRtbHZhcjAwMDE4IiB0cnVlc3BlZWQ9InRydWUiPg0KPGxp bmsgaWQ9Imh0bWx2YXIwMDAyMSIgcnVsZXM9Im5vbmUiPg0KPGtleWdlbiBpZD0iaHRtbHZhcjAw MDIzIiBjb2xzcGFuPSI5NiI+DQ== 413384 2020-11-05 18:50:42 -0800 2020-11-05 18:50:42 -0800 Reduced test case bug218492.html text/html 377 rniwa PCFET0NUWVBFIGh0bWw+CjxodG1sPgo8aGVhZD4KPHNjcmlwdD4KCmZ1bmN0aW9uIHJ1blRlc3Qo KQp7CiAgICBwcm9ncmVzcy5jb250ZW50RWRpdGFibGUgPSBmYWxzZTsKICAgIGRvY3VtZW50LmV4 ZWNDb21tYW5kKCJkZWxldGUiLCBmYWxzZSk7CiAgICBnZXRTZWxlY3Rpb24oKS5zZXRCYXNlQW5k RXh0ZW50KHNwYW4sIDAsIHNwYW4sIDApOwogICAgZG9jdW1lbnQuZXhlY0NvbW1hbmQoImRlbGV0 ZSIsIGZhbHNlKTsKfQoKPC9zY3JpcHQ+CjwvaGVhZD4KPGJvZHkgb25sb2FkPSJydW5UZXN0KCki Pgo8bGkgY29udGVudGVkaXRhYmxlPgo8YmFzZWZvbnQ+Cjxwcm9ncmVzcyBpZD0icHJvZ3Jlc3Mi Pgo8c3BhbiBpZD0ic3BhbiI+CjwvYm9keT4KPC9odG1sPgo= 413968 2020-11-12 12:55:48 -0800 2020-11-13 03:17:17 -0800 Patch bug-218492-20201112215546.patch text/plain 1576 rbuis U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5NzIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGE3OTEwYWViYjZhZWVl NGM5NjRmOGUyNDllNjAxZjNkNjJlODgzNi4uZTFjZmU3ZDA0MWYwY2M3MDgyZTdjMjQ1NGE5Zjlk ZmFkNTRmMWRhNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIwLTExLTEyICBSb2Ig QnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgTnVsbCBjaGVjayBhbmNob3JOb2Rl IG9mIGVuZGluZ1NlbGVjdGlvbiBzdGFydAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjE4NDkyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgTnVsbCBjaGVjayBhbmNob3JOb2RlIG9mIGVuZGluZ1NlbGVjdGlv biBzdGFydC4KKworICAgICAgICAqIGVkaXRpbmcvRGVsZXRlU2VsZWN0aW9uQ29tbWFuZC5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpEZWxldGVTZWxlY3Rpb25Db21tYW5kOjptZXJnZVBhcmFncmFw aHMpOgorCiAyMDIwLTExLTExICBaaXJhbiBTdW4gIDx6c3VuQGlnYWxpYS5jb20+CiAKICAgICAg ICAgW2Nzcy1ncmlkXSBQZXJjZW50YWdlIGhlaWdodCBvbiByZXBsYWNlZCBpdGVtIHdpdGggc2Ny b2xsYmFyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0RlbGV0ZVNlbGVjdGlv bkNvbW1hbmQuY3BwIGIvU291cmNlL1dlYkNvcmUvZWRpdGluZy9EZWxldGVTZWxlY3Rpb25Db21t YW5kLmNwcAppbmRleCBmYTJjOGIyZGY3OTZiZjE5OTU3ZGQyMWRhMTEwZjY5OTVmMzE3ZTgyLi5j ZGFiN2E1OTZkMzhiNDYyN2ZlN2RkMDY3OWU2MWFiMDFkMjY4ZmIyIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9lZGl0aW5nL0RlbGV0ZVNlbGVjdGlvbkNvbW1hbmQuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2VkaXRpbmcvRGVsZXRlU2VsZWN0aW9uQ29tbWFuZC5jcHAKQEAgLTc2MSw3ICs3 NjEsNyBAQCB2b2lkIERlbGV0ZVNlbGVjdGlvbkNvbW1hbmQ6Om1lcmdlUGFyYWdyYXBocygpCiAg ICAgLy8gVGhlIGVuZGluZ1Bvc2l0aW9uIHdhcyBsaWtlbHkgY2xvYmJlcmVkIGJ5IHRoZSBtb3Zl LCBzbyByZWNvbXB1dGUgaXQgKG1vdmVQYXJhZ3JhcGggc2VsZWN0cyB0aGUgbW92ZWQgcGFyYWdy YXBoKS4KIAogICAgIC8vIEZJWE1FIChCdWcgMjExNzkzKTogZW5kaW5nU2VsZWN0aW9uKCkgYmVj b21lcyBkaXNjb25uZWN0ZWQgaW4gbW92ZVBhcmFncmFwaAotICAgIGlmIChlbmRpbmdTZWxlY3Rp b24oKS5zdGFydCgpLmFuY2hvck5vZGUoKS0+aXNDb25uZWN0ZWQoKSkKKyAgICBpZiAoZW5kaW5n U2VsZWN0aW9uKCkuc3RhcnQoKS5hbmNob3JOb2RlKCkgJiYgZW5kaW5nU2VsZWN0aW9uKCkuc3Rh cnQoKS5hbmNob3JOb2RlKCktPmlzQ29ubmVjdGVkKCkpCiAgICAgICAgIG1fZW5kaW5nUG9zaXRp b24gPSBlbmRpbmdTZWxlY3Rpb24oKS5zdGFydCgpOwogfQogCg== 414027 2020-11-13 03:17:21 -0800 2020-11-17 01:56:23 -0800 Patch bug-218492-20201113121720.patch text/plain 3684 rbuis U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5NzE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGE3OTEwYWViYjZhZWVl NGM5NjRmOGUyNDllNjAxZjNkNjJlODgzNi4uNzZkNzk0NzczY2YxNjVmNzY2ZTczZDY4ZWE4MjIx ZTdhNDJhZDRkMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIwLTExLTEzICBSb2Ig QnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgTnVsbCBjaGVjayBhbmNob3JOb2Rl IG9mIGVuZGluZ1NlbGVjdGlvbiBzdGFydAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjE4NDkyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgTnVsbCBjaGVjayBhbmNob3JOb2RlIG9mIGVuZGluZ1NlbGVjdGlv biBzdGFydC4KKworICAgICAgICBUZXN0OiBlZGl0aW5nL2RlbGV0aW5nL2RlbGV0ZS1jb250ZW50 ZWRpdGFibGUtY3Jhc2guaHRtbAorCisgICAgICAgICogZWRpdGluZy9EZWxldGVTZWxlY3Rpb25D b21tYW5kLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRlbGV0ZVNlbGVjdGlvbkNvbW1hbmQ6Om1l cmdlUGFyYWdyYXBocyk6CisKIDIwMjAtMTEtMTEgIFppcmFuIFN1biAgPHpzdW5AaWdhbGlhLmNv bT4KIAogICAgICAgICBbY3NzLWdyaWRdIFBlcmNlbnRhZ2UgaGVpZ2h0IG9uIHJlcGxhY2VkIGl0 ZW0gd2l0aCBzY3JvbGxiYXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRGVs ZXRlU2VsZWN0aW9uQ29tbWFuZC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0RlbGV0ZVNl bGVjdGlvbkNvbW1hbmQuY3BwCmluZGV4IGZhMmM4YjJkZjc5NmJmMTk5NTdkZDIxZGExMTBmNjk5 NWYzMTdlODIuLjEwMzBmNWMxMDJlODA3OWNlZDA4N2JiNzMxMTU3OGFjYTllYTUxMDIgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRGVsZXRlU2VsZWN0aW9uQ29tbWFuZC5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvZWRpdGluZy9EZWxldGVTZWxlY3Rpb25Db21tYW5kLmNwcApA QCAtNzYxLDcgKzc2MSw3IEBAIHZvaWQgRGVsZXRlU2VsZWN0aW9uQ29tbWFuZDo6bWVyZ2VQYXJh Z3JhcGhzKCkKICAgICAvLyBUaGUgZW5kaW5nUG9zaXRpb24gd2FzIGxpa2VseSBjbG9iYmVyZWQg YnkgdGhlIG1vdmUsIHNvIHJlY29tcHV0ZSBpdCAobW92ZVBhcmFncmFwaCBzZWxlY3RzIHRoZSBt b3ZlZCBwYXJhZ3JhcGgpLgogCiAgICAgLy8gRklYTUUgKEJ1ZyAyMTE3OTMpOiBlbmRpbmdTZWxl Y3Rpb24oKSBiZWNvbWVzIGRpc2Nvbm5lY3RlZCBpbiBtb3ZlUGFyYWdyYXBoCi0gICAgaWYgKGVu ZGluZ1NlbGVjdGlvbigpLnN0YXJ0KCkuYW5jaG9yTm9kZSgpLT5pc0Nvbm5lY3RlZCgpKQorICAg IGlmIChhdXRvKiBhbmNob3JOb2RlID0gZW5kaW5nU2VsZWN0aW9uKCkuc3RhcnQoKS5hbmNob3JO b2RlKCk7IGFuY2hvck5vZGUgJiYgYW5jaG9yTm9kZS0+aXNDb25uZWN0ZWQoKSkKICAgICAgICAg bV9lbmRpbmdQb3NpdGlvbiA9IGVuZGluZ1NlbGVjdGlvbigpLnN0YXJ0KCk7CiB9CiAKZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRl eCA5NDViNjBmZDBlYjE4M2ZkMWRjM2JjNmFiYTZlYTVkZTdlMzQwNzMxLi41YjMzOGVlODRkMWE3 MGM2OWYzMWI2YTMyZjkzZTY3Y2UyMDJlNTg1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjAt MTEtMTMgIFJvYiBCdWlzICA8cmJ1aXNAaWdhbGlhLmNvbT4KKworICAgICAgICBOdWxsIGNoZWNr IGFuY2hvck5vZGUgb2YgZW5kaW5nU2VsZWN0aW9uIHN0YXJ0CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTg0OTIKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgdGVzdGNhc2UuCisKKyAgICAgICAgKiBl ZGl0aW5nL2RlbGV0aW5nL2RlbGV0ZS1jb250ZW50ZWRpdGFibGUtY3Jhc2gtZXhwZWN0ZWQudHh0 OiBBZGRlZC4KKyAgICAgICAgKiBlZGl0aW5nL2RlbGV0aW5nL2RlbGV0ZS1jb250ZW50ZWRpdGFi bGUtY3Jhc2guaHRtbDogQWRkZWQuCisKIDIwMjAtMTEtMTEgIEpvaG4gV2lsYW5kZXIgIDx3aWxh bmRlckBhcHBsZS5jb20+CiAKICAgICAgICAgUENNOiBDaGFuZ2UgZnJvbSBhZC1jbGljay1hdHRy aWJ1dGlvbiB0byBwcml2YXRlLWNsaWNrLW1lYXN1cmVtZW50IChpbiBhbGwgZm9ybXMsIGluY2x1 ZGluZyAud2VsbC1rbm93biBVUkwpCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9lZGl0aW5nL2Rl bGV0aW5nL2RlbGV0ZS1jb250ZW50ZWRpdGFibGUtY3Jhc2gtZXhwZWN0ZWQudHh0IGIvTGF5b3V0 VGVzdHMvZWRpdGluZy9kZWxldGluZy9kZWxldGUtY29udGVudGVkaXRhYmxlLWNyYXNoLWV4cGVj dGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwLi40MGEzZjY5OWE3MjhlOTE2OTFjMTRhNzQzMDhlMmQ3M2NiMWVk ZmYzCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZWRpdGluZy9kZWxldGluZy9kZWxl dGUtY29udGVudGVkaXRhYmxlLWNyYXNoLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxIEBACitUZXN0 IHBhc3NlcyBpZiBubyBjcmFzaGVzIHdpdGggYXNhbi4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L2VkaXRpbmcvZGVsZXRpbmcvZGVsZXRlLWNvbnRlbnRlZGl0YWJsZS1jcmFzaC5odG1sIGIvTGF5 b3V0VGVzdHMvZWRpdGluZy9kZWxldGluZy9kZWxldGUtY29udGVudGVkaXRhYmxlLWNyYXNoLmh0 bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMC4uMTQ5OGViOWEyNWU3ZjI3YzU5ZjlkN2YxMDBmNWQyMzBmZWI5ZjQwMgot LS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2VkaXRpbmcvZGVsZXRpbmcvZGVsZXRlLWNv bnRlbnRlZGl0YWJsZS1jcmFzaC5odG1sCkBAIC0wLDAgKzEsMjYgQEAKKzwhRE9DVFlQRSBodG1s PgorPGh0bWw+Cis8aGVhZD4KKzxzY3JpcHQ+CisKK2Z1bmN0aW9uIHJ1blRlc3QoKQoreworICAg IGlmICh3aW5kb3cudGVzdFJ1bm5lcikKKyAgICAgICAgdGVzdFJ1bm5lci5kdW1wQXNUZXh0KCk7 CisKKyAgICBnZXRTZWxlY3Rpb24oKS5zZXRCYXNlQW5kRXh0ZW50KHNwYW4sIDAsIHNwYW4sIDIp OworICAgIGRvY3VtZW50LmV4ZWNDb21tYW5kKCJkZWxldGUiLCBmYWxzZSk7CisgICAgZG9jdW1l bnQud3JpdGUoIlRlc3QgcGFzc2VzIGlmIG5vIGNyYXNoZXMgd2l0aCBhc2FuLiIpCit9CisKKzwv c2NyaXB0PgorPC9oZWFkPgorPGJvZHkgb25sb2FkPSJydW5UZXN0KCkiPgorPGxpIGNvbnRlbnRl ZGl0YWJsZT0iIj4KKyAgICA8YmFzZWZvbnQ+CisgICAgPHByb2dyZXNzIGNvbnRlbnRlZGl0YWJs ZT0iZmFsc2UiPgorICAgICAgICA8c3BhbiBpZD0ic3BhbiI+Y29udGVudDwvc3Bhbj4KKyAgICA8 L3Byb2dyZXNzPgorPC9saT4KKzwvYm9keT4KKzwvaHRtbD4K 414321 2020-11-17 01:56:35 -0800 2020-11-17 08:29:50 -0800 Patch bug-218492-20201117105633.patch text/plain 3632 rbuis U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5ODk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDU4ZWM5ODdmZDg5ZDdj YzQ3M2UwMTU2NWJjODVlODc0YzljNWE4OS4uYTc4NGQ4YWZmNzFhMThjODJmOWE1ZGEyNDczMDA4 NjNkMTNmMGYzNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIwLTExLTE3ICBSb2Ig QnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgTnVsbCBjaGVjayBhbmNob3JOb2Rl IG9mIGVuZGluZ1NlbGVjdGlvbiBzdGFydAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjE4NDkyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgTnVsbCBjaGVjayBhbmNob3JOb2RlIG9mIGVuZGluZ1NlbGVjdGlv biBzdGFydC4KKworICAgICAgICBUZXN0OiBlZGl0aW5nL2RlbGV0aW5nL2RlbGV0ZS1jb250ZW50 ZWRpdGFibGUtY3Jhc2guaHRtbAorCisgICAgICAgICogZWRpdGluZy9EZWxldGVTZWxlY3Rpb25D b21tYW5kLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRlbGV0ZVNlbGVjdGlvbkNvbW1hbmQ6Om1l cmdlUGFyYWdyYXBocyk6CisKIDIwMjAtMTEtMTcgIFJvYiBCdWlzICA8cmJ1aXNAaWdhbGlhLmNv bT4KIAogICAgICAgICBDaGVjayB3aGV0aGVyIGRlc3RpbmF0aW9uIHN0aWxsIGNhbiBiZSBzZWxl Y3RlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZWRpdGluZy9EZWxldGVTZWxlY3Rpb25D b21tYW5kLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRGVsZXRlU2VsZWN0aW9uQ29tbWFu ZC5jcHAKaW5kZXggZmEyYzhiMmRmNzk2YmYxOTk1N2RkMjFkYTExMGY2OTk1ZjMxN2U4Mi4uMTAz MGY1YzEwMmU4MDc5Y2VkMDg3YmI3MzExNTc4YWNhOWVhNTEwMiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvZWRpdGluZy9EZWxldGVTZWxlY3Rpb25Db21tYW5kLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9lZGl0aW5nL0RlbGV0ZVNlbGVjdGlvbkNvbW1hbmQuY3BwCkBAIC03NjEsNyArNzYx LDcgQEAgdm9pZCBEZWxldGVTZWxlY3Rpb25Db21tYW5kOjptZXJnZVBhcmFncmFwaHMoKQogICAg IC8vIFRoZSBlbmRpbmdQb3NpdGlvbiB3YXMgbGlrZWx5IGNsb2JiZXJlZCBieSB0aGUgbW92ZSwg c28gcmVjb21wdXRlIGl0IChtb3ZlUGFyYWdyYXBoIHNlbGVjdHMgdGhlIG1vdmVkIHBhcmFncmFw aCkuCiAKICAgICAvLyBGSVhNRSAoQnVnIDIxMTc5Myk6IGVuZGluZ1NlbGVjdGlvbigpIGJlY29t ZXMgZGlzY29ubmVjdGVkIGluIG1vdmVQYXJhZ3JhcGgKLSAgICBpZiAoZW5kaW5nU2VsZWN0aW9u KCkuc3RhcnQoKS5hbmNob3JOb2RlKCktPmlzQ29ubmVjdGVkKCkpCisgICAgaWYgKGF1dG8qIGFu Y2hvck5vZGUgPSBlbmRpbmdTZWxlY3Rpb24oKS5zdGFydCgpLmFuY2hvck5vZGUoKTsgYW5jaG9y Tm9kZSAmJiBhbmNob3JOb2RlLT5pc0Nvbm5lY3RlZCgpKQogICAgICAgICBtX2VuZGluZ1Bvc2l0 aW9uID0gZW5kaW5nU2VsZWN0aW9uKCkuc3RhcnQoKTsKIH0KIApkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDJhOWQyN2IzMzhm MTMyYWI1ZTI5YmQwMGQ3NTFkN2EyOGMyOTAwYWQuLmZiYjc5MWE4MDEzNzIyNDE5ODYyOWQwMGE3 OTBlZjkxOWY4NDQzOTAgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9M YXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAyMC0xMS0xNyAgUm9iIEJ1 aXMgIDxyYnVpc0BpZ2FsaWEuY29tPgorCisgICAgICAgIE51bGwgY2hlY2sgYW5jaG9yTm9kZSBv ZiBlbmRpbmdTZWxlY3Rpb24gc3RhcnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIxODQ5MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEFkZCB0ZXN0Y2FzZS4KKworICAgICAgICAqIGVkaXRpbmcvZGVsZXRp bmcvZGVsZXRlLWNvbnRlbnRlZGl0YWJsZS1jcmFzaC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAg ICAgICAqIGVkaXRpbmcvZGVsZXRpbmcvZGVsZXRlLWNvbnRlbnRlZGl0YWJsZS1jcmFzaC5odG1s OiBBZGRlZC4KKwogMjAyMC0xMS0xNyAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxl LmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OIChyMjY5ODI0KTogWW91VHViZSBtZWRpYSBjb250 cm9sIGJhciBzb21ldGltZXMgZmxpY2tlcnMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2VkaXRp bmcvZGVsZXRpbmcvZGVsZXRlLWNvbnRlbnRlZGl0YWJsZS1jcmFzaC1leHBlY3RlZC50eHQgYi9M YXlvdXRUZXN0cy9lZGl0aW5nL2RlbGV0aW5nL2RlbGV0ZS1jb250ZW50ZWRpdGFibGUtY3Jhc2gt ZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjQwYTNmNjk5YTcyOGU5MTY5MWMxNGE3NDMwOGUyZDcz Y2IxZWRmZjMKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9lZGl0aW5nL2RlbGV0aW5n L2RlbGV0ZS1jb250ZW50ZWRpdGFibGUtY3Jhc2gtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEgQEAK K1Rlc3QgcGFzc2VzIGlmIG5vIGNyYXNoZXMgd2l0aCBhc2FuLgpkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvZWRpdGluZy9kZWxldGluZy9kZWxldGUtY29udGVudGVkaXRhYmxlLWNyYXNoLmh0bWwg Yi9MYXlvdXRUZXN0cy9lZGl0aW5nL2RlbGV0aW5nL2RlbGV0ZS1jb250ZW50ZWRpdGFibGUtY3Jh c2guaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwLi4xNDk4ZWI5YTI1ZTdmMjdjNTlmOWQ3ZjEwMGY1ZDIzMGZlYjlm NDAyCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZWRpdGluZy9kZWxldGluZy9kZWxl dGUtY29udGVudGVkaXRhYmxlLWNyYXNoLmh0bWwKQEAgLTAsMCArMSwyNiBAQAorPCFET0NUWVBF IGh0bWw+Cis8aHRtbD4KKzxoZWFkPgorPHNjcmlwdD4KKworZnVuY3Rpb24gcnVuVGVzdCgpCit7 CisgICAgaWYgKHdpbmRvdy50ZXN0UnVubmVyKQorICAgICAgICB0ZXN0UnVubmVyLmR1bXBBc1Rl eHQoKTsKKworICAgIGdldFNlbGVjdGlvbigpLnNldEJhc2VBbmRFeHRlbnQoc3BhbiwgMCwgc3Bh biwgMik7CisgICAgZG9jdW1lbnQuZXhlY0NvbW1hbmQoImRlbGV0ZSIsIGZhbHNlKTsKKyAgICBk b2N1bWVudC53cml0ZSgiVGVzdCBwYXNzZXMgaWYgbm8gY3Jhc2hlcyB3aXRoIGFzYW4uIikKK30K KworPC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keSBvbmxvYWQ9InJ1blRlc3QoKSI+Cis8bGkgY29u dGVudGVkaXRhYmxlPSIiPgorICAgIDxiYXNlZm9udD4KKyAgICA8cHJvZ3Jlc3MgY29udGVudGVk aXRhYmxlPSJmYWxzZSI+CisgICAgICAgIDxzcGFuIGlkPSJzcGFuIj5jb250ZW50PC9zcGFuPgor ICAgIDwvcHJvZ3Jlc3M+Cis8L2xpPgorPC9ib2R5PgorPC9odG1sPgo=