21849 2008-10-23 20:52:48 -0700 A minor build failure on Japanese versions of Windows 2009-06-18 16:00:12 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC Windows XP RESOLVED DUPLICATE 26375 P3 Minor --- 0 hbono webkit-unassigned oldest_to_newest 96477 0 hbono 2008-10-23 20:52:48 -0700 Steps to reproduce: Build WebKit (Revision 37759) on the Japanese version of Windows XP (or Vista) with the "WebKitTOols/Script/build-webkit" script. Actual Results: The C++ compiler of Visual Studio 2005 treats a multiplication sign '×' (U+00D7) as corrupted SHIFT-JIS characters and outputs an error and a warning while compiling "WebKit/win/WebCoreLocalizedString.cpp". 4>WebCoreLocalizedStrings.cpp 4>..\WebCoreLocalizedStrings.cpp : error C2220: warning treated as error - no 'object' file generated 4>..\WebCoreLocalizedStrings.cpp : warning C4819: The file contains a character that cannot be represented in the current code page (932). Save the file in Unicode format to prevent data loss Expected Results: The compiler can compile the file without errors or warnings. Build Date and Platform: Revision 37759 (2008-10-21) on Windows XP SP2 and Vista SP1. Additional Builds and Platforms: - Does not occur on The English version of Windows XP Additional Information: - Possible Solutions The simplest solution is changing the system locale to English (US) in compiling WebKit. Another solution is replacing the multiplication sign (U+00D7) with the quated expression of its UTF-8 value (0xC3 0x97), i.e. "\xC3\x97". 96478 1 24632 hbono 2008-10-23 20:55:51 -0700 Created attachment 24632 A Quick Fix This patch just replaces the multiplication sign (U+00D7) with the quated expression of its UTF-8 value (0xC3 0x97), i.e. "\xC3\x97". 126801 2 levin 2009-06-18 16:00:12 -0700 Although entered later, bug 26375 seems to be progressing in addressing the same issue. *** This bug has been marked as a duplicate of 26375 *** 24632 2008-10-23 20:55:51 -0700 2008-10-23 20:55:51 -0700 A Quick Fix my-stupid-patch.txt text/plain 1348 hbono SW5kZXg6IFdlYktpdC93aW4vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC93aW4vQ2hh bmdlTG9nCShyZXZpc2lvbiAzNzc1OSkKKysrIFdlYktpdC93aW4vQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTAgQEAKKzIwMDgtMTAtMjEgIEhpcm9ub3JpIEJvbm8gIDxoYm9u b0Bnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogV2ViQ29yZUxvY2FsaXplZFN0cmluZ3MuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 aW1hZ2VUaXRsZSk6CisKIDIwMDgtMTAtMjAgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4K IAogICAgICAgICBSZXZpZXdlZCBieSBBbmRlcnMgQ2FybHNzb24uCkluZGV4OiBXZWJLaXQvd2lu L1dlYkNvcmVMb2NhbGl6ZWRTdHJpbmdzLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvd2luL1dl YkNvcmVMb2NhbGl6ZWRTdHJpbmdzLmNwcAkocmV2aXNpb24gMzc3MTEpCisrKyBXZWJLaXQvd2lu L1dlYkNvcmVMb2NhbGl6ZWRTdHJpbmdzLmNwcAkod29ya2luZyBjb3B5KQpAQCAtOTYsNyArOTYs NyBAQCBTdHJpbmcgV2ViQ29yZTo6YWxsRmlsZXNUZXh0KCkgeyByZXR1cm4gCiAKIFN0cmluZyBX ZWJDb3JlOjppbWFnZVRpdGxlKGNvbnN0IFN0cmluZyYgZmlsZW5hbWUsIGNvbnN0IEludFNpemUm IHNpemUpIAogeyAKLSAgICBzdGF0aWMgUmV0YWluUHRyPENGU3RyaW5nUmVmPiBmb3JtYXQoQWRv cHRDRiwgVUlfU1RSSU5HKCIlQCAlZMOXJWQgcGl4ZWxzIiwgIndpbmRvdyB0aXRsZSBmb3IgYSBz dGFuZGFsb25lIGltYWdlICh1c2VzIG11bHRpcGxpY2F0aW9uIHN5bWJvbCwgbm90IHgpIikpOwor ICAgIHN0YXRpYyBSZXRhaW5QdHI8Q0ZTdHJpbmdSZWY+IGZvcm1hdChBZG9wdENGLCBVSV9TVFJJ TkcoIiVAICVkXHhDM1x4OTclZCBwaXhlbHMiLCAid2luZG93IHRpdGxlIGZvciBhIHN0YW5kYWxv bmUgaW1hZ2UgKHVzZXMgbXVsdGlwbGljYXRpb24gc3ltYm9sLCBub3QgeCkiKSk7CiAKICAgICBS ZXRhaW5QdHI8Q0ZTdHJpbmdSZWY+IGZpbGVuYW1lQ0YoQWRvcHRDRiwgZmlsZW5hbWUuY3JlYXRl Q0ZTdHJpbmcoKSk7CiAgICAgUmV0YWluUHRyPENGU3RyaW5nUmVmPiByZXN1bHQoQWRvcHRDRiwg Q0ZTdHJpbmdDcmVhdGVXaXRoRm9ybWF0KDAsIDAsIGZvcm1hdC5nZXQoKSwgZmlsZW5hbWVDRi5n ZXQoKSwgc2l6ZS53aWR0aCgpLCBzaXplLmhlaWdodCgpKSk7Cg==