218480 2020-11-03 00:35:57 -0800 Include path in generated IDL dependencies 2020-11-03 17:13:11 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=218378 https://bugs.webkit.org/show_bug.cgi?id=217696 InRadar P2 Normal --- 1 krollin krollin bfulgham cdumez ews-watchlist graouts sam webkit-bug-importer zalan oldest_to_newest 1703837 0 krollin 2020-11-03 00:35:57 -0800 Changes in Bug 218378 and Bug 217696 have lessened the reliance on VPATH to find files. This means that more places need to be explicit about the locations of their files. This change updates preprocess-idls.pl to include full- and partial-paths when generating dependency information. 1703838 1 krollin 2020-11-03 00:39:21 -0800 This change addresses an issue where Document.idl would alway get rebuilt because a file it depended on couldn't be found because it's path was not specified in SupplementalDependencies.dep. 1703841 2 413011 krollin 2020-11-03 00:41:09 -0800 Created attachment 413011 Patch 1703842 3 webkit-bug-importer 2020-11-03 00:41:23 -0800 <rdar://problem/70984504> 1704032 4 sam 2020-11-03 09:33:54 -0800 You will need to run run-bindings-tests --reset-results to fix the bindings tests/bot. 1704033 5 sam 2020-11-03 09:34:58 -0800 Though, it looks like the tests are actually failing due to issues in the code: Use of uninitialized value $srcroot in regexp compilation at WebCore/bindings/scripts/preprocess-idls.pl line 308. Use of uninitialized value $sdkroot in regexp compilation at WebCore/bindings/scripts/preprocess-idls.pl line 309. Use of uninitialized value $built_products_dir in regexp compilation at WebCore/bindings/scripts/preprocess-idls.pl line 310. 1704038 6 krollin 2020-11-03 09:40:33 -0800 I didn't see those errors/warning locally. And how can those variables be considered uninitialized? Aren't I initializing all of them just a few lines up? My Perl-fu is weak, but I didn't know it was *that* weak. 1704039 7 krollin 2020-11-03 09:42:18 -0800 Ah. I guess it's because the $ENV accesses produce 'undefined' results, due to run-bindings-tests not running in the context of Xcode. 1704071 8 413073 krollin 2020-11-03 10:40:01 -0800 Created attachment 413073 Patch 1704076 9 krollin 2020-11-03 10:43:26 -0800 run-bindings-tests says that it compares the results it generates against reference files. So it seems to me that preserving the previous preprocess-idls.pl behavior when running run-bindings-tests is the best way to pass these tests. So, if things like SRCROOT aren't around, I fall back to calling `basename`, as before. Technically, that causes the tests to pass. I'm not sure if it's in the spirit of run-bindings-tests, though. I think it should be OK since the point is to test the generation of the binding code, and perhaps the dependency relationship between the IDL files, and not the actual expression of those IDL files (that is, it probably doesn't matter to run-bindings-tests if the files are expressed as bare names or partial or full paths). 1704253 10 413073 bfulgham 2020-11-03 15:55:08 -0800 Comment on attachment 413073 Patch The bots now seem happy. r=me 1704290 11 ews-feeder 2020-11-03 17:13:09 -0800 Committed r269347: <https://trac.webkit.org/changeset/269347> All reviewed patches have been landed. Closing bug and clearing flags on attachment 413073. 413011 2020-11-03 00:41:09 -0800 2020-11-03 10:39:59 -0800 Patch bug-218480-20201103004108.patch text/plain 2485 krollin U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5MjcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzQ1ZWNiMzAxYTEwNDVi OWRmYzM0YjAwMGFiZGNlNTlhYTliZTg5Mi4uNzJlOTFlMTJkYzdlYWJkMGFiZjJkMWRiNTg3Y2Nh YTkzMTlkMDJhNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDIwLTExLTAzICBLZWl0 aCBSb2xsaW4gIDxrcm9sbGluQGFwcGxlLmNvbT4KKworICAgICAgICBJbmNsdWRlIHBhdGggaW4g Z2VuZXJhdGVkIElETCBkZXBlbmRlbmNpZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIxODQ4MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIENoYW5nZXMgaW4gQnVnIDIxODM3OCBhbmQgQnVnIDIxNzY5NiBo YXZlIGxlc3NlbmVkIHRoZSByZWxpYW5jZSBvbgorICAgICAgICBWUEFUSCB0byBmaW5kIGZpbGVz LiBUaGlzIG1lYW5zIHRoYXQgbW9yZSBwbGFjZXMgbmVlZCB0byBiZSBleHBsaWNpdAorICAgICAg ICBhYm91dCB0aGUgbG9jYXRpb25zIG9mIHRoZWlyIGZpbGVzLiBUaGlzIGNoYW5nZSB1cGRhdGVz CisgICAgICAgIHByZXByb2Nlc3MtaWRscy5wbCB0byBpbmNsdWRlIGZ1bGwtIGFuZCBwYXJ0aWFs LXBhdGhzIHdoZW4gZ2VuZXJhdGluZworICAgICAgICBkZXBlbmRlbmN5IGluZm9ybWF0aW9uLgor CisgICAgICAgIE5vIG5ldyB0ZXN0cyAtLSB0aGlzIGlzIGEgYnVpbGQgc3lzdGVtIGNoYW5nZS4K KworICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvcHJlcHJvY2Vzcy1pZGxzLnBsOgorICAgICAg ICAoUmVtb3ZlUFdEKToKKwogMjAyMC0xMS0wMiAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUu Y29tPgogCiAgICAgICAgIFsgbWFjT1MgXSB3ZWJhdWRpby9PZmZsaW5lQXVkaW9Db250ZXh0L29u c3RhdGVjaGFuZ2UuaHRtbCBpcyBhIGZsYWt5IGZhaWx1cmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvcHJlcHJvY2Vzcy1pZGxzLnBsIGIvU291cmNlL1dlYkNv cmUvYmluZGluZ3Mvc2NyaXB0cy9wcmVwcm9jZXNzLWlkbHMucGwKaW5kZXggZjRjODRiYzg4YzQx MTQ1ZGQxNmVkMzgzZDRkMzljNDJjYzVkNjk0NS4uMDM4ODAzMTY4MzNmNzRiZTY2ODcyODFhYTk1 MTA4ZWIxNDA5ZmEwNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0 cy9wcmVwcm9jZXNzLWlkbHMucGwKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0 cy9wcmVwcm9jZXNzLWlkbHMucGwKQEAgLTI5NSwxMiArMjk1LDI5IEBAIGZvcmVhY2ggbXkgJGlk bEZpbGVQYXRoIChzb3J0IGtleXMgJXN1cHBsZW1lbnRhbHMpIHsKIH0KIFdyaXRlRmlsZUlmQ2hh bmdlZCgkc3VwcGxlbWVudGFsRGVwZW5kZW5jeUZpbGUsICRkZXBlbmRlbmNpZXMpOwogCitzdWIg UmVtb3ZlV2VsbEtub3duUHJlZml4Cit7CisgICAgbXkgJHBhdGggPSBzaGlmdDsKKworICAgIGNo b21wKG15ICRwd2QgPSBgcHdkYCk7CisgICAgbXkgJHNyY3Jvb3QgPSAkRU5WeydTUkNST09UJ307 CisgICAgbXkgJHNka3Jvb3QgPSAkRU5WeydTREtST09UJ307CisgICAgbXkgJGJ1aWx0X3Byb2R1 Y3RzX2RpciA9ICRFTlZ7J0JVSUxUX1BST0RVQ1RTX0RJUid9OworCisgICAgJHBhdGggPX4gcy9e JHtwd2R9Ly4vOworICAgICRwYXRoID1+IHMvXiR7c3Jjcm9vdH0vV2ViQ29yZS87CisgICAgJHBh dGggPX4gcy9eJHtzZGtyb290fS9cJChTREtST09UKS87CisgICAgJHBhdGggPX4gcy9eJHtidWls dF9wcm9kdWN0c19kaXJ9L1wkKEJVSUxUX1BST0RVQ1RTX0RJUikvOworCisgICAgcmV0dXJuICRw YXRoOworfQorCiBpZiAoJHN1cHBsZW1lbnRhbE1ha2VmaWxlRGVwcykgewogICAgIG15ICRtYWtl ZmlsZURlcHMgPSAiIyBTdXBwbGVtZW50YWwgZGVwZW5kZW5jaWVzXG4iOwogICAgIGZvcmVhY2gg bXkgJGlkbEZpbGVQYXRoIChzb3J0IGtleXMgJXN1cHBsZW1lbnRhbHMpIHsKICAgICAgICAgbXkg JGJhc2VuYW1lID0gJGlkbEZpbGVQYXRoVG9JbnRlcmZhY2VOYW1leyRpZGxGaWxlUGF0aH07CiAK LSAgICAgICAgbXkgQGRlcGVuZGVuY3lMaXN0ID0gbWFwIHsgYmFzZW5hbWUoJF8pIH0gQHskc3Vw cGxlbWVudGFsc3skaWRsRmlsZVBhdGh9fTsKKyAgICAgICAgbXkgQGRlcGVuZGVuY3lMaXN0ID0g bWFwIHsgUmVtb3ZlV2VsbEtub3duUHJlZml4KCRfKSB9IEB7JHN1cHBsZW1lbnRhbHN7JGlkbEZp bGVQYXRofX07CiAgICAgICAgIG15IEBkZXBlbmRlbmNpZXMgPSBzb3J0KGtleXMgJXt7IG1hcHsk Xz0+MX1AZGVwZW5kZW5jeUxpc3R9fSk7CiAKICAgICAgICAgJG1ha2VmaWxlRGVwcyAuPSAiSlMk e2Jhc2VuYW1lfS5oOiBAe2RlcGVuZGVuY2llc31cbiI7Cg== 413073 2020-11-03 10:40:01 -0800 2020-11-03 17:13:10 -0800 Patch bug-218480-20201103104000.patch text/plain 2614 krollin U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5MjcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzQ1ZWNiMzAxYTEwNDVi OWRmYzM0YjAwMGFiZGNlNTlhYTliZTg5Mi4uNzJlOTFlMTJkYzdlYWJkMGFiZjJkMWRiNTg3Y2Nh YTkzMTlkMDJhNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDIwLTExLTAzICBLZWl0 aCBSb2xsaW4gIDxrcm9sbGluQGFwcGxlLmNvbT4KKworICAgICAgICBJbmNsdWRlIHBhdGggaW4g Z2VuZXJhdGVkIElETCBkZXBlbmRlbmNpZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIxODQ4MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIENoYW5nZXMgaW4gQnVnIDIxODM3OCBhbmQgQnVnIDIxNzY5NiBo YXZlIGxlc3NlbmVkIHRoZSByZWxpYW5jZSBvbgorICAgICAgICBWUEFUSCB0byBmaW5kIGZpbGVz LiBUaGlzIG1lYW5zIHRoYXQgbW9yZSBwbGFjZXMgbmVlZCB0byBiZSBleHBsaWNpdAorICAgICAg ICBhYm91dCB0aGUgbG9jYXRpb25zIG9mIHRoZWlyIGZpbGVzLiBUaGlzIGNoYW5nZSB1cGRhdGVz CisgICAgICAgIHByZXByb2Nlc3MtaWRscy5wbCB0byBpbmNsdWRlIGZ1bGwtIGFuZCBwYXJ0aWFs LXBhdGhzIHdoZW4gZ2VuZXJhdGluZworICAgICAgICBkZXBlbmRlbmN5IGluZm9ybWF0aW9uLgor CisgICAgICAgIE5vIG5ldyB0ZXN0cyAtLSB0aGlzIGlzIGEgYnVpbGQgc3lzdGVtIGNoYW5nZS4K KworICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvcHJlcHJvY2Vzcy1pZGxzLnBsOgorICAgICAg ICAoUmVtb3ZlUFdEKToKKwogMjAyMC0xMS0wMiAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUu Y29tPgogCiAgICAgICAgIFsgbWFjT1MgXSB3ZWJhdWRpby9PZmZsaW5lQXVkaW9Db250ZXh0L29u c3RhdGVjaGFuZ2UuaHRtbCBpcyBhIGZsYWt5IGZhaWx1cmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvcHJlcHJvY2Vzcy1pZGxzLnBsIGIvU291cmNlL1dlYkNv cmUvYmluZGluZ3Mvc2NyaXB0cy9wcmVwcm9jZXNzLWlkbHMucGwKaW5kZXggZjRjODRiYzg4YzQx MTQ1ZGQxNmVkMzgzZDRkMzljNDJjYzVkNjk0NS4uZDAzM2VkNjA2MTdkYTQzMmE1MzQxMTE1NGQx MmQwNjVkNDgwODRhNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0 cy9wcmVwcm9jZXNzLWlkbHMucGwKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0 cy9wcmVwcm9jZXNzLWlkbHMucGwKQEAgLTI5NSwxMiArMjk1LDMzIEBAIGZvcmVhY2ggbXkgJGlk bEZpbGVQYXRoIChzb3J0IGtleXMgJXN1cHBsZW1lbnRhbHMpIHsKIH0KIFdyaXRlRmlsZUlmQ2hh bmdlZCgkc3VwcGxlbWVudGFsRGVwZW5kZW5jeUZpbGUsICRkZXBlbmRlbmNpZXMpOwogCitzdWIg UmVtb3ZlV2VsbEtub3duUHJlZml4Cit7CisgICAgbXkgJHBhdGggPSBzaGlmdDsKKworICAgIGNo b21wKG15ICRwd2QgPSBgcHdkYCk7CisgICAgbXkgJHNyY3Jvb3QgPSAkRU5WeydTUkNST09UJ307 CisgICAgbXkgJHNka3Jvb3QgPSAkRU5WeydTREtST09UJ307CisgICAgbXkgJGJ1aWx0X3Byb2R1 Y3RzX2RpciA9ICRFTlZ7J0JVSUxUX1BST0RVQ1RTX0RJUid9OworCisgICAgaWYgKCRzcmNyb290 IGFuZCAkc2Rrcm9vdCBhbmQgJGJ1aWx0X3Byb2R1Y3RzX2RpcikgeworICAgICAgICAkcGF0aCA9 fiBzL14ke3B3ZH0vLi87CisgICAgICAgICRwYXRoID1+IHMvXiR7c3Jjcm9vdH0vV2ViQ29yZS87 CisgICAgICAgICRwYXRoID1+IHMvXiR7c2Rrcm9vdH0vXCQoU0RLUk9PVCkvOworICAgICAgICAk cGF0aCA9fiBzL14ke2J1aWx0X3Byb2R1Y3RzX2Rpcn0vXCQoQlVJTFRfUFJPRFVDVFNfRElSKS87 CisgICAgfSBlbHNlIHsKKyAgICAgICAgJHBhdGggPSBiYXNlbmFtZSgkcGF0aCk7CisgICAgfQor CisgICAgcmV0dXJuICRwYXRoOworfQorCiBpZiAoJHN1cHBsZW1lbnRhbE1ha2VmaWxlRGVwcykg ewogICAgIG15ICRtYWtlZmlsZURlcHMgPSAiIyBTdXBwbGVtZW50YWwgZGVwZW5kZW5jaWVzXG4i OwogICAgIGZvcmVhY2ggbXkgJGlkbEZpbGVQYXRoIChzb3J0IGtleXMgJXN1cHBsZW1lbnRhbHMp IHsKICAgICAgICAgbXkgJGJhc2VuYW1lID0gJGlkbEZpbGVQYXRoVG9JbnRlcmZhY2VOYW1leyRp ZGxGaWxlUGF0aH07CiAKLSAgICAgICAgbXkgQGRlcGVuZGVuY3lMaXN0ID0gbWFwIHsgYmFzZW5h bWUoJF8pIH0gQHskc3VwcGxlbWVudGFsc3skaWRsRmlsZVBhdGh9fTsKKyAgICAgICAgbXkgQGRl cGVuZGVuY3lMaXN0ID0gbWFwIHsgUmVtb3ZlV2VsbEtub3duUHJlZml4KCRfKSB9IEB7JHN1cHBs ZW1lbnRhbHN7JGlkbEZpbGVQYXRofX07CiAgICAgICAgIG15IEBkZXBlbmRlbmNpZXMgPSBzb3J0 KGtleXMgJXt7IG1hcHskXz0+MX1AZGVwZW5kZW5jeUxpc3R9fSk7CiAKICAgICAgICAgJG1ha2Vm aWxlRGVwcyAuPSAiSlMke2Jhc2VuYW1lfS5oOiBAe2RlcGVuZGVuY2llc31cbiI7Cg==