218468 2020-11-02 16:16:16 -0800 Regression(r269227) imported/w3c/web-platform-tests/service-workers/service-worker/referrer-toplevel-script-fetch.https.html is a flaky crash 2020-11-02 17:15:20 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 218363 1 cdumez cdumez achristensen darin ggaren sam webkit-bug-importer oldest_to_newest 1703751 0 cdumez 2020-11-02 16:16:16 -0800 imported/w3c/web-platform-tests/service-workers/service-worker/referrer-toplevel-script-fetch.https.html is a flaky crash since r269227. 1703752 1 cdumez 2020-11-02 16:16:26 -0800 <rdar://problem/70969071> 1703753 2 412986 cdumez 2020-11-02 16:19:33 -0800 Created attachment 412986 Patch 1703759 3 412986 darin 2020-11-02 16:40:38 -0800 Comment on attachment 412986 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=412986&action=review > Source/WebCore/workers/service/ServiceWorkerContainer.cpp:116 > + auto* context = scriptExecutionContext(); > + if (!context) > + return; > + > + auto registration = ServiceWorkerRegistration::getOrCreate(*context, *this, WTFMove(registrationData)); Not sure this needs a blank line. 1703762 4 412988 cdumez 2020-11-02 16:42:30 -0800 Created attachment 412988 Patch 1703776 5 ews-feeder 2020-11-02 17:15:19 -0800 Committed r269281: <https://trac.webkit.org/changeset/269281> All reviewed patches have been landed. Closing bug and clearing flags on attachment 412988. 412986 2020-11-02 16:19:33 -0800 2020-11-02 16:42:28 -0800 Patch bug-218468-20201102161933.patch text/plain 2528 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5Mjc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWRkMWM0ZTU0N2Q1ZWVh NGEzMzNlZGI5ZDUxMzE0M2RiZjgzYzU0ZC4uNDUyODgxZjU4Y2RiMDE0MDQ1OGJkMjk4YTMwMmY1 OGVhNzAxNmEyNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDIwLTExLTAyICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgUmVncmVzc2lvbihyMjY5MjI3 KSBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL3NlcnZpY2Utd29ya2Vycy9zZXJ2aWNl LXdvcmtlci9yZWZlcnJlci10b3BsZXZlbC1zY3JpcHQtZmV0Y2guaHR0cHMuaHRtbCBpcyBhIGZs YWt5IGNyYXNoCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMTg0NjgKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzcwOTY5MDcxPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENvZGUgaW4gU2VydmljZVdvcmtl ckNvbnRhaW5lcjo6cmVhZHkoKSB3YXMgcXVldWVpbmcgYW4gZXZlbnQgbG9vcCB0YXNrIGFuZCB0 aGVuIGRlcmVmZXJlbmNpbmcKKyAgICAgICAgc2NyaXB0RXhlY3V0aW9uQ29udGV4dCgpIGluIHRo ZSB0YXNrLiBUaGlzIGlzIG5vIGxvbmdlciBzYWZlIGFmdGVyIHIyNjkyMjcgc2luY2UgdGFza3Mg bWF5CisgICAgICAgIHN0aWxsIGJlIHJ1biBhZnRlciBBY3RpdmVET01PYmplY3RzIGhhdmUgYmVl biBzdG9wcGVkLiBUbyBhZGRyZXNzIHRoZSBpc3N1ZSwgd2UgbmVlZCB0bworICAgICAgICBudWxs IGNoZWNrIHRoZSBzY3JpcHRFeGVjdXRpb25Db250ZXh0LgorCisgICAgICAgIE5vIG5ldyB0ZXN0 cywgY292ZXJlZCBieSBleGlzdGluZyB0ZXN0LgorCisgICAgICAgICogd29ya2Vycy9zZXJ2aWNl L1NlcnZpY2VXb3JrZXJDb250YWluZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2VydmljZVdv cmtlckNvbnRhaW5lcjo6cmVhZHkpOgorCiAyMDIwLTExLTAyICBDaHJpcyBEdW1leiAgPGNkdW1l ekBhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTiAocjI2OTIyNyk6IENyYXNoIGluIFdl YkNvcmU6Oldvcmtlck9yV29ya2xldEdsb2JhbFNjb3BlOjpwcmVwYXJlRm9yRGVzdHJ1Y3Rpb24K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvc2VydmljZS9TZXJ2aWNlV29ya2Vy Q29udGFpbmVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvc2VydmljZS9TZXJ2aWNlV29y a2VyQ29udGFpbmVyLmNwcAppbmRleCA4NzFjNTI1YjI4OWFmODg0ODBkYWY2YjA2YjdkZDEwOWJm ZWFhZWQwLi4wNWFlMmUzNjY1NGIwYTcwYTRjZGZjMTUxMGJjZmE2M2RmNjUxMmEzIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL3NlcnZpY2UvU2VydmljZVdvcmtlckNvbnRhaW5l ci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvd29ya2Vycy9zZXJ2aWNlL1NlcnZpY2VXb3JrZXJD b250YWluZXIuY3BwCkBAIC0xMDksNyArMTA5LDExIEBAIGF1dG8gU2VydmljZVdvcmtlckNvbnRh aW5lcjo6cmVhZHkoKSAtPiBSZWFkeVByb21pc2UmCiAgICAgICAgIGF1dG8mIGNvbnRleHQgPSAq c2NyaXB0RXhlY3V0aW9uQ29udGV4dCgpOwogICAgICAgICBlbnN1cmVTV0NsaWVudENvbm5lY3Rp b24oKS53aGVuUmVnaXN0cmF0aW9uUmVhZHkoY29udGV4dC50b3BPcmlnaW4oKS5kYXRhKCksIGNv bnRleHQudXJsKCksIFt0aGlzLCBwcm90ZWN0ZWRUaGlzID0gbWFrZVJlZigqdGhpcyldKGF1dG8m JiByZWdpc3RyYXRpb25EYXRhKSBtdXRhYmxlIHsKICAgICAgICAgICAgIHF1ZXVlVGFza0tlZXBp bmdPYmplY3RBbGl2ZSgqdGhpcywgVGFza1NvdXJjZTo6RE9NTWFuaXB1bGF0aW9uLCBbdGhpcywg cmVnaXN0cmF0aW9uRGF0YSA9IFdURk1vdmUocmVnaXN0cmF0aW9uRGF0YSldKCkgbXV0YWJsZSB7 Ci0gICAgICAgICAgICAgICAgYXV0byByZWdpc3RyYXRpb24gPSBTZXJ2aWNlV29ya2VyUmVnaXN0 cmF0aW9uOjpnZXRPckNyZWF0ZSgqc2NyaXB0RXhlY3V0aW9uQ29udGV4dCgpLCAqdGhpcywgV1RG TW92ZShyZWdpc3RyYXRpb25EYXRhKSk7CisgICAgICAgICAgICAgICAgYXV0byogY29udGV4dCA9 IHNjcmlwdEV4ZWN1dGlvbkNvbnRleHQoKTsKKyAgICAgICAgICAgICAgICBpZiAoIWNvbnRleHQp CisgICAgICAgICAgICAgICAgICAgIHJldHVybjsKKworICAgICAgICAgICAgICAgIGF1dG8gcmVn aXN0cmF0aW9uID0gU2VydmljZVdvcmtlclJlZ2lzdHJhdGlvbjo6Z2V0T3JDcmVhdGUoKmNvbnRl eHQsICp0aGlzLCBXVEZNb3ZlKHJlZ2lzdHJhdGlvbkRhdGEpKTsKICAgICAgICAgICAgICAgICBt X3JlYWR5UHJvbWlzZS0+cmVzb2x2ZShXVEZNb3ZlKHJlZ2lzdHJhdGlvbikpOwogICAgICAgICAg ICAgfSk7CiAgICAgICAgIH0pOwo= 412988 2020-11-02 16:42:30 -0800 2020-11-02 17:15:20 -0800 Patch bug-218468-20201102164229.patch text/plain 2507 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5Mjc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWEyNDJiNzliMjZlNjBl NzI4YjA3NmYwYTY4OWY3NjU4OTRiNjM3NC4uNjc4ZGNiMjQxYmZiNzVhMWZjNGI5MWEwMDM1NWQ0 MGI3YzJmNGE2OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDIwLTExLTAyICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgUmVncmVzc2lvbihyMjY5MjI3 KSBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL3NlcnZpY2Utd29ya2Vycy9zZXJ2aWNl LXdvcmtlci9yZWZlcnJlci10b3BsZXZlbC1zY3JpcHQtZmV0Y2guaHR0cHMuaHRtbCBpcyBhIGZs YWt5IGNyYXNoCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMTg0NjgKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzcwOTY5MDcxPgorCisgICAgICAgIFJl dmlld2VkIGJ5IERhcmluIEFkbGVyLgorCisgICAgICAgIENvZGUgaW4gU2VydmljZVdvcmtlckNv bnRhaW5lcjo6cmVhZHkoKSB3YXMgcXVldWVpbmcgYW4gZXZlbnQgbG9vcCB0YXNrIGFuZCB0aGVu IGRlcmVmZXJlbmNpbmcKKyAgICAgICAgc2NyaXB0RXhlY3V0aW9uQ29udGV4dCgpIGluIHRoZSB0 YXNrLiBUaGlzIGlzIG5vIGxvbmdlciBzYWZlIGFmdGVyIHIyNjkyMjcgc2luY2UgdGFza3MgbWF5 CisgICAgICAgIHN0aWxsIGJlIHJ1biBhZnRlciBBY3RpdmVET01PYmplY3RzIGhhdmUgYmVlbiBz dG9wcGVkLiBUbyBhZGRyZXNzIHRoZSBpc3N1ZSwgd2UgbmVlZCB0bworICAgICAgICBudWxsIGNo ZWNrIHRoZSBzY3JpcHRFeGVjdXRpb25Db250ZXh0LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywg Y292ZXJlZCBieSBleGlzdGluZyB0ZXN0LgorCisgICAgICAgICogd29ya2Vycy9zZXJ2aWNlL1Nl cnZpY2VXb3JrZXJDb250YWluZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2VydmljZVdvcmtl ckNvbnRhaW5lcjo6cmVhZHkpOgorCiAyMDIwLTExLTAyICBEZXZpbiBSb3Vzc28gIDxkcm91c3Nv QGFwcGxlLmNvbT4KIAogICAgICAgICBndWFyZCBVSVNjcmliYmxlSW50ZXJhY3Rpb24gY2xhc3Mg cHJvcGVydHkgb2JzZXJ2aW5nIGJlaGluZCBhIExPQSBjaGVjawpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvd29ya2Vycy9zZXJ2aWNlL1NlcnZpY2VXb3JrZXJDb250YWluZXIuY3BwIGIvU291 cmNlL1dlYkNvcmUvd29ya2Vycy9zZXJ2aWNlL1NlcnZpY2VXb3JrZXJDb250YWluZXIuY3BwCmlu ZGV4IDg3MWM1MjViMjg5YWY4ODQ4MGRhZjZiMDZiN2RkMTA5YmZlYWFlZDAuLjZiYjM0NDE1NzNm MGUwNGZkOThhNWEwNjRiZWZhZjAxYzc3MGMxZjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3dvcmtlcnMvc2VydmljZS9TZXJ2aWNlV29ya2VyQ29udGFpbmVyLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS93b3JrZXJzL3NlcnZpY2UvU2VydmljZVdvcmtlckNvbnRhaW5lci5jcHAKQEAgLTEw OSw3ICsxMDksMTAgQEAgYXV0byBTZXJ2aWNlV29ya2VyQ29udGFpbmVyOjpyZWFkeSgpIC0+IFJl YWR5UHJvbWlzZSYKICAgICAgICAgYXV0byYgY29udGV4dCA9ICpzY3JpcHRFeGVjdXRpb25Db250 ZXh0KCk7CiAgICAgICAgIGVuc3VyZVNXQ2xpZW50Q29ubmVjdGlvbigpLndoZW5SZWdpc3RyYXRp b25SZWFkeShjb250ZXh0LnRvcE9yaWdpbigpLmRhdGEoKSwgY29udGV4dC51cmwoKSwgW3RoaXMs IHByb3RlY3RlZFRoaXMgPSBtYWtlUmVmKCp0aGlzKV0oYXV0byYmIHJlZ2lzdHJhdGlvbkRhdGEp IG11dGFibGUgewogICAgICAgICAgICAgcXVldWVUYXNrS2VlcGluZ09iamVjdEFsaXZlKCp0aGlz LCBUYXNrU291cmNlOjpET01NYW5pcHVsYXRpb24sIFt0aGlzLCByZWdpc3RyYXRpb25EYXRhID0g V1RGTW92ZShyZWdpc3RyYXRpb25EYXRhKV0oKSBtdXRhYmxlIHsKLSAgICAgICAgICAgICAgICBh dXRvIHJlZ2lzdHJhdGlvbiA9IFNlcnZpY2VXb3JrZXJSZWdpc3RyYXRpb246OmdldE9yQ3JlYXRl KCpzY3JpcHRFeGVjdXRpb25Db250ZXh0KCksICp0aGlzLCBXVEZNb3ZlKHJlZ2lzdHJhdGlvbkRh dGEpKTsKKyAgICAgICAgICAgICAgICBhdXRvKiBjb250ZXh0ID0gc2NyaXB0RXhlY3V0aW9uQ29u dGV4dCgpOworICAgICAgICAgICAgICAgIGlmICghY29udGV4dCkKKyAgICAgICAgICAgICAgICAg ICAgcmV0dXJuOworICAgICAgICAgICAgICAgIGF1dG8gcmVnaXN0cmF0aW9uID0gU2VydmljZVdv cmtlclJlZ2lzdHJhdGlvbjo6Z2V0T3JDcmVhdGUoKmNvbnRleHQsICp0aGlzLCBXVEZNb3ZlKHJl Z2lzdHJhdGlvbkRhdGEpKTsKICAgICAgICAgICAgICAgICBtX3JlYWR5UHJvbWlzZS0+cmVzb2x2 ZShXVEZNb3ZlKHJlZ2lzdHJhdGlvbikpOwogICAgICAgICAgICAgfSk7CiAgICAgICAgIH0pOwo=