218458 2020-11-02 13:22:36 -0800 REGRESSION (r269244?): ASSERTION FAILED: m_idHashSalt.isEmpty() || m_idHashSalt == salt in WebCore::Document::setDeviceIDHashSalt 2020-11-03 05:35:54 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=218192 InRadar P2 Normal --- 1 ryanhaddad youennf cdumez eric.carlson esprehn+autocc ews-watchlist glenn hta jer.noble kangil.han philipj sergio tommyw webkit-bot-watchers-bugzilla webkit-bug-importer youennf oldest_to_newest 1703671 0 ryanhaddad 2020-11-02 13:22:36 -0800 http/tests/navigation/page-cache-iframe-no-current-historyItem.html has become a flaky assertion failure on iOS and macOS debug bots. This appears to have started with https://trac.webkit.org/changeset/269244/webkit https://results.webkit.org/?suite=layout-tests&test=http%2Ftests%2Fnavigation%2Fpage-cache-iframe-no-current-historyItem.html ASSERTION FAILED: m_idHashSalt.isEmpty() || m_idHashSalt == salt ./dom/Document.cpp(7957) : void WebCore::Document::setDeviceIDHashSalt(const WTF::String &) 1 0x450d89f89 WTFCrash 2 0x4300025eb WTFCrashWithInfo(int, char const*, char const*, int) 3 0x4330fbf36 WebCore::Document::setDeviceIDHashSalt(WTF::String const&) 4 0x4324940b9 WebCore::UserMediaRequest::allow(WebCore::CaptureDevice&&, WebCore::CaptureDevice&&, WTF::String&&, WTF::CompletionHandler<void ()>&&)::$_3::operator()() 5 0x432493f5e WTF::Detail::CallableWrapper<WebCore::UserMediaRequest::allow(WebCore::CaptureDevice&&, WebCore::CaptureDevice&&, WTF::String&&, WTF::CompletionHandler<void ()>&&)::$_3, void>::call() 6 0x430016942 WTF::Function<void ()>::operator()() const 7 0x4324935ae void WebCore::ActiveDOMObject::queueTaskKeepingObjectAlive<WebCore::UserMediaRequest>(WebCore::UserMediaRequest&, WebCore::TaskSource, WTF::Function<void ()>&&)::'lambda'()::operator()() const 8 0x4324930fe WTF::Detail::CallableWrapper<void WebCore::ActiveDOMObject::queueTaskKeepingObjectAlive<WebCore::UserMediaRequest>(WebCore::UserMediaRequest&, WebCore::TaskSource, WTF::Function<void ()>&&)::'lambda'(), void>::call() 9 0x430016942 WTF::Function<void ()>::operator()() const 10 0x433206e0e WebCore::EventLoopFunctionDispatchTask::execute() 11 0x4331fd4b5 WebCore::EventLoop::run() 12 0x433394e0c WebCore::WindowEventLoop::didReachTimeToRun() 13 0x43339a377 decltype(*(std::__1::forward<WebCore::WindowEventLoop*&>(fp0)).*fp()) std::__1::__invoke<void (WebCore::WindowEventLoop::*&)(), WebCore::WindowEventLoop*&, void>(void (WebCore::WindowEventLoop::*&)(), WebCore::WindowEventLoop*&) 14 0x43339a2f0 std::__1::__bind_return<void (WebCore::WindowEventLoop::*)(), std::__1::tuple<WebCore::WindowEventLoop*>, std::__1::tuple<>, __is_valid_bind_return<void (WebCore::WindowEventLoop::*)(), std::__1::tuple<WebCore::WindowEventLoop*>, std::__1::tuple<> >::value>::type std::__1::__apply_functor<void (WebCore::WindowEventLoop::*)(), std::__1::tuple<WebCore::WindowEventLoop*>, 0ul, std::__1::tuple<> >(void (WebCore::WindowEventLoop::*&)(), std::__1::tuple<WebCore::WindowEventLoop*>&, std::__1::__tuple_indices<0ul>, std::__1::tuple<>&&) 15 0x43339a2a9 std::__1::__bind_return<void (WebCore::WindowEventLoop::*)(), std::__1::tuple<WebCore::WindowEventLoop*>, std::__1::tuple<>, __is_valid_bind_return<void (WebCore::WindowEventLoop::*)(), std::__1::tuple<WebCore::WindowEventLoop*>, std::__1::tuple<> >::value>::type std::__1::__bind<void (WebCore::WindowEventLoop::*&)(), WebCore::WindowEventLoop*>::operator()<>() 16 0x43339a24e WTF::Detail::CallableWrapper<std::__1::__bind<void (WebCore::WindowEventLoop::*&)(), WebCore::WindowEventLoop*>, void>::call() 17 0x430016942 WTF::Function<void ()>::operator()() const 18 0x43004deae WebCore::Timer::fired() 19 0x4342aeb84 WebCore::ThreadTimers::sharedTimerFiredInternal() 20 0x4342b7e61 WebCore::ThreadTimers::setSharedTimer(WebCore::SharedTimer*)::$_0::operator()() const 21 0x4342b7e0e WTF::Detail::CallableWrapper<WebCore::ThreadTimers::setSharedTimer(WebCore::SharedTimer*)::$_0, void>::call() 22 0x430016942 WTF::Function<void ()>::operator()() const 23 0x43426b10b WebCore::MainThreadSharedTimer::fired() 24 0x4343263a6 WebCore::timerFired(__CFRunLoopTimer*, void*) 25 0x7fff350507f9 __CFRUNLOOP_IS_CALLING_OUT_TO_A_TIMER_CALLBACK_FUNCTION__ 26 0x7fff3505035f __CFRunLoopDoTimer 27 0x7fff3504fe47 __CFRunLoopDoTimers 28 0x7fff35034bea __CFRunLoopRun 29 0x7fff35033e3e CFRunLoopRunSpecific 30 0x7fff376cf1c8 -[NSRunLoop(NSRunLoop) runMode:beforeDate:] 31 0x7fff37781c6f -[NSRunLoop(NSRunLoop) run] LEAK: 2 WebPageProxy 1703673 1 webkit-bug-importer 2020-11-02 13:23:35 -0800 <rdar://problem/70963733> 1703709 2 ryanhaddad 2020-11-02 14:42:44 -0800 This also affects http/tests/navigation/page-cache-iframe-provisional-load-async-delegates.html https://results.webkit.org/?suite=layout-tests&test=http%2Ftests%2Fnavigation%2Fpage-cache-iframe-no-current-historyItem.html 1703870 3 413021 youennf 2020-11-03 01:46:31 -0800 Created attachment 413021 Patch 1703956 4 ews-feeder 2020-11-03 05:35:53 -0800 Committed r269295: <https://trac.webkit.org/changeset/269295> All reviewed patches have been landed. Closing bug and clearing flags on attachment 413021. 413021 2020-11-03 01:46:31 -0800 2020-11-03 05:35:54 -0800 Patch bug-218458-20201103104630.patch text/plain 3003 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5MjQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDUyMGFmZjMyZTQzMmUw MTA0YzQ2ZGExYWJkMDg4M2FmMTZlZTRlNC4uZjQ4MTA2NDNlZTMxOWFiMTNmNTE3MjRiZmU5ODc3 ODVmNDI5YjZmYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIwLTExLTAyICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMjY5 MjQ0Pyk6IEFTU0VSVElPTiBGQUlMRUQ6IG1faWRIYXNoU2FsdC5pc0VtcHR5KCkgfHwgbV9pZEhh c2hTYWx0ID09IHNhbHQgaW4gV2ViQ29yZTo6RG9jdW1lbnQ6OnNldERldmljZUlESGFzaFNhbHQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxODQ1OAor ICAgICAgICA8cmRhcjovL3Byb2JsZW0vNzA5NjM3MzM+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlIG5vIGxvbmdlciBuZWVkZWQgY29kZS4K KworICAgICAgICAqIE1vZHVsZXMvbWVkaWFzdHJlYW0vVXNlck1lZGlhUmVxdWVzdC5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpVc2VyTWVkaWFSZXF1ZXN0OjphbGxvdyk6CisgICAgICAgICogZG9t L0RvY3VtZW50LmNwcDoKKyAgICAgICAgKiBkb20vRG9jdW1lbnQuaDoKKyAgICAgICAgKFdlYkNv cmU6OkRvY3VtZW50OjpoYXNIYWRDYXB0dXJlTWVkaWFTdHJlYW1UcmFjayBjb25zdCk6CisKIDIw MjAtMTEtMDIgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIEFs bG93IGxvdyBsYXRlbmN5IEgyNjQgZW5jb2RlciBpbiBHUFVQcm9jZXNzCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL1VzZXJNZWRpYVJlcXVlc3QuY3BwIGIv U291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9Vc2VyTWVkaWFSZXF1ZXN0LmNwcApp bmRleCA4NjBlN2UwOGQyMDNiMTYwMDBlMzk5M2I1ODMwN2JhNDFiNzg3YzlmLi42ZWVjMWNjYWI2 Mzg5ZDI3YmJjMGU1MzMxYmVhZWRiM2IxZTY3NWY3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9Nb2R1bGVzL21lZGlhc3RyZWFtL1VzZXJNZWRpYVJlcXVlc3QuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vVXNlck1lZGlhUmVxdWVzdC5jcHAKQEAgLTI1Nyw4 ICsyNTcsNiBAQCB2b2lkIFVzZXJNZWRpYVJlcXVlc3Q6OmFsbG93KENhcHR1cmVEZXZpY2UmJiBh dWRpb0RldmljZSwgQ2FwdHVyZURldmljZSYmIHZpZGVvRAogICAgICAgICB9OwogCiAgICAgICAg IGF1dG8mIGRvY3VtZW50ID0gZG93bmNhc3Q8RG9jdW1lbnQ+KCpzY3JpcHRFeGVjdXRpb25Db250 ZXh0KCkpOwotICAgICAgICBkb2N1bWVudC5zZXREZXZpY2VJREhhc2hTYWx0KGRldmljZUlkZW50 aWZpZXJIYXNoU2FsdCk7Ci0KICAgICAgICAgUmVhbHRpbWVNZWRpYVNvdXJjZUNlbnRlcjo6c2lu Z2xldG9uKCkuY3JlYXRlTWVkaWFTdHJlYW0oZG9jdW1lbnQubG9nZ2VyKCksIFdURk1vdmUoY2Fs bGJhY2spLCBXVEZNb3ZlKGRldmljZUlkZW50aWZpZXJIYXNoU2FsdCksIFdURk1vdmUoYXVkaW9E ZXZpY2UpLCBXVEZNb3ZlKHZpZGVvRGV2aWNlKSwgbV9yZXF1ZXN0KTsKIAogICAgICAgICBpZiAo IW1fc2NyaXB0RXhlY3V0aW9uQ29udGV4dCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Rv bS9Eb2N1bWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCmluZGV4IDQx MmY3ZmVjYTc3MTM4ODVkODIxYzA1NzFlZGVhYTcxZjNmMDEwNGEuLjc2ZTk3YzVkNzNjZTVjYzY5 YzU0MWMzMThmMWViYWQxY2E0MDVmZTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9E b2N1bWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcApAQCAtNzk1 MiwxMiArNzk1Miw2IEBAIHZvaWQgRG9jdW1lbnQ6Om1lZGlhU3RyZWFtQ2FwdHVyZVN0YXRlQ2hh bmdlZCgpCiAgICAgfSk7CiB9CiAKLXZvaWQgRG9jdW1lbnQ6OnNldERldmljZUlESGFzaFNhbHQo Y29uc3QgU3RyaW5nJiBzYWx0KQotewotICAgIEFTU0VSVChtX2lkSGFzaFNhbHQuaXNFbXB0eSgp IHx8IG1faWRIYXNoU2FsdCA9PSBzYWx0KTsKLSAgICBtX2lkSGFzaFNhbHQgPSBzYWx0OwotfQot CiAjZW5kaWYKIAogY29uc3QgQXRvbVN0cmluZyYgRG9jdW1lbnQ6OmJnQ29sb3IoKSBjb25zdApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmggYi9Tb3VyY2UvV2ViQ29y ZS9kb20vRG9jdW1lbnQuaAppbmRleCA2OTkzYWMzN2VhZjJlNWViYWFjYTc0YzY3NTQ3ZDBmY2Ix ODI3YmJjLi43MmMyYjkyNTIyY2MxZGUyNzg3OTQ5YTQ0MWMxNzUwZDU0ODc3YzVhIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9k b20vRG9jdW1lbnQuaApAQCAtMTQyNSw4ICsxNDI1LDYgQEAgcHVibGljOgogI2lmIEVOQUJMRShN RURJQV9TVFJFQU0pCiAgICAgdm9pZCBzZXRIYXNDYXB0dXJlTWVkaWFTdHJlYW1UcmFjaygpIHsg bV9oYXNIYWRDYXB0dXJlTWVkaWFTdHJlYW1UcmFjayA9IHRydWU7IH0KICAgICBib29sIGhhc0hh ZENhcHR1cmVNZWRpYVN0cmVhbVRyYWNrKCkgY29uc3QgeyByZXR1cm4gbV9oYXNIYWRDYXB0dXJl TWVkaWFTdHJlYW1UcmFjazsgfQotICAgIHZvaWQgc2V0RGV2aWNlSURIYXNoU2FsdChjb25zdCBT dHJpbmcmKTsKLSAgICBTdHJpbmcgZGV2aWNlSURIYXNoU2FsdCgpIGNvbnN0IHsgcmV0dXJuIG1f aWRIYXNoU2FsdDsgfQogICAgIHZvaWQgc3RvcE1lZGlhQ2FwdHVyZSgpOwogICAgIHZvaWQgbWVk aWFTdHJlYW1DYXB0dXJlU3RhdGVDaGFuZ2VkKCk7CiAjZW5kaWYK