218455 2020-11-02 13:09:16 -0800 REGRESSION (r269227): Crash in WebCore::WorkerOrWorkletGlobalScope::prepareForDestruction 2020-11-02 14:24:20 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=218363 InRadar P2 Normal --- 1 ryanhaddad cdumez cdumez darin esprehn+autocc ews-watchlist ggaren kangil.han rniwa sam webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1703660 0 ryanhaddad 2020-11-02 13:09:16 -0800 The following two tests are consistently crashing on iOS and macOS debug bots after https://trac.webkit.org/changeset/269227/webkit fast/css-custom-paint/constructor.html fast/css-custom-paint/registerPaintBindings.html https://results.webkit.org/?suite=layout-tests&suite=layout-tests&test=fast%2Fcss-custom-paint%2Fconstructor.html&test=fast%2Fcss-custom-paint%2FregisterPaintBindings.html Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 com.apple.JavaScriptCore 0x000000020f36df8e WTFCrash + 14 (Assertions.cpp:295) 1 com.apple.WebCore 0x00000001ee5e65eb WTFCrashWithInfo(int, char const*, char const*, int) + 27 2 com.apple.WebCore 0x00000001f383bdb5 WebCore::WorkerOrWorkletGlobalScope::prepareForDestruction() + 181 (WorkerOrWorkletGlobalScope.cpp:53) 3 com.apple.WebCore 0x00000001f39b6abf WebCore::WorkletGlobalScope::prepareForDestruction() + 31 (WorkletGlobalScope.cpp:95) 4 com.apple.WebCore 0x00000001f16be46e WebCore::PaintWorkletGlobalScope::prepareForDestruction() + 78 (PaintWorkletGlobalScope.h:73) 5 com.apple.WebCore 0x00000001f16bd7c2 WebCore::Document::willBeRemovedFromFrame() + 1714 (Document.cpp:2621) 6 com.apple.WebCore 0x00000001f25f78d3 WebCore::Frame::setView(WTF::RefPtr<WebCore::FrameView, WTF::RawPtrTraits<WebCore::FrameView>, WTF::DefaultRefDerefTraits<WebCore::FrameView> >&&) + 195 7 com.apple.WebCore 0x00000001f25fc49d WebCore::Frame::createView(WebCore::IntSize const&, WTF::Optional<WebCore::Color> const&, WebCore::IntSize const&, WebCore::IntRect const&, bool, WebCore::ScrollbarMode, bool, WebCore::ScrollbarMode, bool) + 253 (Frame.cpp:870) 8 com.apple.WebKit 0x00000001e19a33c7 WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage() + 887 (WebFrameLoaderClient.cpp:1524) 9 com.apple.WebCore 0x00000001f23d3cde WebCore::FrameLoader::transitionToCommitted(WebCore::CachedPage*) + 1982 (FrameLoader.cpp:2211) 10 com.apple.WebCore 0x00000001f23d2987 WebCore::FrameLoader::commitProvisionalLoad() + 1191 (FrameLoader.cpp:2022) 11 com.apple.WebCore 0x00000001f2356fbc WebCore::DocumentLoader::commitIfReady() + 60 (DocumentLoader.cpp:377) 12 com.apple.WebCore 0x00000001f2357720 WebCore::DocumentLoader::finishedLoading() + 304 (DocumentLoader.cpp:442) 13 com.apple.WebCore 0x00000001f2363154 WebCore::DocumentLoader::maybeLoadEmpty() + 1076 (DocumentLoader.cpp:1831) 14 com.apple.WebCore 0x00000001f23632e5 WebCore::DocumentLoader::startLoadingMainResource() + 357 (DocumentLoader.cpp:1844) 15 com.apple.WebCore 0x00000001f23fc83c WebCore::FrameLoader::continueLoadAfterNavigationPolicy(WebCore::ResourceRequest const&, WebCore::FormState*, WebCore::NavigationPolicyDecision, WebCore::AllowNavigationToInvalidURL)::$_11::operator()() + 1612 1703661 1 webkit-bug-importer 2020-11-02 13:09:44 -0800 <rdar://problem/70963191> 1703662 2 cdumez 2020-11-02 13:10:00 -0800 Looking. 1703678 3 412966 cdumez 2020-11-02 13:42:53 -0800 Created attachment 412966 Patch 1703697 4 412966 ggaren 2020-11-02 14:15:08 -0800 Comment on attachment 412966 Patch r=me 1703701 5 ews-feeder 2020-11-02 14:24:18 -0800 Committed r269275: <https://trac.webkit.org/changeset/269275> All reviewed patches have been landed. Closing bug and clearing flags on attachment 412966. 412966 2020-11-02 13:42:53 -0800 2020-11-02 14:24:19 -0800 Patch bug-218455-20201102134253.patch text/plain 2998 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5MjY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGYzNDY4ZDI0NzFlMDU0 YmYzYjQzYWVkYjQ1N2I2YzdhYTJlMTNjOS4uOWJmN2FmNTIxODA3MjFiZmZkYjQzZGIxZWYzZWVl NGQ0MTY3NzdlNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDIwLTExLTAyICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjI2OTIy Nyk6IENyYXNoIGluIFdlYkNvcmU6Oldvcmtlck9yV29ya2xldEdsb2JhbFNjb3BlOjpwcmVwYXJl Rm9yRGVzdHJ1Y3Rpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIxODQ1NQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNzA5NjMxOTE+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRG9jdW1lbnQ6OndpbGxC ZVJlbW92ZWRGcm9tRnJhbWUoKSBtYXkgaGF2ZSB0aGUgc2FtZSBQYWludFdvcmtsZXRHbG9iYWxT Y29wZSBpbnN0YW5jZQorICAgICAgICBtb3JlIHRoYW4gb25jZSBpbiBpdHMgbV9wYWludFdvcmts ZXRHbG9iYWxTY29wZXMgSGFzaE1hcCwgdW5kZXIgZGlmZmVyZW50IGtleXMuIEFzIGEKKyAgICAg ICAgcmVzdWx0LCBpdCBtYXkgY2FsbCBQYWludFdvcmtsZXRHbG9iYWxTY29wZTo6cHJlcGFyZUZv ckRlc3RydWN0aW9uKCkgbW9yZSB0aGFuIG9uY2UKKyAgICAgICAgb24gdGhlIHNhbWUgaW5zdGFu Y2UuIFRoaXMgd2FzIGNhdXNpbmcgaXNzdWVzIGJlY2F1c2UKKyAgICAgICAgRXZlbnRMb29wVGFz a0dyb3VwOjptYXJrQXNSZWFkeVRvU3RvcCgpLCB3aGVuIGNhbGxlZCB0aGUgc2Vjb25kIHRpbWUs IHdvdWxkIG1vdmUgdGhlCisgICAgICAgIHN0YXRlIGZyb20gU3RvcHBlZCBhbmQgYmFjayB0byBS ZWFkeVRvU3RvcCwgd2hpY2ggaXMgdW5leHBlY3RlZC4KKworICAgICAgICBUbyBhZGRyZXNzIHRo ZSBpc3N1ZSwgRXZlbnRMb29wVGFza0dyb3VwOjptYXJrQXNSZWFkeVRvU3RvcCgpIG5vdyByZXR1 cm5zIGVhcmx5IGlmCisgICAgICAgIHRoZSBzdGF0ZSBpcyAiU3RvcHBlZCIuIEFsc28sIEkgYWRk ZWQgYSBib29sZWFuIGNoZWNrIGluIFBhaW50V29ya2xldEdsb2JhbFNjb3BlJ3MKKyAgICAgICAg cHJlcGFyZUZvckRlc3RydWN0aW9uKCkgdG8gbWFrZSBzdXJlIHdlIG9ubHkgZG8gdGhlIHdvcmsg b25jZSBwZXIgaW5zdGFuY2UuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBjb3ZlcmVkIGJ5IGV4 aXN0aW5nIHRlc3RzLgorCisgICAgICAgICogZG9tL0V2ZW50TG9vcC5oOgorICAgICAgICAoV2Vi Q29yZTo6RXZlbnRMb29wVGFza0dyb3VwOjptYXJrQXNSZWFkeVRvU3RvcCk6CisgICAgICAgICog d29ya2xldHMvUGFpbnRXb3JrbGV0R2xvYmFsU2NvcGUuaDoKKwogMjAyMC0xMS0wMSAgRGFyaW4g QWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CiAKICAgICAgICAgU3RhcnQgcmVtb3ZpbmcgZnVuY3Rp b25zIHRoYXQgaW1wbGljaXRseSB1c2UgY29tcG9zZWQgdHJlZQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvZG9tL0V2ZW50TG9vcC5oIGIvU291cmNlL1dlYkNvcmUvZG9tL0V2ZW50TG9vcC5o CmluZGV4IGMzMzEyYmExMGI5MDUyNWVhY2ViNzg3ZTkxMmIwMjMxYWIwODc2ODkuLmI2MTgzMDcx ZDlhMjNiZGRjZWRiZDM3YzVjM2ZhMjIwMjFhZjMxMDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2RvbS9FdmVudExvb3AuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRXZlbnRMb29wLmgK QEAgLTEzMyw3ICsxMzMsNyBAQCBwdWJsaWM6CiAgICAgLy8gdW50aWwgYWxsIGdyb3VwcyBpbiB0 aGlzIGV2ZW50IGxvb3AgYXJlIHJlYWR5IHRvIHN0b3AuCiAgICAgdm9pZCBtYXJrQXNSZWFkeVRv U3RvcCgpCiAgICAgewotICAgICAgICBpZiAoaXNSZWFkeVRvU3RvcCgpKQorICAgICAgICBpZiAo aXNSZWFkeVRvU3RvcCgpIHx8IGlzU3RvcHBlZFBlcm1hbmVudGx5KCkpCiAgICAgICAgICAgICBy ZXR1cm47CiAKICAgICAgICAgbV9zdGF0ZSA9IFN0YXRlOjpSZWFkeVRvU3RvcDsKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3dvcmtsZXRzL1BhaW50V29ya2xldEdsb2JhbFNjb3BlLmggYi9T b3VyY2UvV2ViQ29yZS93b3JrbGV0cy9QYWludFdvcmtsZXRHbG9iYWxTY29wZS5oCmluZGV4IDNi NzEzZGMzZjRlZGMxYmE3NDJkZTNjOWVhZDBiNTAwYzZmNzQyYzYuLjQyYTc1YjQ1ODI0NzZlZWRh MjhlOWE0MmI5NmIxMWNkYmFjNmU1M2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3dvcmts ZXRzL1BhaW50V29ya2xldEdsb2JhbFNjb3BlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvd29ya2xl dHMvUGFpbnRXb3JrbGV0R2xvYmFsU2NvcGUuaApAQCAtNjUsNiArNjUsMTAgQEAgcHVibGljOgog CiAgICAgdm9pZCBwcmVwYXJlRm9yRGVzdHJ1Y3Rpb24oKSBmaW5hbAogICAgIHsKKyAgICAgICAg aWYgKG1faGFzUHJlcGFyZWRGb3JEZXN0cnVjdGlvbikKKyAgICAgICAgICAgIHJldHVybjsKKyAg ICAgICAgbV9oYXNQcmVwYXJlZEZvckRlc3RydWN0aW9uID0gdHJ1ZTsKKwogICAgICAgICB7CiAg ICAgICAgICAgICBhdXRvIGxvY2tlciA9IGhvbGRMb2NrKHBhaW50RGVmaW5pdGlvbkxvY2soKSk7 CiAgICAgICAgICAgICBwYWludERlZmluaXRpb25NYXAoKS5jbGVhcigpOwpAQCAtODcsNiArOTEs NyBAQCBwcml2YXRlOgogCiAgICAgSGFzaE1hcDxTdHJpbmcsIHN0ZDo6dW5pcXVlX3B0cjxQYWlu dERlZmluaXRpb24+PiBtX3BhaW50RGVmaW5pdGlvbk1hcDsKICAgICBMb2NrIG1fcGFpbnREZWZp bml0aW9uTG9jazsKKyAgICBib29sIG1faGFzUHJlcGFyZWRGb3JEZXN0cnVjdGlvbiB7IGZhbHNl IH07CiB9OwogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCg==