218454 2020-11-02 12:52:25 -0800 Add back swap() free function for RefPtr 2020-11-05 15:04:19 -0800 1 1 1 Unclassified WebKit Web Template Framework Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam benjamin cdumez cmarcelo darin ews-watchlist webkit-bug-importer oldest_to_newest 1703652 0 saam 2020-11-02 12:52:25 -0800 See: https://bugs.webkit.org/show_bug.cgi?id=199866#c40 and Darin's response 1703654 1 saam 2020-11-02 12:53:40 -0800 Darin's possible solution here seems like a good starting point: https://bugs.webkit.org/show_bug.cgi?id=199866#c42 Maybe we can also allow this for all PtrTraits, instead of opting some of them out 1703717 2 412974 saam 2020-11-02 14:50:32 -0800 Created attachment 412974 test EWS Let's see what EWS thinks 1704956 3 413334 saam 2020-11-05 11:32:43 -0800 Created attachment 413334 patch 1705023 4 ews-feeder 2020-11-05 15:03:21 -0800 Committed r269479: <https://trac.webkit.org/changeset/269479> All reviewed patches have been landed. Closing bug and clearing flags on attachment 413334. 1705024 5 webkit-bug-importer 2020-11-05 15:04:19 -0800 <rdar://problem/71096319> 412974 2020-11-02 14:50:32 -0800 2020-11-05 11:32:43 -0800 test EWS c-backup.diff text/plain 575 saam SW5kZXg6IFNvdXJjZS9XVEYvd3RmL1JlZlB0ci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYv d3RmL1JlZlB0ci5oCShyZXZpc2lvbiAyNjkyNjgpCisrKyBTb3VyY2UvV1RGL3d0Zi9SZWZQdHIu aAkod29ya2luZyBjb3B5KQpAQCAtMTkzLDYgKzE5MywxMiBAQCBpbmxpbmUgdm9pZCBSZWZQdHI8 VCwgVSwgVj46OnN3YXAoUmVmUHRyCiAgICAgVTo6c3dhcChtX3B0ciwgby5tX3B0cik7CiB9CiAK K3RlbXBsYXRlPHR5cGVuYW1lIFQsIHR5cGVuYW1lIFUsIHR5cGVuYW1lIFY+CitpbmxpbmUgdm9p ZCBzd2FwKFJlZlB0cjxULCBVLCBWPiYgYSwgUmVmUHRyPFQsIFUsIFY+JiBiKQoreworICAgIGEu c3dhcChiKTsKK30KKwogdGVtcGxhdGU8dHlwZW5hbWUgVCwgdHlwZW5hbWUgVSwgdHlwZW5hbWUg ViwgdHlwZW5hbWUgWCwgdHlwZW5hbWUgWSwgdHlwZW5hbWUgWj4KIGlubGluZSBib29sIG9wZXJh dG9yPT0oY29uc3QgUmVmUHRyPFQsIFUsIFY+JiBhLCBjb25zdCBSZWZQdHI8WCwgWSwgWj4mIGIp CiB7IAo= 413334 2020-11-05 11:32:43 -0800 2020-11-05 15:03:22 -0800 patch c-backup.diff text/plain 1419 saam SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyNjk0NTMpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDIwLTExLTA1ICBTYWFtIEJhcmF0aSAgPHNiYXJh dGlAYXBwbGUuY29tPgorCisgICAgICAgIEFkZCBiYWNrIHN3YXAoKSBmcmVlIGZ1bmN0aW9uIGZv ciBSZWZQdHIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIxODQ1NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEFkZCBiYWNrIHRoZSBzd2FwKCkgZnJlZSBmdW5jdGlvbiBJIHJlbW92ZWQgaW4gcjI2OTExNS4g RGFyaW4ncyBzdWdnZXN0aW9uCisgICAgICAgIG9mIHNwZWNpYWxpemluZyBvbmx5IGEgc2luZ2xl IHR5cGUgb2YgUmVmUHRyIGluc3RlYWQgb2YgdHdvLCBzb2x2ZWQgdGhlCisgICAgICAgIGlzc3Vl LiBJIGFsc28gcmVtb3ZlZCBzb21lIHByZXZpb3VzIGhhY2sgd2hlcmUgd2UgZGlkbid0IGVuYWJs ZSB0aGlzIGZvcgorICAgICAgICBSYXdQdHJUcmFpdHMuIEl0J3Mgbm93IGVuYWJsZWQgZm9yIGFs bCBQdHJUcmFpdHMuCisKKyAgICAgICAgKiB3dGYvUmVmUHRyLmg6CisgICAgICAgIChXVEY6OnN3 YXApOgorCiAyMDIwLTExLTA1ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAog ICAgICAgICBDb25zaWRlciBibG9ja2luZyBwb3J0cyA1MDYwIGFuZCA1MDYxCkluZGV4OiBTb3Vy Y2UvV1RGL3d0Zi9SZWZQdHIuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV1RGL3d0Zi9SZWZQdHIu aAkocmV2aXNpb24gMjY5MzkxKQorKysgU291cmNlL1dURi93dGYvUmVmUHRyLmgJKHdvcmtpbmcg Y29weSkKQEAgLTE5Myw2ICsxOTMsMTIgQEAgaW5saW5lIHZvaWQgUmVmUHRyPFQsIFUsIFY+Ojpz d2FwKFJlZlB0cgogICAgIFU6OnN3YXAobV9wdHIsIG8ubV9wdHIpOwogfQogCit0ZW1wbGF0ZTx0 eXBlbmFtZSBULCB0eXBlbmFtZSBVLCB0eXBlbmFtZSBWPgoraW5saW5lIHZvaWQgc3dhcChSZWZQ dHI8VCwgVSwgVj4mIGEsIFJlZlB0cjxULCBVLCBWPiYgYikKK3sKKyAgICBhLnN3YXAoYik7Cit9 CisKIHRlbXBsYXRlPHR5cGVuYW1lIFQsIHR5cGVuYW1lIFUsIHR5cGVuYW1lIFYsIHR5cGVuYW1l IFgsIHR5cGVuYW1lIFksIHR5cGVuYW1lIFo+CiBpbmxpbmUgYm9vbCBvcGVyYXRvcj09KGNvbnN0 IFJlZlB0cjxULCBVLCBWPiYgYSwgY29uc3QgUmVmUHRyPFgsIFksIFo+JiBiKQogeyAK