21845 2008-10-23 17:57:40 -0700 m_frame null checked but then dereferenced 2008-10-23 18:05:39 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fishd fishd oliver oldest_to_newest 96459 0 fishd 2008-10-23 17:57:40 -0700 m_frame null checked but then dereferenced in EventHandler::allowDHTMLDrag, it appears that a return statement is missing. it looks like this code was introduced in http://trac.webkit.org/changeset/19230 this was found using a static analysis tool. i don't know if it is actually possible for m_frame to be null, so i don't know how to judge the severity of this bug. maybe the null checking code should just be removed. 96462 1 24629 fishd 2008-10-23 17:59:53 -0700 Created attachment 24629 v1 patch: add early return 96464 2 24629 eric 2008-10-23 18:01:12 -0700 Comment on attachment 24629 v1 patch: add early return This looks to me like what the author intended in their original code. Certainly the existing code is incorrect. 96465 3 eric 2008-10-23 18:01:53 -0700 Please add a comment to your changelog when landing about how this was found using a static analysis tool and thus there are no reproduction steps for a test case. 96466 4 fishd 2008-10-23 18:05:39 -0700 http://trac.webkit.org/changeset/37834 24629 2008-10-23 17:59:53 -0700 2008-10-23 18:01:12 -0700 v1 patch: add early return early_return_1.diff text/plain 1069 fishd SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDM3ODMz KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDgtMTAt MjMgIERhcmluIEZpc2hlciAgPGRhcmluQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBtX2ZyYW1lIG51bGwgY2hlY2tlZCBidXQg dGhlbiBkZXJlZmVyZW5jZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIxODQ1CisKKyAgICAgICAgKiBwYWdlL0V2ZW50SGFuZGxlci5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpFdmVudEhhbmRsZXI6OmFsbG93REhUTUxEcmFnKTogQWRkIGFuIGVhcmx5 IHJldHVybi4KKwogMjAwOC0xMC0yMyAgRGFuIEJlcm5zdGVpbiAgPG1pdHpAYXBwbGUuY29tPgog CiAgICAgICAgIFJldmlld2VkIGJ5IFNhbSBXZWluaWcgd2l0aCBubyBoZXNpdGF0aW9uLgpJbmRl eDogcGFnZS9FdmVudEhhbmRsZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHBhZ2UvRXZlbnRIYW5kbGVy LmNwcAkocmV2aXNpb24gMzc4MjMpCisrKyBwYWdlL0V2ZW50SGFuZGxlci5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTY3Nyw2ICs2NzcsNyBAQCB2b2lkIEV2ZW50SGFuZGxlcjo6YWxsb3dESFRNTERy YWcoYm9vbCYgCiAgICAgaWYgKCFtX2ZyYW1lIHx8ICFtX2ZyYW1lLT5kb2N1bWVudCgpKSB7CiAg ICAgICAgIGZsYWdESFRNTCA9IGZhbHNlOwogICAgICAgICBmbGFnVUEgPSBmYWxzZTsKKyAgICAg ICAgcmV0dXJuOwogICAgIH0KICAgICAKICAgICB1bnNpZ25lZCBtYXNrID0gbV9mcmFtZS0+cGFn ZSgpLT5kcmFnQ29udHJvbGxlcigpLT5kZWxlZ2F0ZURyYWdTb3VyY2VBY3Rpb24obV9mcmFtZS0+ dmlldygpLT5jb250ZW50c1RvV2luZG93KG1fbW91c2VEb3duUG9zKSk7Cg==