218443 2020-11-02 06:32:33 -0800 [JSC] Remove compiler warning in LLIntData.cpp 2020-11-02 10:35:27 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 xan.lopez webkit-unassigned ews-watchlist keith_miller mark.lam msaboff saam smoley tzagallo webkit-bug-importer xan.lopez oldest_to_newest 1703510 0 xan.lopez 2020-11-02 06:32:33 -0800 This warning has been around in my machine for a while: In file included from DerivedSources/ForwardingHeaders/wtf/StdLibExtras.h:32, from DerivedSources/ForwardingHeaders/wtf/FastMalloc.h:26, from ../../Source/JavaScriptCore/config.h:38, from ../../Source/JavaScriptCore/llint/LLIntCLoop.cpp:26, from DerivedSources/JavaScriptCore/unified-sources/UnifiedSource-6e4525b9-1.cpp:1: ../../Source/JavaScriptCore/llint/LLIntData.cpp: In static member function ‘static void JSC::LLInt::Data::performAssertions(JSC::VM&)’: ../../Source/JavaScriptCore/llint/LLIntData.cpp:100:88: warning: comparison of integer expressions of different signedness: ‘long unsigned int’ and ‘ptrdiff_t’ {aka ‘long int’} [-Wsign-compare] 100 | ASSERT(static_cast<long unsigned int>(CallFrameSlot::codeBlock * sizeof(Register)) == CallFrame::returnPCOffset() + MachineRegisterSize); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ DerivedSources/ForwardingHeaders/wtf/Assertions.h:346:11: note: in definition of macro ‘ASSERT’ 346 | if (!(assertion)) { \ | ^~~~~~~~~ This seems fixable by casting the scoped enum used in this comparison (CallFrameSlot) to its underlying type, which seems advised in this kind of operation anyway. Also while at it I removed the type annotation for the enum, since we are using the default. 1703515 1 412915 xan.lopez 2020-11-02 06:40:35 -0800 Created attachment 412915 Remove warning from LLIntData v1 1703570 2 webkit-bug-importer 2020-11-02 10:07:15 -0800 <rdar://problem/70955212> 1703575 3 412915 mark.lam 2020-11-02 10:19:15 -0800 Comment on attachment 412915 Remove warning from LLIntData r=me 1703585 4 ews-feeder 2020-11-02 10:35:24 -0800 Committed r269252: <https://trac.webkit.org/changeset/269252> All reviewed patches have been landed. Closing bug and clearing flags on attachment 412915. 412915 2020-11-02 06:40:35 -0800 2020-11-02 10:35:25 -0800 Remove warning from LLIntData 0001-JSC-Remove-compiler-warning-in-LLIntData.cpp.patch text/plain 3742 xan.lopez RnJvbSAxYmQwMjc2ZDJlNDU3ZGJmMWVjNzE4NmMwNGNhNWU5MGRjN2EyY2NhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/WGFuPTIwTD1DMz1CM3Blej89IDx4YW5AaWdh bGlhLmNvbT4KRGF0ZTogTW9uLCAyIE5vdiAyMDIwIDE1OjM5OjQ4ICswMTAwClN1YmplY3Q6IFtQ QVRDSF0gW0pTQ10gUmVtb3ZlIGNvbXBpbGVyIHdhcm5pbmcgaW4gTExJbnREYXRhLmNwcAogaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxODQ0MwoKUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCgpGaXggY29tcGlsZXIgd2FybmluZyBieSBjYXN0aW5nIGEgc2NvcGVk IGVudW0gdG8gaXRzIHVuZGVybHlpbmcKdHlwZS4gTm90IGFsbG93aW5nIGltcGxpY2l0IHR5cGUg Y29udmVyc2lvbnMgaXMgdGhlIHdob2xlIHBvaW50IG9mCnNjb3BlZCBlbnVtcy4KCiogaW50ZXJw cmV0ZXIvQ2FsbEZyYW1lLmg6IHJlbW92ZSB1bmRlcmx5aW5nIHR5cGUgc3BlY2lmaWVyLCBzaW5j ZQp3ZSBhcmUgdXNpbmcgdGhlIGRlZmF1bHQgYW55d2F5ICgnaW50JykuCiogbGxpbnQvTExJbnRE YXRhLmNwcDoKKEpTQzo6TExJbnQ6OkRhdGE6OnBlcmZvcm1Bc3NlcnRpb25zKTogY2FzdCB0aGUg c2NvcGVkIGVudW0gdG8gaXRzCnVuZGVybHlpbmcgdHlwZS4KLS0tCiBTb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgfCAxNyArKysrKysrKysrKysrKysrKwogU291 cmNlL0phdmFTY3JpcHRDb3JlL2ludGVycHJldGVyL0NhbGxGcmFtZS5oIHwgIDIgKy0KIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9sbGludC9MTEludERhdGEuY3BwICAgICB8ICAyICstCiAzIGZpbGVz IGNoYW5nZWQsIDE5IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEv U291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9D aGFuZ2VMb2cKaW5kZXggMmRhMTkyN2M0ZGEzLi5hNjNjN2ZlYjQyZmIgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIwLTExLTAyICBYYW4gTG9wZXogIDx4YW5A aWdhbGlhLmNvbT4KKworICAgICAgICBbSlNDXSBSZW1vdmUgY29tcGlsZXIgd2FybmluZyBpbiBM TEludERhdGEuY3BwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMTg0NDMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBGaXggY29tcGlsZXIgd2FybmluZyBieSBjYXN0aW5nIGEgc2NvcGVkIGVudW0gdG8gaXRz IHVuZGVybHlpbmcKKyAgICAgICAgdHlwZS4gTm90IGFsbG93aW5nIGltcGxpY2l0IHR5cGUgY29u dmVyc2lvbnMgaXMgdGhlIHdob2xlIHBvaW50IG9mCisgICAgICAgIHNjb3BlZCBlbnVtcy4KKwor ICAgICAgICAqIGludGVycHJldGVyL0NhbGxGcmFtZS5oOiByZW1vdmUgdW5kZXJseWluZyB0eXBl IHNwZWNpZmllciwgc2luY2UKKyAgICAgICAgd2UgYXJlIHVzaW5nIHRoZSBkZWZhdWx0IGFueXdh eSAoJ2ludCcpLgorICAgICAgICAqIGxsaW50L0xMSW50RGF0YS5jcHA6CisgICAgICAgIChKU0M6 OkxMSW50OjpEYXRhOjpwZXJmb3JtQXNzZXJ0aW9ucyk6IGNhc3QgdGhlIHNjb3BlZCBlbnVtIHRv IGl0cworICAgICAgICB1bmRlcmx5aW5nIHR5cGUuCisKIDIwMjAtMTAtMjEgIFhhbiBMw7NwZXog IDx4YW5AaWdhbGlhLmNvbT4KIAogICAgICAgICBbSlNDXSBVc2Ugc3ltYm9scyBhcyBpZGVudGlm aWVycyBmb3IgY2xhc3MgZmllbGRzIGNvbXB1dGVkIG5hbWVzIHN0b3JhZ2UKZGlmZiAtLWdpdCBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnRlcnByZXRlci9DYWxsRnJhbWUuaCBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9pbnRlcnByZXRlci9DYWxsRnJhbWUuaAppbmRleCA4OWFkOWMzM2JhZmEu LmMxOGM0YjZjZmIxYyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2ludGVycHJl dGVyL0NhbGxGcmFtZS5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnRlcnByZXRlci9D YWxsRnJhbWUuaApAQCAtODksNyArODksNyBAQCBuYW1lc3BhY2UgSlNDICB7CiAgICAgfTsKICAg ICBzdGF0aWNfYXNzZXJ0KENhbGxlckZyYW1lQW5kUEM6OnNpemVJblJlZ2lzdGVycyA9PSBzaXpl b2YoQ2FsbGVyRnJhbWVBbmRQQykgLyBzaXplb2YoUmVnaXN0ZXIpLCAiQ2FsbGVyRnJhbWVBbmRQ Qzo6c2l6ZUluUmVnaXN0ZXJzIGlzIGluY29ycmVjdC4iKTsKIAotICAgIGVudW0gY2xhc3MgQ2Fs bEZyYW1lU2xvdCA6IGludCB7CisgICAgZW51bSBjbGFzcyBDYWxsRnJhbWVTbG90IHsKICAgICAg ICAgY29kZUJsb2NrID0gQ2FsbGVyRnJhbWVBbmRQQzo6c2l6ZUluUmVnaXN0ZXJzLAogICAgICAg ICBjYWxsZWUgPSBjb2RlQmxvY2sgKyAxLAogICAgICAgICBhcmd1bWVudENvdW50SW5jbHVkaW5n VGhpcyA9IGNhbGxlZSArIDEsCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxp bnQvTExJbnREYXRhLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9MTEludERhdGEu Y3BwCmluZGV4IGJmYTRmM2JjOGVlMi4uNjJkY2E4ZmYyOWRlIDEwMDY0NAotLS0gYS9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvbGxpbnQvTExJbnREYXRhLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvbGxpbnQvTExJbnREYXRhLmNwcApAQCAtOTcsNyArOTcsNyBAQCB2b2lkIERhdGE6OnBl cmZvcm1Bc3NlcnRpb25zKFZNJiB2bSkKICAgICBBU1NFUlQoIUNhbGxGcmFtZTo6Y2FsbGVyRnJh bWVPZmZzZXQoKSk7CiAgICAgU1RBVElDX0FTU0VSVChDYWxsZXJGcmFtZUFuZFBDOjpzaXplSW5S ZWdpc3RlcnMgPT0gKE1hY2hpbmVSZWdpc3RlclNpemUgKiAyKSAvIFNsb3RTaXplKTsKICAgICBB U1NFUlQoQ2FsbEZyYW1lOjpyZXR1cm5QQ09mZnNldCgpID09IENhbGxGcmFtZTo6Y2FsbGVyRnJh bWVPZmZzZXQoKSArIE1hY2hpbmVSZWdpc3RlclNpemUpOwotICAgIEFTU0VSVChDYWxsRnJhbWVT bG90Ojpjb2RlQmxvY2sgKiBzaXplb2YoUmVnaXN0ZXIpID09IENhbGxGcmFtZTo6cmV0dXJuUENP ZmZzZXQoKSArIE1hY2hpbmVSZWdpc3RlclNpemUpOworICAgIEFTU0VSVChzdGF0aWNfY2FzdDxz dGQ6OnVuZGVybHlpbmdfdHlwZV90PENhbGxGcmFtZVNsb3Q+PihDYWxsRnJhbWVTbG90Ojpjb2Rl QmxvY2spICogc2l6ZW9mKFJlZ2lzdGVyKSA9PSBDYWxsRnJhbWU6OnJldHVyblBDT2Zmc2V0KCkg KyBNYWNoaW5lUmVnaXN0ZXJTaXplKTsKICAgICBTVEFUSUNfQVNTRVJUKENhbGxGcmFtZVNsb3Q6 OmNhbGxlZSAqIHNpemVvZihSZWdpc3RlcikgPT0gQ2FsbEZyYW1lU2xvdDo6Y29kZUJsb2NrICog c2l6ZW9mKFJlZ2lzdGVyKSArIFNsb3RTaXplKTsKICAgICBTVEFUSUNfQVNTRVJUKENhbGxGcmFt ZVNsb3Q6OmFyZ3VtZW50Q291bnRJbmNsdWRpbmdUaGlzICogc2l6ZW9mKFJlZ2lzdGVyKSA9PSBD YWxsRnJhbWVTbG90OjpjYWxsZWUgKiBzaXplb2YoUmVnaXN0ZXIpICsgU2xvdFNpemUpOwogICAg IFNUQVRJQ19BU1NFUlQoQ2FsbEZyYW1lU2xvdDo6dGhpc0FyZ3VtZW50ICogc2l6ZW9mKFJlZ2lz dGVyKSA9PSBDYWxsRnJhbWVTbG90Ojphcmd1bWVudENvdW50SW5jbHVkaW5nVGhpcyAqIHNpemVv ZihSZWdpc3RlcikgKyBTbG90U2l6ZSk7Ci0tIAoyLjI4LjAKCg==