<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>218420</bug_id>
          
          <creation_ts>2020-10-31 20:49:21 -0700</creation_ts>
          <short_desc>[LFC][IFC] Empty lines stay empty even when the imaginary strut is present</short_desc>
          <delta_ts>2020-11-09 13:52:02 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Layout and Rendering</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>INVALID</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=218456</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="alan">zalan</reporter>
          <assigned_to name="alan">zalan</assigned_to>
          <cc>bfulgham</cc>
    
    <cc>koivisto</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>zalan</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1703376</commentid>
    <comment_count>0</comment_count>
    <who name="alan">zalan</who>
    <bug_when>2020-10-31 20:49:21 -0700</bug_when>
    <thetext>ssia</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1703377</commentid>
    <comment_count>1</comment_count>
      <attachid>412859</attachid>
    <who name="alan">zalan</who>
    <bug_when>2020-10-31 21:13:43 -0700</bug_when>
    <thetext>Created attachment 412859
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1703422</commentid>
    <comment_count>2</comment_count>
      <attachid>412871</attachid>
    <who name="alan">zalan</who>
    <bug_when>2020-11-01 14:00:05 -0800</bug_when>
    <thetext>Created attachment 412871
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1703506</commentid>
    <comment_count>3</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2020-11-02 06:12:16 -0800</bug_when>
    <thetext>Committed r269245: &lt;https://trac.webkit.org/changeset/269245&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412871.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1703507</commentid>
    <comment_count>4</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2020-11-02 06:13:21 -0800</bug_when>
    <thetext>&lt;rdar://problem/70947450&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1703691</commentid>
    <comment_count>5</comment_count>
    <who name="alan">zalan</who>
    <bug_when>2020-11-02 14:07:08 -0800</bug_when>
    <thetext>Reverted r269245 for reason:

3 LFC tests asserting in WebCore::Layout::LayoutContext::verifyAndOutputMismatchingLayoutTree

Committed r269274: &lt;https://trac.webkit.org/changeset/269274&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1705870</commentid>
    <comment_count>6</comment_count>
    <who name="alan">zalan</who>
    <bug_when>2020-11-09 13:52:02 -0800</bug_when>
    <thetext>fixed differently</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>412859</attachid>
            <date>2020-10-31 21:13:43 -0700</date>
            <delta_ts>2020-10-31 22:07:40 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-218420-20201031211342.patch</filename>
            <type>text/plain</type>
            <size>2005</size>
            <attacher name="alan">zalan</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5MjI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTJmMDNhN2Y1MzE5NjE4
ZDc3MTNiZGNiNzc1NjliZTMzMjY2ODdhMi4uOTYyYWFmMGFmMWJkNGE1YTI2NTc5ODU0MGM5NDBl
ZjQ4NzJiY2I2OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDIwLTEwLTMxICBaYWxh
biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bSUZDXSBPbmx5IHRo
ZSBpbWFnaW5hcnkgc3RydXQgYW5kIHRleHQgY29udGVudC9oYXJkIGxpbmUgYnJlYWsgbWFrZSB0
aGUgcm9vdCBpbmxpbmUgYm94IG5vbi1lbXB0eQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0
Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE4NDIwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ
IChPT1BTISkuCisKKyAgICAgICAgKiBsYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVGb3Jt
YXR0aW5nQ29udGV4dEdlb21ldHJ5LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkxheW91dDo6TGlu
ZUJveEJ1aWxkZXI6OmNvbnN0cnVjdElubGluZUxldmVsQm94ZXMpOgorCiAyMDIwLTEwLTMxICBa
YWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW0xGQ11bSUZDXSBJbmxp
bmVMZXZlbEJveCBsb2dpY2FsIHJlY3Qgc2hvdWxkIG9ubHkgYmUgYWNjZXNzZWQgdGhyb3VnaCBM
aW5lQm94CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGlu
Zy9JbmxpbmVGb3JtYXR0aW5nQ29udGV4dEdlb21ldHJ5LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xh
eW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUZvcm1hdHRpbmdDb250ZXh0R2VvbWV0cnkuY3Bw
CmluZGV4IGM3Y2Y1MzVmZmMwZGRlODk2MWI1ZmY3YmM1MzM1M2UyMTRjMzI2N2IuLjNhY2EzZGQy
ZGVkYjEyM2EzOGM1NjA0NmFiNGM1ZmVlMGFkY2I3YTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD
b3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUZvcm1hdHRpbmdDb250ZXh0R2VvbWV0
cnkuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGlu
ZUZvcm1hdHRpbmdDb250ZXh0R2VvbWV0cnkuY3BwCkBAIC0yMDcsOSArMjA3LDggQEAgdm9pZCBM
aW5lQm94QnVpbGRlcjo6Y29uc3RydWN0SW5saW5lTGV2ZWxCb3hlcyhMaW5lQm94JiBsaW5lQm94
LCBjb25zdCBMaW5lOjpSdW4KICAgICBhdXRvIGNyZWF0ZVJvb3RJbmxpbmVCb3ggPSBbJl0gewog
ICAgICAgICBhdXRvIHJvb3RJbmxpbmVCb3ggPSBMaW5lQm94OjpJbmxpbmVMZXZlbEJveDo6Y3Jl
YXRlUm9vdElubGluZUJveChyb290Qm94KCksIGhvcml6b250YWxBbGlnbWVudE9mZnNldCwgbGlu
ZUJveC5sb2dpY2FsV2lkdGgoKSk7CiAKLSAgICAgICAgYXV0byBsaW5lSGFzSW1hZ2luYXJ5U3Ry
dXQgPSBsYXlvdXRTdGF0ZSgpLmluTm9RdWlya3NNb2RlKCk7Ci0gICAgICAgIGF1dG8gaXNJbml0
aWFsbHlDb25zaWRlcmVkTm9uRW1wdHkgPSAhbGluZUJveC5pc0xpbmVWaXN1YWxseUVtcHR5KCkg
JiYgbGluZUhhc0ltYWdpbmFyeVN0cnV0OwotICAgICAgICBpZiAoaXNJbml0aWFsbHlDb25zaWRl
cmVkTm9uRW1wdHkpCisgICAgICAgIGF1dG8gbGluZVN0YXJ0c1dpdGhJbWFnaW5hcnlTdHJ1dCA9
IGxheW91dFN0YXRlKCkuaW5Ob1F1aXJrc01vZGUoKTsKKyAgICAgICAgaWYgKGxpbmVTdGFydHNX
aXRoSW1hZ2luYXJ5U3RydXQpCiAgICAgICAgICAgICByb290SW5saW5lQm94LT5zZXRJc05vbkVt
cHR5KCk7CiAgICAgICAgIHNldFZlcnRpY2FsR2VvbWV0cnlGb3JJbmxpbmVCb3goKnJvb3RJbmxp
bmVCb3gpOwogICAgICAgICBsaW5lQm94LmFkZFJvb3RJbmxpbmVCb3goV1RGTW92ZShyb290SW5s
aW5lQm94KSk7Cg==
</data>
<flag name="commit-queue"
          id="429360"
          type_id="3"
          status="-"
          setter="ews-feeder"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>412871</attachid>
            <date>2020-11-01 14:00:05 -0800</date>
            <delta_ts>2020-11-02 06:12:16 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-218420-20201101140004.patch</filename>
            <type>text/plain</type>
            <size>1952</size>
            <attacher name="alan">zalan</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5MjM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTljNTM5ZTNhNWE3YjM5
NTEwYzE2ZDBmOGIzYzMxOGZiMWJiNmE2NC4uOWIzZWIwNjFiMjMxYTBkNGU4ZWFhYTBlNjUzOTQ0
NjUyMGQzODhlYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIwLTExLTAxICBaYWxh
biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bSUZDXSBFbXB0eSBs
aW5lcyBzdGF5IGVtcHR5IGV2ZW4gd2hlbiB0aGUgaW1hZ2luYXJ5IHN0cnV0IGlzIHByZXNlbnQK
KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxODQyMAor
CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVzZSB0aGUg
bW9yZSBjb3JyZWN0IHJ1bnMuaXNFbXB0eSgpIGNoZWNrIHRvIGRlY2lkZSB3aGV0aGVyIHRoZSBy
b290IGlubGluZSBib3ggc2hvdWxkIHN0YXkgZW1wdHkuCisKKyAgICAgICAgKiBsYXlvdXQvaW5s
aW5lZm9ybWF0dGluZy9JbmxpbmVGb3JtYXR0aW5nQ29udGV4dEdlb21ldHJ5LmNwcDoKKyAgICAg
ICAgKFdlYkNvcmU6OkxheW91dDo6TGluZUJveEJ1aWxkZXI6OmNvbnN0cnVjdElubGluZUxldmVs
Qm94ZXMpOgorCiAyMDIwLTExLTAxICBDaHJpcyBGbGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5j
b20+CiAKICAgICAgICAgQVg6IFByb3ZpZGUgYnVpbGQgd29ya2Fyb3VuZCB3aGlsZSBpc1N5c3Rl
bVZvaWNlIGlzIG5vdCBpbiBhbGwgU0RLcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbGF5
b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lRm9ybWF0dGluZ0NvbnRleHRHZW9tZXRyeS5jcHAg
Yi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVGb3JtYXR0aW5n
Q29udGV4dEdlb21ldHJ5LmNwcAppbmRleCA2OGNhZDlhZTI5NDNkNDdlNTU1MzBkNTdmYzc4ZWJl
ZDY3ZmNkMjE2Li4zMzYwY2E4N2VhZWZjZWYyZGUwYjYyZDNlZmM4NDE0MDM2NmU3MzE0IDEwMDY0
NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVGb3Jt
YXR0aW5nQ29udGV4dEdlb21ldHJ5LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5s
aW5lZm9ybWF0dGluZy9JbmxpbmVGb3JtYXR0aW5nQ29udGV4dEdlb21ldHJ5LmNwcApAQCAtMjA4
LDcgKzIwOCw3IEBAIHZvaWQgTGluZUJveEJ1aWxkZXI6OmNvbnN0cnVjdElubGluZUxldmVsQm94
ZXMoTGluZUJveCYgbGluZUJveCwgY29uc3QgTGluZTo6UnVuCiAgICAgICAgIGF1dG8gcm9vdElu
bGluZUJveCA9IExpbmVCb3g6OklubGluZUxldmVsQm94OjpjcmVhdGVSb290SW5saW5lQm94KHJv
b3RCb3goKSwgaG9yaXpvbnRhbEFsaWdtZW50T2Zmc2V0LCBsaW5lQm94LmxvZ2ljYWxXaWR0aCgp
KTsKIAogICAgICAgICBhdXRvIGxpbmVIYXNJbWFnaW5hcnlTdHJ1dCA9IGxheW91dFN0YXRlKCku
aW5Ob1F1aXJrc01vZGUoKTsKLSAgICAgICAgYXV0byBpc0luaXRpYWxseUNvbnNpZGVyZWROb25F
bXB0eSA9ICFsaW5lQm94LmlzTGluZVZpc3VhbGx5RW1wdHkoKSAmJiBsaW5lSGFzSW1hZ2luYXJ5
U3RydXQ7CisgICAgICAgIGF1dG8gaXNJbml0aWFsbHlDb25zaWRlcmVkTm9uRW1wdHkgPSBsaW5l
SGFzSW1hZ2luYXJ5U3RydXQgJiYgIXJ1bnMuaXNFbXB0eSgpOwogICAgICAgICBpZiAoaXNJbml0
aWFsbHlDb25zaWRlcmVkTm9uRW1wdHkpCiAgICAgICAgICAgICByb290SW5saW5lQm94LT5zZXRJ
c05vbkVtcHR5KCk7CiAgICAgICAgIHNldFZlcnRpY2FsR2VvbWV0cnlGb3JJbmxpbmVCb3goKnJv
b3RJbmxpbmVCb3gpOwo=
</data>

          </attachment>
      

    </bug>

</bugzilla>