<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>21838</bug_id>
          
          <creation_ts>2008-10-23 13:24:32 -0700</creation_ts>
          <short_desc>Fix some forward declares to use &apos;struct&apos; instead of &apos;class&apos; to match the type definition</short_desc>
          <delta_ts>2008-10-30 22:41:17 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Layout and Rendering</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Darin Fisher (:fishd, Google)">fishd</reporter>
          <assigned_to name="Darin Fisher (:fishd, Google)">fishd</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>96388</commentid>
    <comment_count>0</comment_count>
    <who name="Darin Fisher (:fishd, Google)">fishd</who>
    <bug_when>2008-10-23 13:24:32 -0700</bug_when>
    <thetext>Fix some forward declares to use &apos;struct&apos; instead of &apos;class&apos; to match the type definition

This avoids compiler warnings in some build configurations.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>96389</commentid>
    <comment_count>1</comment_count>
      <attachid>24612</attachid>
    <who name="Darin Fisher (:fishd, Google)">fishd</who>
    <bug_when>2008-10-23 13:25:32 -0700</bug_when>
    <thetext>Created attachment 24612
v1 patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>96391</commentid>
    <comment_count>2</comment_count>
      <attachid>24612</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2008-10-23 13:29:57 -0700</bug_when>
    <thetext>Comment on attachment 24612
v1 patch

LGTM.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>96401</commentid>
    <comment_count>3</comment_count>
      <attachid>24612</attachid>
    <who name="Mark Rowe (bdash)">mrowe</who>
    <bug_when>2008-10-23 13:36:05 -0700</bug_when>
    <thetext>Comment on attachment 24612
v1 patch

The forward declarations in StyleRareNonInheritedData.h need to be re-sorted.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>96415</commentid>
    <comment_count>4</comment_count>
    <who name="Darin Fisher (:fishd, Google)">fishd</who>
    <bug_when>2008-10-23 14:12:23 -0700</bug_when>
    <thetext>bdash, good catch.  thanks!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>97219</commentid>
    <comment_count>5</comment_count>
    <who name="Timothy Hatcher">timothy</who>
    <bug_when>2008-10-30 22:41:17 -0700</bug_when>
    <thetext>This already landed. Please comment with the revision number and close as fixed next time.

Landed in r37824.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>24612</attachid>
            <date>2008-10-23 13:25:32 -0700</date>
            <delta_ts>2008-10-23 13:29:57 -0700</delta_ts>
            <desc>v1 patch</desc>
            <filename>style-1.diff</filename>
            <type>text/plain</type>
            <size>1561</size>
            <attacher name="Darin Fisher (:fishd, Google)">fishd</attacher>
            
              <data encoding="base64">SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDM3ODIx
KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDgtMTAt
MjMgIERhcmluIEZpc2hlciAgPGRhcmluQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdl
ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggZm9yd2FyZCBkZWNscyB0byBiZSBz
dHJ1Y3QgaW5zdGVhZCBvZiBjbGFzcy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv
c2hvd19idWcuY2dpP2lkPTIxODM4CisKKyAgICAgICAgKiByZW5kZXJpbmcvc3R5bGUvU3R5bGVS
YXJlSW5oZXJpdGVkRGF0YS5oOgorICAgICAgICAqIHJlbmRlcmluZy9zdHlsZS9TdHlsZVJhcmVO
b25Jbmhlcml0ZWREYXRhLmg6CisKIDIwMDgtMTAtMjMgIE1pa2UgUGlua2VydG9uICA8cGlua2Vy
dG9uQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KSW5k
ZXg6IHJlbmRlcmluZy9zdHlsZS9TdHlsZVJhcmVJbmhlcml0ZWREYXRhLmgKPT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot
LS0gcmVuZGVyaW5nL3N0eWxlL1N0eWxlUmFyZUluaGVyaXRlZERhdGEuaAkocmV2aXNpb24gMzc4
MTgpCisrKyByZW5kZXJpbmcvc3R5bGUvU3R5bGVSYXJlSW5oZXJpdGVkRGF0YS5oCSh3b3JraW5n
IGNvcHkpCkBAIC0zMiw3ICszMiw3IEBACiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAotY2xhc3Mg
U2hhZG93RGF0YTsKK3N0cnVjdCBTaGFkb3dEYXRhOwogCiAvLyBUaGlzIHN0cnVjdCBpcyBmb3Ig
cmFyZWx5IHVzZWQgaW5oZXJpdGVkIENTUzMsIENTUzIsIGFuZCBXZWJLaXQtc3BlY2lmaWMgcHJv
cGVydGllcy4KIC8vIEJ5IGdyb3VwaW5nIHRoZW0gdG9nZXRoZXIsIHdlIHNhdmUgc3BhY2UsIGFu
ZCBvbmx5IGFsbG9jYXRlIHRoaXMgb2JqZWN0IHdoZW4gc29tZW9uZQpJbmRleDogcmVuZGVyaW5n
L3N0eWxlL1N0eWxlUmFyZU5vbkluaGVyaXRlZERhdGEuaAo9PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSByZW5kZXJp
bmcvc3R5bGUvU3R5bGVSYXJlTm9uSW5oZXJpdGVkRGF0YS5oCShyZXZpc2lvbiAzNzgxOCkKKysr
IHJlbmRlcmluZy9zdHlsZS9TdHlsZVJhcmVOb25Jbmhlcml0ZWREYXRhLmgJKHdvcmtpbmcgY29w
eSkKQEAgLTM4LDggKzM4LDggQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogCiBjbGFzcyBBbmltYXRp
b25MaXN0OwogY2xhc3MgQ1NTU3R5bGVTZWxlY3RvcjsKLWNsYXNzIENvbnRlbnREYXRhOwotY2xh
c3MgU2hhZG93RGF0YTsKK3N0cnVjdCBDb250ZW50RGF0YTsKK3N0cnVjdCBTaGFkb3dEYXRhOwog
Y2xhc3MgU3R5bGVGbGV4aWJsZUJveERhdGE7CiBjbGFzcyBTdHlsZU1hcnF1ZWVEYXRhOwogY2xh
c3MgU3R5bGVNdWx0aUNvbERhdGE7Cg==
</data>
<flag name="review"
          id="11232"
          type_id="1"
          status="+"
          setter="eric"
    />
          </attachment>
      

    </bug>

</bugzilla>