218350 2020-10-29 13:17:44 -0700 REGRESSION (r269146): ASSERTION FAILED: didNeedLayout || logicalHeight() == oldHeight in WebCore::RenderBlockFlow::ensureLineBoxes 2020-10-30 09:04:31 -0700 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=218283 InRadar P2 Normal --- 1 ryanhaddad webkit-unassigned cdumez changseok esprehn+autocc ews-watchlist glenn koivisto kondapallykalyan mifenton mmaxfield pdr webkit-bot-watchers-bugzilla webkit-bug-importer zalan oldest_to_newest 1702831 0 ryanhaddad 2020-10-29 13:17:44 -0700 The following three API tests are failing an assertion on iOS Debug bots: TestWebKitAPI.DragAndDropTests.LinkToInput TestWebKitAPI.DragAndDropTests.BackgroundImageLinkToInput TestWebKitAPI.DragAndDropTests.ImageInLinkToInput ASSERTION FAILED: didNeedLayout || logicalHeight() == oldHeight ./rendering/RenderBlockFlow.cpp(3689) : void WebCore::RenderBlockFlow::ensureLineBoxes() 1 0x586f375a9 WTFCrash 2 0x58ed18b2b WTFCrashWithInfo(int, char const*, char const*, int) 3 0x59321fad9 WebCore::RenderBlockFlow::ensureLineBoxes() 4 0x591c0fbfa WebCore::Position::ensureLineBoxes() const 5 0x591dd1a64 WebCore::RenderedPosition::RenderedPosition(WebCore::Position const&, WebCore::Affinity) 6 0x591dd1bab WebCore::RenderedPosition::RenderedPosition(WebCore::Position const&, WebCore::Affinity) 7 0x591dd1b66 WebCore::RenderedPosition::RenderedPosition(WebCore::VisiblePosition const&) 8 0x591e4d197 WebCore::startPositionForLine(WebCore::VisiblePosition const&, WebCore::LineEndpointComputationMode) 9 0x591e3c7c0 WebCore::startOfLine(WebCore::VisiblePosition const&, WebCore::LineEndpointComputationMode, bool*) 10 0x591e3717a WebCore::startOfLine(WebCore::VisiblePosition const&) 11 0x591e30ee0 WebCore::inSameLine(WebCore::VisiblePosition const&, WebCore::VisiblePosition const&) 12 0x591e30872 WebCore::VisiblePosition::VisiblePosition(WebCore::Position const&, WebCore::Affinity) 13 0x591e30f7b WebCore::VisiblePosition::VisiblePosition(WebCore::Position const&, WebCore::Affinity) 14 0x591e3c3b4 WebCore::nextBoundary(WebCore::VisiblePosition const&, unsigned int (*)(WTF::StringView, unsigned int, WebCore::BoundarySearchContextAvailability, bool&)) 15 0x591e3c5b0 WebCore::nextWordPosition(WebCore::VisiblePosition const&) 16 0x591d77700 WebCore::Editor::updateMarkersForWordsAffectedByEditing(bool) 17 0x591d773af WebCore::Editor::respondToChangedContents(WebCore::VisibleSelection const&) 18 0x591d7a79c WebCore::Editor::appliedEditing(WebCore::CompositeEditCommand&) 19 0x591d316a3 WebCore::CompositeEditCommand::didApplyCommand() 20 0x591d1e9d5 WebCore::CompositeEditCommand::apply() 21 0x59291fb57 WebCore::DragController::concludeEditDrag(WebCore::DragData const&) 22 0x59291e2d0 WebCore::DragController::performDragOperation(WebCore::DragData const&) 23 0x571bed88a WebKit::WebPage::performDragControllerAction(WebKit::DragControllerAction, WebCore::DragData const&, WebKit::SandboxExtension::Handle&&, WebKit::SandboxExtension::HandleArray&&) 24 0x571cd50ce void IPC::callMemberFunctionImpl<WebKit::WebPage, void (WebKit::WebPage::*)(WebKit::DragControllerAction, WebCore::DragData const&, WebKit::SandboxExtension::Handle&&, WebKit::SandboxExtension::HandleArray&&), std::__1::tuple<WebKit::DragControllerAction, WebCore::DragData, WebKit::SandboxExtension::Handle, WebKit::SandboxExtension::HandleArray>, 0ul, 1ul, 2ul, 3ul>(WebKit::WebPage*, void (WebKit::WebPage::*)(WebKit::DragControllerAction, WebCore::DragData const&, WebKit::SandboxExtension::Handle&&, WebKit::SandboxExtension::HandleArray&&), std::__1::tuple<WebKit::DragControllerAction, WebCore::DragData, WebKit::SandboxExtension::Handle, WebKit::SandboxExtension::HandleArray>&&, std::__1::integer_sequence<unsigned long, 0ul, 1ul, 2ul, 3ul>) 25 0x571cd2b20 void IPC::callMemberFunction<WebKit::WebPage, void (WebKit::WebPage::*)(WebKit::DragControllerAction, WebCore::DragData const&, WebKit::SandboxExtension::Handle&&, WebKit::SandboxExtension::HandleArray&&), std::__1::tuple<WebKit::DragControllerAction, WebCore::DragData, WebKit::SandboxExtension::Handle, WebKit::SandboxExtension::HandleArray>, std::__1::integer_sequence<unsigned long, 0ul, 1ul, 2ul, 3ul> >(std::__1::tuple<WebKit::DragControllerAction, WebCore::DragData, WebKit::SandboxExtension::Handle, WebKit::SandboxExtension::HandleArray>&&, WebKit::WebPage*, void (WebKit::WebPage::*)(WebKit::DragControllerAction, WebCore::DragData const&, WebKit::SandboxExtension::Handle&&, WebKit::SandboxExtension::HandleArray&&)) 26 0x571c5900e void IPC::handleMessage<Messages::WebPage::PerformDragControllerAction, WebKit::WebPage, void (WebKit::WebPage::*)(WebKit::DragControllerAction, WebCore::DragData const&, WebKit::SandboxExtension::Handle&&, WebKit::SandboxExtension::HandleArray&&)>(IPC::Decoder&, WebKit::WebPage*, void (WebKit::WebPage::*)(WebKit::DragControllerAction, WebCore::DragData const&, WebKit::SandboxExtension::Handle&&, WebKit::SandboxExtension::HandleArray&&)) 27 0x571c4cca4 WebKit::WebPage::didReceiveWebPageMessage(IPC::Connection&, IPC::Decoder&) 28 0x571bf0da2 WebKit::WebPage::didReceiveMessage(IPC::Connection&, IPC::Decoder&) 29 0x57050ed31 IPC::MessageReceiverMap::dispatchMessage(IPC::Connection&, IPC::Decoder&) 30 0x5716f6c77 WebKit::WebProcess::didReceiveMessage(IPC::Connection&, IPC::Decoder&) 31 0x57012304a IPC::Connection::dispatchMessage(IPC::Decoder&) https://results.webkit.org/?suite=api-tests&suite=api-tests&suite=api-tests&test=TestWebKitAPI.DragAndDropTests.LinkToInput&test=TestWebKitAPI.DragAndDropTests.BackgroundImageLinkToInput&test=TestWebKitAPI.DragAndDropTests.ImageInLinkToInput 1702832 1 webkit-bug-importer 2020-10-29 13:18:32 -0700 <rdar://problem/70822708> 1702834 2 ryanhaddad 2020-10-29 13:19:19 -0700 Test history suggests that this started with https://trac.webkit.org/changeset/269146/webkit 1703039 3 412735 koivisto 2020-10-30 06:27:27 -0700 Created attachment 412735 patch 1703079 4 ews-feeder 2020-10-30 09:04:29 -0700 Committed r269188: <https://trac.webkit.org/changeset/269188> All reviewed patches have been landed. Closing bug and clearing flags on attachment 412735. 412735 2020-10-30 06:27:27 -0700 2020-10-30 09:04:30 -0700 patch innertext-style-height.patch text/plain 2867 koivisto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhYjY5YjRjMmVjODIuLjBiM2VkN2I3NzllZCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt MSwzICsxLDIzIEBACisyMDIwLTEwLTMwICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNv bT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMjY5MTQ2KTogQVNTRVJUSU9OIEZBSUxFRDogZGlk TmVlZExheW91dCB8fCBsb2dpY2FsSGVpZ2h0KCkgPT0gb2xkSGVpZ2h0IGluIFdlYkNvcmU6OlJl bmRlckJsb2NrRmxvdzo6ZW5zdXJlTGluZUJveGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTgzNTAKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzcw ODIyNzA4PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IERyb3BwaW5nIG9mIGVuc3VyZUxpbmVCb3hlcyBjYWxsIHJldmVhbGVkIGEgYnVnIGluIHRleHQg Y29udHJvbCBzdHlsZSB1cGRhdGVzLgorCisgICAgICAgIFJlbmRlclRleHRDb250cm9sU2luZ2xl TGluZSBtdXRhdGVzIHN0eWxlIG9mIHRoZSBpbm5lclRleHRFbGVtZW50KCkgcmVuZGVyZXIgYnkg YWx0ZXJpbmcgdGhlIGhlaWdodCBwcm9wZXJ0eS4KKyAgICAgICAgT24gc3R5bGUgdXBkYXRlIHRo aXMgbXV0YXRpb24gaXMgbG9zdCB3aGljaCBjYXVzZXMgZW5zdXJlTGluZUJveGVzIGZvciBpbm5l clRleHRFbGVtZW50KCkgdG8gbWlzY29tcHV0ZSBibG9jayBoZWlnaHQKKyAgICAgICAgaWYgUmVu ZGVyVGV4dENvbnRyb2xTaW5nbGVMaW5lIGxheW91dCBoYXMgbm90IGhhcHBlbmVkIGJlZm9yZS4K KworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJUZXh0Q29udHJvbC5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpSZW5kZXJUZXh0Q29udHJvbDo6c3R5bGVEaWRDaGFuZ2UpOgorCisgICAgICAgIERv bid0IHplcm8gdGhlIGRpbWVuc2lvbiBwcm9wZXJ0aWVzIG9mIHRoZSBpbm5lclRleHRFbGVtZW50 KCkgdW5uZWNlc3NhcmlseS4gSW5zdGVhZCBzZWUgb2YgdGhlIHVuZGVybHlpbmcgc3R5bGUgaGFz CisgICAgICAgIGFjdHVhbGx5IGNoYW5nZWQgYW5kIHNldCB0aGUgc3R5bGUgb25seSBpbiB0aGF0 IGNhc2UuIFRoYXQgd2lsbCB0aGVuIHRyaWdnZXIgbGF5b3V0IGFzIG5lZWRlZC4KKwogMjAyMC0x MC0yOSAgQWRpdHlhIEtlZXJ0aGkgIDxha2VlcnRoaUBhcHBsZS5jb20+CiAKICAgICAgICAgW0Nv Y29hXSBSZW1vdmUgc29mdCBsaW5raW5nIG9mIE5ldHdvcmtFeHRlbnNpb24uZnJhbWV3b3JrCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGV4dENvbnRyb2wuY3Bw IGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRleHRDb250cm9sLmNwcAppbmRleCA3 YWM2ZTAyM2E4Y2YuLmY1NzVlMTNhMGI2YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlclRleHRDb250cm9sLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyVGV4dENvbnRyb2wuY3BwCkBAIC02NCwxMiArNjQsMTMgQEAgdm9pZCBSZW5kZXJU ZXh0Q29udHJvbDo6c3R5bGVEaWRDaGFuZ2UoU3R5bGVEaWZmZXJlbmNlIGRpZmYsIGNvbnN0IFJl bmRlclN0eWxlKgogICAgIGlmICghaW5uZXJUZXh0KQogICAgICAgICByZXR1cm47CiAgICAgUmVu ZGVyVGV4dENvbnRyb2xJbm5lckJsb2NrKiBpbm5lclRleHRSZW5kZXJlciA9IGlubmVyVGV4dC0+ cmVuZGVyZXIoKTsKLSAgICBpZiAoaW5uZXJUZXh0UmVuZGVyZXIpIHsKLSAgICAgICAgLy8gV2Ug bWF5IGhhdmUgc2V0IHRoZSB3aWR0aCBhbmQgdGhlIGhlaWdodCBpbiB0aGUgb2xkIHN0eWxlIGlu IGxheW91dCgpLgotICAgICAgICAvLyBSZXNldCB0aGVtIG5vdyB0byBhdm9pZCBnZXR0aW5nIGEg c3B1cmlvdXMgbGF5b3V0IGhpbnQuCi0gICAgICAgIGlubmVyVGV4dFJlbmRlcmVyLT5tdXRhYmxl U3R5bGUoKS5zZXRIZWlnaHQoTGVuZ3RoKCkpOwotICAgICAgICBpbm5lclRleHRSZW5kZXJlci0+ bXV0YWJsZVN0eWxlKCkuc2V0V2lkdGgoTGVuZ3RoKCkpOwotICAgICAgICBpbm5lclRleHRSZW5k ZXJlci0+c2V0U3R5bGUodGV4dEZvcm1Db250cm9sRWxlbWVudCgpLmNyZWF0ZUlubmVyVGV4dFN0 eWxlKHN0eWxlKCkpKTsKKyAgICBpZiAoaW5uZXJUZXh0UmVuZGVyZXIgJiYgb2xkU3R5bGUpIHsK KyAgICAgICAgLy8gRklYTUU6IFRoZSBoZWlnaHQgcHJvcGVydHkgb2YgdGhlIGlubmVyIHRleHQg YmxvY2sgc3R5bGUgbWF5IGJlIG11dGF0ZWQgYnkgUmVuZGVyVGV4dENvbnRyb2xTaW5nbGVMaW5l OjpsYXlvdXQuCisgICAgICAgIC8vIFNlZSBpZiB0aGUgb3JpZ2luYWwgaGFzIGNoYW5nZWQgYmVm b3JlIHNldHRpbmcgaXQgYW5kIHRyaWdnZXJpbmcgYSBsYXlvdXQuCisgICAgICAgIGF1dG8gbmV3 SW5uZXJUZXh0U3R5bGUgPSB0ZXh0Rm9ybUNvbnRyb2xFbGVtZW50KCkuY3JlYXRlSW5uZXJUZXh0 U3R5bGUoc3R5bGUoKSk7CisgICAgICAgIGF1dG8gb2xkSW5uZXJUZXh0U3R5bGUgPSB0ZXh0Rm9y bUNvbnRyb2xFbGVtZW50KCkuY3JlYXRlSW5uZXJUZXh0U3R5bGUoKm9sZFN0eWxlKTsKKyAgICAg ICAgaWYgKG5ld0lubmVyVGV4dFN0eWxlICE9IG9sZElubmVyVGV4dFN0eWxlKQorICAgICAgICAg ICAgaW5uZXJUZXh0UmVuZGVyZXItPnNldFN0eWxlKFdURk1vdmUobmV3SW5uZXJUZXh0U3R5bGUp KTsKICAgICB9CiAgICAgdGV4dEZvcm1Db250cm9sRWxlbWVudCgpLnVwZGF0ZVBsYWNlaG9sZGVy VmlzaWJpbGl0eSgpOwogfQo=