218328 2020-10-29 03:44:55 -0700 Add some logging to SequenceCheckerImpl::IsCurrent 2020-10-29 11:11:17 -0700 1 1 1 Unclassified WebKit WebRTC WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf eric.carlson ews-watchlist webkit-bug-importer youennf oldest_to_newest 1702663 0 youennf 2020-10-29 03:44:55 -0700 Add some logging to SequenceCheckerImpl::IsCurrent 1702664 1 412629 youennf 2020-10-29 03:46:00 -0700 Created attachment 412629 Patch 1702776 2 412629 eric.carlson 2020-10-29 10:34:21 -0700 Comment on attachment 412629 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=412629&action=review > Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/synchronization/sequence_checker.cc:63 > + if (valid_queue_ != current_queue) > + RTC_LOG(LS_ERROR) << "SequenceCheckerImpl queue check is failing"; > return valid_queue_ == current_queue; > } > if (valid_system_queue_ && valid_system_queue_ == current_system_queue) { > + if (valid_queue_ != current_queue) > + RTC_LOG(LS_ERROR) << "SequenceCheckerImpl system queue check is failing"; > return true; > } > - return rtc::IsThreadRefEqual(valid_thread_, current_thread); > + auto result = rtc::IsThreadRefEqual(valid_thread_, current_thread); > + if (!result) > + RTC_LOG(LS_ERROR) << "SequenceCheckerImpl thread check is failing"; Would it be helpful have unique log strings to help identify which check fails? 1702784 3 youennf 2020-10-29 11:04:12 -0700 > Would it be helpful have unique log strings to help identify which check > fails? These strings are each different so we should know which one is failing. 1702786 4 ews-feeder 2020-10-29 11:10:32 -0700 Committed r269156: <https://trac.webkit.org/changeset/269156> All reviewed patches have been landed. Closing bug and clearing flags on attachment 412629. 1702787 5 webkit-bug-importer 2020-10-29 11:11:17 -0700 <rdar://problem/70817257> 412629 2020-10-29 03:46:00 -0700 2020-10-29 11:10:32 -0700 Patch bug-218328-20201029114558.patch text/plain 2240 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjY4OTYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9saWJ3ZWJydGMvQ2hhbmdlTG9nIGIvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL0NoYW5n ZUxvZwppbmRleCAxMDE5MTc0NzYzY2M4ZmM3ODJlMGMxNjUwOTVlYmZiNjY2ZGVhYTViLi5hMGI2 NzUwNmU5MGIxMmFiOGU0YThkZWY4OGY1MGNhNWExMjMzMjE5IDEwMDY0NAotLS0gYS9Tb3VyY2Uv VGhpcmRQYXJ0eS9saWJ3ZWJydGMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L2xp YndlYnJ0Yy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAyMC0xMC0yOSAgWW91ZW5uIEZh YmxldCAgPHlvdWVubkBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIHNvbWUgbG9nZ2luZyB0byBT ZXF1ZW5jZUNoZWNrZXJJbXBsOjpJc0N1cnJlbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIxODMyOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogU291cmNlL3dlYnJ0Yy9ydGNfYmFzZS9zeW5jaHJvbml6 YXRpb24vc2VxdWVuY2VfY2hlY2tlci5jYzoKKyAgICAgICAgVGhpcyBtaWdodCBoZWxwIGRlYnVn Z2luZyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE4MDYzLgorCiAy MDIwLTEwLTI2ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBB ZGQgc3VwcG9ydCBmb3IgVlA5IFByb2ZpbGUgMiAoMTAtYml0IGNvbG9yKSBpbiBXZWJSVEMKZGlm ZiAtLWdpdCBhL1NvdXJjZS9UaGlyZFBhcnR5L2xpYndlYnJ0Yy9Tb3VyY2Uvd2VicnRjL3J0Y19i YXNlL3N5bmNocm9uaXphdGlvbi9zZXF1ZW5jZV9jaGVja2VyLmNjIGIvU291cmNlL1RoaXJkUGFy dHkvbGlid2VicnRjL1NvdXJjZS93ZWJydGMvcnRjX2Jhc2Uvc3luY2hyb25pemF0aW9uL3NlcXVl bmNlX2NoZWNrZXIuY2MKaW5kZXggZDY0ZjMyYTYxNmQ0OWNlOTlhOWNmMDk5YzZlMzc5N2Y3YmI4 NDdkYi4uNmExYzYyYTgzZmQ5MjYzNGZkNTUwZjcyYTVhZWIyZjkyODRmNzNmNiAxMDA2NDQKLS0t IGEvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL1NvdXJjZS93ZWJydGMvcnRjX2Jhc2Uvc3lu Y2hyb25pemF0aW9uL3NlcXVlbmNlX2NoZWNrZXIuY2MKKysrIGIvU291cmNlL1RoaXJkUGFydHkv bGlid2VicnRjL1NvdXJjZS93ZWJydGMvcnRjX2Jhc2Uvc3luY2hyb25pemF0aW9uL3NlcXVlbmNl X2NoZWNrZXIuY2MKQEAgLTksNiArOSw4IEBACiAgKi8KICNpbmNsdWRlICJydGNfYmFzZS9zeW5j aHJvbml6YXRpb24vc2VxdWVuY2VfY2hlY2tlci5oIgogCisjaW5jbHVkZSAicnRjX2Jhc2UvbG9n Z2luZy5oIgorCiAjaWYgZGVmaW5lZChXRUJSVENfTUFDKQogI2luY2x1ZGUgPGRpc3BhdGNoL2Rp c3BhdGNoLmg+CiAjZW5kaWYKQEAgLTQ3LDEyICs0OSwxOSBAQCBib29sIFNlcXVlbmNlQ2hlY2tl ckltcGw6OklzQ3VycmVudCgpIGNvbnN0IHsKICAgICByZXR1cm4gdHJ1ZTsKICAgfQogICBpZiAo dmFsaWRfcXVldWVfIHx8IGN1cnJlbnRfcXVldWUpIHsKKyAgICBpZiAodmFsaWRfcXVldWVfICE9 IGN1cnJlbnRfcXVldWUpCisgICAgICBSVENfTE9HKExTX0VSUk9SKSA8PCAiU2VxdWVuY2VDaGVj a2VySW1wbCBxdWV1ZSBjaGVjayBpcyBmYWlsaW5nIjsKICAgICByZXR1cm4gdmFsaWRfcXVldWVf ID09IGN1cnJlbnRfcXVldWU7CiAgIH0KICAgaWYgKHZhbGlkX3N5c3RlbV9xdWV1ZV8gJiYgdmFs aWRfc3lzdGVtX3F1ZXVlXyA9PSBjdXJyZW50X3N5c3RlbV9xdWV1ZSkgeworICAgIGlmICh2YWxp ZF9xdWV1ZV8gIT0gY3VycmVudF9xdWV1ZSkKKyAgICAgIFJUQ19MT0coTFNfRVJST1IpIDw8ICJT ZXF1ZW5jZUNoZWNrZXJJbXBsIHN5c3RlbSBxdWV1ZSBjaGVjayBpcyBmYWlsaW5nIjsKICAgICBy ZXR1cm4gdHJ1ZTsKICAgfQotICByZXR1cm4gcnRjOjpJc1RocmVhZFJlZkVxdWFsKHZhbGlkX3Ro cmVhZF8sIGN1cnJlbnRfdGhyZWFkKTsKKyAgYXV0byByZXN1bHQgPSBydGM6OklzVGhyZWFkUmVm RXF1YWwodmFsaWRfdGhyZWFkXywgY3VycmVudF90aHJlYWQpOworICBpZiAoIXJlc3VsdCkKKyAg ICBSVENfTE9HKExTX0VSUk9SKSA8PCAiU2VxdWVuY2VDaGVja2VySW1wbCB0aHJlYWQgY2hlY2sg aXMgZmFpbGluZyI7CisgIHJldHVybiByZXN1bHQ7CiB9CiAKIHZvaWQgU2VxdWVuY2VDaGVja2Vy SW1wbDo6RGV0YWNoKCkgewo=