21832 2008-10-23 11:28:19 -0700 Fix scripts using 'new File::Temp' for Perl 5.10 2008-10-23 17:02:25 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED https://lists.webkit.org/pipermail/webkit-dev/2008-October/005489.html P2 Normal --- 1 ddkilzer ddkilzer aroben mrowe oldest_to_newest 96358 0 ddkilzer 2008-10-23 11:28:19 -0700 In Perl 5.10, the File::Temp module changed from this method of creating a new object: $fh = new File::Temp($template); To this method: $fh = File::Temp->new(TEMPLATE => $template); The apparent solution to this is to use File::Temp->tempfile() instead per: http://marc.info/?l=git&m=122089280626625&w=2 96369 1 ddkilzer 2008-10-23 12:22:59 -0700 These scripts are affected: JavaScriptCore/pcre/dftables WebKitTools/Scripts/bisect-builds WebKitTools/Scripts/sort-Xcode-project-file 96409 2 24615 ddkilzer 2008-10-23 13:56:21 -0700 Created attachment 24615 Patch v1 Note that using File::Temp->tempfile() instead of importing tempfile() first causes the template to be ignored, so I imported tempfile() and used it directly. 96443 3 24615 sam 2008-10-23 16:14:40 -0700 Comment on attachment 24615 Patch v1 Very nice. 96452 4 ddkilzer 2008-10-23 17:02:25 -0700 Committed r37832 http://trac.webkit.org/changeset/37832 24615 2008-10-23 13:56:21 -0700 2008-10-23 16:14:40 -0700 Patch v1 bug-21832-v1.diff text/plain 4805 ddkilzer Y29tbWl0IDk3YzRkMmNjNDM5ZjgwMzA1NTZkMThkZDA4NDJlMzE3MTE5NTljZTMKQXV0aG9yOiBE YXZpZCBLaWx6ZXIgPGRka2lsemVyQGFwcGxlLmNvbT4KRGF0ZTogICBUaHUgT2N0IDIzIDEzOjUz OjQ3IDIwMDggLTA3MDAKCiAgICAgICAgICAgIEJ1ZyAyMTgzMjogRml4IHNjcmlwdHMgdXNpbmcg J25ldyBGaWxlOjpUZW1wJyBmb3IgUGVybCA1LjEwCiAgICAKICAgIEphdmFTY3JpcHRDb3JlOgog ICAgCiAgICAgICAgICAgIEJ1ZyAyMTgzMjogRml4IHNjcmlwdHMgdXNpbmcgJ25ldyBGaWxlOjpU ZW1wJyBmb3IgUGVybCA1LjEwCiAgICAKICAgICAgICAgICAgPGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMTgzMj4KICAgIAogICAgICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KICAgIAogICAgICAgICAgICAqIHBjcmUvZGZ0YWJsZXM6IFVzZSBpbXBv cnRlZCB0ZW1wZmlsZSgpIGZyb20gRmlsZTo6VGVtcCBpbnN0ZWFkIG9mCiAgICAgICAgICAgICdu ZXcgRmlsZTo6VGVtcCcgdG8gbWFrZSB0aGUgc2NyaXB0IHdvcmsgd2l0aCBQZXJsIDUuMTAuCiAg ICAKICAgIFdlYktpdFRvb2xzOgogICAgCiAgICAgICAgICAgIEJ1ZyAyMTgzMjogRml4IHNjcmlw dHMgdXNpbmcgJ25ldyBGaWxlOjpUZW1wJyBmb3IgUGVybCA1LjEwCiAgICAKICAgICAgICAgICAg PGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTgzMj4KICAgIAogICAg ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KICAgIAogICAgICAgICAgICAqIFNj cmlwdHMvYmlzZWN0LWJ1aWxkczogVXNlIGltcG9ydGVkIHRlbXBmaWxlKCkgZnJvbSBGaWxlOjpU ZW1wCiAgICAgICAgICAgIGluc3RlYWQgb2YgJ25ldyBGaWxlOjpUZW1wJyB0byBtYWtlIHRoZSBz Y3JpcHQgd29yayB3aXRoIFBlcmwgNS4xMC4KICAgICAgICAgICAgKiBTY3JpcHRzL3NvcnQtWGNv ZGUtcHJvamVjdC1maWxlOiBEaXR0by4KCmRpZmYgLS1naXQgYS9KYXZhU2NyaXB0Q29yZS9DaGFu Z2VMb2cgYi9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKaW5kZXggZTAwOGM0Zi4uZWM2MGE5MyAx MDA2NDQKLS0tIGEvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCisrKyBiL0phdmFTY3JpcHRDb3Jl L0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE2IEBACiAyMDA4LTEwLTIzICBEYXZpZCBLaWx6ZXIgIDxk ZGtpbHplckBhcHBsZS5jb20+CiAKKyAgICAgICAgQnVnIDIxODMyOiBGaXggc2NyaXB0cyB1c2lu ZyAnbmV3IEZpbGU6OlRlbXAnIGZvciBQZXJsIDUuMTAKKworICAgICAgICA8aHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxODMyPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGNyZS9kZnRhYmxlczogVXNlIGltcG9ydGVk IHRlbXBmaWxlKCkgZnJvbSBGaWxlOjpUZW1wIGluc3RlYWQgb2YKKyAgICAgICAgJ25ldyBGaWxl OjpUZW1wJyB0byBtYWtlIHRoZSBzY3JpcHQgd29yayB3aXRoIFBlcmwgNS4xMC4KKworMjAwOC0x MC0yMyAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgorCiAgICAgICAgIEJ1ZyAy MTgzMTogRml4IGNyZWF0ZV9oYXNoX3RhYmxlIGZvciBQZXJsIDUuMTAKIAogICAgICAgICA8aHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxODMxPgpkaWZmIC0tZ2l0IGEv SmF2YVNjcmlwdENvcmUvcGNyZS9kZnRhYmxlcyBiL0phdmFTY3JpcHRDb3JlL3BjcmUvZGZ0YWJs ZXMKaW5kZXggMTIxNWRmMC4uOTI2OGYxOSAxMDA3NTUKLS0tIGEvSmF2YVNjcmlwdENvcmUvcGNy ZS9kZnRhYmxlcworKysgYi9KYXZhU2NyaXB0Q29yZS9wY3JlL2RmdGFibGVzCkBAIC00Niw3ICs0 Niw3IEBAIHVzZSBzdHJpY3Q7CiAKIHVzZSBGaWxlOjpCYXNlbmFtZTsKIHVzZSBGaWxlOjpTcGVj OwotdXNlIEZpbGU6OlRlbXA7Cit1c2UgRmlsZTo6VGVtcCBxdyh0ZW1wZmlsZSk7CiB1c2UgR2V0 b3B0OjpMb25nOwogCiBzdWIgcmVhZEhlYWRlclZhbHVlcygpOwpAQCAtMjQyLDEzICsyNDIsMTIg QEAgc3ViIHJlYWRIZWFkZXJWYWx1ZXMoKQogCiAgICAgbXkgJGhlYWRlclBhdGggPSBGaWxlOjpT cGVjLT5jYXRmaWxlKGRpcm5hbWUoJDApLCAicGNyZV9pbnRlcm5hbC5oIik7CiAgCi0gICAgbXkg JGZoID0gbmV3IEZpbGU6OlRlbXAoCisgICAgbXkgKCRmaCwgJHRlbXBGaWxlKSA9IHRlbXBmaWxl KAorICAgICAgICBiYXNlbmFtZSgkMCkgLiAiLVhYWFhYWFhYIiwKICAgICAgICAgRElSID0+ICgk RU5WeydUTVBESVInfSB8fCAiL3RtcCIpLAogICAgICAgICBTVUZGSVggPT4gIi5pbiIsCi0gICAg ICAgIFRFTVBMQVRFID0+IGJhc2VuYW1lKCQwKSAuICItWFhYWFhYWFgiLAogICAgICAgICBVTkxJ TksgPT4gMCwKICAgICApOwotICAgIG15ICR0ZW1wRmlsZSA9ICRmaC0+ZmlsZW5hbWUoKTsKIAog ICAgIHByaW50ICRmaCAiI2RlZmluZSBERlRBQkxFU1xuXG4iOwogCmRpZmYgLS1naXQgYS9XZWJL aXRUb29scy9DaGFuZ2VMb2cgYi9XZWJLaXRUb29scy9DaGFuZ2VMb2cKaW5kZXggOWU1NjdlYy4u MjFmM2E5ZCAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCisrKyBiL1dlYktpdFRv b2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDA4LTEwLTIzICBEYXZpZCBLaWx6ZXIg IDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAgICAgICAgQnVnIDIxODMyOiBGaXggc2NyaXB0cyB1 c2luZyAnbmV3IEZpbGU6OlRlbXAnIGZvciBQZXJsIDUuMTAKKworICAgICAgICA8aHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxODMyPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy9iaXNlY3QtYnVpbGRzOiBV c2UgaW1wb3J0ZWQgdGVtcGZpbGUoKSBmcm9tIEZpbGU6OlRlbXAKKyAgICAgICAgaW5zdGVhZCBv ZiAnbmV3IEZpbGU6OlRlbXAnIHRvIG1ha2UgdGhlIHNjcmlwdCB3b3JrIHdpdGggUGVybCA1LjEw LgorICAgICAgICAqIFNjcmlwdHMvc29ydC1YY29kZS1wcm9qZWN0LWZpbGU6IERpdHRvLgorCiAy MDA4LTEwLTIyICBCcmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBS ZXZpZXdlZCBieSBBZGFtIFJvYmVuCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL2Jp c2VjdC1idWlsZHMgYi9XZWJLaXRUb29scy9TY3JpcHRzL2Jpc2VjdC1idWlsZHMKaW5kZXggNTVi MzFjMS4uZjc3ZjgxZiAxMDA3NTUKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9iaXNlY3QtYnVp bGRzCisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvYmlzZWN0LWJ1aWxkcwpAQCAtNDIsNyArNDIs NyBAQCB1c2Ugc3RyaWN0OwogdXNlIEZpbGU6OkJhc2VuYW1lOwogdXNlIEZpbGU6OlBhdGg7CiB1 c2UgRmlsZTo6U3BlYzsKLXVzZSBGaWxlOjpUZW1wOwordXNlIEZpbGU6OlRlbXAgcXcodGVtcGZp bGUpOwogdXNlIEdldG9wdDo6TG9uZzsKIHVzZSBUaW1lOjpIaVJlcyBxdyh1c2xlZXApOwogCkBA IC0yMDQsMTMgKzIwNCwxMiBAQCBzdWIgY3JlYXRlVGVtcEZpbGUoJCkKIAogICAgIHJldHVybiB1 bmRlZiBpZiAhJHVybDsKIAotICAgIG15ICRmaCA9IG5ldyBGaWxlOjpUZW1wKAorICAgIG15ICgk ZmgsICR0ZW1wRmlsZSkgPSB0ZW1wZmlsZSgKKyAgICAgICAgYmFzZW5hbWUoJDApIC4gIi1YWFhY WFhYWCIsCiAgICAgICAgIERJUiA9PiAoJEVOVnsnVE1QRElSJ30gfHwgIi90bXAiKSwKICAgICAg ICAgU1VGRklYID0+ICIuaHRtbCIsCi0gICAgICAgIFRFTVBMQVRFID0+IGJhc2VuYW1lKCQwKSAu ICItWFhYWFhYWFgiLAogICAgICAgICBVTkxJTksgPT4gMCwKICAgICApOwotICAgIG15ICR0ZW1w RmlsZSA9ICRmaC0+ZmlsZW5hbWUoKTsKICAgICBwcmludCAkZmggIjxtZXRhIGh0dHAtZXF1aXY9 XCJyZWZyZXNoXCIgY29udGVudD1cIjA7ICR1cmxcIj5cbiI7CiAgICAgY2xvc2UoJGZoKTsKIApk aWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9zb3J0LVhjb2RlLXByb2plY3QtZmlsZSBi L1dlYktpdFRvb2xzL1NjcmlwdHMvc29ydC1YY29kZS1wcm9qZWN0LWZpbGUKaW5kZXggZTliN2E1 Ni4uYTM1ZmU3MyAxMDA3NTUKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9zb3J0LVhjb2RlLXBy b2plY3QtZmlsZQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL3NvcnQtWGNvZGUtcHJvamVjdC1m aWxlCkBAIC0zMSw3ICszMSw3IEBACiB1c2Ugc3RyaWN0OwogCiB1c2UgRmlsZTo6QmFzZW5hbWU7 Ci11c2UgRmlsZTo6VGVtcDsKK3VzZSBGaWxlOjpUZW1wIHF3KHRlbXBmaWxlKTsKIHVzZSBHZXRv cHQ6Okxvbmc7CiAKIHN1YiBzb3J0QnlGaWxlTmFtZSgkJCk7CkBAIC02NCwxMiArNjQsMTEgQEAg Zm9yIG15ICRwcm9qZWN0RmlsZSAoQEFSR1YpIHsKICAgICAgICAgbmV4dDsKICAgICB9CiAKLSAg ICBteSAkT1VUID0gbmV3IEZpbGU6OlRlbXAoCisgICAgbXkgKCRPVVQsICR0ZW1wRmlsZU5hbWUp ID0gdGVtcGZpbGUoCisgICAgICAgIGJhc2VuYW1lKCRwcm9qZWN0RmlsZSkgLiAiLVhYWFhYWFhY IiwKICAgICAgICAgRElSID0+IGRpcm5hbWUoJHByb2plY3RGaWxlKSwKLSAgICAgICAgVEVNUExB VEUgPT4gYmFzZW5hbWUoJHByb2plY3RGaWxlKSAuICItWFhYWFhYWFgiLAogICAgICAgICBVTkxJ TksgPT4gMCwKICAgICApOwotICAgIG15ICR0ZW1wRmlsZU5hbWUgPSAkT1VULT5maWxlbmFtZSgp OwogCiAgICAgIyBDbGVhbiB1cCB0ZW1wIGZpbGUgaW4gY2FzZSBvZiBkaWUoKQogICAgICRTSUd7 X19ESUVfX30gPSBzdWIgewo=